Re: [FFmpeg-devel] [PATCH 2/3] avcodec: add SGA Video decoder

2021-02-23 Thread Carl Eugen Hoyos
Am Di., 23. Feb. 2021 um 20:27 Uhr schrieb Paul B Mahol : > > On Tue, Feb 23, 2021 at 8:20 PM Carl Eugen Hoyos wrote: > > > Am Di., 23. Feb. 2021 um 18:32 Uhr schrieb Paul B Mahol > >: > > > > > +static int decode_palette(GetByteContext *gb, uint32_t *pal) &g

Re: [FFmpeg-devel] [PATCH 2/3] avcodec: add SGA Video decoder

2021-02-23 Thread Carl Eugen Hoyos
Am Di., 23. Feb. 2021 um 18:32 Uhr schrieb Paul B Mahol : > +static int decode_palette(GetByteContext *gb, uint32_t *pal) > +{ > +GetBitContext gbit; > + > +if (bytestream2_get_bytes_left(gb) < 18) > +return AVERROR_INVALIDDATA; > + > +memset(pal, 0, 16 * sizeof(*pal)); > +

Re: [FFmpeg-devel] [PATCH]lavf/imx: Do not probe number of frames

2021-02-21 Thread Carl Eugen Hoyos
Am So., 21. Feb. 2021 um 14:12 Uhr schrieb Paul B Mahol : > > On Sun, Feb 21, 2021 at 2:10 PM Carl Eugen Hoyos wrote: > > > Am So., 21. Feb. 2021 um 12:35 Uhr schrieb Paul B Mahol > >: > > > > > > Because there is not point in it. > &g

Re: [FFmpeg-devel] [PATCH]lavf/imx: Do not probe number of frames

2021-02-21 Thread Carl Eugen Hoyos
Am So., 21. Feb. 2021 um 12:35 Uhr schrieb Paul B Mahol : > > Because there is not point in it. > Number of frames should always be probed. It is neither necessary nor useful to probe it. Both is immediately obvious: You already check 48 bits, ruling out one possible value for 32bit does not

Re: [FFmpeg-devel] [PATCH v2 18/19] fate/matroska: Test remuxing tracks for hearing/visually impaired

2021-02-21 Thread Carl Eugen Hoyos
Am Sa., 20. Feb. 2021 um 17:00 Uhr schrieb Andreas Rheinhardt : > > The tests also test the other dispositions: commentary, descriptions > as well as dub and original language. > > Signed-off-by: Andreas Rheinhardt > --- > The first version of the matroska-wtv-remux test used the fixed-point >

Re: [FFmpeg-devel] [PATCH]lavf/imx: Do not probe number of frames

2021-02-21 Thread Carl Eugen Hoyos
Am So., 21. Feb. 2021 um 11:39 Uhr schrieb Paul B Mahol : > > This patch is not good. Could you elaborate? Carl Eugen ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link

[FFmpeg-devel] [PATCH]lavf/imx: Do not probe number of frames

2021-02-21 Thread Carl Eugen Hoyos
Hi! The Simbiosis IMX probe function looks strict enough, do not check for a field that does not cause decoding to fail. Please comment, Carl Eugen From 62ce4e42c1dae6696007e22cd13a8e43eabbc38d Mon Sep 17 00:00:00 2001 From: Carl Eugen Hoyos Date: Sun, 21 Feb 2021 10:31:16 +0100 Subject: [PATCH

Re: [FFmpeg-devel] [PATCH] fix for https://trac.ffmpeg.org/ticket/9057

2021-02-16 Thread Carl Eugen Hoyos
Am Do., 21. Jan. 2021 um 17:59 Uhr schrieb : > > From: KM > > --- > libavcodec/aacdec_template.c | 11 +++ > 1 file changed, 7 insertions(+), 4 deletions(-) > > diff --git a/libavcodec/aacdec_template.c b/libavcodec/aacdec_template.c > index fbe3074..3c2dbe3 100644 > ---

[FFmpeg-devel] [PATCH]libavfi/pseudocolor: Add missing braces around initializers

2021-02-16 Thread Carl Eugen Hoyos
Hi, attached patch fixes many warnings when compiling with gcc 10. Please comment, Carl Eugen From 721a6444d30c65b3bb69e0ef2154bc9b2c2ffa8f Mon Sep 17 00:00:00 2001 From: Carl Eugen Hoyos Date: Tue, 16 Feb 2021 23:36:04 +0100 Subject: [PATCH] lavfi/pseudocolor: Add missing braces around

Re: [FFmpeg-devel] [PATCH 1/1] avcodec/libopusdec: Enable FEC/PLC

2021-02-16 Thread Carl Eugen Hoyos
Am Di., 16. Feb. 2021 um 15:02 Uhr schrieb Philip-Dylan Gleonec : > > Adds FEC/PLC support to libopus. The lost packets are detected as a > discontinuity in the audio stream. When a discontinuity is used, this > patch tries to decode the FEC data. If FEC data is present in the > packet, it is

Re: [FFmpeg-devel] [PATCH]lavc/pnm_parser: Add a pfm parser

2021-02-16 Thread Carl Eugen Hoyos
Am Di., 16. Feb. 2021 um 19:28 Uhr schrieb Andreas Rheinhardt : > > Carl Eugen Hoyos: > > Am Di., 16. Feb. 2021 um 00:56 Uhr schrieb Andreas Rheinhardt > > : > >> > >> Carl Eugen Hoyos: > >>> Hi! > >>> > >>> Attached patch is

Re: [FFmpeg-devel] [PATCH]lavc/pnm_parser: Add a pfm parser

2021-02-16 Thread Carl Eugen Hoyos
Am Di., 16. Feb. 2021 um 00:56 Uhr schrieb Andreas Rheinhardt : > > Carl Eugen Hoyos: > > Hi! > > > > Attached patch is necessary for a new pfm demuxer. > > > > Please comment, Carl Eugen > > > Can't we just wait and increment the number of codec_id

[FFmpeg-devel] [PATCH]lavc/pnm_parser: Add a pfm parser

2021-02-15 Thread Carl Eugen Hoyos
Hi! Attached patch is necessary for a new pfm demuxer. Please comment, Carl Eugen From bd8d192651b3778c2cda387dbdce58eb377ca077 Mon Sep 17 00:00:00 2001 From: Carl Eugen Hoyos Date: Mon, 15 Feb 2021 23:22:35 +0100 Subject: [PATCH] lavc/pnm_parser: Add a pfm parser. A parser cannot support more

Re: [FFmpeg-devel] [PATCH]lavc/pnm: Support decoding gray float pbm images.

2021-02-15 Thread Carl Eugen Hoyos
Am Mo., 15. Feb. 2021 um 20:18 Uhr schrieb Paul B Mahol : > > then add new parser bellow Already working on it: ff_pnm2_parser or ff_pfm_parser? Or another idea? Thank you, Carl Eugen ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org

Re: [FFmpeg-devel] [PATCH]lavc/pnm: Support decoding gray float pbm images.

2021-02-15 Thread Carl Eugen Hoyos
Am Mo., 15. Feb. 2021 um 19:13 Uhr schrieb Carl Eugen Hoyos : > > Am Mo., 15. Feb. 2021 um 02:39 Uhr schrieb Paul B Mahol : > > > > Why you use pbm decoder for probing of pfm files? > > The only samples I found have the extension pbm and I > simply misunderstood how

Re: [FFmpeg-devel] [PATCH]lavc/pnm: Support decoding gray float pbm images.

2021-02-15 Thread Carl Eugen Hoyos
Am Mo., 15. Feb. 2021 um 02:39 Uhr schrieb Paul B Mahol : > > Why you use pbm decoder for probing of pfm files? The only samples I found have the extension pbm and I simply misunderstood how you designed this since my samples were detected as pbm (because of their extension). Will fix, Carl

Re: [FFmpeg-devel] [PATCH]lavc/pnm: Support decoding gray float pbm images.

2021-02-14 Thread Carl Eugen Hoyos
Am Fr., 12. Feb. 2021 um 00:24 Uhr schrieb Paul B Mahol : > > On Fri, Feb 12, 2021 at 12:21 AM Carl Eugen Hoyos > wrote: > > > Am Fr., 12. Feb. 2021 um 00:18 Uhr schrieb Paul B Mahol > >: > > > > > > This is variant of PFM images, PBM image format

Re: [FFmpeg-devel] [PATCH]lavfi/vflip: Support Bayer vertical flip

2021-02-14 Thread Carl Eugen Hoyos
Am Mi., 10. Feb. 2021 um 19:50 Uhr schrieb Paul B Mahol : > > Just apply this, it is very unlikely that there are faster ways. Thank you, patch applied. Carl Eugen ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org

Re: [FFmpeg-devel] [PATCH] avcodec/movtextenc: fix compile warning for type-limits

2021-02-14 Thread Carl Eugen Hoyos
Am So., 14. Feb. 2021 um 18:57 Uhr schrieb Nuo Mi : > > https://github.com/FFmpeg/FFmpeg/blob/21346672270ae723aa774a9c8b0749954a75b3df/libavcodec/movtextenc.c#L110 > > > > > s->count * sizeof(*s->style_attributes) never > 32 bits. > > > > This is not correct afaict: > > The relevant line is 369

Re: [FFmpeg-devel] [PATCH] avcodec/movtextenc: fix compile warning for type-limits

2021-02-14 Thread Carl Eugen Hoyos
Am So., 14. Feb. 2021 um 18:15 Uhr schrieb Nuo Mi : > > On Mon, Feb 15, 2021 at 1:05 AM Carl Eugen Hoyos wrote: > > > Am So., 14. Feb. 2021 um 17:30 Uhr schrieb Nuo Mi : > > > > > > On Sun, Feb 14, 2021 at 6:35 PM Anton Khirnov wrote: > > > &

Re: [FFmpeg-devel] [PATCH] avformat/protocols: fix discarded-qualifiers compiler warning

2021-02-14 Thread Carl Eugen Hoyos
Am So., 14. Feb. 2021 um 18:00 Uhr schrieb Paul B Mahol : > > On Sun, Feb 14, 2021 at 5:58 PM Carl Eugen Hoyos wrote: > > > Am So., 14. Feb. 2021 um 17:53 Uhr schrieb Nuo Mi : > > > > > > --- > > > libavformat/protocols.c | 4 ++-- > >

Re: [FFmpeg-devel] [PATCH v2] avutils/video_enc_params: fix type-limits compile warning on 64 bits build system

2021-02-14 Thread Carl Eugen Hoyos
Am So., 14. Feb. 2021 um 17:57 Uhr schrieb Nuo Mi : > > On Mon, Feb 15, 2021 at 12:41 AM Nuo Mi wrote: > > > This will fix following compile warning: > > > > libavutil/video_enc_params.c: In function ‘av_video_enc_params_alloc: > > > > > >libavutil/video_enc_params.c:36:19:

Re: [FFmpeg-devel] [PATCH] avcodec/movtextenc: fix compile warning for type-limits

2021-02-14 Thread Carl Eugen Hoyos
Am So., 14. Feb. 2021 um 17:30 Uhr schrieb Nuo Mi : > > On Sun, Feb 14, 2021 at 6:35 PM Anton Khirnov wrote: > > > Quoting Nuo Mi (2021-02-14 07:27:39) > > > CC libavcodec/mpegaudiodec_common.o > > > libavcodec/movtextenc.c: In function ‘mov_text_style_start’: > > >

Re: [FFmpeg-devel] [PATCH] avformat/protocols: fix discarded-qualifiers compiler warning

2021-02-14 Thread Carl Eugen Hoyos
Am So., 14. Feb. 2021 um 17:53 Uhr schrieb Nuo Mi : > > --- > libavformat/protocols.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/libavformat/protocols.c b/libavformat/protocols.c > index 7df18fbb3b..0b43f66baf 100644 > --- a/libavformat/protocols.c > +++

Re: [FFmpeg-devel] [PATCH] avcodec/pngdec: use correct frame for none disposition

2021-02-14 Thread Carl Eugen Hoyos
Am So., 14. Feb. 2021 um 17:10 Uhr schrieb Paul B Mahol : > > Signed-off-by: Paul B Mahol > --- > libavcodec/pngdec.c | 5 ++--- > 1 file changed, 2 insertions(+), 3 deletions(-) > > diff --git a/libavcodec/pngdec.c b/libavcodec/pngdec.c > index 61642b7cbe..f0e2a0cad4 100644 > ---

Re: [FFmpeg-devel] [PATCH]lavc/pnm: Support decoding gray float pbm images.

2021-02-11 Thread Carl Eugen Hoyos
Am Fr., 12. Feb. 2021 um 00:18 Uhr schrieb Paul B Mahol : > > This is variant of PFM images, PBM image format is only fixed point gray. Should I change the commit message or the patch? Thank you, Carl Eugen ___ ffmpeg-devel mailing list

[FFmpeg-devel] [PATCH]lavc/pnm: Support decoding gray float pbm images.

2021-02-11 Thread Carl Eugen Hoyos
Hi! Attached patch allows to decode gray float pbm images, sample by ami_stuff. Please comment, Carl Eugen From 71283c6de2eb5ef45382390d695845abb500b316 Mon Sep 17 00:00:00 2001 From: Carl Eugen Hoyos Date: Thu, 11 Feb 2021 23:37:06 +0100 Subject: [PATCH] lavc/pnm: Allow decoding of gray float

Re: [FFmpeg-devel] [PATCH] Add matroska codec id S_TEXT/WEBVTT for WebVTT streams.

2021-02-06 Thread Carl Eugen Hoyos
Am So., 7. Feb. 2021 um 03:50 Uhr schrieb Walter Wong : > > Added the codec id S_TEXT/WEBVTT in order to bring ffmpeg generated files > closer to the matroska spec. The list of matroska codec ids was also > rearranged to push the old codec id (D_WEBVTT/SUBTITLES) to the bottom of > the list so

Re: [FFmpeg-devel] [PATCH] fix for https://trac.ffmpeg.org/ticket/9057

2021-02-03 Thread Carl Eugen Hoyos
Am Do., 21. Jan. 2021 um 17:59 Uhr schrieb : > > From: KM > > --- > libavcodec/aacdec_template.c | 11 +++ > 1 file changed, 7 insertions(+), 4 deletions(-) > > diff --git a/libavcodec/aacdec_template.c b/libavcodec/aacdec_template.c > index fbe3074..3c2dbe3 100644 > ---

Re: [FFmpeg-devel] REQUEST: remove photocd_pipe demuxer as there is no parser

2021-02-03 Thread Carl Eugen Hoyos
Am Mi., 3. Feb. 2021 um 11:38 Uhr schrieb Paul B Mahol : [...] While you and others - thankfully! - implemented parsers for many formats, there are several image formats for which FFmpeg probably will not implement a parser, I believe it makes a lot of sense to auto-detect such images, and this

Re: [FFmpeg-devel] [PATCH] avdevice/xcbgrab: don't assume Xserver endianness

2021-02-02 Thread Carl Eugen Hoyos
Am Di., 2. Feb. 2021 um 04:26 Uhr schrieb Andriy Gelman : > > On Sun, 31. Jan 23:28, Carl Eugen Hoyos wrote: > > Am So., 31. Jan. 2021 um 20:51 Uhr schrieb Andriy Gelman > > : > > > > > > From: Andriy Gelman > > > > > > Xserver defines the

Re: [FFmpeg-devel] [PATCH] avdevice/xcbgrab: don't assume Xserver endianness

2021-01-31 Thread Carl Eugen Hoyos
Am So., 31. Jan. 2021 um 20:51 Uhr schrieb Andriy Gelman : > > From: Andriy Gelman > > Xserver defines the endianness of the grabbed images. Use this information > to set the correct pixel format. lgtm if tested. Could you look at pal8? This used to work fine with x11grab... Thank you, Carl

Re: [FFmpeg-devel] [PATCH 0/4] Better colorspace support in dnxhddec

2021-01-30 Thread Carl Eugen Hoyos
Am Sa., 30. Jan. 2021 um 10:20 Uhr schrieb Christophe Gisquet : > > Nobody complained so the CIDs are likely litle used. https://trac.ffmpeg.org/ticket/7342 There are also tickets #7258 and #3707. Thank you, Carl Eugen ___ ffmpeg-devel mailing list

Re: [FFmpeg-devel] [PATCH]lavfi/vflip: Support Bayer vertical flip

2021-01-24 Thread Carl Eugen Hoyos
Am Sa., 5. Sept. 2020 um 21:15 Uhr schrieb Carl Eugen Hoyos : > Attached patch fixes ticket #8819. Paul, I believe you had an objection but I forgot what it was... Please comment, Carl Eugen ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org ht

Re: [FFmpeg-devel] [PATCH] Ticket #8750 Add inline function for the vec_xl intrinsic in non-VSX environments

2021-01-24 Thread Carl Eugen Hoyos
Am Sa., 10. Okt. 2020 um 02:44 Uhr schrieb Andriy Gelman : > > From: Chip Kerchner > > --- > libswscale/ppc/yuv2rgb_altivec.c | 10 ++ > 1 file changed, 10 insertions(+) > > diff --git a/libswscale/ppc/yuv2rgb_altivec.c > b/libswscale/ppc/yuv2rgb_altivec.c > index 536545293d..930ef6b98f

Re: [FFmpeg-devel] [PATCH]lsws/ppc/yuv2rgb: Fix transparency converting from yuv->rgb32

2021-01-24 Thread Carl Eugen Hoyos
Am Sa., 23. Jan. 2021 um 23:21 Uhr schrieb Reimar Döffinger : > > > > > On 23 Jan 2021, at 19:35, Carl Eugen Hoyos wrote: > > > > > > New patch attached, thank you! > > > > Looks good to me. Patch applied. Thank you, Carl Eugen ___

Re: [FFmpeg-devel] [PATCH]lsws/ppc/yuv2rgb: Fix transparency converting from yuv->rgb32

2021-01-23 Thread Carl Eugen Hoyos
Am Sa., 23. Jan. 2021 um 19:16 Uhr schrieb Reimar Döffinger : > > Hi! > > > On 23 Jan 2021, at 17:31, Carl Eugen Hoyos wrote: > > Attached patch fixes ticket #9077 for me. > > > > Please comment, Carl Eugen > > <0001-lsws-ppc-yuv2rgb-Fix-transparency-con

[FFmpeg-devel] [PATCH]lsws/ppc/yuv2rgb: Fix transparency converting from yuv->rgb32

2021-01-23 Thread Carl Eugen Hoyos
Hi! Attached patch fixes ticket #9077 for me. Please comment, Carl Eugen From 82ac1fb1e33340e956ed36e106ea8a74ecf1f3a3 Mon Sep 17 00:00:00 2001 From: Carl Eugen Hoyos Date: Sat, 23 Jan 2021 17:28:14 +0100 Subject: [PATCH] lsws/ppc/yuv2rgb: Fix transparency converting from yuv->rgb32. Ba

Re: [FFmpeg-devel] [PATCH 2/3] libavformat/hls: add support for SAMPLE-AES decryption in HLS demuxer

2021-01-22 Thread Carl Eugen Hoyos
Am Do., 21. Jan. 2021 um 20:42 Uhr schrieb Nachiket Tarate : > > Apple HTTP Live Streaming Sample Encryption: This is definitely important enough to warrant a line in the Changelog. Thank you for your effort, Carl Eugen ___ ffmpeg-devel mailing list

Re: [FFmpeg-devel] [PATCH] avformat/rtsp: don't overwrite session control uri

2021-01-17 Thread Carl Eugen Hoyos
Am So., 11. Okt. 2020 um 01:54 Uhr schrieb Andriy Gelman : > > From: Andriy Gelman > > Fixes #1941 > > Currently the session control uri gets overwritten by the media's uri > when mpegts is signalled in the media description. This happens because > s->nb_streams doesn't count mpegts which is

Re: [FFmpeg-devel] [PATCH] Add support for "omp simd" pragma.

2021-01-10 Thread Carl Eugen Hoyos
Am So., 10. Jan. 2021 um 19:55 Uhr schrieb Lynne : > > Jan 10, 2021, 17:43 by reimar.doeffin...@gmx.de: > > > From: Reimar Döffinger > > > > This requests loops to be vectorized using SIMD > > instructions. > > The performance increase is far from hand-optimized > > assembly but still significant

Re: [FFmpeg-devel] [PATCH] libswscale/swscale.c: Clarify what exactly 'data is not aligned' to

2020-12-27 Thread Carl Eugen Hoyos
> Am 27.12.2020 um 09:36 schrieb Franziska Thul : > > If "bytes" or "pixels" doesn't matter from the user's perspective, I'd stick > with the latter, even if it's not exactly right regarding the internal > workings of ffmpeg. It does matter because while data has to be 16-bytes aligned,

Re: [FFmpeg-devel] [PATCH]lavd/decklink_dec: Use correct case for codec point / fourcc v210

2020-12-24 Thread Carl Eugen Hoyos
Am Mo., 21. Dez. 2020 um 01:18 Uhr schrieb Marton Balint : > >>> Attached patch fixes ticket #9005. > >> > >> Why are the codec_tags set at all? Can't we simply remove setting of all > >> the codec tags in decklink? They hold no additional information to > >> codec id and pixel format. This

Re: [FFmpeg-devel] [PATCH]lavd/decklink_dec: Use correct case for codec point / fourcc v210

2020-12-13 Thread Carl Eugen Hoyos
Am Sa., 12. Dez. 2020 um 10:57 Uhr schrieb Marton Balint : > > On Fri, 11 Dec 2020, Carl Eugen Hoyos wrote: > > > Attached patch fixes ticket #9005. > > Why are the codec_tags set at all? Can't we simply remove setting of all > the codec tags in decklink? They hold n

Re: [FFmpeg-devel] [PATCH] swscale/rgb2rgb_template: use shuffle macro on BE arches

2020-12-12 Thread Carl Eugen Hoyos
Am Sa., 12. Dez. 2020 um 23:41 Uhr schrieb Andriy Gelman : > > On Wed, 02. Dec 22:09, Michael Niedermayer wrote: > > On Mon, Nov 30, 2020 at 12:46:51AM -0500, Andriy Gelman wrote: > > > From: Andriy Gelman > > > > > > Fixes fate-qtrle-32bit on PPC64 qemu > > > > also fixes this on mips-qemu > > >

Re: [FFmpeg-devel] [PATCH 1/6] fate: Add dpx-probe test

2020-12-10 Thread Carl Eugen Hoyos
Am Do., 10. Dez. 2020 um 13:22 Uhr schrieb Paul B Mahol : > > I already uploaded the other file to servers. We can still remove it. Downloading the fate suite takes very long and it will get bigger no matter the year. Carl Eugen ___ ffmpeg-devel

[FFmpeg-devel] [PATCH]lavd/decklink_dec: Use correct case for codec point / fourcc v210

2020-12-10 Thread Carl Eugen Hoyos
Hi! Attached patch fixes ticket #9005. Please comment, Carl Eugen From e1ee77e80f041aff2e24e029acdf0cc2ce073ecf Mon Sep 17 00:00:00 2001 From: Carl Eugen Hoyos Date: Fri, 11 Dec 2020 00:26:20 +0100 Subject: [PATCH] lavd/decklink_dec: Use correct case for codec point / fourcc v210. Reported

Re: [FFmpeg-devel] [PATCH]lavf/img2dec: Return a low score for mjpeg when probing jpeg_pipe

2020-12-10 Thread Carl Eugen Hoyos
Am Do., 10. Dez. 2020 um 23:59 Uhr schrieb Michael Niedermayer : > > On Wed, Dec 09, 2020 at 11:43:49PM +0100, Carl Eugen Hoyos wrote: > > Am Mi., 9. Dez. 2020 um 23:38 Uhr schrieb Carl Eugen Hoyos > > : > > > > > Attached patch fixes ticket #9026. > > >

Re: [FFmpeg-devel] [PATCH 1/6] fate: Add dpx-probe test

2020-12-09 Thread Carl Eugen Hoyos
Am Mo., 7. Dez. 2020 um 12:39 Uhr schrieb Harry Mallon : > > I attach the cyan.dpx that I generated for this test, it needs to be in the > dpx folder in fate. The file is >400k, I believe a very small file should also allow to test ffprobe with dpx. Carl Eugen

Re: [FFmpeg-devel] [PATCH]lavf/img2dec: Return a low score for mjpeg when probing jpeg_pipe

2020-12-09 Thread Carl Eugen Hoyos
Am Mi., 9. Dez. 2020 um 23:38 Uhr schrieb Carl Eugen Hoyos : > Attached patch fixes ticket #9026. Alternative patch attached. Carl Eugen From eff71dca7111042cf696f47267ba311a5565629f Mon Sep 17 00:00:00 2001 From: Carl Eugen Hoyos Date: Wed, 9 Dec 2020 23:42:33 +0100 Subject: [PATCH] l

[FFmpeg-devel] [PATCH]lavf/img2dec: Return a low score for mjpeg when probing jpeg_pipe

2020-12-09 Thread Carl Eugen Hoyos
Hi! Attached patch fixes ticket #9026. Please comment, Carl Eugen From 0acdf4ccbad59d10d1b8fa2a1bde0b7cf59a46ab Mon Sep 17 00:00:00 2001 From: Carl Eugen Hoyos Date: Wed, 9 Dec 2020 23:35:36 +0100 Subject: [PATCH] lavf/img2dec: Return a low score for mjpeg when probing jpeg_pipe. Fixes ticket

Re: [FFmpeg-devel] [PATCH] swscale/rgb2rgb_template: use shuffle macro on BE arches

2020-11-30 Thread Carl Eugen Hoyos
Am Mo., 30. Nov. 2020 um 06:48 Uhr schrieb Andriy Gelman : > > From: Andriy Gelman > > Fixes fate-qtrle-32bit on PPC64 qemu I suspect your patch fixes colourspace conversion (and the fate test) on big-endian. Carl Eugen ___ ffmpeg-devel mailing list

Re: [FFmpeg-devel] [PATCH v2] configure: fix the bigendian test

2020-11-14 Thread Carl Eugen Hoyos
Am Sa., 14. Nov. 2020 um 20:16 Uhr schrieb David Michael : > > On Sat, Nov 14, 2020 at 2:06 PM Carl Eugen Hoyos wrote: > > Am Sa., 14. Nov. 2020 um 18:22 Uhr schrieb David Michael > > : > > > > > > There are two issues: > > > > > > When

Re: [FFmpeg-devel] [PATCH v2] configure: fix the bigendian test

2020-11-14 Thread Carl Eugen Hoyos
Am Sa., 14. Nov. 2020 um 18:22 Uhr schrieb David Michael : > > There are two issues: > > When build systems enable LTO in CFLAGS, the unused global integer > does not make it into the compiled object file. As a workaround, > check if the compiler understands -fno-lto and append it after > CFLAGS

Re: [FFmpeg-devel] Bundling ffmpeg into windows application

2020-11-12 Thread Carl Eugen Hoyos
Am Do., 12. Nov. 2020 um 11:30 Uhr schrieb Tobias Rapp : > > On 11.11.2020 17:15, Carl Eugen Hoyos wrote: > > Not necessarily related: In no way whatsoever does the LGPL mandate > > dynamic linking (this was claimed several times lately). > The "License Compliance Check

Re: [FFmpeg-devel] [PATCH] configure: fix the bigendian test

2020-11-11 Thread Carl Eugen Hoyos
> Am 12.11.2020 um 00:41 schrieb David Michael : > >> On Wed, Nov 11, 2020 at 6:20 PM Carl Eugen Hoyos wrote: >>> Am Mi., 11. Nov. 2020 um 16:30 Uhr schrieb David Michael >>> : >>> There are two issues: >>> >>> The unused global integ

Re: [FFmpeg-devel] [PATCH] configure: fix the bigendian test

2020-11-11 Thread Carl Eugen Hoyos
Am Mi., 11. Nov. 2020 um 16:30 Uhr schrieb David Michael : > > There are two issues: > > The unused global integer does not make it into the compiled object > file, so declare it static to correct this. How can I reproduce this issue? > The hexdump output is line-wrapped, so the expected value

Re: [FFmpeg-devel] Bundling ffmpeg into windows application

2020-11-11 Thread Carl Eugen Hoyos
Am Mi., 11. Nov. 2020 um 06:50 Uhr schrieb Brian D. Pemberton : > I am thinking about writing an app that bundles or includes FFmpeg to do > some video processing. Is this allowed? If so, where can I read about the > constraints or requirements of doing this? Also, is there anything I should >

Re: [FFmpeg-devel] Next developer meeting

2020-11-11 Thread Carl Eugen Hoyos
Am Mi., 11. Nov. 2020 um 16:49 Uhr schrieb Anton Khirnov : > I gave you arguments last time this was discussed. You keep ignoring > them, because presumably you are the sole arbiter of what is actual and > practical. I am not convinced that you are in an ideal position for personal attacks.

Re: [FFmpeg-devel] [PATCH] Moves yuv2yuvX_sse3 to yasm, unrolls main loop and other small optimizations for ~20% speedup.

2020-11-10 Thread Carl Eugen Hoyos
Am Fr., 6. Nov. 2020 um 09:04 Uhr schrieb Alan Kelly : > > The function was re-written in asm, this code is heavily derived from the > original code, the algorithm remains unchanged, the implementation is > optimized. Would you agree to adding the copyright from swscale.c: > * Copyright (C)

Re: [FFmpeg-devel] [PATCH] avformat/dv: fix timestamps of audio packets in case of dropped corrupt audio frames

2020-10-31 Thread Carl Eugen Hoyos
Am Sa., 31. Okt. 2020 um 19:43 Uhr schrieb Dave Rice : > > Hi Marton, > > > On Oct 31, 2020, at 12:56 PM, Marton Balint wrote: > > > > Fixes out of sync timestamps in ticket #8762. > > Although Michael’s recent patch does address the issue documented in 8762, I > haven’t found this patch to fix

Re: [FFmpeg-devel] [PATCH v3] Add support for playing Audible AAXC (.aaxc) files

2020-10-31 Thread Carl Eugen Hoyos
Am Mi., 8. Apr. 2020 um 05:59 Uhr schrieb Vesselin Bontchev : > +static int mov_aaxc_crypto(MOVContext *c) This function does return error codes in some cases but they are ignored in the calling function. > +fail: > + > +return ret; This does not look like a useful hunk to me, use a fail

Re: [FFmpeg-devel] [PATCH] avformat/dv: allow returning damaged audio

2020-10-31 Thread Carl Eugen Hoyos
Am Do., 29. Okt. 2020 um 22:59 Uhr schrieb Michael Niedermayer : > +static const AVOption dv_options[] = { > +{ "dvaudio_concealment", "", OFFSET(dvaudio_concealment), > AV_OPT_TYPE_INT , {.i64 = AUDIO_CONCEAL_DROP}, 0, INT_MAX, DEC, > "dvaudio_concealment"}, > +{ "drop",

Re: [FFmpeg-devel] [PATCH] Moves yuv2yuvX_sse3 to yasm, unrolls main loop and other small optimizations for ~20% speedup.

2020-10-31 Thread Carl Eugen Hoyos
Am Di., 27. Okt. 2020 um 09:56 Uhr schrieb Alan Kelly : > --- /dev/null > +++ b/libswscale/x86/yuv2yuvX.asm > @@ -0,0 +1,105 @@ > +;** > +;* x86-optimized yuv2yuvX > +;* Copyright 2020 Google LLC Either the commit

Re: [FFmpeg-devel] Looking for contractors to improve DPX decoding

2020-10-21 Thread Carl Eugen Hoyos
Am Mi., 21. Okt. 2020 um 14:01 Uhr schrieb Dedy Yohann : > The ticket I opened a couple of month ago is one of those case : > https://trac.ffmpeg.org/ticket/8390 Two patches exist for this issue. Please provide samples for the other issues you see so we know what you actually need. Carl Eugen

Re: [FFmpeg-devel] ION MP4 causing issues

2020-10-18 Thread Carl Eugen Hoyos
Am So., 18. Okt. 2020 um 16:38 Uhr schrieb Matthias Opitz : > I am capturing mp4 files since several years with an ION SPEED PRO > without any issues. I did not use the camera a while. Today I realized > that either W10 (tested different laptops) and even Linux ins not able > to play these files

Re: [FFmpeg-devel] [PATCH] libavformat/hls: add support for SAMPLE-AES decryption in HLS demuxer

2020-10-11 Thread Carl Eugen Hoyos
Am So., 11. Okt. 2020 um 22:15 Uhr schrieb Nachiket Tarate : > > -pls->ctx->probesize = s->probesize > 0 ? s->probesize : 1024 * 4; > > -pls->ctx->max_analyze_duration = s->max_analyze_duration > 0 ? > > s->max_analyze_duration : 4 * AV_TIME_BASE; > > -

Re: [FFmpeg-devel] [PATCH] libavformat/hls: add support for SAMPLE-AES decryption in HLS demuxer

2020-10-11 Thread Carl Eugen Hoyos
Am Sa., 10. Okt. 2020 um 17:01 Uhr schrieb Nachiket Tarate : > -pls->ctx->probesize = s->probesize > 0 ? s->probesize : 1024 * 4; > -pls->ctx->max_analyze_duration = s->max_analyze_duration > 0 ? > s->max_analyze_duration : 4 * AV_TIME_BASE; > -

Re: [FFmpeg-devel] [PATCH]lavc/aomdec: Allow RGB decoding

2020-10-11 Thread Carl Eugen Hoyos
Am So., 11. Okt. 2020 um 19:51 Uhr schrieb James Almer : > > On 10/11/2020 2:27 PM, Carl Eugen Hoyos wrote: > > Hi! > > > > Attached patch fixes ticket #8929 for me. > > > > Please comment, Carl Eugen > > > From 580477c4b0e07fa5436474ae732596bed5faf2d4

[FFmpeg-devel] [PATCH]lavc/aomdec: Allow RGB decoding

2020-10-11 Thread Carl Eugen Hoyos
Hi! Attached patch fixes ticket #8929 for me. Please comment, Carl Eugen From 580477c4b0e07fa5436474ae732596bed5faf2d4 Mon Sep 17 00:00:00 2001 From: Carl Eugen Hoyos Date: Sun, 11 Oct 2020 19:25:10 +0200 Subject: [PATCH] lavc/aomdec: Allow RGB decoding. Fixes ticket #8929. --- libavcodec

Re: [FFmpeg-devel] [PATCH v4 0/9] avformat: wav-s337m support + new probe_stream option

2020-10-08 Thread Carl Eugen Hoyos
Am Mo., 5. Okt. 2020 um 12:23 Uhr schrieb Nicolas Gaullier : > > >> Because of the dependencies, I had to group all the patches in a serie, > >> but they are 3 functional parts : > >> * patch 1 is necessary to fix dolby_e pts that will be part of the > >> test in patch 8 > >> * patch

Re: [FFmpeg-devel] [PATCH] avformat: add tri-ACE demuxer

2020-10-03 Thread Carl Eugen Hoyos
Am Do., 24. Sept. 2020 um 19:35 Uhr schrieb Paul B Mahol : > +static int ace_probe(const AVProbeData *p) > +{ > +uint32_t asc; > + > +if (AV_RB32(p->buf) != MKBETAG('A','A','C',' ')) > +return 0; > +if (p->buf_size < 0x44) > +return 0; > +asc = AV_RB32(p->buf +

Re: [FFmpeg-devel] [PATCH v4 9/9] avformat: Add probe_stream option

2020-10-03 Thread Carl Eugen Hoyos
Am Sa., 3. Okt. 2020 um 00:25 Uhr schrieb Nicolas Gaullier : > Allows user to disable codec auto-detection. > Probe requests are ignored, including spdif/s337m submux detection in wavdec. > Note: this option is required to pass-through dolby_e data from a wav file. I don't think this is

Re: [FFmpeg-devel] [PATCH v4 4/9] avformat/s337m: New ff_s337m_probe()

2020-10-03 Thread Carl Eugen Hoyos
Am Sa., 3. Okt. 2020 um 00:24 Uhr schrieb Nicolas Gaullier : > > Similar to ff_spdif_probe() with just an additional checking of > the bit resolution of the container as it may be 16 or 24 for s337m. Sorry if I miss something: Why is the new function part of s337m.c? Carl Eugen

Re: [FFmpeg-devel] [PATCH v4 0/9] avformat: wav-s337m support + new probe_stream option

2020-10-03 Thread Carl Eugen Hoyos
Am Sa., 3. Okt. 2020 um 00:24 Uhr schrieb Nicolas Gaullier : > > Because of the dependencies, I had to group all the patches in a serie, but > they are 3 functional parts : > * patch 1 is necessary to fix dolby_e pts that will be part of the test in > patch 8 > * patch 2,3,4,5,6,7,8 : s337m

Re: [FFmpeg-devel] [FFmpeg-cvslog] avformat: add IPU demuxer

2020-09-24 Thread Carl Eugen Hoyos
Am Do., 24. Sept. 2020 um 13:44 Uhr schrieb Paul B Mahol : > +static int ipu_read_probe(const AVProbeData *p) > +{ > +if (AV_RB32(p->buf) != MKBETAG('i', 'p', 'u', 'm')) > +return 0; > + > +if (AV_RL32(p->buf + 4) == 0) > +return 0; > + > +if (AV_RL16(p->buf + 8) == 0)

Re: [FFmpeg-devel] Unrecognized video

2020-09-21 Thread Carl Eugen Hoyos
Am Mo., 21. Sept. 2020 um 11:24 Uhr schrieb Nicolas Julien : > I just uploaded a video file (named video.h264) to > https://streams.videolan.org/upload/ web site. > This video is from the recorded replay of an IP camera, with openrtsp. > I am trying to convert this H265 video to mp4 format with

Re: [FFmpeg-devel] [PATCH] configure: Add atsc_a53 dependencies for H.264 and HEVC parser

2020-09-20 Thread Carl Eugen Hoyos
Am Sa., 19. Sept. 2020 um 20:18 Uhr schrieb Andreas Rheinhardt : > > They need it because they make use of SEI parsing code. > > Signed-off-by: Andreas Rheinhardt > --- > configure | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/configure b/configure > index

Re: [FFmpeg-devel] [PATCH 1/1] configure: use require_pkg_config to check for wavpack

2020-09-20 Thread Carl Eugen Hoyos
> Am 20.09.2020 um 13:52 schrieb Bernd Kuhls : > > Fixes static builds with toolchains needing "-lm" for math functions. Please don’t. Why is this necessary? Doesn’t every FFmpeg link command contain -lm? Carl Eugen ___ ffmpeg-devel mailing list

Re: [FFmpeg-devel] Patch: added V210 codec support to MXF encoder

2020-09-18 Thread Carl Eugen Hoyos
> Am 17.09.2020 um 23:34 schrieb Swami Kevala : > > Verified the container_ui and element_ui with a sample file produced by > Sony Server 1.3.0.0.1 (Sony MXF Development Kit (Win32) 4.9.1.118.1) Imo - and this is not meant to block your patch - it would make more sense to test the file

Re: [FFmpeg-devel] [PATCH v5 2/2] libavformat/webp: add WebP demuxer

2020-09-12 Thread Carl Eugen Hoyos
Am Fr., 11. Sept. 2020 um 08:36 Uhr schrieb Josef Zlomek : This is not the requested review, I am just curious about the behaviour: > +static int webp_probe(const AVProbeData *p) > +{ > +const uint8_t *b = p->buf; > + > +if (AV_RB32(b) == MKBETAG('R', 'I', 'F', 'F') && > +

[FFmpeg-devel] [PATCH]lavfi/vflip: Support Bayer vertical flip

2020-09-05 Thread Carl Eugen Hoyos
Hi! Attached patch fixes ticket #8819. Please comment, Carl Eugen From 61f4e419cbeae3d0adb726578bc1c8d87fb0c50b Mon Sep 17 00:00:00 2001 From: Carl Eugen Hoyos Date: Sat, 5 Sep 2020 21:14:01 +0200 Subject: [PATCH] lavfi/vflip: Support Bayer vertical flip. Fixes ticket #8819. --- libavfilter

[FFmpeg-devel] [PATCH]lavc/tiff: Do not fail for an ICC profile with invalid type

2020-09-05 Thread Carl Eugen Hoyos
Hi! Attached patch fixes ticket 8884. Please comment, Carl Eugen From 0f7a5c6d2c739119ceb50fd8efd570807b8c7eb5 Mon Sep 17 00:00:00 2001 From: Carl Eugen Hoyos Date: Sat, 5 Sep 2020 19:22:54 +0200 Subject: [PATCH] lavc/tiff: Do not fail for an ICC profile with invalid type. Fixes ticket #8884

Re: [FFmpeg-devel] [PATCH]lavf/img2dec: Autodetect Photo CD images

2020-09-05 Thread Carl Eugen Hoyos
Am Do., 20. Dez. 2018 um 01:00 Uhr schrieb Carl Eugen Hoyos : > Attached patch depends on Paul's PhotoCD decoder. Patch applied. Carl Eugen ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-de

Re: [FFmpeg-devel] [PATCH v3] avformat: add mca demuxer

2020-09-03 Thread Carl Eugen Hoyos
Am Do., 3. Sept. 2020 um 01:17 Uhr schrieb : > +static int probe(const AVProbeData *p) > +{ > +if (AV_RL32(p->buf) == MKTAG('M', 'A', 'D', 'P') && > +AV_RL16(p->buf + 4) <= 0xff) > +return AVPROBE_SCORE_MAX / 3 * 2; > +return 0; > +} > +if (version <= 4) { > +

Re: [FFmpeg-devel] [PATCH] avformat: add mca demuxer

2020-09-01 Thread Carl Eugen Hoyos
Am Mi., 2. Sept. 2020 um 00:58 Uhr schrieb : > +static int probe(const AVProbeData *p) > +{ > +if (AV_RL32(p->buf) == MKTAG('M', 'A', 'D', 'P') && > +(AV_RL16(p->buf + 4) > 0x00 || AV_RL16(p->buf + 4) <= 0xff)) > +return AVPROBE_SCORE_MAX / 3 * 2; > +return 0; At least

Re: [FFmpeg-devel] libopenjpeg decoder not correctly setting the pixel format for cinema JP2K wrapped MXF

2020-09-01 Thread Carl Eugen Hoyos
Am Di., 1. Sept. 2020 um 19:32 Uhr schrieb Rémi Achard : > We can use the native decoder yes, not sure what the state is right now > though, because I heard that some work was ongoing on that decoder, but > back then (approx. 1 year ago) it was not really an option due to its poor > performance,

Re: [FFmpeg-devel] libopenjpeg decoder not correctly setting the pixel format for cinema JP2K wrapped MXF

2020-09-01 Thread Carl Eugen Hoyos
Am Di., 1. Sept. 2020 um 12:14 Uhr schrieb Rémi Achard : > > > Do you have a sample that does not work with the native decoder? > > According to my tests, the native decoder detect pixel format just fine So what problem do you see? Yes, we prefer using the native codecs over external

Re: [FFmpeg-devel] libopenjpeg decoder not correctly setting the pixel format for cinema JP2K wrapped MXF

2020-08-30 Thread Carl Eugen Hoyos
Am So., 30. Aug. 2020 um 21:39 Uhr schrieb Paul B Mahol : > > On 8/30/20, Carl Eugen Hoyos wrote: > > Am So., 30. Aug. 2020 um 19:28 Uhr schrieb Rémi Achard > > : > > > >> As you are probably aware, the libopenjpeg decoder is not able > >> to interpret c

Re: [FFmpeg-devel] libopenjpeg decoder not correctly setting the pixel format for cinema JP2K wrapped MXF

2020-08-30 Thread Carl Eugen Hoyos
Am So., 30. Aug. 2020 um 19:28 Uhr schrieb Rémi Achard : > As you are probably aware, the libopenjpeg decoder is not able > to interpret cinema jp2k mxf correctly, the pixel format being > assigned as rgb48 instead of xyz12 as it should. Do you have a cinema xyz12 sample that does not work with

Re: [FFmpeg-devel] libopenjpeg decoder not correctly setting the pixel format for cinema JP2K wrapped MXF

2020-08-30 Thread Carl Eugen Hoyos
Am So., 30. Aug. 2020 um 19:28 Uhr schrieb Rémi Achard : > As you are probably aware, the libopenjpeg decoder is not able > to interpret cinema jp2k mxf correctly, the pixel format being > assigned as rgb48 instead of xyz12 as it should. Do you have a sample that does not work with the native

Re: [FFmpeg-devel] [FFmpeg-cvslog] avfilter/yadif: simplify the code for better readability

2020-08-26 Thread Carl Eugen Hoyos
Am Mi., 26. Aug. 2020 um 14:55 Uhr schrieb Limin Wang : > > ffmpeg | branch: master | Limin Wang | Wed Aug 12 > 00:21:54 2020 +0800| [2a9b934675b9e2d3850b46f8a618c19b03f02551] | committer: > Limin Wang > > avfilter/yadif: simplify the code for better readability This broke compilation of

Re: [FFmpeg-devel] [PATCH]lavf/rtpdec_jpeg: Fix JFIF version

2020-08-25 Thread Carl Eugen Hoyos
Am Fr., 22. Mai 2020 um 22:39 Uhr schrieb Michael Niedermayer : > > On Thu, May 21, 2020 at 10:05:57PM +0200, Carl Eugen Hoyos wrote: > > Hi! > > > > When receiving jpeg frames via rtp, libavformat currently writes a > > wrong JFIF version (2.01 instead of 1.02), see

Re: [FFmpeg-devel] [PATCH]doc/examples: Always open files as "binary", not "text"

2020-08-25 Thread Carl Eugen Hoyos
Am Do., 25. Juni 2020 um 00:04 Uhr schrieb Carl Eugen Hoyos : > Attached patch fixes ticket #8638 and the only other occurrence of > fopen() without b in doc/examples. Patch applied. Carl Eugen ___ ffmpeg-devel mailing list ffmpeg-devel@ffmp

Re: [FFmpeg-devel] [PATCH]lavc: Lower MediaFoundation encoder priority

2020-08-25 Thread Carl Eugen Hoyos
Am Mi., 24. Juni 2020 um 12:02 Uhr schrieb Moritz Barsnick : > > On Tue, Jun 23, 2020 at 20:43:34 +0200, Carl Eugen Hoyos wrote: > > Pushed with that change, Carl Eugen > > I suggest backporting this to 4.3, where MediaFoundation support was > added (and this issue is present

Re: [FFmpeg-devel] [PATCH]lavfi/hflip: Support Bayer pixel formats

2020-08-24 Thread Carl Eugen Hoyos
Am So., 26. Juli 2020 um 21:59 Uhr schrieb Carl Eugen Hoyos : > > Am So., 26. Juli 2020 um 21:28 Uhr schrieb Paul B Mahol : > > > > On 7/26/20, Carl Eugen Hoyos wrote: > > > Hi! > > > > > > Attached patch fixes a part of ticket #8819. > > >

Re: [FFmpeg-devel] [PATCH]lavf/mxfdec: Limit score for strangely cut files

2020-08-24 Thread Carl Eugen Hoyos
Am Di., 25. Aug. 2020 um 00:48 Uhr schrieb Tomas Härdin : > > mån 2020-08-24 klockan 21:42 +0200 skrev Carl Eugen Hoyos: > > Hi! > > > > Attached patch fixes ticket #8846, the sample there is both a mov and > > an mxf file. > > It is not entirely clear to me if

Re: [FFmpeg-devel] [PATCH]lavf/mpegts: Support mulaw audio in Lorex LNC recordings

2020-08-24 Thread Carl Eugen Hoyos
Am Mo., 24. Aug. 2020 um 21:56 Uhr schrieb Carl Eugen Hoyos : > Attached patch allows audio decoding in Lorex LNC recordings, > tested with hi- and low-res files. Sorry. this cannot work, not sure how to detect such recordings. Carl Eugen ___

[FFmpeg-devel] [PATCH]lavf/mpegts: Support mulaw audio in Lorex LNC recordings

2020-08-24 Thread Carl Eugen Hoyos
Hi! Attached patch allows audio decoding in Lorex LNC recordings, tested with hi- and low-res files. Please comment, Carl Eugen From 4ade92cd6612a21226ea42113bb66deacfd2b8e1 Mon Sep 17 00:00:00 2001 From: Carl Eugen Hoyos Date: Mon, 24 Aug 2020 21:52:52 +0200 Subject: [PATCH] lavf/mpegts

[FFmpeg-devel] [PATCH]lavf/mxfdec: Limit score for strangely cut files

2020-08-24 Thread Carl Eugen Hoyos
solutions welcome, Carl Eugen From 4e6ff4465f9d2928b181b5cfc652d45b703a82f4 Mon Sep 17 00:00:00 2001 From: Carl Eugen Hoyos Date: Mon, 24 Aug 2020 21:37:00 +0200 Subject: [PATCH] lavf/mxfdec: Limit score for strangely cut files. Only return AVPROBE_SCORE_MAX if the header partition pack key

<    1   2   3   4   5   6   7   8   9   10   >