Re: [FFmpeg-devel] [PATCH v1] avfilter: Add tonemap vaapi filter for H2S

2019-11-12 Thread Carl Eugen Hoyos
Hi! > Am 12.11.2019 um 17:59 schrieb Xinpeng Sun : > > It performs HDR(High Dynamic Range) to SDR(Standard Dynamic Range) conversion > with tone-mapping. It supports HDR10 only as input temporarily. > > H2S: P010 -> NV12 No objection here but could you tell us if you (Intel) already have a

Re: [FFmpeg-devel] [PATCH] lavf/mov: initial support for reading HEIF images

2019-11-12 Thread Carl Eugen Hoyos
> Am 12.11.2019 um 09:09 schrieb Dale Curtis : > >> On Fri, Nov 1, 2019 at 4:46 PM Carl Eugen Hoyos wrote: >> >> Testing would be helpful. >> >> > Works for AVIF after adding the line I proposed as well as setting > codecpar->width/height fo

Re: [FFmpeg-devel] [PATCH 5/5] avformat: add an AV1 Annex B demuxer

2019-11-11 Thread Carl Eugen Hoyos
> Am 11.11.2019 um 22:36 schrieb James Almer : > > +AVInputFormat ff_obu_demuxer = { > +.name = "obu", Why is the demuxer not called “av1”? Thank you, Carl Eugen (Sleepless in Japan) ___ ffmpeg-devel mailing list

Re: [FFmpeg-devel] [PATCH] avcodec/v4l2_m2m_enc: Check encoder pix_fmt matches pix_fmt on device

2019-11-10 Thread Carl Eugen Hoyos
> Am 11.11.2019 um 04:42 schrieb Andriy Gelman : > > +/* check configured pix_fmt matches avctx->pix_fmt */ Is this comment really useful? > +pix_fmt_output = ff_v4l2_format_v4l2_to_avfmt(v4l2_fmt_output, > AV_CODEC_ID_RAWVIDEO); > +if (pix_fmt_output != avctx->pix_fmt) { > +

Re: [FFmpeg-devel] [PATCH v2] avformat/utils: Fixes misdetection of zYLx.wav

2019-11-06 Thread Carl Eugen Hoyos
> Am 07.11.2019 um 02:23 schrieb lance.lmw...@gmail.com: > > From: Limin Wang > > Signed-off-by: Limin Wang > --- > libavformat/wavdec.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/libavformat/wavdec.c b/libavformat/wavdec.c > index 52194f54ef..109c931a22

Re: [FFmpeg-devel] [PATCH 1/2] configure: select missing rdft for several filters

2019-11-06 Thread Carl Eugen Hoyos
Am Mi., 6. Nov. 2019 um 20:52 Uhr schrieb Lou Logan : > > afir, sinc, superequalizer, surround > > Signed-off-by: Lou Logan You could add the additional information to the commit messages... Carl Eugen ___ ffmpeg-devel mailing list

Re: [FFmpeg-devel] [PATCH v1] avformat/utils: Fixes misdetection of zYLx.wav

2019-11-06 Thread Carl Eugen Hoyos
Am Mi., 6. Nov. 2019 um 12:01 Uhr schrieb Limin Wang : > > On Wed, Nov 06, 2019 at 11:30:41AM +0100, Hendrik Leppkes wrote: > > On Wed, Nov 6, 2019 at 10:01 AM wrote: > > > > > > From: Limin Wang > > > > > > Signed-off-by: Limin Wang > > > --- > > > libavformat/utils.c | 3 +-- > > > 1 file

Re: [FFmpeg-devel] [PATCH v1] avformat/utils: Fixes misdetection of zYLx.wav

2019-11-06 Thread Carl Eugen Hoyos
Am Mi., 6. Nov. 2019 um 12:21 Uhr schrieb Limin Wang : > > On Wed, Nov 06, 2019 at 11:18:10AM +0100, Carl Eugen Hoyos wrote: > > Am Mi., 6. Nov. 2019 um 10:01 Uhr schrieb : > > > > > > From: Limin Wang > > > > > > Signed-off-by: Limin Wang >

Re: [FFmpeg-devel] [PATCH v1] avfilter/vf_vaguedenoiser: use fabsf() instead of FFABS()

2019-11-06 Thread Carl Eugen Hoyos
Am Mi., 6. Nov. 2019 um 12:04 Uhr schrieb Limin Wang : > > On Wed, Nov 06, 2019 at 11:11:08AM +0100, Carl Eugen Hoyos wrote: > > Am Mi., 6. Nov. 2019 um 10:31 Uhr schrieb : > > > > > > From: Limin Wang > > > > > > Signed-off-by: Limin Wang >

Re: [FFmpeg-devel] [PATCH] fftools/ffmpeg_opt: Fix mixed declarations and code

2019-11-06 Thread Carl Eugen Hoyos
Am Mi., 6. Nov. 2019 um 13:18 Uhr schrieb Andreas Rheinhardt : > > Introduced in ed3c317d. > > Signed-off-by: Andreas Rheinhardt > --- > fftools/ffmpeg_opt.c | 6 -- > 1 file changed, 4 insertions(+), 2 deletions(-) > > diff --git a/fftools/ffmpeg_opt.c b/fftools/ffmpeg_opt.c > index

Re: [FFmpeg-devel] [FFmpeg-cvslog] avcodec/libvpxdec: reject video and alpha dimension mismatches

2019-11-06 Thread Carl Eugen Hoyos
Am Mi., 6. Nov. 2019 um 08:28 Uhr schrieb Marton Balint : > > ffmpeg | branch: master | Marton Balint | Sun Oct 27 > 18:10:36 2019 +0100| [c54268ce02f71c144d444a5e6d35417d5f043ed5] | committer: > James Zern > > avcodec/libvpxdec: reject video and alpha dimension mismatches > > Signed-off-by:

Re: [FFmpeg-devel] [PATCH v1] avformat/utils: Fixes misdetection of zYLx.wav

2019-11-06 Thread Carl Eugen Hoyos
Am Mi., 6. Nov. 2019 um 10:01 Uhr schrieb : > > From: Limin Wang > > Signed-off-by: Limin Wang > --- > libavformat/utils.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/libavformat/utils.c b/libavformat/utils.c > index 8196442dd1..8381498e2b 100644 > ---

Re: [FFmpeg-devel] [PATCH] avformat/utils: fix logic failure

2019-11-06 Thread Carl Eugen Hoyos
Am Di., 29. Okt. 2019 um 13:15 Uhr schrieb Paul B Mahol : > > On 10/29/19, Michael Niedermayer wrote: > > On Tue, Oct 29, 2019 at 10:45:20AM +0100, Paul B Mahol wrote: > >> Fixes decoding of wav file which is wrongly recognized as mp1 audio. > >> > >> Signed-off-by: Paul B Mahol > >> --- > >>

Re: [FFmpeg-devel] [PATCH v1] avfilter/vf_vaguedenoiser: use fabsf() instead of FFABS()

2019-11-06 Thread Carl Eugen Hoyos
Am Mi., 6. Nov. 2019 um 10:31 Uhr schrieb : > > From: Limin Wang > > Signed-off-by: Limin Wang > --- > libavfilter/vf_vaguedenoiser.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/libavfilter/vf_vaguedenoiser.c b/libavfilter/vf_vaguedenoiser.c > index

Re: [FFmpeg-devel] [PATCH 2/5] avcodec/nuv: Move comptype check up

2019-11-05 Thread Carl Eugen Hoyos
Am Sa., 2. Nov. 2019 um 17:08 Uhr schrieb Michael Niedermayer : > > Fixes: Timeout (23sec -> 5ms) > Fixes: > 18517/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_NUV_fuzzer-5753135536013312 > > Found-by: continuous fuzzing process >

Re: [FFmpeg-devel] [PATCH v2 0/2] lavf/isom: support for demuxing MPEG-H 3D Audio in MP4

2019-11-05 Thread Carl Eugen Hoyos
Am Mi., 30. Okt. 2019 um 03:52 Uhr schrieb Yuki.Tsuchiya : > Here is the sample content of the MPEG-H 3D Audio. > https://www.filehosting.org/file/details/829625/mpeg-h_3d_audio_mhm1_sample.mp4 Does not work here, please use any other filehoster. Thank you, Carl Eugen

Re: [FFmpeg-devel] [PATCH v3 1/2] lavf/isom: support for demuxing MPEG-H 3D Audio in MP4

2019-11-05 Thread Carl Eugen Hoyos
Am Fr., 1. Nov. 2019 um 06:24 Uhr schrieb Yuki Tsuchiya : > > Implemented according to the specification at > https://www.iso.org/standard/69561.html > The "mhm1" sample entry is registered with MP4RA, which is defined as MHAS > encapsulated single stream MPEG-H 3D Audio. > "MHAS" stands for

Re: [FFmpeg-devel] [PATCH 5/5] avcodec/g729dec: Use 64bit and clip in scalar product

2019-11-05 Thread Carl Eugen Hoyos
Am Mi., 6. Nov. 2019 um 00:31 Uhr schrieb Michael Niedermayer : > > The G729 reference clips after each individual operation and keeps > track if overflow occurred (in the fixed point implementation) I believe this is missing the word "decoder". Carl Eugen

Re: [FFmpeg-devel] [PATCH 1/4] configure: select mdct for dca encoder

2019-11-05 Thread Carl Eugen Hoyos
Am Di., 5. Nov. 2019 um 20:36 Uhr schrieb Lou Logan : [...] Set lgtm. Thank you, Carl Eugen ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email

Re: [FFmpeg-devel] [PATCH 1/8] configure: select mdct & sinewin for atrac3pal decoder

2019-11-04 Thread Carl Eugen Hoyos
Am Di., 5. Nov. 2019 um 00:45 Uhr schrieb Lou Logan : [...] Set lgtm. Carl Eugen ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email

Re: [FFmpeg-devel] [PATCH] avdevice/v4l2: Change assert type when format not supported

2019-11-03 Thread Carl Eugen Hoyos
Am So., 3. Nov. 2019 um 18:03 Uhr schrieb Andriy Gelman : > > On Sun, 03. Nov 17:37, Nicolas George wrote: > > Andriy Gelman (12019-11-03): > > > From: Andriy Gelman > > > > > > Currently an av_assert0 is triggered when a target format is not > > > supported by a v4l2 device. Replace by

Re: [FFmpeg-devel] [PATCH] avcodec/dvdec: correctly decode bottom mb row in 1080i field mode

2019-11-03 Thread Carl Eugen Hoyos
Am Sa., 2. Nov. 2019 um 20:02 Uhr schrieb Baptiste Coudurier : > > On Wed, Sep 11, 2019 at 12:29 PM Baptiste Coudurier < > baptiste.coudur...@gmail.com> wrote: > > > --- > > libavcodec/dv.h| 2 ++ > > libavcodec/dvdec.c | 90 +++--- > > 2 files

Re: [FFmpeg-devel] [PATCH] avcodec/dvenc: support encoding dvcprohd

2019-11-03 Thread Carl Eugen Hoyos
Am Sa., 2. Nov. 2019 um 20:06 Uhr schrieb Baptiste Coudurier : > -if (avctx->height > 576) { > -av_log(avctx, AV_LOG_ERROR, "DVCPRO HD encoding is not > supported.\n"); > -return AVERROR_PATCHWELCOME; > -} Please mention ticket #1370. Thank you for the patch, Carl Eugen

Re: [FFmpeg-devel] [PATCH 5/5] avformat/Makefile: add missing pcm dependency to sdx demuxer

2019-11-02 Thread Carl Eugen Hoyos
Am Fr., 1. Nov. 2019 um 23:37 Uhr schrieb Lou Logan : [...] Set lgtm. Thank you, Carl Eugen ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email

Re: [FFmpeg-devel] [PATCH] lavf/mov: initial support for reading HEIF images

2019-11-01 Thread Carl Eugen Hoyos
Am Do., 31. Okt. 2019 um 18:30 Uhr schrieb Dale Curtis : > > On Thu, Oct 31, 2019 at 1:32 AM Swaraj Hota wrote: > > > Yes I will send the patch soon for review. Still a few things left to do. > > > > Swaraj > > > > Great! Let me know if there's anything I can help with. Testing would be helpful.

[FFmpeg-devel] Reimbursement request

2019-10-30 Thread Carl Eugen Hoyos
Hi! I am requesting reimbursement for my travel to the Google mentor summit. My total travelling expenses were € 90,90 Thank you, Carl Eugen ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To

Re: [FFmpeg-devel] [PATCH] lavf/mov: initial support for reading HEIF images

2019-10-30 Thread Carl Eugen Hoyos
Am Mi., 30. Okt. 2019 um 21:05 Uhr schrieb Dale Curtis : > > Was there a reason this never landed? I sympathize with the complexity of > the format, but since AVIF has adopted it as well, it'd be nice to have > ffmpeg support. Feel free to test this tree: https://github.com/Swaraj1998/FFmpeg

Re: [FFmpeg-devel] [PATCH] libavcodec/h261dec: Fix keyframe markup and frame skipping.

2019-10-26 Thread Carl Eugen Hoyos
Am Sa., 26. Okt. 2019 um 13:12 Uhr schrieb Andrey Semashev : > > The decoder never marks pictures as I-frames, which results in no > keyframe indication and incorrect frame skipping, in cases when > keyframes should be decoded. > > This commit works around this decoder limitation and marks

Re: [FFmpeg-devel] [PATCH] add phqm filter and img_hash

2019-10-26 Thread Carl Eugen Hoyos
Am Sa., 26. Okt. 2019 um 14:00 Uhr schrieb : > > From: Christopher Kennedy > > this adds a phqm filter and OpenCV img_hash based resource usable > by the phqm and future filters using image hash functionality > from OpenCV. > C++ to C handling so that full OpenCV functionality and API can > be

Re: [FFmpeg-devel] [PATCH] add phqm filter and img_hash

2019-10-26 Thread Carl Eugen Hoyos
Am Sa., 26. Okt. 2019 um 06:45 Uhr schrieb : > +// convert from avframe to iplimage format > +static int fill_iplimage_from_frame(IplImage *img, const AVFrame *frame, > enum AVPixelFormat pixfmt) > +{ > +IplImage *tmpimg; > +int depth = IPL_DEPTH_8U, channels_nb; > + > +switch

Re: [FFmpeg-devel] [PATCH v1] avcodec/v410dec: add the frame and slice threading support

2019-10-25 Thread Carl Eugen Hoyos
Am Fr., 25. Okt. 2019 um 17:37 Uhr schrieb : > -.capabilities = AV_CODEC_CAP_DR1, > +.capabilities = AV_CODEC_CAP_DR1 | AV_CODEC_CAP_SLICE_THREADS | > +AV_CODEC_CAP_FRAME_THREADS In your tests: Was slice threading or frame threading more effective? Carl Eugen

Re: [FFmpeg-devel] [PATCH] add phqm filter and img_hash

2019-10-25 Thread Carl Eugen Hoyos
Am Fr., 25. Okt. 2019 um 02:24 Uhr schrieb : > +// convert from avframe to iplimage format > +static void fill_iplimage_from_frame(IplImage *img, const AVFrame *frame, > enum AVPixelFormat pixfmt) > +{ > +IplImage *tmpimg; > +int depth, channels_nb; > + > +if (pixfmt ==

Re: [FFmpeg-devel] [PATCH v4 2/2] avfilter: Add tonemap vaapi filter

2019-10-23 Thread Carl Eugen Hoyos
Am 23.10.2019 um 06:48 schrieb Xiang, Haihao : >>> On 11/09/2019 06:39, Zachary Zhou wrote: >>> It supports ICL platform. >>> H2H (HDR to HDR): P010 -> A2R10G10B10 >>> H2S (HDR to SDR): P010 -> ARGB >> >> The input format doesn't have any alpha so the output shouldn't either. Not >> sure what

Re: [FFmpeg-devel] [PATCH] lavf/isom: support for demuxing MPEG-H 3D Audio in MP4

2019-10-17 Thread Carl Eugen Hoyos
> Am 17.10.2019 um 09:57 schrieb Yuki.Tsuchiya : > > Implemented according to the specification at > https://www.iso.org/standard/69561.html > The 'mhm1' sample entry is registered with MP4RA, which is defined as MHAS > encapsulated single stream MPEG-H 3D Audio. > 'MHAS' stands for MPEG-H

Re: [FFmpeg-devel] [PATCH] avutil/eval: add sgn()

2019-10-12 Thread Carl Eugen Hoyos
> Am 12.10.2019 um 11:42 schrieb James Darnley : > >> On 2019-10-11 21:45, Paul B Mahol wrote: >> >> diff --git a/doc/utils.texi b/doc/utils.texi >> index d55dd315c3..4e2e713505 100644 >> --- a/doc/utils.texi >> +++ b/doc/utils.texi >> @@ -920,6 +920,9 @@ corresponding input value will be

Re: [FFmpeg-devel] [PATCH] avcodec/tiff: add support for 16-bit YCbCr images and correct processing of border pixels

2019-10-09 Thread Carl Eugen Hoyos
Am Mi., 9. Okt. 2019 um 21:16 Uhr schrieb Skakov Pavel : > Added support for 16-bit per sample YUV formats. This would allow ffmpeg > to losslessly save (later) and load subsampled 10/16-bit YUV frames in > simple and somewhat standard format. > Corrected handling of border pixels when unpacking

Re: [FFmpeg-devel] [PATCH] avcodec/tiff: add support for 16-bit YCbCr images and correct processing of border pixels

2019-10-09 Thread Carl Eugen Hoyos
Am Mi., 9. Okt. 2019 um 21:16 Uhr schrieb Skakov Pavel : > > Added support for 16-bit per sample YUV formats. This would allow ffmpeg to > losslessly save (later) and load subsampled 10/16-bit YUV frames in simple > and somewhat standard format. > Corrected handling of border pixels when

Re: [FFmpeg-devel] [PATCH] avformat/matroskaenc: don't rescale mastering metadata values

2019-10-03 Thread Carl Eugen Hoyos
Am Fr., 4. Okt. 2019 um 01:59 Uhr schrieb James Almer : > > The rescaling can be done at muxing/encoding time, for formats that require > it. Doesn't this need a micro version bump? Carl Eugen ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org

Re: [FFmpeg-devel] [PATCH] avcodec/tiff: add limited support for ReferenceBlackWhite and YCbCrCoefficients tags

2019-10-03 Thread Carl Eugen Hoyos
Am Do., 3. Okt. 2019 um 20:50 Uhr schrieb Skakov Pavel : > > Add support for properly handling PC/TV ranges and Rec601/Rec709 color spaces. Can't this be implemented without using floats? Carl Eugen ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org

Re: [FFmpeg-devel] [PATCH v3] avformat/movenc: split empty text sample when duration overflow

2019-10-02 Thread Carl Eugen Hoyos
Am Mi., 2. Okt. 2019 um 02:21 Uhr schrieb Jun Li : > > On Tue, Oct 1, 2019 at 4:19 AM Carl Eugen Hoyos wrote: > > > Am Di., 10. Sept. 2019 um 21:12 Uhr schrieb Jun Li : > > > > > > Fix #7637 > > > One empty/end sample is created and inserted between

Re: [FFmpeg-devel] [PATCH] avformat/amr: reduce raw amr false positive detection

2019-10-02 Thread Carl Eugen Hoyos
Am Mi., 2. Okt. 2019 um 22:27 Uhr schrieb Carl Eugen Hoyos : > Another idea is to require different modes This would work for amr-wb but not amr-nb: Silence encoded with libopencore_amrnb looks similar to the provided sample that decodes to noise. Carl Eu

Re: [FFmpeg-devel] [PATCH] avformat/amr: reduce raw amr false positive detection

2019-10-02 Thread Carl Eugen Hoyos
Am Mi., 2. Okt. 2019 um 22:18 Uhr schrieb Carl Eugen Hoyos : > > Am Mi., 2. Okt. 2019 um 20:19 Uhr schrieb Paul B Mahol : > > > > Signed-off-by: Paul B Mahol > > --- > > libavformat/amr.c | 18 -- > > 1 file changed, 12 insertions(+

Re: [FFmpeg-devel] [PATCH] avformat/amr: reduce raw amr false positive detection

2019-10-02 Thread Carl Eugen Hoyos
Am Mi., 2. Okt. 2019 um 20:19 Uhr schrieb Paul B Mahol : > > Signed-off-by: Paul B Mahol > --- > libavformat/amr.c | 18 -- > 1 file changed, 12 insertions(+), 6 deletions(-) > > diff --git a/libavformat/amr.c b/libavformat/amr.c > index 42840a50a3..600cb1b0f0 100644 > ---

Re: [FFmpeg-devel] libavfilter new filter proposal

2019-10-02 Thread Carl Eugen Hoyos
Am Mi., 2. Okt. 2019 um 16:54 Uhr schrieb Alexandre Buisson : > I developed a simple filter to process all the video frame using > any other external process while keeping the simplicity of the > ffmpeg command line to transcode and keep all the properties > of the original file (audio, subtitle,

Re: [FFmpeg-devel] [PATCH]lavc/x264: Use FF_CODEC_CAP_INIT_THREADSAFE if x264 is new

2019-10-01 Thread Carl Eugen Hoyos
Am So., 25. Aug. 2019 um 17:48 Uhr schrieb James Almer : > > On 8/25/2019 11:55 AM, Carl Eugen Hoyos wrote: > > Am So., 25. Aug. 2019 um 16:15 Uhr schrieb Carl Eugen Hoyos > > : > >> Hi! > >> > >> x264 removed the usage of strtok(), using FF_CODEC_CA

Re: [FFmpeg-devel] [PATCH]lavfi/movie: Use filter threads as decoding threads

2019-10-01 Thread Carl Eugen Hoyos
Am So., 25. Aug. 2019 um 18:43 Uhr schrieb Carl Eugen Hoyos : > > Am So., 25. Aug. 2019 um 18:38 Uhr schrieb James Almer : > > > > On 8/25/2019 1:27 PM, Carl Eugen Hoyos wrote: > > > Hi! > > > > > > Attached patch should fix ticket

Re: [FFmpeg-devel] [PATCH] avformat/ivf: Change the length field to 32 bits

2019-10-01 Thread Carl Eugen Hoyos
Am Di., 1. Okt. 2019 um 21:35 Uhr schrieb Raphaël Zumer : > > On Tue, 2019-10-01 at 20:09 +0100, Derek Buitenhuis wrote: > > On 01/10/2019 18:25, James Almer wrote: > > > The value in the unused field will be 0x after this change > > > instead of 0, since you're writing 32 bits as duration

Re: [FFmpeg-devel] [PATCH] cmdutils: trailing options may be ignored

2019-10-01 Thread Carl Eugen Hoyos
Am Sa., 28. Sept. 2019 um 00:52 Uhr schrieb Lou Logan : > > Signed-off-by: Lou Logan > --- > fftools/cmdutils.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/fftools/cmdutils.c b/fftools/cmdutils.c > index 6f4031fbb9..84f98b7c04 100644 > --- a/fftools/cmdutils.c >

Re: [FFmpeg-devel] [PATCH]lavf/avio: Print https warning also for avio_find_protocol_name()

2019-10-01 Thread Carl Eugen Hoyos
Am Do., 26. Sept. 2019 um 03:48 Uhr schrieb Liu Steven : > > > > > 在 2019年9月25日,下午8:11,Carl Eugen Hoyos 写道: > > > > Am Mi., 25. Sept. 2019 um 11:35 Uhr schrieb Carl Eugen Hoyos > > : > >> > >> Hi! > >> > >> Attached patch helps

Re: [FFmpeg-devel] [PATCH] avformat/ivfenc: Encode the number of frames

2019-10-01 Thread Carl Eugen Hoyos
Am Di., 1. Okt. 2019 um 16:59 Uhr schrieb Raphaël Zumer : > > Signed-off-by: Raphaël Zumer > --- > libavformat/ivfenc.c | 3 ++- > libavformat/version.h | 2 +- > 2 files changed, 3 insertions(+), 2 deletions(-) > > diff --git a/libavformat/ivfenc.c b/libavformat/ivfenc.c > index

Re: [FFmpeg-devel] [PATCH v1 1/6] avfilter/af_silencedetect: change parameters order for av_malllocz_array

2019-10-01 Thread Carl Eugen Hoyos
Am Mo., 30. Sept. 2019 um 15:37 Uhr schrieb : > > From: Limin Wang > > Signed-off-by: Limin Wang > --- > libavfilter/af_silencedetect.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/libavfilter/af_silencedetect.c b/libavfilter/af_silencedetect.c > index

Re: [FFmpeg-devel] [PATCH v3] avformat/movenc: split empty text sample when duration overflow

2019-10-01 Thread Carl Eugen Hoyos
Am Di., 10. Sept. 2019 um 21:12 Uhr schrieb Jun Li : > > Fix #7637 > One empty/end sample is created and inserted between two caption lines when > there is a gap. > This patch is to split the sample into multiple ones when its duration is too > long (>= INT_MAX). > --- > libavformat/movenc.c

Re: [FFmpeg-devel] Location header to be ignored with status code 200 (and others)

2019-10-01 Thread Carl Eugen Hoyos
Am Di., 1. Okt. 2019 um 10:32 Uhr schrieb Armin Hasitzka : > sorry for dumping this here with HTML formatting (haven't yet figured out > how to turn it off in Gmail); we ran into a weird HLS playlist today that > sends a malformed location header together with a 200 status code (which is > a

Re: [FFmpeg-devel] [PATCH 5/5] avcodec/flicvideo: Use bytestream2_get_buffer() in flic_decode_frame_15_16BPP() for FLI_COPY

2019-09-28 Thread Carl Eugen Hoyos
Am Sa., 28. Sept. 2019 um 16:52 Uhr schrieb Tomas Härdin : > > tor 2019-09-26 klockan 23:10 +0200 skrev Michael Niedermayer: > > Fixes: Timeout(103sec -> 3sec) > > Fixes: > > 17678/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_FLIC_fuzzer-5715436989054976 > > > > Found-by: continuous fuzzing

Re: [FFmpeg-devel] [PATCH v1 1/2] lavu/pixfmt: add new pixel format a2r10g10b10/a2b10g10r10

2019-09-27 Thread Carl Eugen Hoyos
Am Sa., 28. Sept. 2019 um 02:14 Uhr schrieb Song, Ruiling : > > Am Fr., 27. Sept. 2019 um 11:02 Uhr schrieb Sun, Xinpeng > > : > > > > > > > Add two 10 bit RGBA pixel format for hardware color space conversion > > > > > support in VAAPI and QSV: > > > > > > > > > > 2:10:10:10 10 bit: A2R10G10B10

Re: [FFmpeg-devel] [PATCH 2/2] fate: update references after mov sdtp parsing change

2019-09-27 Thread Carl Eugen Hoyos
Am Fr., 27. Sept. 2019 um 16:45 Uhr schrieb Matthieu Bouron : > > --- > tests/ref/fate/hapqa-extract-snappy1-to-hapalphaonly | 2 +- > tests/ref/fate/hapqa-extract-snappy1-to-hapq | 2 +- > tests/ref/fate/hapqa-extract-snappy16-to-hapalphaonly | 2 +- >

Re: [FFmpeg-devel] [PATCH] lavc/dnxhddec: do not warn if CID == 1271 && CLF == 0 && CLV > 0

2019-09-27 Thread Carl Eugen Hoyos
Am Fr., 27. Sept. 2019 um 09:59 Uhr schrieb Michael Bradshaw : > > The original code requires CID to be 1256 or 1270 if CLV or CLF are set. > This is unnecessarily restrictive. If CLF is 1, then CID must be 1256 or > 1270. But if CLF is 0, then CID may be different. If CLV is 1 or 2, then > CID

Re: [FFmpeg-devel] [PATCH] avcodec/nvenc: multiple reference frames support

2019-09-27 Thread Carl Eugen Hoyos
Am Fr., 27. Sept. 2019 um 14:15 Uhr schrieb Timo Rothenpieler : > > On 27/09/2019 12:28, Roman Arzumanyan wrote: > >> First, this needs SDK Version Guards > > Thanks, I've missed that. Added to patch. > > >> Second, in what way is this different from the existing global > >> option(avctx->refs),

Re: [FFmpeg-devel] [PATCH v1 1/2] lavu/pixfmt: add new pixel format a2r10g10b10/a2b10g10r10

2019-09-27 Thread Carl Eugen Hoyos
Am Fr., 27. Sept. 2019 um 11:02 Uhr schrieb Sun, Xinpeng : > > > Add two 10 bit RGBA pixel format for hardware color space conversion > > > support in VAAPI and QSV: > > > > > > 2:10:10:10 10 bit: A2R10G10B10 > > > 2:10:10:10 10 bit: A2B10G10R10 > > > > Without more explanation, this patch is not

Re: [FFmpeg-devel] [PATCH] Adding a flag to give user the option to have ffmpeg fail instead of warn when mismatches are found in rtmp url stream or application names.

2019-09-25 Thread Carl Eugen Hoyos
Am Mi., 25. Sept. 2019 um 21:04 Uhr schrieb William Martin : > > From: Will Martin > > Motivation: When running multiple rtmp ingest on the same machine on the same > port, users may want to explicitly forbid mismatched rtmp streams from > successfully completing handshakes. This patch allows

Re: [FFmpeg-devel] [PATCH]lavf/avio: Print https warning also for avio_find_protocol_name()

2019-09-25 Thread Carl Eugen Hoyos
Am Mi., 25. Sept. 2019 um 11:35 Uhr schrieb Carl Eugen Hoyos : > > Hi! > > Attached patch helps users fixing ticket #8197. > > Please comment, Carl Eugen From 92a62e4f56f4820d79529060636e0382b33b376b Mon Sep 17 00:00:00 2001 From: Carl Eugen Hoyos Date: Wed, 25 Sep 2019 11:3

[FFmpeg-devel] [PATCH]lavf/avio: Print https warning also for avio_find_protocol_name()

2019-09-25 Thread Carl Eugen Hoyos
Hi! Attached patch helps users fixing ticket #8197. Please comment, Carl Eugen ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email

Re: [FFmpeg-devel] [PATCH v1 1/2] lavu/pixfmt: add new pixel format a2r10g10b10/a2b10g10r10

2019-09-25 Thread Carl Eugen Hoyos
Am Mi., 25. Sept. 2019 um 04:46 Uhr schrieb Xinpeng Sun : > Add two 10 bit RGBA pixel format for hardware color space > conversion support in VAAPI and QSV: > > 2:10:10:10 10 bit: A2R10G10B10 > 2:10:10:10 10 bit: A2B10G10R10 Without more explanation, this patch is not ok. Carl Eugen

Re: [FFmpeg-devel] [PATCH] avcodec/tiff: correct the default value of YCbCrSubsampling

2019-09-25 Thread Carl Eugen Hoyos
Am Di., 24. Sept. 2019 um 20:32 Uhr schrieb Skakov Pavel : > TIFF decoder uses wrong default YCbCrSubsampling value so it breaks > on files that rely on standard default and omit the value. Patch applied. Thank you, Carl Eugen ___ ffmpeg-devel mailing

Re: [FFmpeg-devel] [PATCH 4/6] lavu/hwcontext_vaapi: add vaapi_format_map support for AYUV/Y210/Y410

2019-09-24 Thread Carl Eugen Hoyos
Am Do., 19. Sept. 2019 um 09:11 Uhr schrieb Fu, Linjie : > > 4:2:2: > > * 8-bit: YUYV or similar? > > Supported FourCC is YUY2, and supported decode format is YUYV422; Why is this not AV_PIX_FMT_YUYV422? Carl Eugen ___ ffmpeg-devel mailing list

Re: [FFmpeg-devel] [PATCH 4/6] lavu/hwcontext_vaapi: add vaapi_format_map support for AYUV/Y210/Y410

2019-09-24 Thread Carl Eugen Hoyos
Am Mi., 25. Sept. 2019 um 00:45 Uhr schrieb Mark Thompson : > From what you've said so far, I get the impression that the alpha channel in > your AYUV and Y410 formats is not actually supported at all in the hardware > you have? (That is, there is no support for decoding video with an alpha >

Re: [FFmpeg-devel] [PATCH] avcodec/tiff: correct the default value of YCbCrSubsampling

2019-09-24 Thread Carl Eugen Hoyos
Am Di., 24. Sept. 2019 um 20:32 Uhr schrieb Skakov Pavel : > TIFF decoder uses wrong default YCbCrSubsampling value so it breaks on > files that rely on standard default and omit the value. The patch seems to agree with the specification, can you provide a sample?

Re: [FFmpeg-devel] [PATCH] avcodec/hevc_ps: Remove dead code in vps_id check

2019-09-21 Thread Carl Eugen Hoyos
Am Sa., 21. Sept. 2019 um 04:06 Uhr schrieb Andriy Gelman : > > From: Andriy Gelman > > Since reading 4 bits always returns a value in the range [0, 15], the > check for vps_id >= HEVC_MAX_VPS_COUNT, where HEVC_MAX_VPS_COUNT = 16, is > redudant. > --- > libavcodec/hevc_ps.c | 12 ++-- >

Re: [FFmpeg-devel] [PATCH 1/3] avcodec/mpeg4audio: add a logging context parameter to avpriv_mpeg4audio_get_config()

2019-09-21 Thread Carl Eugen Hoyos
Am So., 22. Sept. 2019 um 00:40 Uhr schrieb James Almer : > > On 9/21/2019 7:38 PM, Carl Eugen Hoyos wrote: > > Am So., 22. Sept. 2019 um 00:36 Uhr schrieb James Almer : > >> > >> On 9/21/2019 7:31 PM, Carl Eugen Hoyos wrote: > >>> Am Sa., 21. S

Re: [FFmpeg-devel] [PATCH 1/3] avcodec/mpeg4audio: add a logging context parameter to avpriv_mpeg4audio_get_config()

2019-09-21 Thread Carl Eugen Hoyos
Am So., 22. Sept. 2019 um 00:36 Uhr schrieb James Almer : > > On 9/21/2019 7:31 PM, Carl Eugen Hoyos wrote: > > Am Sa., 21. Sept. 2019 um 17:53 Uhr schrieb James Almer : > > > >> This is an ABI change, so it's scheduled for the next bump. > > > > Why don'

Re: [FFmpeg-devel] [PATCH 1/3] avcodec/mpeg4audio: add a logging context parameter to avpriv_mpeg4audio_get_config()

2019-09-21 Thread Carl Eugen Hoyos
Am Sa., 21. Sept. 2019 um 17:53 Uhr schrieb James Almer : > This is an ABI change, so it's scheduled for the next bump. Why don't you add avpriv_mpeg4audio_get_config2() now? Carl Eugen ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org

Re: [FFmpeg-devel] [PATCH] lavf/mp3dec: increase probe score of buffers entirely composed of valid packets

2019-09-21 Thread Carl Eugen Hoyos
Am Sa., 21. Sept. 2019 um 20:16 Uhr schrieb Rodger Combs : > > Fixes some files misdetecting as MPEG PS The reason for the misdetection (mp3 file with 50k header that contains a mjpeg cover) are the following "lame tags" (I couldn't immediately find out what they really are) which nearly all

Re: [FFmpeg-devel] [PATCH v2] avcodec/v210enc: add yuv420p/yuv420p10 input pixel format support

2019-09-21 Thread Carl Eugen Hoyos
Am Sa., 21. Sept. 2019 um 16:49 Uhr schrieb Limin Wang : > however the patch try to fix the autoscale, if user prefer to use > swscale conversion, he can use it still by claims pix_fmt clearly. This seems like a very bad argument assuming there is a quality hit and the speed gain is very

Re: [FFmpeg-devel] [PATCH] lavf/movdec: add position_order option

2019-09-21 Thread Carl Eugen Hoyos
Am Sa., 21. Sept. 2019 um 19:58 Uhr schrieb Rodger Combs : > +{ "position_order", "Read packets in position order (rather than > timestamp order)", > +OFFSET(position_order), AV_OPT_TYPE_BOOL, {.i64 = 0}, 0, 1, FLAGS }, Should this also say "avoids seeks"? Carl Eugen

Re: [FFmpeg-devel] Is it ok to add G.722.1 decoder as external lib?

2019-09-21 Thread Carl Eugen Hoyos
Am Sa., 21. Sept. 2019 um 16:51 Uhr schrieb Ronald S. Bultje : > So it appears, from the discussion (..), that although there is source > code, it is not actually "open" in the sense that it's not redistributable > (at least not explicitly so) or modifiable? If I were hosting a copy on, > say,

Re: [FFmpeg-devel] Is it ok to add G.722.1 decoder as external lib?

2019-09-21 Thread Carl Eugen Hoyos
Am Sa., 21. Sept. 2019 um 16:25 Uhr schrieb Nicolas George : > > I believe you misunderstand. > > You are entitled to your beliefs. Let us discuss arguments on this > mailing-list. > > Can we close the subject now? And again, you cut the relevant part: Are you maybe less interested in arguments

Re: [FFmpeg-devel] Is it ok to add G.722.1 decoder as external lib?

2019-09-21 Thread Carl Eugen Hoyos
Am Sa., 21. Sept. 2019 um 16:07 Uhr schrieb Nicolas George : > > Carl Eugen Hoyos (12019-09-21): > > I now wonder if this isn't much nicer than "You may use this FDK AAC > > Codec software or modifications thereto only for purposes that are > > authorized b

Re: [FFmpeg-devel] Is it ok to add G.722.1 decoder as external lib?

2019-09-21 Thread Carl Eugen Hoyos
Am Sa., 21. Sept. 2019 um 15:19 Uhr schrieb Nicolas George : > > Carl Eugen Hoyos (12019-09-21): > > I did and I ask you. > > Please tell me how you can think that "require the licencing of patents > from Polycom" is compatible with "shall not restrict any

Re: [FFmpeg-devel] Is it ok to add G.722.1 decoder as external lib?

2019-09-21 Thread Carl Eugen Hoyos
Am Sa., 21. Sept. 2019 um 15:11 Uhr schrieb Nicolas George : > > Carl Eugen Hoyos (12019-09-21): > > But I wonder now which specific part of the OSI definition is not met > > by libg7221 in your opinion? > > Read the license, read the OSD. I did and I ask you. Note th

Re: [FFmpeg-devel] [PATCH v2] avcodec/v210enc: add yuv420p/yuv420p10 input pixel format support

2019-09-21 Thread Carl Eugen Hoyos
Am Sa., 21. Sept. 2019 um 14:42 Uhr schrieb : > > From: Limin Wang > > With the patch, we simply reuse the same source chroma line for each pair > of lines in the output Is there really no quality hit for a 20% speed-up? Carl Eugen ___ ffmpeg-devel

Re: [FFmpeg-devel] Is it ok to add G.722.1 decoder as external lib?

2019-09-21 Thread Carl Eugen Hoyos
Am Sa., 21. Sept. 2019 um 15:03 Uhr schrieb Nicolas George : > > Carl Eugen Hoyos (12019-09-21): > > The FSF does make a difference between open-source software and > > free software, I believe they are more qualified than you are. > > The FSF is known to make a f

Re: [FFmpeg-devel] Is it ok to add G.722.1 decoder as external lib?

2019-09-21 Thread Carl Eugen Hoyos
Am Sa., 21. Sept. 2019 um 14:48 Uhr schrieb Nicolas George : > > Carl Eugen Hoyos (12019-09-21): > > This is obviously not true as there are licenses that - for example - > > only allow non-commercial distribution. > > They are therefore not Open Source. You obvi

Re: [FFmpeg-devel] Is it ok to add G.722.1 decoder as external lib?

2019-09-21 Thread Carl Eugen Hoyos
Am Sa., 21. Sept. 2019 um 14:43 Uhr schrieb Nicolas George : > There is almost no practical difference between Free Software > and Open Source. This is obviously not true as there are licenses that - for example - only allow non-commercial distribution. Carl Eugen

Re: [FFmpeg-devel] Is it ok to add G.722.1 decoder as external lib?

2019-09-21 Thread Carl Eugen Hoyos
Am Sa., 21. Sept. 2019 um 14:35 Uhr schrieb Nicolas George : > > Carl Eugen Hoyos (12019-09-21): > > Both libraries are open-source > > Please re-read my mail from 13:41:34 +0200 and the license I pointed at > 13:55:53 +0200. > > And just in case you managed to

Re: [FFmpeg-devel] Is it ok to add G.722.1 decoder as external lib?

2019-09-21 Thread Carl Eugen Hoyos
Am Sa., 21. Sept. 2019 um 14:29 Uhr schrieb Nicolas George : > > Carl Eugen Hoyos (12019-09-21): > > So what is the difference between open-source software with a license > > incompatible > > with the GPL and an open-source software with a license incompatible > > wit

Re: [FFmpeg-devel] Is it ok to add G.722.1 decoder as external lib?

2019-09-21 Thread Carl Eugen Hoyos
Am Sa., 21. Sept. 2019 um 13:56 Uhr schrieb Nicolas George : > > Carl Eugen Hoyos (12019-09-21): > > Could you elaborate? > > I can point you to the license file: > > https://github.com/traviscross/freeswitch/blob/master/libs/libg722_1/COPYING So what is the differ

Re: [FFmpeg-devel] Is it ok to add G.722.1 decoder as external lib?

2019-09-21 Thread Carl Eugen Hoyos
Am Sa., 21. Sept. 2019 um 13:41 Uhr schrieb Nicolas George : > > Carl Eugen Hoyos (12019-09-21): > > > Non-free originally came to be because of fdk-aac, which is open > > > source but doesn't meet the requirements of the (L)GPL. > > How is that different from libg

Re: [FFmpeg-devel] Is it ok to add G.722.1 decoder as external lib?

2019-09-21 Thread Carl Eugen Hoyos
Am Do., 19. Sept. 2019 um 09:10 Uhr schrieb Tomas Härdin : > Non-free originally came to be because of fdk-aac, which is open > source but doesn't meet the requirements of the (L)GPL. How is that different from libg7221? Carl Eugen ___ ffmpeg-devel

Re: [FFmpeg-devel] Ableton live aiff file

2019-09-20 Thread Carl Eugen Hoyos
Am Fr., 20. Sept. 2019 um 10:30 Uhr schrieb Carl Eugen Hoyos : > > https://files-adamj-eu.s3.amazonaws.com/ffmpeg-devel/Raylon-190-Full.aif > > https://files-adamj-eu.s3.amazonaws.com/ffmpeg-devel/Raylon-190-Full.wav > Thank you for posting the samples! > They are &q

Re: [FFmpeg-devel] Ableton live aiff file

2019-09-20 Thread Carl Eugen Hoyos
Am Fr., 20. Sept. 2019 um 09:58 Uhr schrieb Adam Johnson : > > I have some aiff files in my music production library that I'd like to > convert to flac. However they aren't recognized by ffmpeg: > > $ ffmpeg -i Raylon-190-Full.aif > ... > [aiff @ 0x7fc3ce80] unknown or unsupported codec tag:

Re: [FFmpeg-devel] [PATCH]lavfi/movie: Use filter threads as decoding threads

2019-09-19 Thread Carl Eugen Hoyos
Am So., 25. Aug. 2019 um 18:43 Uhr schrieb Carl Eugen Hoyos : > > Am So., 25. Aug. 2019 um 18:38 Uhr schrieb James Almer : > > > > On 8/25/2019 1:27 PM, Carl Eugen Hoyos wrote: > > > Hi! > > > > > > Attached patch should fix ticket

Re: [FFmpeg-devel] [PATCH 05/11] avformat/nutenc: Don't pass NULL to memcmp

2019-09-19 Thread Carl Eugen Hoyos
Am Fr., 20. Sept. 2019 um 00:30 Uhr schrieb Andreas Rheinhardt : > > Fixes lots of FATE tests, e.g. lavf-nut, as well as the nut part of > ticket #7980. > > Signed-off-by: Andreas Rheinhardt > --- > This patch is made to match the previous behaviour; whether the previous > behaviour is correct at

Re: [FFmpeg-devel] [PATCH 00/11] Fix undefined behaviour

2019-09-19 Thread Carl Eugen Hoyos
Am Fr., 20. Sept. 2019 um 00:23 Uhr schrieb Andreas Rheinhardt : > > 1. When one uses UBSan (Undefined behaviour sanitizer) compiled with the > -fsanitize-trap=undefined option (that makes the resulting binary trap > on undefined behaviour instead of simply emitting a warning), lots of > FATE

[FFmpeg-devel] [PATCH]lavc/opus: Create extradata if it is missing

2019-09-19 Thread Carl Eugen Hoyos
Hi! Attached patch fixes remuxing opus from sdp, reported by Juan Navarro. Please comment, Carl Eugen From 957e568e7dd1c2acc0ea29dad122919c8c9e05ce Mon Sep 17 00:00:00 2001 From: Carl Eugen Hoyos Date: Fri, 20 Sep 2019 00:29:16 +0200 Subject: [PATCH] lavc/opus: Create extradata if it is missing

Re: [FFmpeg-devel] [PATCH 05/10] avformat/asfdec_o: Unify switch cases

2019-09-18 Thread Carl Eugen Hoyos
Am Mi., 18. Sept. 2019 um 05:33 Uhr schrieb Andreas Rheinhardt : > > Found via PVS-Studio (see ticket #8156). > > Signed-off-by: Andreas Rheinhardt > --- > libavformat/asfdec_o.c | 4 +--- Instead please remove this demuxer, it cannot be used for any testing. Carl Eugen

Re: [FFmpeg-devel] Is it ok to add G.722.1 decoder as external lib?

2019-09-18 Thread Carl Eugen Hoyos
Am Di., 17. Sept. 2019 um 02:37 Uhr schrieb Hyun Yoo : > > I implemented a g.722.1 decoder by linking FreeSwitch's libg722_1 > as external lib like libilbc, libspeex(ex. configure --enable-libg722_1) > (https://github.com/traviscross/freeswitch/tree/master/libs/libg722_1) Please provide your

Re: [FFmpeg-devel] Is it ok to add G.722.1 decoder as external lib?

2019-09-18 Thread Carl Eugen Hoyos
Am Di., 17. Sept. 2019 um 10:14 Uhr schrieb Andrey Semashev : > > On 2019-09-17 03:29, Hyun Yoo wrote: > > I implemented a g.722.1 decoder by linking FreeSwitch's libg722_1 > > as external lib like libilbc, libspeex(ex. configure --enable-libg722_1) > >

Re: [FFmpeg-devel] [PATCH v4 2/4] fate: Overwrite output file in hevc-bsf-mp4toannexb test

2019-09-18 Thread Carl Eugen Hoyos
Am Mi., 18. Sept. 2019 um 23:15 Uhr schrieb Andriy Gelman : > > On Wed, 18. Sep 22:34, Carl Eugen Hoyos wrote: > > Am Mi., 18. Sept. 2019 um 21:38 Uhr schrieb Andriy Gelman > > : > > > > > > From: Andriy Gelman > > > > > > Overwrite test

Re: [FFmpeg-devel] [PATCH v4 2/4] fate: Overwrite output file in hevc-bsf-mp4toannexb test

2019-09-18 Thread Carl Eugen Hoyos
Am Mi., 18. Sept. 2019 um 21:38 Uhr schrieb Andriy Gelman : > > From: Andriy Gelman > > Overwrite tests/data/fate/hevc-bsf-mp4toannexb.out in case it exists. > --- > tests/fate/hevc.mak | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/tests/fate/hevc.mak

Re: [FFmpeg-devel] Is it ok to add G.722.1 decoder as external lib?

2019-09-18 Thread Carl Eugen Hoyos
> Am 18.09.2019 um 10:52 schrieb Paul B Mahol : > >> On 9/18/19, Carl Eugen Hoyos wrote: >> >> >> >>> Am 18.09.2019 um 07:34 schrieb Hyun Yoo : >>> >>> How can I mark the new external codec as “nonfree” in configure? >> &g

<    4   5   6   7   8   9   10   11   12   13   >