On 6/10/2024 2:23 PM, Frank Plowman wrote:
On 10/06/2024 14:26, Nuo Mi wrote:
Hi Frank,
Thank you for the patch.
Could we follow the naming conventions used for other clips?
Hi,
I did it this way because I do not have access to the FATE server, so
somebody had to upload the clip for me and I
On 6/9/2024 12:36 PM, James Almer wrote:
So I would not add these SSE2 versions. But the one missing SSSE3
version (shuffle_bytes_2103_ssse3) is of course worth it.
I will look into that.
I'm not sure why you said it's missing, because it's
On 6/8/2024 12:55 PM, Andreas Rheinhardt wrote:
James Almer:
On 6/6/2024 11:48 AM, Andreas Rheinhardt wrote:
James Almer:
And remove shuffle_bytes_2103_mmxext.
shuffle_bytes_0321_c: 28.1
shuffle_bytes_0321_sse2: 13.6
shuffle_bytes_0321_ssse3: 9.6
shuffle_bytes_0321_avx2: 7.1
On 6/9/2024 2:56 AM, Pierre-Anthony Lemieux wrote:
On Sat, Jun 8, 2024 at 6:13 PM James Almer wrote:
On 6/8/2024 9:59 PM, p...@sandflow.com wrote:
From: Pierre-Anthony Lemieux
If `--toolchain=valgrind-memcheck` is selected, fate-lavf-asf fails on a false
positive.
I can't reproduce
On 6/8/2024 9:59 PM, p...@sandflow.com wrote:
From: Pierre-Anthony Lemieux
If `--toolchain=valgrind-memcheck` is selected, fate-lavf-asf fails on a false
positive.
I can't reproduce this. Tried with both --disable-optimizations and
without it, on Ubuntu 22.04 x86_64.
How are you getting
On 6/6/2024 11:48 AM, Andreas Rheinhardt wrote:
James Almer:
And remove shuffle_bytes_2103_mmxext.
shuffle_bytes_0321_c: 28.1
shuffle_bytes_0321_sse2: 13.6
shuffle_bytes_0321_ssse3: 9.6
shuffle_bytes_0321_avx2: 7.1
shuffle_bytes_1230_c: 52.6
shuffle_bytes_1230_sse2: 12.1
: 14.6
shuffle_bytes_3210_ssse3: 8.6
shuffle_bytes_3210_avx2: 7.1
Signed-off-by: James Almer
---
libswscale/x86/rgb2rgb.c | 14 --
libswscale/x86/rgb_2_rgb.asm | 83 +---
2 files changed, 69 insertions(+), 28 deletions(-)
diff --git a/libswscale/x86
Test all four pixel formats, but only bench the two native endian ones for a
given target.
Signed-off-by: James Almer
---
tests/checkasm/sw_rgb.c | 28 ++--
1 file changed, 22 insertions(+), 6 deletions(-)
diff --git a/tests/checkasm/sw_rgb.c b/tests/checkasm/sw_rgb.c
shuffle_bytes_2103_c: 46.5
shuffle_bytes_2103_mmxext: 29.3
shuffle_bytes_2103_sse2: 12.5
Signed-off-by: James Almer
---
libswscale/x86/rgb2rgb.c | 6 ++
libswscale/x86/rgb_2_rgb.asm | 30 +++---
2 files changed, 13 insertions(+), 23 deletions(-)
diff --git
uyvytoyuv422_c: 23991.8
uyvytoyuv422_sse2: 2817.8
uyvytoyuv422_avx: 2819.3
uyvytoyuv422_avx2: 1972.3
Signed-off-by: James Almer
---
libswscale/x86/rgb2rgb.c | 6 ++
libswscale/x86/rgb_2_rgb.asm | 32
2 files changed, 30 insertions(+), 8 deletions
bgra_to_y_1080_avx2: 399.8
bgra_to_y_1920_c: 4202.8
bgra_to_y_1920_sse2: 906.8
bgra_to_y_1920_avx: 907.3
bgra_to_y_1920_avx2: 526.3
Signed-off-by: James Almer
---
libswscale/x86/input.asm | 51
libswscale/x86/swscale.c | 8 +++
2 files changed, 55 insertions
On 6/5/2024 5:10 PM, Andreas Rheinhardt wrote:
James Almer:
Test all four pixel formats, but only bench the two native endian ones for a
given target.
Signed-off-by: James Almer
---
tests/checkasm/sw_rgb.c | 22 --
1 file changed, 16 insertions(+), 6 deletions(-)
diff
On 6/5/2024 5:08 PM, Andreas Rheinhardt wrote:
The MMXEXT versions of the rgb2rgb functions tested here
always emit emms on their own. Therefore one can use
a stricter test to ensure that it stays that way.
Or we could nuke it in favor of an SSE2 version :p
Signed-off-by: Andreas Rheinhardt
Test all four pixel formats, but only bench the two native endian ones for a
given target.
Signed-off-by: James Almer
---
tests/checkasm/sw_rgb.c | 22 --
1 file changed, 16 insertions(+), 6 deletions(-)
diff --git a/tests/checkasm/sw_rgb.c b/tests/checkasm/sw_rgb.c
index
Signed-off-by: James Almer
---
tests/checkasm/sw_rgb.c | 10 ++
1 file changed, 6 insertions(+), 4 deletions(-)
diff --git a/tests/checkasm/sw_rgb.c b/tests/checkasm/sw_rgb.c
index b51d0836c3..57bd6b20cd 100644
--- a/tests/checkasm/sw_rgb.c
+++ b/tests/checkasm/sw_rgb.c
@@ -187,11
On 6/5/2024 12:08 AM, Lynne via ffmpeg-devel wrote:
This allows users to determine whether a stream is USAC or not.
---
libavcodec/aac/aacdec_usac.c | 4
libavcodec/avcodec.h | 1 +
libavcodec/defs.h| 1 +
libavcodec/profiles.c| 1 +
libavcodec/profiles.h
On 6/5/2024 12:08 AM, Lynne via ffmpeg-devel wrote:
---
doc/APIchanges | 3 +++
libavcodec/version.h | 2 +-
2 files changed, 4 insertions(+), 1 deletion(-)
diff --git a/doc/APIchanges b/doc/APIchanges
index e36a01336c..d9bec790a3 100644
--- a/doc/APIchanges
+++ b/doc/APIchanges
@@
On 6/5/2024 12:08 AM, Lynne via ffmpeg-devel wrote:
This makes it far easier to figure out which AOT belongs to which
profile.
Also, explicitly highlight the holes.
---
libavcodec/mpeg4audio.h | 82 +
1 file changed, 42 insertions(+), 40 deletions(-)
On 6/5/2024 12:08 AM, Lynne via ffmpeg-devel wrote:
The issue is that AOT 45 isn't defined anywhere, and looking at the git
blame, it seems to have sprung up through a reordering of the enum,
and adding a hole.
The spec does not define an explicit AOT for SBR and no SBR, and only
uses AOT 42
On 6/4/2024 11:06 AM, Zhao Zhili wrote:
On Jun 4, 2024, at 21:58, James Almer wrote:
On 6/4/2024 10:55 AM, Zhao Zhili wrote:
From: Zhao Zhili
---
tests/checkasm/sw_rgb.c | 103
1 file changed, 103 insertions(+)
diff --git a/tests/checkasm
On 6/4/2024 4:32 PM, Andreas Rheinhardt wrote:
James Almer:
On 6/4/2024 4:25 PM, Andreas Rheinhardt wrote:
James Almer:
rgb24_to_uv_8_c: 39.3
rgb24_to_uv_8_sse2: 14.3
rgb24_to_uv_8_ssse3: 13.3
rgb24_to_uv_8_avx: 12.8
rgb24_to_uv_8_avx2: 14.3
Worse than avx and ssse3
Can't be disabled
On 6/4/2024 4:25 PM, Andreas Rheinhardt wrote:
James Almer:
rgb24_to_uv_8_c: 39.3
rgb24_to_uv_8_sse2: 14.3
rgb24_to_uv_8_ssse3: 13.3
rgb24_to_uv_8_avx: 12.8
rgb24_to_uv_8_avx2: 14.3
Worse than avx and ssse3
Can't be disabled for small sizes.
rgb24_to_uv_128_c: 582.8
rgb24_to_uv_128_sse2
rgb24_to_y_1280_avx2: 350.8
rgb24_to_y_1920_c: 4338.8
rgb24_to_y_1920_sse2: 1210.8
rgb24_to_y_1920_ssse3: 928.3
rgb24_to_y_1920_avx: 920.3
rgb24_to_y_1920_avx2: 534.8
Signed-off-by: James Almer
---
libswscale/x86/input.asm | 49
libswscale/x86/swscale.c | 7
On 6/4/2024 3:37 AM, Rémi Denis-Courmont wrote:
Le 4 juin 2024 04:23:43 GMT+03:00, James Almer a écrit :
quant_bands_signed_sse2: 417.0
quant_bands_signed_avx: 202.0
What about unsigned?
Pretty much the same. Will add them before pushing
On 6/4/2024 10:55 AM, Zhao Zhili wrote:
From: Zhao Zhili
---
tests/checkasm/sw_rgb.c | 103
1 file changed, 103 insertions(+)
diff --git a/tests/checkasm/sw_rgb.c b/tests/checkasm/sw_rgb.c
index 7cd815e5be..cc9b957461 100644
---
On 6/3/2024 10:42 PM, Andreas Rheinhardt wrote:
James Almer:
quant_bands_signed_sse2: 417.0
quant_bands_signed_avx: 202.0
Missing benchmark numbers for the C code
About 1670. And it doesn't matter as I'm only adding the AVX version
(The subject is wrong, copy-paste fail), so i mentioned
quant_bands_signed_sse2: 417.0
quant_bands_signed_avx: 202.0
Signed-off-by: James Almer
---
libavcodec/aacenc.h | 2 +-
libavcodec/x86/aacencdsp.asm| 27 ---
libavcodec/x86/aacencdsp_init.c | 6 ++
tests/checkasm/aacencdsp.c | 4 ++--
4 files
On 6/3/2024 6:32 PM, Michael Niedermayer wrote:
On Sun, Jun 02, 2024 at 03:49:42PM +0200, Sebastian Ramacher wrote:
On 2024-03-03 09:55:15 +0100, Sebastian Ramacher wrote:
On 2024-03-02 20:39:08 -0500, Sean McGovern wrote:
On Sat, Mar 2, 2024, 18:19 Michael Niedermayer
wrote:
On Sun, Mar
On 6/3/2024 10:02 AM, Zhao Zhili wrote:
From: Zhao Zhili
---
The test still failed on x86, but success on arm64 and longarch.
I have tried to call rgb24ToY_c and ff_rgb24ToY_avx directly and
compare the results, they don't match.
You're using an incomplete table. See below.
On 5/31/2024 4:47 PM, James Almer wrote:
Signed-off-by: James Almer
---
libavutil/x86/float_dsp.asm| 52 ++
libavutil/x86/float_dsp_init.c | 5
2 files changed, 57 insertions(+)
diff --git a/libavutil/x86/float_dsp.asm b/libavutil/x86/float_dsp.asm
Fixes "libavcodec/aac/aacdec_usac.c(543): error C2440: 'type cast': cannot
convert from 'GetBitContext' to 'GetBitContext'"
from msvc.
Signed-off-by: James Almer
---
libavcodec/aac/aacdec_usac.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/libavcodec/aac/aacde
On 6/2/2024 2:10 PM, Lynne via ffmpeg-devel wrote:
---
doc/APIchanges | 6 ++
libavutil/version.h | 2 +-
2 files changed, 7 insertions(+), 1 deletion(-)
diff --git a/doc/APIchanges b/doc/APIchanges
index 60f056b863..e36a01336c 100644
--- a/doc/APIchanges
+++ b/doc/APIchanges
@@
On 6/2/2024 10:06 AM, James Almer wrote:
On 6/2/2024 9:14 AM, Kacper Michajłow wrote:
Fixes runtime error: member access within misaligned address
for type 'av_alias64', which requires 8 byte alignment.
VP9mv is aligned to 4 bytes, so instead doing 8 bytes clear, let's do
2 times 4 bytes
On 6/2/2024 9:14 AM, Kacper Michajłow wrote:
Fixes runtime error: member access within misaligned address
for type 'av_alias64', which requires 8 byte alignment.
VP9mv is aligned to 4 bytes, so instead doing 8 bytes clear, let's do
2 times 4 bytes.
Signed-off-by: Kacper Michajłow
---
On 5/31/2024 2:47 PM, Anton Khirnov wrote:
---
libavcodec/Makefile | 12 ++-
libavcodec/aarch64/hevcdsp_init_aarch64.c | 2 +-
libavcodec/arm/hevcdsp_arm.h | 2 +-
libavcodec/arm/hevcdsp_init_arm.c | 2 +-
On 5/30/2024 6:21 PM, Sean McGovern wrote:
---
Changelog| 1 +
libavcodec/alpha/Makefile| 10 -
libavcodec/alpha/asm.h | 153 --
libavcodec/alpha/blockdsp_alpha.c| 49 -
libavcodec/alpha/hpeldsp_alpha.c | 213
On 5/31/2024 3:18 PM, Rémi Denis-Courmont wrote:
---
tests/checkasm/aacencdsp.c | 37 +
1 file changed, 37 insertions(+)
diff --git a/tests/checkasm/aacencdsp.c b/tests/checkasm/aacencdsp.c
index 1756c4ecd5..756f92fd8f 100644
---
Signed-off-by: James Almer
---
libavutil/x86/float_dsp.asm| 52 ++
libavutil/x86/float_dsp_init.c | 5
2 files changed, 57 insertions(+)
diff --git a/libavutil/x86/float_dsp.asm b/libavutil/x86/float_dsp.asm
index e84ba52566..e9816cdf02 100644
On 5/31/2024 2:51 PM, Rémi Denis-Courmont wrote:
---
tests/checkasm/lpc.c | 57 ++--
1 file changed, 55 insertions(+), 2 deletions(-)
diff --git a/tests/checkasm/lpc.c b/tests/checkasm/lpc.c
index 592e34c03d..62232fdaf7 100644
---
Signed-off-by: James Almer
---
libavcodec/lpc.c | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/libavcodec/lpc.c b/libavcodec/lpc.c
index dfd6114690..e793e54038 100644
--- a/libavcodec/lpc.c
+++ b/libavcodec/lpc.c
@@ -120,9 +120,8 @@ static void lpc_compute_autocorr_c
Signed-off-by: James Almer
---
fftools/ffmpeg.h| 7 +++
fftools/ffmpeg_demux.c | 16
fftools/ffmpeg_filter.c | 10 ++
fftools/ffmpeg_opt.c| 3 +++
4 files changed, 36 insertions(+)
diff --git a/fftools/ffmpeg.h b/fftools/ffmpeg.h
index fe75706afd
On 5/30/2024 12:58 PM, Rémi Denis-Courmont wrote:
Also restrict length to even values as per (questionable) assumption in
the reference C code.
---
tests/checkasm/lpc.c | 59 +---
1 file changed, 56 insertions(+), 3 deletions(-)
diff --git
On 5/30/2024 4:31 PM, Rémi Denis-Courmont wrote:
Le torstaina 30. toukokuuta 2024, 22.06.55 EEST Rémi Denis-Courmont a écrit :
The function pointer is appended to the structure for backward binary
compatibility. Fortunately, this is allocated by libavutil, not by the
user, so increasing the
On 5/30/2024 4:21 PM, Rémi Denis-Courmont wrote:
Le torstaina 30. toukokuuta 2024, 22.10.28 EEST James Almer a écrit :
Why are you adding this to the doxy for scalarproduct_float()? Those
constrains are not correct for it. They are for scalarproduct_double()
which you're adding now.
Because
On 5/30/2024 4:06 PM, Rémi Denis-Courmont wrote:
The function pointer is appended to the structure for backward binary
compatibility. Fortunately, this is allocated by libavutil, not by the
user, so increasing the structure size is safe.
---
libavutil/float_dsp.c | 12
On 5/30/2024 12:32 PM, Tomas Härdin wrote:
tor 2024-05-30 klockan 17:28 +0300 skrev Rémi Denis-Courmont:
Le 30 mai 2024 17:07:21 GMT+03:00, "Tomas Härdin" a
écrit :
We should depend on punning as long as it conforms to the
standard.
My mistake, I forgot type punning is allowed in C. It's
On 5/29/2024 10:02 PM, Lynne via ffmpeg-devel wrote:
On 29/05/2024 23:46, James Almer wrote:
Signed-off-by: James Almer
---
libavcodec/packet.h | 14 ++
1 file changed, 14 insertions(+)
diff --git a/libavcodec/packet.h b/libavcodec/packet.h
index a9a41576da..9dee035690 100644
On 5/29/2024 10:01 PM, Lynne via ffmpeg-devel wrote:
On 29/05/2024 23:46, James Almer wrote:
Signed-off-by: James Almer
---
fftools/ffmpeg.h | 7 +++
fftools/ffmpeg_demux.c | 16
fftools/ffmpeg_filter.c | 11 +++
fftools/ffmpeg_opt.c | 3 +++
4
On 5/29/2024 9:14 PM, Andreas Rheinhardt wrote:
Forgotten in 65ddc74988245a01421a63c5cffa4d900c47117c.
Signed-off-by: Andreas Rheinhardt
---
libavformat/nutdec.c | 14 --
1 file changed, 4 insertions(+), 10 deletions(-)
diff --git a/libavformat/nutdec.c b/libavformat/nutdec.c
They were forgotten in 65ddc74988245a01421a63c5cffa4d900c47117c.
Signed-off-by: James Almer
---
libavcodec/packet.h | 4
1 file changed, 4 deletions(-)
diff --git a/libavcodec/packet.h b/libavcodec/packet.h
index a9a41576da..f05deb7950 100644
--- a/libavcodec/packet.h
+++ b/libavcodec
Signed-off-by: James Almer
---
fftools/ffplay.c | 25 +
1 file changed, 25 insertions(+)
diff --git a/fftools/ffplay.c b/fftools/ffplay.c
index 1d0511b254..47e2865abb 100644
--- a/fftools/ffplay.c
+++ b/fftools/ffplay.c
@@ -32,6 +32,7 @@
#include "libavutil/avstr
Signed-off-by: James Almer
---
fftools/ffmpeg.h| 7 +++
fftools/ffmpeg_demux.c | 16
fftools/ffmpeg_filter.c | 11 +++
fftools/ffmpeg_opt.c| 3 +++
4 files changed, 37 insertions(+)
diff --git a/fftools/ffmpeg.h b/fftools/ffmpeg.h
index fe75706afd
Signed-off-by: James Almer
---
libavcodec/packet.h | 14 ++
1 file changed, 14 insertions(+)
diff --git a/libavcodec/packet.h b/libavcodec/packet.h
index a9a41576da..9dee035690 100644
--- a/libavcodec/packet.h
+++ b/libavcodec/packet.h
@@ -330,6 +330,20 @@ enum AVPacketSideDataType
Signed-off-by: James Almer
---
libavformat/matroskaenc.c | 44 ---
1 file changed, 37 insertions(+), 7 deletions(-)
diff --git a/libavformat/matroskaenc.c b/libavformat/matroskaenc.c
index 76c542d50b..37a6a5b4f8 100644
--- a/libavformat/matroskaenc.c
+++ b
Signed-off-by: James Almer
---
libavformat/matroskadec.c | 53 +++
1 file changed, 43 insertions(+), 10 deletions(-)
diff --git a/libavformat/matroskadec.c b/libavformat/matroskadec.c
index 2f07e11d87..a30bac786b 100644
--- a/libavformat/matroskadec.c
+++ b
Signed-off-by: James Almer
---
libavformat/dump.c | 21 +
1 file changed, 21 insertions(+)
diff --git a/libavformat/dump.c b/libavformat/dump.c
index 059fb84522..610965cf81 100644
--- a/libavformat/dump.c
+++ b/libavformat/dump.c
@@ -431,6 +431,23 @@ static void
On 5/29/2024 4:42 PM, Rémi Denis-Courmont wrote:
Also restrict length to even values, matching real uses.
This test is disabled, known broken, on x86.
---
tests/checkasm/lpc.c | 57 +---
1 file changed, 54 insertions(+), 3 deletions(-)
diff --git
On 5/29/2024 12:51 PM, Rémi Denis-Courmont wrote:
Le keskiviikkona 29. toukokuuta 2024, 18.44.13 EEST Andreas Rheinhardt a écrit
:
+static double ff_scalarproduct_double_c(const double *v1,
Don't use an ff_ prefix for a static function.
I can see over 300 such identifiers in the code base
They will be filled immediately after.
Signed-off-by: James Almer
---
tests/checkasm/vvc_mc.c | 3 ---
1 file changed, 3 deletions(-)
diff --git a/tests/checkasm/vvc_mc.c b/tests/checkasm/vvc_mc.c
index 40be837d68..bc6b580f42 100644
--- a/tests/checkasm/vvc_mc.c
+++ b/tests/checkasm/vvc_mc.c
Signed-off-by: James Almer
---
tests/checkasm/vvc_mc.c | 7 ---
1 file changed, 4 insertions(+), 3 deletions(-)
diff --git a/tests/checkasm/vvc_mc.c b/tests/checkasm/vvc_mc.c
index 09cac82edb..40be837d68 100644
--- a/tests/checkasm/vvc_mc.c
+++ b/tests/checkasm/vvc_mc.c
@@ -341,8 +341,10
On 5/28/2024 4:57 PM, Rémi Denis-Courmont wrote:
---
tests/checkasm/Makefile | 1 +
tests/checkasm/checkasm.c | 1 +
tests/checkasm/checkasm.h | 1 +
tests/checkasm/lls.c | 110 ++
tests/fate/checkasm.mak | 1 +
5 files changed, 114
On 5/27/2024 11:49 PM, Andreas Rheinhardt wrote:
These strings are so short that they can be put directly
into the containing structure, avoiding the pointer
and putting it into .rodata.
Also use chars for interlaced and level while at it, as
these are so small.
Signed-off-by: Andreas
On 5/27/2024 9:22 PM, James Almer wrote:
On 5/27/2024 4:15 PM, James Almer wrote:
On 5/27/2024 4:10 PM, James Almer wrote:
On 5/27/2024 1:01 PM, Rémi Denis-Courmont wrote:
---
Changes since v2:
- Scale the error factor to length since this computes sums.
- Check the last element from results
On 5/27/2024 4:15 PM, James Almer wrote:
On 5/27/2024 4:10 PM, James Almer wrote:
On 5/27/2024 1:01 PM, Rémi Denis-Courmont wrote:
---
Changes since v2:
- Scale the error factor to length since this computes sums.
- Check the last element from results.
- Use fixed vector size for benchmarks
On 5/27/2024 4:50 PM, Michael Niedermayer wrote:
On Mon, May 27, 2024 at 04:33:21PM -0300, James Almer wrote:
On 5/27/2024 4:31 PM, Michael Niedermayer wrote:
On Mon, May 27, 2024 at 09:20:55PM +0200, Michael Niedermayer wrote:
On Mon, May 27, 2024 at 03:17:15PM -0300, James Almer wrote
On 5/27/2024 4:31 PM, Michael Niedermayer wrote:
On Mon, May 27, 2024 at 09:20:55PM +0200, Michael Niedermayer wrote:
On Mon, May 27, 2024 at 03:17:15PM -0300, James Almer wrote:
On 5/27/2024 3:11 PM, Michael Niedermayer wrote:
On Mon, May 27, 2024 at 10:15:43AM +0200, Anton Khirnov wrote
On 5/27/2024 4:20 PM, Michael Niedermayer wrote:
On Mon, May 27, 2024 at 03:17:15PM -0300, James Almer wrote:
On 5/27/2024 3:11 PM, Michael Niedermayer wrote:
On Mon, May 27, 2024 at 10:15:43AM +0200, Anton Khirnov wrote:
Quoting Michael Niedermayer (2024-04-27 02:36:23)
This allows
On 5/27/2024 4:10 PM, James Almer wrote:
On 5/27/2024 1:01 PM, Rémi Denis-Courmont wrote:
---
Changes since v2:
- Scale the error factor to length since this computes sums.
- Check the last element from results.
- Use fixed vector size for benchmarks.
---
tests/checkasm/lpc.c | 51
On 5/27/2024 1:01 PM, Rémi Denis-Courmont wrote:
---
Changes since v2:
- Scale the error factor to length since this computes sums.
- Check the last element from results.
- Use fixed vector size for benchmarks.
---
tests/checkasm/lpc.c | 51 +---
1
On 5/27/2024 3:11 PM, Michael Niedermayer wrote:
On Mon, May 27, 2024 at 10:15:43AM +0200, Anton Khirnov wrote:
Quoting Michael Niedermayer (2024-04-27 02:36:23)
This allows detecting issues in side data related code, same as what
framecrc does for before already for packet data itself.
On 5/27/2024 5:15 AM, Anton Khirnov wrote:
Quoting Michael Niedermayer (2024-04-27 02:36:23)
This allows detecting issues in side data related code, same as what
framecrc does for before already for packet data itself.
Signed-off-by: Michael Niedermayer
---
I am against this patch.
On 5/25/2024 10:51 PM, James Almer wrote:
On 5/25/2024 10:42 PM, Lynne via ffmpeg-devel wrote:
The inline asm function had issues running under checkasm.
So I came to finish what I started, and wrote the last part
of LPC computation in assembly.
---
libavcodec/x86/lpc.asm | 91
On 5/25/2024 10:42 PM, Lynne via ffmpeg-devel wrote:
The inline asm function had issues running under checkasm.
So I came to finish what I started, and wrote the last part
of LPC computation in assembly.
---
libavcodec/x86/lpc.asm| 91 +++
On 5/25/2024 5:57 PM, Lynne via ffmpeg-devel wrote:
The inline asm function had issues running under checkasm.
So I came to finish what I started, and wrote the last part
of LPC computation in assembly.
autocorr_10_c: 135525.8
autocorr_10_sse2: 50729.8
autocorr_10_fma3: 19007.8
autocorr_30_c:
On 5/25/2024 9:02 PM, Lynne via ffmpeg-devel wrote:
On 26/05/2024 00:45, James Almer wrote:
On 5/25/2024 7:31 PM, James Almer wrote:
On 5/25/2024 5:57 PM, Lynne via ffmpeg-devel wrote:
The inline asm function had issues running under checkasm.
So I came to finish what I started, and wrote
On 5/25/2024 8:24 PM, Lynne via ffmpeg-devel wrote:
On 26/05/2024 00:31, James Almer wrote:
On 5/25/2024 5:57 PM, Lynne via ffmpeg-devel wrote:
The inline asm function had issues running under checkasm.
So I came to finish what I started, and wrote the last part
of LPC computation in assembly
On 5/25/2024 7:31 PM, James Almer wrote:
On 5/25/2024 5:57 PM, Lynne via ffmpeg-devel wrote:
The inline asm function had issues running under checkasm.
So I came to finish what I started, and wrote the last part
of LPC computation in assembly.
autocorr_10_c: 135525.8
autocorr_10_sse2: 50729.8
On 5/25/2024 5:57 PM, Lynne via ffmpeg-devel wrote:
The inline asm function had issues running under checkasm.
So I came to finish what I started, and wrote the last part
of LPC computation in assembly.
autocorr_10_c: 135525.8
autocorr_10_sse2: 50729.8
autocorr_10_fma3: 19007.8
autocorr_30_c:
On 5/18/2024 3:44 PM, Rémi Denis-Courmont wrote:
---
tests/checkasm/Makefile | 1 +
tests/checkasm/checkasm.c | 3 ++
tests/checkasm/checkasm.h | 1 +
tests/checkasm/h263dsp.c | 62 +++
tests/fate/checkasm.mak | 1 +
5 files changed, 68
On 5/25/2024 8:58 AM, Rémi Denis-Courmont wrote:
--
Change since previous version:
- Disable test on x86, since the x86 optimisation fails
with a suspiciously large and regular error with 10-20% probability.
Weird. The sse2 function is written using inline gcc, so it's pretty
old. And it
On 5/24/2024 12:37 PM, Andreas Rheinhardt wrote:
Forgotten in 0380a03f1f9d55e5690bb92bfa4897f2c728c1e5.
LGTM. And sorry, i was sure i had amended it locally when you pointed it
out.
Signed-off-by: Andreas Rheinhardt
---
libavcodec/flacdec.c | 2 +-
1 file changed, 1 insertion(+), 1
On 5/24/2024 6:11 AM, Anton Khirnov wrote:
Quoting James Almer (2024-04-10 15:42:51)
On 4/10/2024 10:31 AM, Anton Khirnov wrote:
diff --git a/libavcodec/vulkan_hevc.c b/libavcodec/vulkan_hevc.c
index 5d7c6b1b64..c2b65fc201 100644
--- a/libavcodec/vulkan_hevc.c
+++ b/libavcodec/vulkan_hevc.c
On 5/14/2024 10:08 PM, James Almer wrote:
Signed-off-by: James Almer
---
libavformat/movenc.c | 61
1 file changed, 61 insertions(+)
Will apply the set.
___
ffmpeg-devel mailing list
ffmpeg-devel
On 5/22/2024 12:50 PM, Cosmin Stejerean via ffmpeg-devel wrote:
From: Cosmin Stejerean
These two fields are coded together into a single 16 bit integer with upper 8
bits for ext_mapping_idc and lower 8 bits for el_bit_depth_minus8.
Furthermore ext_mapping_idc has two components, upper 3 bits
Signed-off-by: James Almer
---
libavcodec/x86/vvc/vvc_sad.asm | 20 ++--
1 file changed, 10 insertions(+), 10 deletions(-)
diff --git a/libavcodec/x86/vvc/vvc_sad.asm b/libavcodec/x86/vvc/vvc_sad.asm
index 9881b1180d..14f7ce230e 100644
--- a/libavcodec/x86/vvc/vvc_sad.asm
+++ b
This way they can be assembled on x86_32 targets.
Signed-off-by: James Almer
---
libavcodec/x86/vvc/vvc_sad.asm | 22 ++
libavcodec/x86/vvc/vvcdsp_init.c | 16 +---
2 files changed, 23 insertions(+), 15 deletions(-)
diff --git a/libavcodec/x86/vvc/vvc_sad.asm
sad_128x128_c: 12581.3
sad_128x128_sse4: 1560.8
sad_128x128_avx2: 1151.8
Signed-off-by: James Almer
---
libavcodec/x86/vvc/vvc_sad.asm | 53 +---
libavcodec/x86/vvc/vvcdsp_init.c | 42 +
2 files changed, 65 insertions(+), 30 deletions(-)
diff --git
Signed-off-by: James Almer
---
libavcodec/x86/vvc/vvc_sad.asm | 27 ++-
1 file changed, 14 insertions(+), 13 deletions(-)
diff --git a/libavcodec/x86/vvc/vvc_sad.asm b/libavcodec/x86/vvc/vvc_sad.asm
index a20818530f..829dbce489 100644
--- a/libavcodec/x86/vvc/vvc_sad.asm
Signed-off-by: James Almer
---
libavcodec/vvc/dsp.h | 2 +-
libavcodec/vvc/inter.c | 6 --
libavcodec/vvc/inter_template.c | 6 +-
libavcodec/x86/vvc/vvc_sad.asm | 32 ++--
libavcodec/x86/vvc/vvcdsp_init.c | 22
On 5/23/2024 4:11 AM, Anton Khirnov wrote:
Quoting James Almer (2024-05-15 03:08:28)
Signed-off-by: James Almer
---
libavutil/channel_layout.c | 17 -
libavutil/channel_layout.h | 10 ++
2 files changed, 18 insertions(+), 9 deletions(-)
diff --git a/libavutil
On 5/14/2024 8:25 AM, Nuo Mi wrote:
On Mon, May 13, 2024 at 8:32 PM wrote:
From: Wu Jianhua
Perforamnce Test (fps):
clip before after delta
Tango2_3840x2160_60_10_420_27_LD.266 56 115 105.36%
RitualDance_1920x1080_60_10_420_32_LD.266 272
On 5/21/2024 10:01 PM, Ronald S. Bultje wrote:
Hi,
On Tue, May 21, 2024 at 8:01 PM Stone Chen wrote:
Implements AVX2 DMVR (decoder-side motion vector refinement) SAD
functions. DMVR SAD is only calculated if w >= 8, h >= 8, and w * h > 128.
To reduce complexity, SAD is only calculated on
On 5/21/2024 10:12 PM, Ronald S. Bultje wrote:
Hi,
On Tue, May 21, 2024 at 8:01 PM Stone Chen wrote:
Adds checkasm for DMVR SAD AVX2 implementation.
Benchmarks ( AMD 7940HS )
vvc_sad_8x8_c: 50.3
vvc_sad_8x8_avx2: 0.3
vvc_sad_16x16_c: 250.3
vvc_sad_16x16_avx2: 10.3
vvc_sad_32x32_c: 1020.3
On 5/22/2024 2:02 AM, Andreas Rheinhardt wrote:
Stone Chen:
Implements AVX2 DMVR (decoder-side motion vector refinement) SAD functions. DMVR SAD is
only calculated if w >= 8, h >= 8, and w * h > 128. To reduce complexity, SAD
is only calculated on even rows. This is calculated for all video
On 5/19/2024 10:41 PM, James Almer wrote:
As defined in Section 8.7.3.2.1 of ISO 14496-12.
Any unsupported value will be rejected in mov_build_index() without outright
aborting demuxing.
Fixes ticket #11005.
Signed-off-by: James Almer
---
libavformat/isom.h | 2 +-
libavformat/mov.c | 4
On 5/19/2024 10:25 AM, James Almer wrote:
The length of the sps_subpic_id[i] syntax element is sps_subpic_id_len_minus1 +
1 bits.
Signed-off-by: James Almer
---
libavformat/vvc.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/libavformat/vvc.c b/libavformat/vvc.c
On 5/21/2024 9:00 PM, Stone Chen wrote:
Adds checkasm for DMVR SAD AVX2 implementation.
Benchmarks ( AMD 7940HS )
vvc_sad_8x8_c: 50.3
vvc_sad_8x8_avx2: 0.3
vvc_sad_16x16_c: 250.3
vvc_sad_16x16_avx2: 10.3
vvc_sad_32x32_c: 1020.3
vvc_sad_32x32_avx2: 60.3
vvc_sad_64x64_c: 3850.3
Let its magic figure out the correct mnemonic based on target instruction set.
Signed-off-by: James Almer
---
libavcodec/x86/vvc/vvc_alf.asm | 202 -
1 file changed, 101 insertions(+), 101 deletions(-)
diff --git a/libavcodec/x86/vvc/vvc_alf.asm b/libavcodec/x86
As defined in Section 8.7.3.2.1 of ISO 14496-12.
Any unsupported value will be rejected in mov_build_index() without outright
aborting demuxing.
Fixes ticket #11005.
Signed-off-by: James Almer
---
libavformat/isom.h | 2 +-
libavformat/mov.c | 4 ++--
2 files changed, 3 insertions(+), 3
Signed-off-by: James Almer
---
libavcodec/cbs_h266_syntax_template.c | 28 ++-
1 file changed, 15 insertions(+), 13 deletions(-)
diff --git a/libavcodec/cbs_h266_syntax_template.c
b/libavcodec/cbs_h266_syntax_template.c
index 725cee5b03..38685704c5 100644
1 - 100 of 9730 matches
Mail list logo
