Re: [FFmpeg-devel] [PATCH] avcodec/libaomenc: add an option to set the encoder "usage"

On Thu, Jan 23, 2020 at 2:26 AM James Almer wrote: > > This allows the user enable the realtime encoding speed mode > > Signed-off-by: James Almer > --- > The g_usage field is present since 1.0.0, but the AOM_USAGE_* defines were > introduced with the real time mode about a year ago. Builds

Re: [FFmpeg-devel] [PATCH v4] avcodec/libvpxenc: add VP9 temporal scalability encoding option

On Fri, Jan 17, 2020 at 1:50 PM Wonkap Jang wrote: > > This commit reuses the configuration options for VP8 that enables > temporal scalability for VP9. It also adds a way to enable three > preset temporal structures (refer to the documentation for more > detail) that can be used in offline

Re: [FFmpeg-devel] [PATCH] Add a commandline option to control loop restoration for libaom

On Fri, Jan 17, 2020 at 2:45 PM James Zern wrote: > > On Mon, Dec 23, 2019 at 12:53 PM Wang Cao wrote: > > > > Signed-off-by: Wang Cao > > --- > > doc/encoders.texi | 3 +++ > > libavcodec/libaomenc.c | 6 ++ > > 2 files changed, 9 insertio

Re: [FFmpeg-devel] [PATCH] Add a commandline option to control loop restoration for libaom

On Mon, Dec 23, 2019 at 12:53 PM Wang Cao wrote: > > Signed-off-by: Wang Cao > --- > doc/encoders.texi | 3 +++ > libavcodec/libaomenc.c | 6 ++ > 2 files changed, 9 insertions(+) > lgtm. sorry for losing track of this. > [...] > +if (ctx->enable_restoration >= 0) > +

Re: [FFmpeg-devel] [PATCH v4] avcodec/libvpxenc: add VP9 temporal scalability encoding option

On Thu, Jan 16, 2020 at 11:04 AM Wonkap Jang wrote: > > James, > > On Thu, Jan 16, 2020 at 10:58 AM Wonkap Jang < > wonkap-at-google@ffmpeg.org> wrote: > > > This commit reuses the configuration options for VP8 that enables > > temporal scalability for VP9. It also adds a way to enable three

Re: [FFmpeg-devel] [PATCH v4] avcodec/libvpxenc: add VP9 temporal scalability encoding option

On Wed, Jan 15, 2020 at 6:20 PM Wonkap Jang wrote: > > HI, > My comments are in-line. > > On Tue, Jan 14, 2020 at 8:55 PM James Zern > wrote: > > > On Tue, Jan 14, 2020 at 11:07 AM Wonkap Jang > > wrote: > > > [...] > > > + > > > +

Re: [FFmpeg-devel] [PATCH v4] avcodec/libvpxenc: add VP9 temporal scalability encoding option

On Tue, Jan 14, 2020 at 11:07 AM Wonkap Jang wrote: > > This commit reuses the configuration options for VP8 that enables > temporal scalability for VP9. It also adds a way to enable three > preset temporal structures (refer to the documentation for more > detail) that can be used in offline

Re: [FFmpeg-devel] [PATCH v4 1/2] avcodec/libvpxenc: add VP9 temporal scalability encoding option

Hi, On Fri, Jan 10, 2020 at 9:59 AM Wonkap Jang wrote: > > This commit reuses the configuration options for VP8 that enables > temporal scalability for VP9. It also adds a way to enable three > preset temporal structures (refer to the documentation for more > detail) that can be used in offline

Re: [FFmpeg-devel] [PATCH v3 3/3] doc/encoders: add VP9 temporal scalability encoding option

On Wed, Jan 8, 2020 at 3:00 PM Wonkap Jang wrote: > > Documentation change for adding support for encoding > with temporal scalability in VP9. > --- > doc/encoders.texi | 18 +++--- > 1 file changed, 15 insertions(+), 3 deletions(-) > This could be a part of the first patch in the

Re: [FFmpeg-devel] [PATCH] avcodec/libvpxenc, cosmetics: prefer sizeof(var)

On Fri, Jan 3, 2020 at 5:28 PM James Almer wrote: > > On 1/3/2020 10:16 PM, James Zern wrote: > > Signed-off-by: James Zern > > --- > > libavcodec/libvpxenc.c | 3 +-- > > 1 file changed, 1 insertion(+), 2 deletions(-) > > > > diff --git a/libav

[FFmpeg-devel] [PATCH] avcodec/libvpxenc, cosmetics: prefer sizeof(var)

Signed-off-by: James Zern --- libavcodec/libvpxenc.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/libavcodec/libvpxenc.c b/libavcodec/libvpxenc.c index 3f659b4b67..0b8a070304 100644 --- a/libavcodec/libvpxenc.c +++ b/libavcodec/libvpxenc.c @@ -1041,8 +1041,7 @@ static

Re: [FFmpeg-devel] [PATCH V1 04/12] lavc/libvpxenc: fix memory leak after av_dict_parse_string fail

Hi, On Tue, Dec 31, 2019 at 9:21 PM Jun Zhao wrote: > > From: Jun Zhao > > In case of failure, all the successfully set entries are stored in > *pm. We need to manually free the created dictionary to avoid > memory leak. > > Signed-off-by: Jun Zhao > --- > libavcodec/libvpxenc.c |3 +-- >

Re: [FFmpeg-devel] [PATCH] doc/encoders: correct the description for ts_target_bitrate

On Wed, Dec 18, 2019 at 4:17 PM Wonkap Jang wrote: > > ts_target_bitrate is in kbps, not bps. This commit clarifies the unit > and modifies the example to match the description. > --- > doc/encoders.texi | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) > applied, thanks.

Re: [FFmpeg-devel] [PATCH] Add a commandline option to control loop restoration for libaom

On Wed, Dec 18, 2019 at 7:25 PM Wang Cao wrote: > > Signed-off-by: Wang Cao > --- > libavcodec/libaomenc.c | 6 ++ Can you update doc/encoders.texi with this detail please? ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org

Re: [FFmpeg-devel] [PATCH] doc/encoders: correct the description for ts_target_bitrate

http://ffmpeg.org/contact.html#MailingLists > Thank you, > > Wonkap > > On Wed, Dec 18, 2019 at 1:39 PM James Zern > wrote: > > > Hi, > > > > On Wed, Dec 18, 2019 at 1:17 PM Wonkap Jang > > wrote: > > > > > > ts_target_bitrate is in kbps

Re: [FFmpeg-devel] [PATCH] doc/encoders: correct the description for ts_target_bitrate

Hi, On Wed, Dec 18, 2019 at 1:17 PM Wonkap Jang wrote: > > ts_target_bitrate is in kbps, not bps. This commit clarifies the unit > and modifies the example to match the description. > --- > doc/encoders.texi | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) > lgtm if you can verify

Re: [FFmpeg-devel] [PATCH] doc/encoders: add VP9 temporal scalability encoding option

the code already has > two commits... so overall 4 commits in succession. > The doc fix should land quickly, so the other could be rebased after that. > Would this work? > > Thank you, > > Wonkap > > > On Tue, Dec 17, 2019 at 5:59 PM James Zern > wrote: > &g

Re: [FFmpeg-devel] [PATCH] doc/encoders: add VP9 temporal scalability encoding option

Hi, On Mon, Dec 16, 2019 at 2:21 PM Wonkap Jang wrote: > > Documentation change for adding support for encoding > with temporal scalability in VP9. > --- This part sounds related to the other patches you're sending. The documentation can be added with the code change for vp9. >

[FFmpeg-devel] [PATCH] avcodec/libvpxdec.c,cosmetics: bpp -> bpc

Signed-off-by: James Zern --- libavcodec/libvpxdec.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavcodec/libvpxdec.c b/libavcodec/libvpxdec.c index 1ae2361167..1063c546b0 100644 --- a/libavcodec/libvpxdec.c +++ b/libavcodec/libvpxdec.c @@ -288,7 +288,7 @@ static int

Re: [FFmpeg-devel] [FFmpeg-cvslog] avcodec/libvpxdec: reject video and alpha dimension mismatches

On Wed, Nov 6, 2019 at 2:21 AM Carl Eugen Hoyos wrote: > > Am Mi., 6. Nov. 2019 um 08:28 Uhr schrieb Marton Balint : > > [...] > > +if (ctx->has_alpha_channel && > > +(img->d_w != img_alpha->d_w || > > + img->d_h != img_alpha->d_h || > > +

Re: [FFmpeg-devel] [PATCH 1/6] avcodec/libvpxenc: fix alpha stride

On Fri, Nov 1, 2019 at 11:47 AM James Zern wrote: > > On Sun, Oct 27, 2019 at 10:10 AM Marton Balint wrote: > > > > Signed-off-by: Marton Balint > > --- > > libavcodec/libvpxenc.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deleti

Re: [FFmpeg-devel] [PATCH 3/6] avcodec/libvpxdec: make sure BlockAdditional side data size >= 8

On Fri, Nov 1, 2019 at 11:52 AM James Zern wrote: > > On Sun, Oct 27, 2019 at 10:11 AM Marton Balint wrote: > > > > Signed-off-by: Marton Balint > > --- > > libavcodec/libvpxdec.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > &

Re: [FFmpeg-devel] [PATCH 6/6] avcodec/libvpxdec: reject video and alpha dimension mismatches

On Fri, Nov 1, 2019 at 1:01 PM James Zern wrote: > > On Sun, Oct 27, 2019 at 10:11 AM Marton Balint wrote: > > > > Signed-off-by: Marton Balint > > --- > > libavcodec/libvpxdec.c | 11 +++ > > 1 file changed, 11 insertio

Re: [FFmpeg-devel] [PATCH 5/6] avcodec/libvpxdec: decode to custom framebuffers for vp9

On Fri, Nov 1, 2019 at 1:01 PM James Zern wrote: > > On Sun, Oct 27, 2019 at 10:11 AM Marton Balint wrote: > > > > This avoids copying the full frame after decoding. > > > > Signed-off-by: Marton Balint > >

Re: [FFmpeg-devel] [PATCH 4/6] avcodec/libvpxdec: pass decoder instances to vpx_init directly

On Fri, Nov 1, 2019 at 11:55 AM James Zern wrote: > > On Sun, Oct 27, 2019 at 10:11 AM Marton Balint wrote: > > > > If the alpha decoder init failed we presented the error message from the > > normal > > decoder. This change should prevent such mistakes. > &

Re: [FFmpeg-devel] [PATCHv2 2/6] avcodec/libvpxenc: only allocate alpha U/V planes on size changes

On Mon, Nov 4, 2019 at 4:55 PM James Zern wrote: > > On Sat, Nov 2, 2019 at 9:20 AM Marton Balint wrote: > > > > Signed-off-by: Marton Balint > > --- > > libavcodec/libvpxenc.c | 60 > > ++ > > 1 fi

Re: [FFmpeg-devel] [PATCH 6/6] avcodec/libvpxdec: reject video and alpha dimension mismatches

On Sun, Oct 27, 2019 at 10:11 AM Marton Balint wrote: > > Signed-off-by: Marton Balint > --- > libavcodec/libvpxdec.c | 11 +++ > 1 file changed, 11 insertions(+) > lgtm. ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org

Re: [FFmpeg-devel] [PATCH 5/6] avcodec/libvpxdec: decode to custom framebuffers for vp9

On Sun, Oct 27, 2019 at 10:11 AM Marton Balint wrote: > > This avoids copying the full frame after decoding. > > Signed-off-by: Marton Balint > --- > libavcodec/libvpxdec.c | 73 > ++ > 1 file changed, 68 insertions(+), 5 deletions(-) > lgtm. >

Re: [FFmpeg-devel] [PATCH 3/6] avcodec/libvpxdec: make sure BlockAdditional side data size >= 8

On Sun, Oct 27, 2019 at 10:11 AM Marton Balint wrote: > > Signed-off-by: Marton Balint > --- > libavcodec/libvpxdec.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > lgtm. good catch. ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org

Re: [FFmpeg-devel] [PATCH 4/6] avcodec/libvpxdec: pass decoder instances to vpx_init directly

On Sun, Oct 27, 2019 at 10:11 AM Marton Balint wrote: > > If the alpha decoder init failed we presented the error message from the > normal > decoder. This change should prevent such mistakes. > > Signed-off-by: Marton Balint > --- > libavcodec/libvpxdec.c | 26 +- > 1

Re: [FFmpeg-devel] [PATCH 1/6] avcodec/libvpxenc: fix alpha stride

On Sun, Oct 27, 2019 at 10:10 AM Marton Balint wrote: > > Signed-off-by: Marton Balint > --- > libavcodec/libvpxenc.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > lgtm. ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org

Re: [FFmpeg-devel] [PATCH 2/6] avcodec/libvpxenc: only allocate U/V planes once for the alpha encoder instance

On Sun, Oct 27, 2019 at 10:11 AM Marton Balint wrote: > > Signed-off-by: Marton Balint > --- > libavcodec/libvpxenc.c | 44 +++- > 1 file changed, 23 insertions(+), 21 deletions(-) > The encoder can handle frame size changes. This seems to assume the

Re: [FFmpeg-devel] [PATCH] Change libvpxenc default to crf=32.

On Sat, Oct 5, 2019 at 1:23 PM James Zern wrote: > > On Tue, Sep 24, 2019 at 4:31 PM Elliott Karpilovsky > wrote: > > > > Current default is 200kbps, which produces inconsistent > > results (too high for low-res, too low for hi-res). Use > > CRF instead, which w

Re: [FFmpeg-devel] [PATCH] Change libvpxenc default to crf=32.

On Tue, Sep 24, 2019 at 4:31 PM Elliott Karpilovsky wrote: > > Current default is 200kbps, which produces inconsistent > results (too high for low-res, too low for hi-res). Use > CRF instead, which will adapt. Affects VP9. Also have > VP8 use a default bitrate of 256kbps. > --- >

Re: [FFmpeg-devel] [PATCH] tools/patcheck: remove gcc-2.95 compat check

On Fri, Sep 20, 2019 at 12:38 AM Paul B Mahol wrote: > > LGTM > > On 9/20/19, James Zern wrote: > > this conflicts with the current contributing guidance: > > http://ffmpeg.org/developer.html#Contributing > > FFmpeg is programmed in the ISO C90 language with a fe

[FFmpeg-devel] [PATCH] tools/patcheck: remove gcc-2.95 compat check

this conflicts with the current contributing guidance: http://ffmpeg.org/developer.html#Contributing FFmpeg is programmed in the ISO C90 language with a few additional features from ISO C99, namely: ... for loops with variable definition (‘for (int i = 0; i < 8; i++)’); Signed-off-by: James Z

Re: [FFmpeg-devel] [PATCH] Delete unused branch in libaomenc

On Wed, Sep 18, 2019 at 11:42 AM James Zern wrote: > > On Sun, Sep 15, 2019 at 2:03 PM Elliott Karpilovsky > wrote: > > > > --- > > libavcodec/libaomenc.c | 14 +- > > 1 file changed, 5 insertions(+), 9 deletions(-) > > > > lgtm. This

Re: [FFmpeg-devel] [PATCH V9] avcodec/libvpxenc: add ROI-based encoding support for VP8/VP9

On Wed, Sep 18, 2019 at 12:03 PM James Zern wrote: > > On Wed, Sep 18, 2019 at 7:54 AM Guo, Yejun wrote: > > > > > > > > > -Original Message- > > > From: Guo, Yejun > > > Sent: Thursday, September 12, 2019 6:25 PM > > > To:

Re: [FFmpeg-devel] [PATCH V9] avcodec/libvpxenc: add ROI-based encoding support for VP8/VP9

On Wed, Sep 18, 2019 at 7:54 AM Guo, Yejun wrote: > > > > > -Original Message- > > From: Guo, Yejun > > Sent: Thursday, September 12, 2019 6:25 PM > > To: ffmpeg-devel@ffmpeg.org > > Cc: Guo, Yejun > > Subject: [PATCH V9] avcodec/libvpxenc: add ROI-based encoding support for > > VP8/VP9

Re: [FFmpeg-devel] [PATCH] Delete unused branch in libaomenc

On Wed, Sep 18, 2019 at 11:42 AM James Zern wrote: > > On Sun, Sep 15, 2019 at 2:03 PM Elliott Karpilovsky > wrote: > > > > --- > > libavcodec/libaomenc.c | 14 +- > > 1 file changed, 5 insertions(+), 9 deletions(-) > > > > lgtm. This

Re: [FFmpeg-devel] [PATCH] Delete unused branch in libaomenc

On Sun, Sep 15, 2019 at 2:03 PM Elliott Karpilovsky wrote: > > --- > libavcodec/libaomenc.c | 14 +- > 1 file changed, 5 insertions(+), 9 deletions(-) > lgtm. This is leftover from libvpxenc, only vp8 can hit the path there. > diff --git a/libavcodec/libaomenc.c

Re: [FFmpeg-devel] [PATCH V8] avcodec/libvpxenc: add ROI-based encoding support for VP8/VP9

Hi, On Tue, Sep 10, 2019 at 6:13 PM Guo, Yejun wrote: > > example command line to verify it: > ./ffmpeg -i input.stream -vf addroi=0:0:iw/3:ih/3:-0.8 -c:v libvpx -b:v 2M > tmp.webm > > Signed-off-by: Guo, Yejun > --- > libavcodec/libvpxenc.c | 188 >

Re: [FFmpeg-devel] [PATCH] Change libvpx-vpx default to crf=32.

Hi, On Wed, Aug 28, 2019 at 2:26 PM Elliott Karpilovsky wrote: > > Current default is 200kbps, which produces inconsistent > results (too high for low-res, too low for hi-res). Use > CRF instead, which will adapt. Affects vp8/vp9. Also > have VP8 use a default bitrate of 256kbps. > --- >

Re: [FFmpeg-devel] [PATCH V5] avcodec/libvpxenc: add ROI-based encoding support for VP8/VP9 support

On Wed, Aug 28, 2019 at 10:20 PM Guo, Yejun wrote: > > > > > -Original Message- > > From: James Zern [mailto:jz...@google.com] > > Sent: Thursday, August 29, 2019 12:39 PM > > To: Guo, Yejun > > Cc: FFmpeg development discussions and patches &g

Re: [FFmpeg-devel] [PATCH V5] avcodec/libvpxenc: add ROI-based encoding support for VP8/VP9 support

Hi, On Mon, Aug 26, 2019 at 11:30 PM Guo, Yejun wrote: > > > > > -Original Message- > > From: James Zern [mailto:jz...@google.com] > > Sent: Tuesday, August 27, 2019 12:03 PM > > To: FFmpeg development discussions and patches > > Cc: Guo, Yejun &g

Re: [FFmpeg-devel] [PATCH V5] avcodec/libvpxenc: add ROI-based encoding support for VP8/VP9 support

Hi, On Thu, Aug 22, 2019 at 5:56 PM Guo, Yejun wrote: > > example command line to verify it: > ./ffmpeg -i input.stream -vf addroi=0:0:iw/3:ih/3:-0.8 -c:v libvpx -b:v 2M > tmp.webm > > Signed-off-by: Guo, Yejun > --- > libavcodec/libvpxenc.c | 194 >

Re: [FFmpeg-devel] [PATCH] Change libaom default to crf=32.

On Wed, Aug 21, 2019 at 6:03 PM James Zern wrote: > > On Wed, Aug 21, 2019 at 12:18 PM Elliott Karpilovsky > wrote: > > > > From: elliottk > > > > Current default is 256kbps, which produces inconsistent > > results (too high for low-res, too low

Re: [FFmpeg-devel] [PATCH] Change libaom default to crf=32.

Hi, On Thu, Aug 22, 2019 at 12:25 AM Moritz Barsnick wrote: > > On Wed, Aug 21, 2019 at 18:03:23 -0700, James Zern wrote: > > > From: elliottk > > > Current default is 256kbps, which produces inconsistent > > > results (too high for low-res, too low for hi-r

Re: [FFmpeg-devel] [PATCH] Change libaom default to crf=32.

On Wed, Aug 21, 2019 at 12:18 PM Elliott Karpilovsky wrote: > > From: elliottk > > Current default is 256kbps, which produces inconsistent > results (too high for low-res, too low for hi-res). > Use CRF instead, which will adapt. > --- > libavcodec/libaomenc.c | 9 + > 1 file changed, 5

Re: [FFmpeg-devel] [PATCH] Change libaom default to crf=28.

On Tue, Aug 20, 2019 at 5:31 PM Elliott Karpilovsky wrote: > > I believe the documentation is out of date. I added some debug > statements and verified that variable was being used to pull CRF > values when AOM_Q mode is set. I have > https://aomedia-review.googlesource.com/c/aom/+/94104 out to

Re: [FFmpeg-devel] [PATCH V3] avcodec/libvpxenc: add ROI-based encoding support for VP8/VP9 support

Hi, On Tue, Aug 13, 2019 at 8:29 PM Guo, Yejun wrote: > example command line to verify it: > ./ffmpeg -i input.stream -vf addroi=0:0:iw/3:ih/3:-0.8 -c:v libvpx -b:v 2M > tmp.webm > > Signed-off-by: Guo, Yejun > --- > libavcodec/libvpxenc.c | 197 >

Re: [FFmpeg-devel] [PATCH] Change libaom default to crf=28.

Hi, On Thu, Aug 15, 2019 at 1:22 PM elliottk wrote: > > Current default is 256kbps, which produces inconsistent > results (too high for low-res, too low for hi-res). > Use CRF instead, which will adapt. > --- > libavcodec/libaomenc.c | 9 + > 1 file changed, 5 insertions(+), 4

Re: [FFmpeg-devel] [PATCH] Change libaom default to crf=28.

Hi, On Tue, Aug 13, 2019 at 8:23 PM elliottk wrote: > > Current default is 256kbps, which produces inconsistent > results (too high for low-res, too low for hi-res). > Use CRF instead, which will adapt. > --- > libavcodec/libaomenc.c | 8 > 1 file changed, 4 insertions(+), 4

Re: [FFmpeg-devel] [PATCH, RFC, v2 3/3] lavc/libvpxenc: add dynamic resolution encode support for libvpx

Hi, On Tue, Aug 13, 2019 at 2:30 AM Linjie Fu wrote: > > According to spec, libvpx should support dynamic resolution changes. > > Add dynamic resolution encoding support in libvpx. > > Only single pass mode with no look ahead is supported for variable > resolution encoding without

Re: [FFmpeg-devel] [PATCH V2] avcodec/libvpxenc: add ROI-based encoding support for VP8/VP9 support

Hi, On Tue, Aug 13, 2019 at 1:18 AM Guo, Yejun wrote: > > example command line to verify it: > ./ffmpeg -i input.stream -vf addroi=0:0:iw/3:ih/3:-0.8 -c:v libvpx -b:v 2M > tmp.webm > > Signed-off-by: Guo, Yejun > --- > configure | 7 ++ > libavcodec/libvpxenc.c | 197 >

Re: [FFmpeg-devel] [PATCH, v2 3/3] lavc/libvpxenc: add dynamic resolution encode support for libvpx

Hi, On Tue, Jul 30, 2019 at 10:06 PM Linjie Fu wrote: > [...] > diff --git a/libavcodec/libvpxenc.c b/libavcodec/libvpxenc.c > index feb52ea..800ba18 100644 > --- a/libavcodec/libvpxenc.c > +++ b/libavcodec/libvpxenc.c > @@ -1067,6 +1067,15 @@ static int vpx_encode(AVCodecContext *avctx,

[FFmpeg-devel] [PATCH] avcodec/utils, avcodec_open2: close codec on failure

after a successful init if the function fails for another reason close the codec without requiring FF_CODEC_CAP_INIT_CLEANUP which is meant to cover init failures themselves. fixes a memory leak in those cases. BUG=oss-fuzz:15529 Signed-off-by: James Zern --- libavcodec/utils.c | 5 - 1

Re: [FFmpeg-devel] [PATCH V3] avcodec/libvpxenc: add VP8 support for ROI-based encoding

On Thu, Feb 28, 2019 at 11:23 PM Guo, Yejun wrote: > > Signed-off-by: Guo, Yejun > --- > libavcodec/libvpxenc.c | 150 > + > 1 file changed, 150 insertions(+) > > diff --git a/libavcodec/libvpxenc.c b/libavcodec/libvpxenc.c > index

Re: [FFmpeg-devel] [PATCH 2/2] configure: use vpx_codec_vp8_dx/cx for libvpx-vp8 checking

On Mon, Mar 4, 2019 at 6:19 AM Guo, Yejun wrote: > > Signed-off-by: Guo, Yejun > --- > configure | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > lgtm. This is a remnant from when vp8 was the only codec in the library. ___ ffmpeg-devel

Re: [FFmpeg-devel] [PATCH] avcodec/libvpxenc: add VP8 support for ROI-based encoding

On Fri, Mar 1, 2019 at 4:51 AM Derek Buitenhuis wrote: > > On 01/03/2019 03:18, Guo, Yejun wrote: > > yes, that's the reason I pending VP9 work. As for VP8 ROI, another thinking > > is to first push vp8 roi, since libvpx is an external dependency and we > > don't > > know the time when it is

Re: [FFmpeg-devel] [PATCH] avcodec/libvpxenc: add VP8 support for ROI-based encoding

> > > > > +if (avctx->codec_id == AV_CODEC_ID_VP8) > > > +vp8_encode_set_roi(avctx, frame); > > > > The API only exists for VP8, or is this due to different quant scales or > > something? > > currently, VP9 ROI does not work, see my discussion at >

Re: [FFmpeg-devel] lavc/libvpxenc: Deprecate lossless option

On Sat, Feb 9, 2019 at 3:15 AM Carl Eugen Hoyos wrote: > > 2019-02-09 7:49 GMT+01:00, Gyan : > > > > > > On 09-02-2019 02:26 AM, Carl Eugen Hoyos wrote: > >> 2019-02-08 6:08 GMT+01:00, Gyan : > >>> > >>> On 08-02-2019 03:31 AM, Carl Eugen Hoyos wrote: > . > No strong opinion here, I

Re: [FFmpeg-devel] [PATCH] avcodec/libvpxenc: add VP8/9 sharpness config option

On Fri, Dec 21, 2018 at 7:38 PM James Zern wrote: > > On Fri, Dec 21, 2018 at 1:36 PM Rene Claus > wrote: > > > > This commit adds configuration options to libvpxenc.c that can be used to > > tune the sharpness parameter for VP8 and VP9. > > > > Sign

Re: [FFmpeg-devel] [PATCH] avcodec/libvpxenc: add VP8/9 sharpness config option

On Fri, Dec 21, 2018 at 11:24 AM James Almer wrote: > > On 12/21/2018 1:09 PM, James Zern wrote: > > On Thu, Dec 20, 2018 at 7:51 PM Rene Claus > > wrote: > >> > >> This commit adds configuration options to libvpxenc.c that can be used to > >>

Re: [FFmpeg-devel] [PATCH] avcodec/libvpxenc: add VP8/9 sharpness config option

On Fri, Dec 21, 2018 at 1:36 PM Rene Claus wrote: > > This commit adds configuration options to libvpxenc.c that can be used to > tune the sharpness parameter for VP8 and VP9. > > Signed-off-by: Rene Claus > --- > doc/encoders.texi | 4 > libavcodec/libvpxenc.c | 6 ++ > 2 files

Re: [FFmpeg-devel] [PATCH] avcodec/libvpxenc: add VP8/9 sharpness config option

On Thu, Dec 20, 2018 at 7:51 PM Rene Claus wrote: > > This commit adds configuration options to libvpxenc.c that can be used to > tune the sharpness parameter for VP8 and VP9. > > Signed-off-by: Rene Claus > --- > doc/encoders.texi | 4 > libavcodec/libvpxenc.c | 6 ++ > 2 files

Re: [FFmpeg-devel] [PATCH] avcodec/libvpxenc: add VP8/9 sharpness config option

On Wed, Dec 19, 2018 at 2:03 PM James Almer wrote: > > On 12/19/2018 6:52 PM, Rene Claus wrote: > > This commit adds configuration options to libvpxenc.c that can be used to > > tune the sharpness parameter for VP8 and VP9. > > > > Signed-off-by: Rene Claus > > --- > > doc/encoders.texi |

Re: [FFmpeg-devel] [PATCH] avcodec/libvpxenc: add VP8/9 sharpness config option

On Wed, Dec 19, 2018 at 10:24 AM Rene Claus wrote: > > This commit adds configuration options to libvpxenc.c that can be used to > tune the sharpness parameter of the loop filter for VP8 and VP9. > > Signed-off-by: Rene Claus > --- > doc/encoders.texi | 4 > libavcodec/libvpxenc.c | 5

Re: [FFmpeg-devel] [PATCH] avcodec/libvpxenc: add VP8 temporal scalability configuration options

On Fri, Nov 16, 2018 at 8:59 PM James Zern wrote: > > On Wed, Nov 14, 2018 at 12:56 PM Ard Oerlemans > wrote: > > > > This commit adds configuration options to libvpxenc.c that can be used to > > enable VP8 temporal scalability. It also adds a way to programmatically

Re: [FFmpeg-devel] [PATCH] avcodec/libvpxenc: add VP8 temporal scalability configuration options

On Wed, Nov 14, 2018 at 12:56 PM Ard Oerlemans wrote: > > This commit adds configuration options to libvpxenc.c that can be used to > enable VP8 temporal scalability. It also adds a way to programmatically set > the > per-frame encoding flags which can be used to control usage and updates of >

Re: [FFmpeg-devel] [PATCH] avcodec/libvpxenc: add VP8 temporal scalability configuration options

On Mon, Nov 12, 2018 at 10:37 AM Ard Oerlemans wrote: > > Thanks for the suggestion. I have updated the patch. > Try to keep the original patch message so it's easier to apply. > Ard > > --- > doc/encoders.texi | 28 +++ > libavcodec/libvpxenc.c | 79

Re: [FFmpeg-devel] [PATCH] libvpxenc,vp9: add enable-tpl option

On Thu, Nov 8, 2018 at 2:46 PM James Zern wrote: > > On Sat, Nov 3, 2018 at 2:01 PM James Zern wrote: > > > > enables temporal dependency model > > > > Signed-off-by: James Zern > > --- > > doc/encoders.texi | 2 ++ > > libavcodec/libvp

Re: [FFmpeg-devel] [PATCH] libvpxenc: extend auto-alt-ref range

On Mon, Nov 5, 2018 at 5:03 PM James Zern wrote: > > On Mon, Nov 5, 2018 at 5:02 PM James Zern wrote: > > > > vp9 now supports [0, 6] > > > > Signed-off-by: James Zern > > --- > > doc/encoders.texi | 1 + > > libavcodec/libvpxenc.c | 6

Re: [FFmpeg-devel] [PATCH] libvpxenc,vp9: add enable-tpl option

On Sat, Nov 3, 2018 at 2:01 PM James Zern wrote: > > enables temporal dependency model > > Signed-off-by: James Zern > --- > doc/encoders.texi | 2 ++ > libavcodec/libvpxenc.c | 11 +++ > 2 files changed, 13 insertions(+) > If there aren't any comment

[FFmpeg-devel] [PATCH] libvpxenc: extend auto-alt-ref range

vp9 now supports [0, 6] Signed-off-by: James Zern --- doc/encoders.texi | 1 + libavcodec/libvpxenc.c | 6 -- 2 files changed, 5 insertions(+), 2 deletions(-) diff --git a/doc/encoders.texi b/doc/encoders.texi index 899faac49b..3c6f5cd70b 100644 --- a/doc/encoders.texi +++ b/doc

Re: [FFmpeg-devel] [PATCH] libvpxenc: extend auto-alt-ref range

On Mon, Nov 5, 2018 at 5:02 PM James Zern wrote: > > vp9 now supports [0, 6] > > Signed-off-by: James Zern > --- > doc/encoders.texi | 1 + > libavcodec/libvpxenc.c | 6 -- > 2 files changed, 5 insertions(+), 2 deletions(-) > This version moves the

Re: [FFmpeg-devel] [PATCH] libvpxenc: extend auto-alt-ref range

On Mon, Nov 5, 2018 at 4:45 PM James Zern wrote: > > On Sat, Nov 3, 2018 at 2:31 PM James Almer wrote: > > > > On 11/3/2018 6:04 PM, James Zern wrote: > > > On Sat, Nov 3, 2018 at 2:02 PM James Zern wrote: > > >> [...] > > >> #define COMMON

Re: [FFmpeg-devel] [PATCH] libvpxenc: extend auto-alt-ref range

On Sat, Nov 3, 2018 at 2:31 PM James Almer wrote: > > On 11/3/2018 6:04 PM, James Zern wrote: > > On Sat, Nov 3, 2018 at 2:02 PM James Zern wrote: > >> [...] > >> #define COMMON_OPTIONS \ > >> { "auto-alt

Re: [FFmpeg-devel] [PATCH] libvpxenc: extend auto-alt-ref range

On Sat, Nov 3, 2018 at 2:02 PM James Zern wrote: > [...] > #define COMMON_OPTIONS \ > { "auto-alt-ref","Enable use of alternate reference " \ > - "frames (2-pass only)", > OFFSET(auto_alt_ref),

[FFmpeg-devel] [PATCH] libvpxenc,vp9: add enable-tpl option

enables temporal dependency model Signed-off-by: James Zern --- doc/encoders.texi | 2 ++ libavcodec/libvpxenc.c | 11 +++ 2 files changed, 13 insertions(+) diff --git a/doc/encoders.texi b/doc/encoders.texi index 899faac49b..fced8d7369 100644 --- a/doc/encoders.texi +++ b/doc

[FFmpeg-devel] [PATCH] libvpxenc: extend auto-alt-ref range

vp9 now supports [0, 6] Signed-off-by: James Zern --- doc/encoders.texi | 1 + libavcodec/libvpxenc.c | 2 +- 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/doc/encoders.texi b/doc/encoders.texi index 899faac49b..3c6f5cd70b 100644 --- a/doc/encoders.texi +++ b/doc

Re: [FFmpeg-devel] [PATCH] avcodec/libvpxdec: fix setting auto threads

On Mon, Oct 29, 2018 at 10:58 PM James Zern wrote: > > On Sat, Oct 27, 2018 at 1:54 PM James Almer wrote: > > > > On 10/27/2018 5:52 PM, James Zern wrote: > > > a thread count of 0 is treated the same as 1, use av_cpu_count() to get > > > the correct thread

Re: [FFmpeg-devel] [PATCH] avcodec/libvpxdec: fix setting auto threads

On Sat, Oct 27, 2018 at 1:54 PM James Almer wrote: > > On 10/27/2018 5:52 PM, James Zern wrote: > > a thread count of 0 is treated the same as 1, use av_cpu_count() to get > > the correct thread count when auto threads is requested. > > > > this matches the fi

[FFmpeg-devel] [PATCH] avcodec/libvpxdec: fix setting auto threads

a thread count of 0 is treated the same as 1, use av_cpu_count() to get the correct thread count when auto threads is requested. this matches the fix in libvpxenc: 27df34bf1f avcodec/libvpxenc: fix setting amount of threads used for encoding Signed-off-by: James Zern --- libavcodec/libvpxdec.c

Re: [FFmpeg-devel] [PATCH] avformat/vpcc: fix values in VP9 level detection heuristics

On Fri, Sep 14, 2018 at 6:39 PM James Almer wrote: > > On 8/27/2018 10:59 PM, James Almer wrote: > > The levels are stored as decimal values, not hexadecimal. > > > > Signed-off-by: James Almer > > --- > > libavformat/vpcc.c | 28 ++-- > > 1 file changed, 14

Re: [FFmpeg-devel] [PATCH] lavc/libaomenc: Add -tile-columns/-tile-rows

On Fri, Aug 31, 2018 at 9:40 AM James Almer wrote: > > On 8/31/2018 1:00 PM, Kagami Hiiragi wrote: > > On 31/08/18 18:18, James Almer wrote: > >> On 8/31/2018 11:52 AM, Kagami Hiiragi wrote: > >>> On 31/08/18 02:58, James Almer wrote: > On 8/20/2018 2:56 PM, Kagami Hiiragi wrote: > >

Re: [FFmpeg-devel] [PATCH] avcodec/libvpxenc: fix setting amount of threads used for encoding

On Sat, May 19, 2018 at 11:16 AM James Almer wrote: > The libvpx doxy says that a value of 0 for the g_threads field is > equivalent to a value of 1, whereas for avctx->thread_count it means > the maximum amount of threads possible for the host system. > Use av_cpu_count() to

Re: [FFmpeg-devel] [PATCH] avcodec/vp9: mark frame as finished on decode_tiles() failure

fps_10bit_420.y4m.vp9.noaltref.webm.ivf.s149104_r01-05_b6-.ivf > Fixes: ducks_take_off_444_720p50.y4m.vp9.webm.ivf.s107375_r01-05_b6-.ivf > > Reported-by: James Zern <jz...@google.com> > Signed-off-by: Michael Niedermayer <mich...@niedermayer.cc> > --- > libavcodec/vp9.c | 4 +++- > 1 file c

Re: [FFmpeg-devel] [PATCH] libvpxenc, vp9: add corpus-complexity option

On Mon, Nov 27, 2017 at 10:55 AM, James Zern <jz...@google.com> wrote: > On Mon, Nov 20, 2017 at 5:36 PM, James Zern <jz...@google.com> wrote: >> Corpus VBR mode is a variant of standard VBR where the complexity >> distribution midpoint is passed in rather than calcul

Re: [FFmpeg-devel] [PATCH] libvpxenc, vp9: add corpus-complexity option

On Mon, Nov 20, 2017 at 5:36 PM, James Zern <jz...@google.com> wrote: > Corpus VBR mode is a variant of standard VBR where the complexity > distribution midpoint is passed in rather than calculated for a specific > clip or chunk. > > The valid range is [0, 1]. 0 (defau

[FFmpeg-devel] [PATCH] libvpxenc, vp9: add corpus-complexity option

Corpus VBR mode is a variant of standard VBR where the complexity distribution midpoint is passed in rather than calculated for a specific clip or chunk. The valid range is [0, 1]. 0 (default) uses standard VBR. Signed-off-by: James Zern <jz...@google.com> --- doc/encoders.texi

Re: [FFmpeg-devel] [PATCH 3/4] libvpxdec: remove pre-1.4.0 checks

On Fri, Nov 17, 2017 at 5:50 PM, James Zern <jz...@google.com> wrote: > Signed-off-by: James Zern <jz...@google.com> > --- > libavcodec/libvpxdec.c | 25 - > 1 file changed, 25 deletions(-) > applied. _

Re: [FFmpeg-devel] [PATCH 4/4] libvpxenc: remove pre-1.4.0 checks

On Fri, Nov 17, 2017 at 5:50 PM, James Zern <jz...@google.com> wrote: > Signed-off-by: James Zern <jz...@google.com> > --- > libavcodec/libvpxenc.c | 25 +++-- > 1 file changed, 3 insertions(+), 22 deletions(-) > applied. ___

Re: [FFmpeg-devel] [PATCH 2/4] libvpx: remove pre-1.4.0 checks

On Fri, Nov 17, 2017 at 5:50 PM, James Zern <jz...@google.com> wrote: > Signed-off-by: James Zern <jz...@google.com> > --- > libavcodec/libvpx.c | 12 +--- > 1 file changed, 1 insertion(+), 11 deletions(-) > applied. _

Re: [FFmpeg-devel] [PATCH 1/4] configure: require libvpx-1.4.0 for vp[89] support

On Mon, Nov 20, 2017 at 11:51 AM, James Almer <jamr...@gmail.com> wrote: > On 11/20/2017 4:38 PM, James Zern wrote: >> On Mon, Nov 20, 2017 at 11:17 AM, James Zern <jz...@google.com> wrote: >>> On Sun, Nov 19, 2017 at 6:03 AM, James Almer <jamr...@gmail.com>

Re: [FFmpeg-devel] [PATCH 1/4] configure: require libvpx-1.4.0 for vp[89] support

On Mon, Nov 20, 2017 at 11:17 AM, James Zern <jz...@google.com> wrote: > On Sun, Nov 19, 2017 at 6:03 AM, James Almer <jamr...@gmail.com> wrote: >> On 11/17/2017 10:50 PM, James Zern wrote: >>> this will simplify libvpxenc/dec.c and ensure more stable versions

Re: [FFmpeg-devel] [PATCH 2/4] libvpx: remove pre-1.4.0 checks

On Sun, Nov 19, 2017 at 5:57 AM, James Almer <jamr...@gmail.com> wrote: > On 11/17/2017 10:50 PM, James Zern wrote: >> Signed-off-by: James Zern <jz...@google.com> >> --- >> libavcodec/libvpx.c | 12 +--- >> 1 file changed, 1 insertion(+), 11 del

Re: [FFmpeg-devel] [PATCH 1/4] configure: require libvpx-1.4.0 for vp[89] support

On Sun, Nov 19, 2017 at 6:03 AM, James Almer <jamr...@gmail.com> wrote: > On 11/17/2017 10:50 PM, James Zern wrote: >> this will simplify libvpxenc/dec.c and ensure more stable versions of >> the codecs are present. >> >> Signed-off-by: James Zern <jz...@g

[FFmpeg-devel] [PATCH 1/4] configure: require libvpx-1.4.0 for vp[89] support

this will simplify libvpxenc/dec.c and ensure more stable versions of the codecs are present. Signed-off-by: James Zern <jz...@google.com> --- configure | 20 ++-- 1 file changed, 10 insertions(+), 10 deletions(-) diff --git a/configure b/configure index c8e2e35192..bfb1

[FFmpeg-devel] [PATCH 3/4] libvpxdec: remove pre-1.4.0 checks

Signed-off-by: James Zern <jz...@google.com> --- libavcodec/libvpxdec.c | 25 - 1 file changed, 25 deletions(-) diff --git a/libavcodec/libvpxdec.c b/libavcodec/libvpxdec.c index ad0ea3b02a..2ae29d202a 100644 --- a/libavcodec/libvpxdec.c +++ b/libavcodec/libvp

<    1   2   3   4   5   >