Re: [FFmpeg-devel] [PATCH 2/2] tests/checkasm/vvc_mc: don't zero the SAD buffers

2024-05-31 Thread Nuo Mi
On Wed, May 29, 2024 at 10:03 PM James Almer wrote: > They will be filled immediately after. > Pushed. thank you, James > > Signed-off-by: James Almer > --- > tests/checkasm/vvc_mc.c | 3 --- > 1 file changed, 3 deletions(-) > > diff --git a/tests/checkasm/vvc_mc.c b/tests/checkasm/vvc_mc.c >

Re: [FFmpeg-devel] [PATCH v2 1/3] avcodec/x86/vvc/vvc_alf: fix integer overflow

2024-05-31 Thread Nuo Mi
On Fri, May 31, 2024 at 2:29 AM Ronald S. Bultje wrote: > Hi, > > On Thu, May 30, 2024 at 12:28 PM wrote: > > > From: Wu Jianhua > > > > Some tests fails with certain seeds > > > > tests/checkasm/checkasm 2325607578 --test=vvc_alf > > checkasm: using random seed 2325607578 > > AVX2: > >

Re: [FFmpeg-devel] [PATCH v2 1/3] avcodec/x86/vvc/vvc_alf: fix integer overflow

2024-05-31 Thread Nuo Mi
On Fri, May 31, 2024 at 4:49 AM Ronald S. Bultje wrote: > Hi Andreas, > > On Thu, May 30, 2024 at 2:33 PM Andreas Rheinhardt < > andreas.rheinha...@outlook.com> wrote: > > > toq...@outlook.com: > > > From: Wu Jianhua > > > > > > Some tests fails with certain seeds > > > > > >

Re: [FFmpeg-devel] [PATCH v1 2/2][GSoC 2024] tests/checkasm/vvc_mc: for SAD, only test valid subblock sizes

2024-05-29 Thread Nuo Mi
On Wed, May 29, 2024 at 3:10 AM Stone Chen wrote: > According to the VVC specification (section 8.5.1), the maximum > width/height of a subblock passed for DMVR SAD is 16. This along with > previous constraint requiring width * height >= 128 means that 8x16, 16x8, > and 16x16 are the only

Re: [FFmpeg-devel] [PATCH] lavc/vvc: Validate temporal MVP references

2024-05-27 Thread Nuo Mi
ecoding some fuzzed bitstreams. > > Additionally, only set up the collocated reference picture if it is > actually going to be used (i.e. if ph_temporal_mvp_enabled_flag is 1), > else legal RPR bitstreams will fail the new checks. > Applied, thank you, Frank. > > Co-authored-b

Re: [FFmpeg-devel] [PATCH v3 1/2] avcodec: add external enc libvvenc for H266/VVC

2024-05-24 Thread Nuo Mi
Hi @Andreas, Thank you for the review. Seems Christian still needs some guidance from you, see 1, 2, 3 On Thu, May 16, 2024 at 11:22 PM Christian wrote: > > > > On 14. May 2024, at 18:49, Andreas Rheinhardt < > andreas.rheinha...@outlook.com> wrote: > > > > Christian Bartnik: > >> From: Thomas

Re: [FFmpeg-devel] [PATCH v5 1/2][GSoC 2024] libavcodec/x86/vvc: Add AVX2 DMVR SAD functions for VVC

2024-05-23 Thread Nuo Mi
On Thu, May 23, 2024 at 7:38 AM James Almer wrote: > On 5/21/2024 10:01 PM, Ronald S. Bultje wrote: > > Hi, > > > > On Tue, May 21, 2024 at 8:01 PM Stone Chen > wrote: > > > >> Implements AVX2 DMVR (decoder-side motion vector refinement) SAD > >> functions. DMVR SAD is only calculated if w >=

Re: [FFmpeg-devel] 回复: [PATCH] x86/vvc_alf: use the x86inc instruction macros

2024-05-22 Thread Nuo Mi
On Wed, May 22, 2024 at 12:29 AM Wu Jianhua wrote: > > 发件人: ffmpeg-devel 代表 James Almer < > jamr...@gmail.com> > > 发送时间: 2024年5月21日 6:52 > > 收件人: ffmpeg-devel@ffmpeg.org > > 主题: [FFmpeg-devel] [PATCH] x86/vvc_alf: use the x86inc instruction macros > > > > Let its magic figure out the correct

Re: [FFmpeg-devel] [PATCH] checkasm: vvc_alf: Limit benchmarking to a reasonable subset of functions

2024-05-21 Thread Nuo Mi
On Tue, May 21, 2024 at 6:16 PM Martin Storsjö wrote: > On Tue, 21 May 2024, Martin Storsjö wrote: > > > Don't benchmark every single combination of widths and heights; > > only benchmark cases which are squares (like in vvc_mc.c). > > > > Contrary to vvc_mc, which increases sizes by doubling

Re: [FFmpeg-devel] [PATCH 18/18] Changelog: add DVB compatible information for VVC decoder

2024-05-21 Thread Nuo Mi
On Sun, May 19, 2024 at 9:39 PM Nuo Mi wrote: > see > https://dvb.org/specifications/verification-validation/vvc-test-content/ > --- > Changelog | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/Changelog b/Changelog > index dd25715d6b..12770e4296 100644 &

Re: [FFmpeg-devel] [PATCH] checkasm: vvc_alf: Limit benchmarking to a reasonable subset of functions

2024-05-21 Thread Nuo Mi
On Tue, May 21, 2024 at 7:11 PM Rémi Denis-Courmont wrote: > > > Le 21 mai 2024 13:04:29 GMT+03:00, "Martin Storsjö" a > écrit : > >Don't benchmark every single combination of widths and heights; > >only benchmark cases which are squares (like in vvc_mc.c). > > > >Contrary to vvc_mc, which

Re: [FFmpeg-devel] [PATCH 12/18] avcodec/vvcdec: inter, wait reference with a diffrent resolution

2024-05-20 Thread Nuo Mi
On Sun, May 19, 2024 at 11:21 PM Jean-Baptiste Kempf wrote: > Careful about the typo on "different" on the title of the patch. > Changed locally. Thank you, jb > > On Sun, 19 May 2024, at 13:27, Nuo Mi wrote: > > For RPR, the current frame may reference a frame w

Re: [FFmpeg-devel] [PATCH 3/9] avcodec/vvc/ctu: Simplify pred_mode_plt_flag

2024-05-19 Thread Nuo Mi
On Sun, May 19, 2024 at 10:49 AM Michael Niedermayer wrote: > Fixes: CID1560039 Logically dead code > > Sponsored-by: Sovereign Tech Fund > Signed-off-by: Michael Niedermayer > --- > libavcodec/vvc/ctu.c | 23 ++- > 1 file changed, 6 insertions(+), 17 deletions(-) > > diff

Re: [FFmpeg-devel] [PATCH 6/9] avcodec/vvc/dec: Check init_get_bits8() for failure

2024-05-19 Thread Nuo Mi
On Sun, May 19, 2024 at 10:50 AM Michael Niedermayer wrote: > Fixes: CID1560042 Unchecked return value > > Sponsored-by: Sovereign Tech Fund > Signed-off-by: Michael Niedermayer > --- > libavcodec/vvc/dec.c | 5 - > 1 file changed, 4 insertions(+), 1 deletion(-) > > diff --git

Re: [FFmpeg-devel] [PATCH 7/9] avcodec/vvc/mvs: Initialize mvf

2024-05-19 Thread Nuo Mi
On Sun, May 19, 2024 at 10:50 AM Michael Niedermayer wrote: > This might not be needed for correctness but it could > help general reproducability of issues > > Related to: CID1560037 Uninitialized scalar variable > Related to: CID1560044 Uninitialized scalar variable > > Sponsored-by: Sovereign

Re: [FFmpeg-devel] [PATCH] avcodec/cbs_h266: read vps_ptl_max_tid before using it

2024-05-19 Thread Nuo Mi
On Sun, May 19, 2024 at 9:28 PM James Almer wrote: > Signed-off-by: James Almer > --- > libavcodec/cbs_h266_syntax_template.c | 28 ++- > 1 file changed, 15 insertions(+), 13 deletions(-) > > diff --git a/libavcodec/cbs_h266_syntax_template.c >

[FFmpeg-devel] [PATCH 07/18] avcodec/vvcdec: refact out VVCRefPic from RefPicList

2024-05-19 Thread Nuo Mi
--- libavcodec/vvc/ctu.c| 10 +- libavcodec/vvc/dec.c| 4 ++-- libavcodec/vvc/dec.h| 10 +++--- libavcodec/vvc/filter.c | 22 +++--- libavcodec/vvc/inter.c | 4 ++-- libavcodec/vvc/mvs.c| 36 ++-- libavcodec/vvc/refs.c

[FFmpeg-devel] [PATCH 17/18] avcodec/vvcdec: support Reference Picture Resampling

2024-05-19 Thread Nuo Mi
passed clips: RPR_A_Alibaba_4.bit RPR_B_Alibaba_3.bit RPR_C_Alibaba_3.bit RPR_D_Qualcomm_1.bit VVC_HDR_UHDTV1_OpenGOP_Max3840x2160_50fps_HLG10_res_change_with_RPR.ts --- libavcodec/vvc/inter.c | 190 + 1 file changed, 173 insertions(+),

[FFmpeg-devel] [PATCH 15/18] avcodec/vvcdec: refact, remove hf_idx and vf_idx from mc_xxx's param list

2024-05-19 Thread Nuo Mi
--- libavcodec/vvc/inter.c | 27 +++ 1 file changed, 15 insertions(+), 12 deletions(-) diff --git a/libavcodec/vvc/inter.c b/libavcodec/vvc/inter.c index 23b9a8af6b..5d553708d9 100644 --- a/libavcodec/vvc/inter.c +++ b/libavcodec/vvc/inter.c @@ -208,6 +208,7 @@ static

[FFmpeg-devel] [PATCH 16/18] avcodec/vvcdec: increase edge_emu_buffer for RPR

2024-05-19 Thread Nuo Mi
--- libavcodec/vvc/ctu.h | 9 - 1 file changed, 4 insertions(+), 5 deletions(-) diff --git a/libavcodec/vvc/ctu.h b/libavcodec/vvc/ctu.h index 50109154aa..a987328d81 100644 --- a/libavcodec/vvc/ctu.h +++ b/libavcodec/vvc/ctu.h @@ -46,7 +46,8 @@ #define MAX_QP 63

[FFmpeg-devel] [PATCH 13/18] avcodec/vvcdec: fix dmvr, bdof, cb_prof for RPR

2024-05-19 Thread Nuo Mi
--- libavcodec/vvc/ctu.c | 18 +- libavcodec/vvc/mvs.c | 3 ++- 2 files changed, 11 insertions(+), 10 deletions(-) diff --git a/libavcodec/vvc/ctu.c b/libavcodec/vvc/ctu.c index 242caa58f7..809510b93d 100644 --- a/libavcodec/vvc/ctu.c +++ b/libavcodec/vvc/ctu.c @@ -1689,25

[FFmpeg-devel] [PATCH 14/18] avcodec/vvcdec: refact out luma_prof from luma_prof_bi

2024-05-19 Thread Nuo Mi
--- libavcodec/vvc/inter.c | 52 -- 1 file changed, 30 insertions(+), 22 deletions(-) diff --git a/libavcodec/vvc/inter.c b/libavcodec/vvc/inter.c index f432a2dc3c..23b9a8af6b 100644 --- a/libavcodec/vvc/inter.c +++ b/libavcodec/vvc/inter.c @@ -347,40

[FFmpeg-devel] [PATCH 11/18] avcodec/vvcdec: add RPR dsp

2024-05-19 Thread Nuo Mi
--- libavcodec/vvc/ctu.h| 2 + libavcodec/vvc/dsp.h| 13 +++ libavcodec/vvc/inter_template.c | 168 3 files changed, 183 insertions(+) diff --git a/libavcodec/vvc/ctu.h b/libavcodec/vvc/ctu.h index 337d0e7c28..50109154aa 100644 ---

[FFmpeg-devel] [PATCH 12/18] avcodec/vvcdec: inter, wait reference with a diffrent resolution

2024-05-19 Thread Nuo Mi
For RPR, the current frame may reference a frame with a different resolution. Therefore, we need to consider frame scaling when we wait for reference pixels. --- libavcodec/vvc/dec.c| 5 + libavcodec/vvc/dec.h| 17 + libavcodec/vvc/refs.c | 39

[FFmpeg-devel] [PATCH 09/18] avcodec/vvcdec: add vvc inter filters for RPR

2024-05-19 Thread Nuo Mi
--- libavcodec/vvc/data.c | 83 - libavcodec/vvc/data.h | 10 +++-- libavcodec/vvc/inter.c | 8 ++-- tests/checkasm/vvc_mc.c | 12 +++--- 4 files changed, 98 insertions(+), 15 deletions(-) diff --git a/libavcodec/vvc/data.c b/libavcodec/vvc/data.c

[FFmpeg-devel] [PATCH 10/18] avcodec/vvcdec: emulated_edge, use reference frame's sps and pps

2024-05-19 Thread Nuo Mi
a preparation for Reference Picture Resampling --- libavcodec/vvc/dec.c | 3 +++ libavcodec/vvc/dec.h | 2 ++ libavcodec/vvc/inter.c | 54 ++ libavcodec/vvc/refs.c | 5 4 files changed, 38 insertions(+), 26 deletions(-) diff --git

[FFmpeg-devel] [PATCH 04/18] avcodec/vvcdec: refact, unify {luma, chroma}_mc_bi to mc_bi

2024-05-19 Thread Nuo Mi
--- libavcodec/vvc/inter.c | 95 +- 1 file changed, 30 insertions(+), 65 deletions(-) diff --git a/libavcodec/vvc/inter.c b/libavcodec/vvc/inter.c index 6d866c1bad..9132bfaee2 100644 --- a/libavcodec/vvc/inter.c +++ b/libavcodec/vvc/inter.c @@ -151,6

[FFmpeg-devel] [PATCH 08/18] avcodec/vvcdec: refact, pred_get_refs return VVCRefPic instead of VVCFrame

2024-05-19 Thread Nuo Mi
--- libavcodec/vvc/inter.c | 30 +++--- 1 file changed, 15 insertions(+), 15 deletions(-) diff --git a/libavcodec/vvc/inter.c b/libavcodec/vvc/inter.c index cd96707c02..23d9ac05e6 100644 --- a/libavcodec/vvc/inter.c +++ b/libavcodec/vvc/inter.c @@ -387,15 +387,15 @@

[FFmpeg-devel] [PATCH 18/18] Changelog: add DVB compatible information for VVC decoder

2024-05-19 Thread Nuo Mi
see https://dvb.org/specifications/verification-validation/vvc-test-content/ --- Changelog | 1 + 1 file changed, 1 insertion(+) diff --git a/Changelog b/Changelog index dd25715d6b..12770e4296 100644 --- a/Changelog +++ b/Changelog @@ -10,6 +10,7 @@ version : - vf_scale supports secondary ref

[FFmpeg-devel] [PATCH 03/18] avcodec/vvcdec: refact, unify {luma, chroma}_mc_uni to mc_uni

2024-05-19 Thread Nuo Mi
--- libavcodec/vvc/inter.c | 80 +- 1 file changed, 25 insertions(+), 55 deletions(-) diff --git a/libavcodec/vvc/inter.c b/libavcodec/vvc/inter.c index 8657541eaf..6d866c1bad 100644 --- a/libavcodec/vvc/inter.c +++ b/libavcodec/vvc/inter.c @@ -236,33

[FFmpeg-devel] [PATCH 06/18] avcodec/vvcdec: refact, unify pred_regular_{luma, chroma} to pred_regular

2024-05-19 Thread Nuo Mi
--- libavcodec/vvc/ctu.h | 3 +- libavcodec/vvc/inter.c | 133 + 2 files changed, 41 insertions(+), 95 deletions(-) diff --git a/libavcodec/vvc/ctu.h b/libavcodec/vvc/ctu.h index 4e38ecf54a..337d0e7c28 100644 --- a/libavcodec/vvc/ctu.h +++

[FFmpeg-devel] [PATCH 05/18] avcodec/vvcdec: misc, remove unused EMULATED_EDGE_{LUMA, CHROMA}, EMULATED_EDGE_DMVR_{LUAM, CHROMA}

2024-05-19 Thread Nuo Mi
--- libavcodec/vvc/inter.c | 24 +++- 1 file changed, 7 insertions(+), 17 deletions(-) diff --git a/libavcodec/vvc/inter.c b/libavcodec/vvc/inter.c index 9132bfaee2..cc93184ca0 100644 --- a/libavcodec/vvc/inter.c +++ b/libavcodec/vvc/inter.c @@ -142,25 +142,13 @@ static void

[FFmpeg-devel] [PATCH 02/18] avcodec/vvcdec: refact, unify {luma, chroma}_mc to mc

2024-05-19 Thread Nuo Mi
--- libavcodec/vvc/inter.c | 47 +- 1 file changed, 14 insertions(+), 33 deletions(-) diff --git a/libavcodec/vvc/inter.c b/libavcodec/vvc/inter.c index 3f0718cb5a..8657541eaf 100644 --- a/libavcodec/vvc/inter.c +++ b/libavcodec/vvc/inter.c @@ -142,6

[FFmpeg-devel] [PATCH 01/18] avcodec/vvcdec: misc, inter, use is_chroma instead of is_luma

2024-05-19 Thread Nuo Mi
--- libavcodec/vvc/inter.c | 50 +- 1 file changed, 25 insertions(+), 25 deletions(-) diff --git a/libavcodec/vvc/inter.c b/libavcodec/vvc/inter.c index 4a8d1d866a..3f0718cb5a 100644 --- a/libavcodec/vvc/inter.c +++ b/libavcodec/vvc/inter.c @@ -31,33

Re: [FFmpeg-devel] [PATCH v3 2/2] avcodec: add external dec libvvdec for H266/VVC

2024-05-18 Thread Nuo Mi
On Sat, May 18, 2024 at 1:20 AM Cosmin Stejerean via ffmpeg-devel < ffmpeg-devel@ffmpeg.org> wrote: > > > > On May 14, 2024, at 9:28 AM, Lynne via ffmpeg-devel < > ffmpeg-devel@ffmpeg.org> wrote: > > > > On 14/05/2024 17:09, Christian Bartnik wrote: > >> From: Thomas Siedel > >> Add external

Re: [FFmpeg-devel] [PATCH v3 4/4] tests/checkasm/vvc_alf: add check_alf_classify

2024-05-14 Thread Nuo Mi
On Mon, May 13, 2024 at 8:32 PM wrote: > From: Wu Jianhua > > Perforamnce Test (fps): > clip before after delta > Tango2_3840x2160_60_10_420_27_LD.266 56 115 105.36% > RitualDance_1920x1080_60_10_420_32_LD.266 272 481 76.83% >

Re: [FFmpeg-devel] [PATCH v2 1/2] avcodec: add external enc libvvenc for H266/VVC

2024-05-09 Thread Nuo Mi
On Tue, May 7, 2024 at 9:53 PM Christian wrote: > > > On 7. May 2024, at 03:53, Nuo Mi wrote: > > > > Hi Christian, > > Thank you for the patch. > > Let us review and merge the encoder part. > > > > On Tue, May 7, 2024 at 1:05 AM Christian Bartni

Re: [FFmpeg-devel] [PATCH v2 1/2] avcodec: add external enc libvvenc for H266/VVC

2024-05-06 Thread Nuo Mi
Hi Christian, Thank you for the patch. Let us review and merge the encoder part. On Tue, May 7, 2024 at 1:05 AM Christian Bartnik wrote: > From: Thomas Siedel > > Add external encoder VVenC for H266/VVC encoding. > Register new encoder libvvenc. > Add libvvenc to wrap the vvenc interface. >

Re: [FFmpeg-devel] [PATCH v2 4/4] tests/checkasm/vvc_alf: add check_alf_classify

2024-05-06 Thread Nuo Mi
On Wed, May 1, 2024 at 7:06 PM wrote: > From: Wu Jianhua > > Perforamnce Test (fps): > clip before after delta > Tango2_3840x2160_60_10_420_27_LD.266 56 115 105.36% > RitualDance_1920x1080_60_10_420_32_LD.266 272 481 76.83% >

Re: [FFmpeg-devel] [PATCH v2 2/2] avcodec/vvcdec: ff_vvc_frame_submit, avoid initializing task twice.

2024-05-06 Thread Nuo Mi
On Thu, Apr 25, 2024 at 10:02 PM Nuo Mi wrote: > For some error bitstreams, a CTU belongs to two slices/entry points. > If the decoder initializes and submmits the CTU task twice, it may crash > the program > or cause it to enter an infinite loop. > > Reported-by: Frank Pl

Re: [FFmpeg-devel] [PATCH 2/4] tests/checkasm: add checkasm_check_vvc_alf and check_alf_filter

2024-04-30 Thread Nuo Mi
> @@ -132,6 +132,7 @@ void checkasm_check_vp8dsp(void); > > void checkasm_check_vp9dsp(void); > > void checkasm_check_videodsp(void); > > void checkasm_check_vorbisdsp(void); > > +void checkasm_check_vvc_alf(void); > > void checkasm_check_vv

Re: [FFmpeg-devel] [PATCH 1/4] avcodec/x86/vvc: add alf filter luma and chroma avx2 optimizations

2024-04-30 Thread Nuo Mi
On Tue, Apr 30, 2024 at 12:34 AM Andreas Rheinhardt < andreas.rheinha...@outlook.com> wrote: > toq...@outlook.com: > > vvc_alf_filter_chroma_16x12_10_c: 7235.5 > > vvc_alf_filter_chroma_16x12_10_avx2: 9751.0 > > Are these numbers correct? If so, the avx2 version should not be committed. > It

Re: [FFmpeg-devel] [PATCH] avcodec/vvcdec: ff_vvc_frame_submit, avoid initializing task twice.

2024-04-25 Thread Nuo Mi
Thank you, Frank Fixed by v2 On Mon, Apr 22, 2024 at 12:34 AM Frank Plowman wrote: > On 21/04/2024 15:52, Nuo Mi wrote: > > For some error bitstreams, a CTU belongs to two slices/entry points. > > If the decoder initializes and submmits the CTU task twice, it may cras

[FFmpeg-devel] [PATCH v2 2/2] avcodec/vvcdec: ff_vvc_frame_submit, avoid initializing task twice.

2024-04-25 Thread Nuo Mi
For some error bitstreams, a CTU belongs to two slices/entry points. If the decoder initializes and submmits the CTU task twice, it may crash the program or cause it to enter an infinite loop. Reported-by: Frank Plowman --- libavcodec/vvc/dec.c| 10 -- libavcodec/vvc/thread.c | 43

[FFmpeg-devel] [PATCH v2 1/2] avcodec/vvcdec: we need error handling if fc->ft is NULL

2024-04-25 Thread Nuo Mi
Another inter frame may be waiting on this frame. We must finish it to avoid infinite waiting. --- libavcodec/vvc/dec.c | 10 +++--- 1 file changed, 7 insertions(+), 3 deletions(-) diff --git a/libavcodec/vvc/dec.c b/libavcodec/vvc/dec.c index 6aeec27eaf..92999a3ce3 100644 ---

[FFmpeg-devel] [PATCH] avcodec/vvcdec: ff_vvc_frame_submit, avoid initializing task twice.

2024-04-21 Thread Nuo Mi
For some error bitstreams, a CTU belongs to two slices/entry points. If the decoder initializes and submmits the CTU task twice, it may crash the program or cause it to enter an infinite loop. Reported-by: Frank Plowman --- libavcodec/vvc/dec.c| 7 +-- libavcodec/vvc/thread.c | 43

Re: [FFmpeg-devel] [PATCH 4/4] lavc/vvc/refs: Use dpb_max_num_reorder_pics to control output

2024-04-21 Thread Nuo Mi
Thank you for the clip. Applied all except the libxevd one On Sun, Apr 21, 2024 at 10:34 AM myp...@gmail.com wrote: > Send it privately via email > > > On Sat, Apr 20, 2024 at 11:55 AM Nuo Mi wrote: > > > > Hi Barry and Eliny, > > LGTM. > > Thank y

Re: [FFmpeg-devel] [PATCH 3/4] lavc/vvc_parser: Fixed the has_b_frames setting

2024-04-21 Thread Nuo Mi
On Sun, Apr 21, 2024 at 10:51 AM myp...@gmail.com wrote: > On Sat, Apr 20, 2024 at 11:50 AM Nuo Mi wrote: > > > > On Fri, Apr 19, 2024 at 9:55 PM Jun Zhao wrote: > > > > > From: Jun Zhao > > > > > > has_b_frames used in decoder for size of the f

Re: [FFmpeg-devel] [PATCH v2 1/3] avcodec/x86/vvc/vvcdsp_init: add put prototypes

2024-04-20 Thread Nuo Mi
On Thu, Apr 18, 2024 at 2:30 AM Wu Jianhua wrote: > > 发件人: Nuo Mi > > 发送时间: 2024年4月17日 6:14 > > 收件人: FFmpeg development discussions and patches > > 抄送: Wu Jianhua > > 主题: Re: [FFmpeg-devel] [PATCH v2 1/3] avcodec/x86/vvc/vvcdsp_init: add > put prototypes

Re: [FFmpeg-devel] [PATCH 1/4] lavc/vvc_parser: Remove max_b_frames setting

2024-04-19 Thread Nuo Mi
LGTM On Fri, Apr 19, 2024 at 9:47 PM Jun Zhao wrote: > From: Jun Zhao > > We don't used the max_b_frames field in decoder normally > > Signed-off-by: Jun Zhao > --- > libavcodec/vvc_parser.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/libavcodec/vvc_parser.c

Re: [FFmpeg-devel] [PATCH 3/4] lavc/vvc_parser: Fixed the has_b_frames setting

2024-04-19 Thread Nuo Mi
On Fri, Apr 19, 2024 at 9:55 PM Jun Zhao wrote: > From: Jun Zhao > > has_b_frames used in decoder for size of the frame reordering > buffer, setting this field from dpb_max_num_reorder_pics. > > Signed-off-by: Jun Zhao > --- > libavcodec/vvc_parser.c | 4 ++-- > 1 file changed, 2

Re: [FFmpeg-devel] [PATCH 4/4] lavc/vvc/refs: Use dpb_max_num_reorder_pics to control output

2024-04-19 Thread Nuo Mi
Hi Barry and Eliny, LGTM. Thank you for the patch. Is it possible to provide the clip so we can add it to our CI? ci like https://github.com/ffvvc/FFmpeg/actions On Fri, Apr 19, 2024 at 9:48 PM Jun Zhao wrote: > From: Jun Zhao > > Use dpb_max_num_reorder_pics to control output instead of >

Re: [FFmpeg-devel] [PATCH v2 1/3] avcodec/x86/vvc/vvcdsp_init: add put prototypes

2024-04-17 Thread Nuo Mi
Hi Jianhua, thank you for the patches. could you add a log for each commit to explain why we need this commit? On Tue, Apr 16, 2024 at 1:36 AM wrote: > From: Wu Jianhua > > Signed-off-by: Wu Jianhua > --- > libavcodec/x86/vvc/vvcdsp_init.c | 35 +++- > 1 file

Re: [FFmpeg-devel] [PATCH] lavc/vvc: Increase size of ctb_size_y

2024-04-15 Thread Nuo Mi
On Sat, Apr 13, 2024 at 9:55 PM James Almer wrote: > On 4/13/2024 7:55 AM, Frank Plowman wrote: > > sps_log2_ctu_size_minus5 is between 0 and 2, with 3 reserved for future > > use. The VVC decoder allows sps_log2_ctu_size_minus5 to be 3, and so > > ctb_size_y should be at least 16 bits to

Re: [FFmpeg-devel] [PATCH] avcodec/vvc/ps: reset sps_id_used on PS uninit

2024-04-15 Thread Nuo Mi
Mostly Harmless :) On Mon, Apr 15, 2024 at 6:24 AM James Almer wrote: > On 4/13/2024 7:18 AM, Frank Plowman wrote: > > > > > > On 09/04/2024 14:36, Nuo Mi wrote: > >> On Mon, Apr 8, 2024 at 11:15 PM Frank Plowman > wrote: > >> > >>> On 08/0

Re: [FFmpeg-devel] [PATCH] lavc/vvc_parser: Fix integer overflow calculating framerate

2024-04-09 Thread Nuo Mi
On Tue, Apr 9, 2024 at 3:04 AM James Almer wrote: > On 4/8/2024 3:20 PM, Frank Plowman wrote: > > num_units_in_tick and time_scale are both 32-bit unsigned integers. > > Storing them as ints was causing overflows. > > > > Signed-off-by: Frank Plowman > > --- > > libavcodec/vvc_parser.c | 4

Re: [FFmpeg-devel] [PATCH] avcodec/vvc/ps: reset sps_id_used on PS uninit

2024-04-09 Thread Nuo Mi
On Mon, Apr 8, 2024 at 11:15 PM Frank Plowman wrote: > On 08/04/2024 15:12, Nuo Mi wrote: > > On Mon, Apr 8, 2024 at 4:37 PM Frank Plowman > wrote: > > > >> On 07/04/2024 15:48, James Almer wrote: > >>> On 4/7/2024 10:38 AM, Nuo Mi wrote: > >&g

Re: [FFmpeg-devel] [PATCH] avcodec/vvc/ps: reset sps_id_used on PS uninit

2024-04-08 Thread Nuo Mi
On Mon, Apr 8, 2024 at 4:37 PM Frank Plowman wrote: > On 07/04/2024 15:48, James Almer wrote: > > On 4/7/2024 10:38 AM, Nuo Mi wrote: > >> On Sun, Apr 7, 2024 at 11:05 AM James Almer wrote: > >> > >>> Signed-off-by: James Almer > >>> --- >

Re: [FFmpeg-devel] [PATCH] avcodec/vvc/ps: reset sps_id_used on PS uninit

2024-04-07 Thread Nuo Mi
On Sun, Apr 7, 2024 at 11:05 AM James Almer wrote: > Signed-off-by: James Almer > --- > libavcodec/vvc/ps.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/libavcodec/vvc/ps.c b/libavcodec/vvc/ps.c > index 3c71c34bae..83ee75fb62 100644 > --- a/libavcodec/vvc/ps.c > +++

Re: [FFmpeg-devel] [PATCH v2] lavc/vvc: Error if SPS ID is duplicated within CVS

2024-04-07 Thread Nuo Mi
On Sun, Apr 7, 2024 at 8:16 PM Anton Khirnov wrote: > Quoting Nuo Mi (2024-04-07 14:13:58) > > On Sun, Apr 7, 2024 at 2:15 PM Anton Khirnov wrote: > > > > > Quoting Frank Plowman (2024-04-06 15:46:09) > > > > Key line from the spec is: > > > > &g

Re: [FFmpeg-devel] [PATCH v2] lavc/vvc: Error if SPS ID is duplicated within CVS

2024-04-07 Thread Nuo Mi
On Sun, Apr 7, 2024 at 2:15 PM Anton Khirnov wrote: > Quoting Frank Plowman (2024-04-06 15:46:09) > > Key line from the spec is: > > > > "All SPS NAL units with a particular value of sps_seq_parameter_set_id > > in a CVS shall have the same content." > > > > Prior to this patch, the VVC

Re: [FFmpeg-devel] [PATCH v2] lavc/vvc: Error if SPS ID is duplicated within CVS

2024-04-06 Thread Nuo Mi
On Sat, Apr 6, 2024 at 9:46 PM Frank Plowman wrote: > Key line from the spec is: > > "All SPS NAL units with a particular value of sps_seq_parameter_set_id > in a CVS shall have the same content." > > Prior to this patch, the VVC decoder's behaviour on encountering a > duplicated SPS ID (within

Re: [FFmpeg-devel] [PATCH] lavc/vvc: Error if SPS ID is duplicated within CVS

2024-04-06 Thread Nuo Mi
Hi Frank, Thank you for the patch. On Thu, Apr 4, 2024 at 3:01 AM Frank Plowman wrote: > Key line from the spec is: > > "All SPS NAL units with a particular value of sps_seq_parameter_set_id > in a CVS shall have the same content." > > Prior to this patch, the VVC decoder's behaviour on

Re: [FFmpeg-devel] [PATCH v1 7/7] lavc/vaapi_dec: Add VVC decoder

2024-04-05 Thread Nuo Mi
> > > > --- a/libavcodec/vaapi_decode.c > > > +++ b/libavcodec/vaapi_decode.c > > > @@ -455,6 +455,9 @@ static const struct { > > > MAP(AV1, AV1_MAIN,AV1Profile0), > > > MAP(AV1, AV1_HIGH,AV1Profile1), > > > #endif > > > +#if VA_CHECK_VERSION(1, 22, 0) >

Re: [FFmpeg-devel] [PATCH] avcodec/vvc/vvc_inter_template: Fix left shift of negative number

2024-04-03 Thread Nuo Mi
On Thu, Apr 4, 2024 at 10:00 AM Andreas Rheinhardt < andreas.rheinha...@outlook.com> wrote: > Affected the vvc-conformance-WP_A_3 FATE test. > > Applied. Thank you, Andreas. ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org

Re: [FFmpeg-devel] [PATCH v2 00/16] avcodec/vvcdec: support subpicture

2024-04-03 Thread Nuo Mi
On Thu, Apr 4, 2024 at 10:09 AM James Almer wrote: > On 4/3/2024 11:05 PM, Nuo Mi wrote: > > On Tue, Apr 2, 2024 at 11:24 PM James Almer wrote: > > > >> On 4/2/2024 10:01 AM, Nuo Mi wrote: > >>> On Wed, Mar 27, 2024 at 9:01 PM Nuo Mi wrote: > >>

Re: [FFmpeg-devel] [PATCH v2 2/2] avcodec/vvc: Rename vvc_?foo->foo

2024-04-03 Thread Nuo Mi
> > > > rename to libavcodec/vvc/dec.h > index aa3d715524..4dacefc06a 100644 > --- a/libavcodec/vvc/vvcdec.h > +++ b/libavcodec/vvc/dec.h > @@ -21,14 +21,14 @@ > * Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA > 02110-1301 USA > */ > > -#ifndef AVCODEC_VVC_VVCDEC_H > -#define

Re: [FFmpeg-devel] [PATCH v2 00/16] avcodec/vvcdec: support subpicture

2024-04-03 Thread Nuo Mi
On Tue, Apr 2, 2024 at 11:24 PM James Almer wrote: > On 4/2/2024 10:01 AM, Nuo Mi wrote: > > On Wed, Mar 27, 2024 at 9:01 PM Nuo Mi wrote: > > > >> Changes since v1: > >> add v2-0004-avcodec-vvcdec-fix-uninitialized-last-element-of-.patch to > >>

Re: [FFmpeg-devel] [PATCH] lavc/vvc: Only read split_cu_flag if a split is allowed

2024-04-03 Thread Nuo Mi
On Wed, Apr 3, 2024 at 5:59 PM Frank Plowman wrote: > On 02/04/2024 22:48, Frank Plowman wrote: > > Add a check to ensure some split is possible before reading the > > split_cu_flag. This is present in the spec, in VVCv3 section 7.3.11.4. > > Its omission could lead to infinite loops and

Re: [FFmpeg-devel] [PATCH v2 00/16] avcodec/vvcdec: support subpicture

2024-04-02 Thread Nuo Mi
On Wed, Mar 27, 2024 at 9:01 PM Nuo Mi wrote: > Changes since v1: > add v2-0004-avcodec-vvcdec-fix-uninitialized-last-element-of-.patch to > address > the clang-usan and clang-asan failures reported by Frank pushed. ___ ffmpeg-devel

Re: [FFmpeg-devel] [PATCH v1 7/7] lavc/vaapi_dec: Add VVC decoder

2024-04-02 Thread Nuo Mi
On Thu, Mar 28, 2024 at 9:27 AM wrote: > From: Fei Wang > > Signed-off-by: Fei Wang > --- > Changelog | 4 + > configure | 3 + > libavcodec/Makefile | 1 + > libavcodec/hwaccels.h | 1 + > libavcodec/vaapi_decode.c | 7 + >

Re: [FFmpeg-devel] [PATCH 1/3] avcodec/vvc/vvcdec: Do not submit frames without VVCFrameThread

2024-04-01 Thread Nuo Mi
On Tue, Apr 2, 2024 at 1:06 AM Michael Niedermayer wrote: > On Fri, Jan 26, 2024 at 10:46:49PM +0100, Michael Niedermayer wrote: > > Such frames will crash when pthread functions are called on the NULL > pointer > > > > Fixes: member access within null pointer of type 'VVCFrameThread' (aka >

[FFmpeg-devel] [PATCH v2 12/16] avcodec/vvcdec: sao, refact out tile_edge arrays

2024-03-27 Thread Nuo Mi
--- libavcodec/vvc/vvc_filter.c | 36 ++-- 1 file changed, 14 insertions(+), 22 deletions(-) diff --git a/libavcodec/vvc/vvc_filter.c b/libavcodec/vvc/vvc_filter.c index ecb004d245..1a3cd02a9f 100644 --- a/libavcodec/vvc/vvc_filter.c +++

[FFmpeg-devel] [PATCH v2 11/16] avcodec/vvcdec: refact, movie the lc->sc assignment to task_run_stage to simplify the code

2024-03-27 Thread Nuo Mi
This change also make the lc->sc assigned for run_sao --- libavcodec/vvc/vvc_thread.c | 66 ++--- 1 file changed, 17 insertions(+), 49 deletions(-) diff --git a/libavcodec/vvc/vvc_thread.c b/libavcodec/vvc/vvc_thread.c index 5d2e8c67b9..8f23b8138b 100644 ---

[FFmpeg-devel] [PATCH v2 16/16] avcodec/vvcdec: inter prediction, support subpicture

2024-03-27 Thread Nuo Mi
passed files: LMCS_B_Dolby_2.bit CodingToolsSets_E_Tencent_1.bit SUBPIC_A_HUAWEI_3.bit SUBPIC_B_HUAWEI_3.bit SUBPIC_C_ERICSSON_1.bit SUBPIC_D_ERICSSON_1.bit SUBPIC_E_MediaTek_1.bit passed dvb conformance files

[FFmpeg-devel] [PATCH v2 15/16] avcodec/vvcdec: mvs, support subpicture

2024-03-27 Thread Nuo Mi
--- libavcodec/vvc/vvc_mvs.c | 33 + 1 file changed, 21 insertions(+), 12 deletions(-) diff --git a/libavcodec/vvc/vvc_mvs.c b/libavcodec/vvc/vvc_mvs.c index cf92202b5b..37a2d0a228 100644 --- a/libavcodec/vvc/vvc_mvs.c +++ b/libavcodec/vvc/vvc_mvs.c @@ -200,10

[FFmpeg-devel] [PATCH v2 14/16] avcodec/vvcdec: alf, support subpicture

2024-03-27 Thread Nuo Mi
--- libavcodec/vvc/vvc_filter.c | 9 + 1 file changed, 9 insertions(+) diff --git a/libavcodec/vvc/vvc_filter.c b/libavcodec/vvc/vvc_filter.c index 6b4c2050c7..de0816619b 100644 --- a/libavcodec/vvc/vvc_filter.c +++ b/libavcodec/vvc/vvc_filter.c @@ -1199,6 +1199,7 @@ void

[FFmpeg-devel] [PATCH v2 13/16] avcodec/vvcdec: sao, support subpicture

2024-03-27 Thread Nuo Mi
--- libavcodec/vvc/vvc_filter.c | 40 + 1 file changed, 27 insertions(+), 13 deletions(-) diff --git a/libavcodec/vvc/vvc_filter.c b/libavcodec/vvc/vvc_filter.c index 1a3cd02a9f..6b4c2050c7 100644 --- a/libavcodec/vvc/vvc_filter.c +++

[FFmpeg-devel] [PATCH v2 10/16] avcodec/vvcdec: deblock, support subpicture

2024-03-27 Thread Nuo Mi
--- libavcodec/vvc/vvc_filter.c | 52 + libavcodec/vvc/vvc_filter.h | 6 +++-- libavcodec/vvc/vvc_thread.c | 4 +-- 3 files changed, 35 insertions(+), 27 deletions(-) diff --git a/libavcodec/vvc/vvc_filter.c b/libavcodec/vvc/vvc_filter.c index

[FFmpeg-devel] [PATCH v2 09/16] avcodec/vvcdec: refact out deblock_is_boundary

2024-03-27 Thread Nuo Mi
--- libavcodec/vvc/vvc_filter.c | 66 +++-- 1 file changed, 26 insertions(+), 40 deletions(-) diff --git a/libavcodec/vvc/vvc_filter.c b/libavcodec/vvc/vvc_filter.c index 10bd57e078..11972bde41 100644 --- a/libavcodec/vvc/vvc_filter.c +++

[FFmpeg-devel] [PATCH v2 08/16] avcodec/vvcdec: misc, rename x_ctb, y_ctb, ctu_x, ctu_y to rx, ry to avoid misleading

2024-03-27 Thread Nuo Mi
--- libavcodec/vvc/vvc_ctu.c| 8 ++-- libavcodec/vvc/vvc_filter.c | 96 ++--- libavcodec/vvc/vvc_ps.c | 38 +++ 3 files changed, 71 insertions(+), 71 deletions(-) diff --git a/libavcodec/vvc/vvc_ctu.c b/libavcodec/vvc/vvc_ctu.c index

[FFmpeg-devel] [PATCH v2 06/16] avcodec/vvcdec: derive subpic postion for PPS

2024-03-27 Thread Nuo Mi
--- libavcodec/vvc/vvc_ps.c | 19 +++ libavcodec/vvc/vvc_ps.h | 4 2 files changed, 23 insertions(+) diff --git a/libavcodec/vvc/vvc_ps.c b/libavcodec/vvc/vvc_ps.c index 6b5aa31ccd..556135fee2 100644 --- a/libavcodec/vvc/vvc_ps.c +++ b/libavcodec/vvc/vvc_ps.c @@ -514,6

[FFmpeg-devel] [PATCH v2 07/16] avcodec/vvcdec: ff_vvc_decode_neighbour, support subpicture

2024-03-27 Thread Nuo Mi
--- libavcodec/vvc/vvc_ctu.c | 4 libavcodec/vvc/vvc_ctu.h | 6 -- 2 files changed, 8 insertions(+), 2 deletions(-) diff --git a/libavcodec/vvc/vvc_ctu.c b/libavcodec/vvc/vvc_ctu.c index e48ffda938..05c3e04b83 100644 --- a/libavcodec/vvc/vvc_ctu.c +++ b/libavcodec/vvc/vvc_ctu.c @@

[FFmpeg-devel] [PATCH v2 03/16] avcodec/vvcdec: misc, add specification name for pps members

2024-03-27 Thread Nuo Mi
--- libavcodec/cbs_h266.h | 10 +- libavcodec/vvc/vvc_ps.h | 8 2 files changed, 9 insertions(+), 9 deletions(-) diff --git a/libavcodec/cbs_h266.h b/libavcodec/cbs_h266.h index 73d94157d4..21b9a4196c 100644 --- a/libavcodec/cbs_h266.h +++ b/libavcodec/cbs_h266.h @@ -588,11

[FFmpeg-devel] [PATCH v2 05/16] avcodec/vvcdec: support rectangular single-slice subpics

2024-03-27 Thread Nuo Mi
From: Frank Plowman Co-authored-by: Nuo Mi --- libavcodec/cbs_h266_syntax_template.c | 5 +- libavcodec/vvc/vvc_ps.c | 93 +-- 2 files changed, 91 insertions(+), 7 deletions(-) diff --git a/libavcodec/cbs_h266_syntax_template.c b/libavcodec

[FFmpeg-devel] [PATCH v2 04/16] avcodec/vvcdec: fix uninitialized last element of xxx_bd and ctb_to_xxx_bd arrays

2024-03-27 Thread Nuo Mi
From: Frank Plowman see "6.5.1 CTB raster scanning, tile scanning, and subpicture scanning processes" Co-authored-by: Nuo Mi --- libavcodec/vvc/vvc_ps.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/libavcodec/vvc/vvc_ps.c b/libavcodec/vvc/vvc_ps.c index 7972803da6..

[FFmpeg-devel] [PATCH v2 01/16] avcodec/vvcdec: NoBackwardPredFlag, only check active pictures

2024-03-27 Thread Nuo Mi
see "8.3.6 Decoding process for collocated picture and no backward prediction" --- libavcodec/vvc/vvc_mvs.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavcodec/vvc/vvc_mvs.c b/libavcodec/vvc/vvc_mvs.c index 6398fd3571..cf92202b5b 100644 --- a/libavcodec/vvc/vvc_mvs.c

[FFmpeg-devel] [PATCH v2 02/16] avcodec/cbs_h266: fix sh_collocated_from_l0_flag and sh_collocated_ref_idx infer

2024-03-27 Thread Nuo Mi
we have to infer sh_collocated_from_l0_flag and sh_collocated_ref_idx from picture head if pps_rpl_info_in_ph_flag is true --- libavcodec/cbs_h266_syntax_template.c | 32 +-- 1 file changed, 20 insertions(+), 12 deletions(-) diff --git

[FFmpeg-devel] [PATCH v2 00/16] avcodec/vvcdec: support subpicture

2024-03-27 Thread Nuo Mi
rectangular single-slice subpics Nuo Mi (14): avcodec/vvcdec: NoBackwardPredFlag, only check active pictures avcodec/cbs_h266: fix sh_collocated_from_l0_flag and sh_collocated_ref_idx infer avcodec/vvcdec: misc, add specification name for pps members avcodec/vvcdec: derive subpic postion for PPS

Re: [FFmpeg-devel] [PATCH 3/4] avcodec/cbs_h266_syntax_template: Check tile_y

2024-03-23 Thread Nuo Mi
On Thu, Mar 21, 2024 at 9:15 AM Michael Niedermayer wrote: > Fixes: out of array access > Fixes: > 67021/clusterfuzz-testcase-minimized-ffmpeg_DEMUXER_fuzzer-4883576579489792 > > Found-by: continuous fuzzing process > https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg > Signed-off-by

Re: [FFmpeg-devel] [PATCH 1/2] lavc/vvc_parser: small cleanup for style

2024-03-23 Thread Nuo Mi
On Fri, Mar 22, 2024 at 6:36 PM Jun Zhao wrote: > From: Jun Zhao > > small cleanup for style, redundant semicolons, goto labels, > in FFmpeg, we put goto labels at brace level. > Pushed this patch. Thanks, Jun > Signed-off-by: Jun Zhao > --- > libavcodec/vvc_parser.c | 8 > 1 file

Re: [FFmpeg-devel] [PATCH] lavc/vvc: Fix check whether QG is in first tile col

2024-03-20 Thread Nuo Mi
On Wed, Mar 20, 2024 at 3:48 AM Frank Plowman wrote: > The second part of this condition is intended to check whether the > current quantisation group is in the first CTU column of the current > tile. The issue is that ctb_to_col_bd gives the x-ordinate of the first > column of the current tile

Re: [FFmpeg-devel] [PATCH 00/14] avcodec/vvcdec: support subpicture

2024-03-19 Thread Nuo Mi
On Tue, Mar 19, 2024 at 6:18 PM Frank Plowman wrote: > On 18/03/2024 14:16, Nuo Mi wrote: > > see introductions here: > https://dashif.org/docs/VVC%20HLS%20overview%20.pdf > > > > Frank Plowman (1): > > avcodec/vvcdec: support rectangular single-slice subpics >

[FFmpeg-devel] [PATCH 13/14] avcodec/vvcdec: mvs, support subpicture

2024-03-18 Thread Nuo Mi
--- libavcodec/vvc/vvc_mvs.c | 33 + 1 file changed, 21 insertions(+), 12 deletions(-) diff --git a/libavcodec/vvc/vvc_mvs.c b/libavcodec/vvc/vvc_mvs.c index cf92202b5b..37a2d0a228 100644 --- a/libavcodec/vvc/vvc_mvs.c +++ b/libavcodec/vvc/vvc_mvs.c @@ -200,10

[FFmpeg-devel] [PATCH 11/14] avcodec/vvcdec: sao, support subpicture

2024-03-18 Thread Nuo Mi
--- libavcodec/vvc/vvc_filter.c | 40 + 1 file changed, 27 insertions(+), 13 deletions(-) diff --git a/libavcodec/vvc/vvc_filter.c b/libavcodec/vvc/vvc_filter.c index 1a3cd02a9f..6b4c2050c7 100644 --- a/libavcodec/vvc/vvc_filter.c +++

[FFmpeg-devel] [PATCH 12/14] avcodec/vvcdec: alf, support subpicture

2024-03-18 Thread Nuo Mi
--- libavcodec/vvc/vvc_filter.c | 9 + 1 file changed, 9 insertions(+) diff --git a/libavcodec/vvc/vvc_filter.c b/libavcodec/vvc/vvc_filter.c index 6b4c2050c7..de0816619b 100644 --- a/libavcodec/vvc/vvc_filter.c +++ b/libavcodec/vvc/vvc_filter.c @@ -1199,6 +1199,7 @@ void

[FFmpeg-devel] [PATCH 10/14] avcodec/vvcdec: sao, refact out tile_edge arrays

2024-03-18 Thread Nuo Mi
--- libavcodec/vvc/vvc_filter.c | 36 ++-- 1 file changed, 14 insertions(+), 22 deletions(-) diff --git a/libavcodec/vvc/vvc_filter.c b/libavcodec/vvc/vvc_filter.c index ecb004d245..1a3cd02a9f 100644 --- a/libavcodec/vvc/vvc_filter.c +++

[FFmpeg-devel] [PATCH 09/14] avcodec/vvcdec: refact, movie the lc->sc assignment to task_run_stage to simplify the code

2024-03-18 Thread Nuo Mi
This change also make the lc->sc assigned for run_sao --- libavcodec/vvc/vvc_thread.c | 66 ++--- 1 file changed, 17 insertions(+), 49 deletions(-) diff --git a/libavcodec/vvc/vvc_thread.c b/libavcodec/vvc/vvc_thread.c index 5d2e8c67b9..8f23b8138b 100644 ---

[FFmpeg-devel] [PATCH 06/14] avcodec/vvcdec: misc, rename x_ctb, y_ctb, ctu_x, ctu_y to rx, ry to avoid misleading

2024-03-18 Thread Nuo Mi
--- libavcodec/vvc/vvc_ctu.c| 8 ++-- libavcodec/vvc/vvc_filter.c | 96 ++--- libavcodec/vvc/vvc_ps.c | 38 +++ 3 files changed, 71 insertions(+), 71 deletions(-) diff --git a/libavcodec/vvc/vvc_ctu.c b/libavcodec/vvc/vvc_ctu.c index

[FFmpeg-devel] [PATCH 08/14] avcodec/vvcdec: deblock, support subpicture

2024-03-18 Thread Nuo Mi
--- libavcodec/vvc/vvc_filter.c | 52 + libavcodec/vvc/vvc_filter.h | 6 +++-- libavcodec/vvc/vvc_thread.c | 4 +-- 3 files changed, 35 insertions(+), 27 deletions(-) diff --git a/libavcodec/vvc/vvc_filter.c b/libavcodec/vvc/vvc_filter.c index

  1   2   3   4   5   6   7   >