Re: [FFmpeg-devel] [PATCH] avcodec/hevc_cabac: cabac_init_state, do not use magic number which not listed on the spec

2021-03-21 Thread Nuo Mi
On Sun, Mar 21, 2021 at 4:33 PM Carl Eugen Hoyos wrote: > Am So., 21. März 2021 um 06:13 Uhr schrieb Nuo Mi : > > > > Magic number 124 and ^= are not listed on the spec. > > Strictly following the spec will make a reader's life much easier. See > (9-6) for details > > But FFmpeg is not providing

Re: [FFmpeg-devel] [PATCH] avcodec/hevc_cabac: cabac_init_state, do not use magic number which not listed on the spec

2021-03-21 Thread Carl Eugen Hoyos
Am So., 21. März 2021 um 06:13 Uhr schrieb Nuo Mi : > > Magic number 124 and ^= are not listed on the spec. > Strictly following the spec will make a reader's life much easier. See (9-6) > for details But FFmpeg is not providing a reference application for the reader, this is software actually

[FFmpeg-devel] [PATCH] avcodec/hevc_cabac: cabac_init_state, do not use magic number which not listed on the spec

2021-03-20 Thread Nuo Mi
Magic number 124 and ^= are not listed on the spec. Strictly following the spec will make a reader's life much easier. See (9-6) for details --- libavcodec/hevc_cabac.c | 10 -- 1 file changed, 4 insertions(+), 6 deletions(-) diff --git a/libavcodec/hevc_cabac.c

Re: [FFmpeg-devel] [PATCH] avcodec/hevc_cabac: cabac_init_state, do not use magic number which not listed on the spec

2021-03-20 Thread Nuo Mi
passed h264,hevc decoder fate test. On Sun, Mar 21, 2021 at 1:06 PM Nuo Mi wrote: > Magic number 124 and ^= are not listed on the spec. > Strictly following the spec will make a reader's life much easier. See > (9-6) for details > --- > libavcodec/hevc_cabac.c | 10 -- > 1 file