Re: [FFmpeg-devel] [PATCH] configure: Change _cflags_noopt for MSVC to -Od

2022-12-14 Thread Thomson Tan
With this configuration (WSL2+MSVC) for this diff, I ran `make fate-rsync SAMPLES=fate-suite && make fate SAMPLES=fate-suite/` which passed locally. I also checked the binaries (ffmpeg.exe) and made sure the previous inlined functions are not inlined here. On Mon, Dec 12, 2022 at 1:13 PM Carl

Re: [FFmpeg-devel] [PATCH] configure: Change _cflags_noopt for MSVC to -Od

2022-12-12 Thread Carl Eugen Hoyos
Am Mo., 12. Dez. 2022 um 22:02 Uhr schrieb Thomson Tan : > > I built the latest FFmpeg with WSL2+MSVC on Windows. Tried configure > with --disable-optimizations, but still got an optimized build which makes > it hard to set breakpoint on hot functions (likely inlined). Of course, this explains

Re: [FFmpeg-devel] [PATCH] configure: Change _cflags_noopt for MSVC to -Od

2022-12-12 Thread Thomson Tan
I built the latest FFmpeg with WSL2+MSVC on Windows. Tried configure with --disable-optimizations, but still got an optimized build which makes it hard to set breakpoint on hot functions (likely inlined). On Mon, Dec 12, 2022 at 12:49 PM Carl Eugen Hoyos wrote: > Am Mo., 12. Dez. 2022 um 19:30

Re: [FFmpeg-devel] [PATCH] configure: Change _cflags_noopt for MSVC to -Od

2022-12-12 Thread Carl Eugen Hoyos
Am Mo., 12. Dez. 2022 um 19:30 Uhr schrieb : > > Currently -O1 is set to _cflags_noopt, but -O1 is actually for size > optimization instead of no-opt which causes size optimized binaries > been built with --disable-optimizations. > > Signed-off-by: Thomson Tan > --- > configure | 2 +- > 1 file

Re: [FFmpeg-devel] [PATCH] configure: Change _cflags_noopt for MSVC to -Od

2022-12-12 Thread Timo Rothenpieler
On 12.12.2022 21:32, Thomson Tan wrote: Thanks. Wondering why and where DCE is needed in FFmpeg build? Every single time "HAVE_SOMETHING" or "CONFIG_SOMETHING" is used in a normal if() instead of a pre-processor #if. That's used in a lot of places all over the codebase.

Re: [FFmpeg-devel] [PATCH] configure: Change _cflags_noopt for MSVC to -Od

2022-12-12 Thread Thomson Tan
Thanks. Wondering why and where DCE is needed in FFmpeg build? On Mon, Dec 12, 2022 at 12:26 PM Timo Rothenpieler wrote: > On 12.12.2022 19:30, lilo...@gmail.com wrote: > > Currently -O1 is set to _cflags_noopt, but -O1 is actually for size > > optimization instead of no-opt which causes size

Re: [FFmpeg-devel] [PATCH] configure: Change _cflags_noopt for MSVC to -Od

2022-12-12 Thread Timo Rothenpieler
On 12.12.2022 19:30, lilo...@gmail.com wrote: Currently -O1 is set to _cflags_noopt, but -O1 is actually for size optimization instead of no-opt which causes size optimized binaries been built with --disable-optimizations. It's like this very intentionally, since ffmpeg relies on

[FFmpeg-devel] [PATCH] configure: Change _cflags_noopt for MSVC to -Od

2022-12-12 Thread lilotom
Currently -O1 is set to _cflags_noopt, but -O1 is actually for size optimization instead of no-opt which causes size optimized binaries been built with --disable-optimizations. Signed-off-by: Thomson Tan --- configure | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/configure