Re: [FFmpeg-devel] [PATCH] mov: Prioritize aspect ratio values found in pasp atom

2021-04-13 Thread Vittorio Giovara
On Wed, Apr 7, 2021 at 10:00 PM Derek Buitenhuis wrote: > On 07/04/2021 19:56, Vittorio Giovara wrote: > > My OS doesn't even let me install Quicktime 7, if anybody could chime in > > and help solve this point it would be much appreciated. > > Alternatively, I'd say we shouldn't cargo cult

Re: [FFmpeg-devel] [PATCH] mov: Prioritize aspect ratio values found in pasp atom

2021-04-07 Thread Derek Buitenhuis
On 07/04/2021 19:56, Vittorio Giovara wrote: > My OS doesn't even let me install Quicktime 7, if anybody could chime in > and help solve this point it would be much appreciated. > Alternatively, I'd say we shouldn't cargo cult broken files generated by 11 > year old software, but if people

Re: [FFmpeg-devel] [PATCH] mov: Prioritize aspect ratio values found in pasp atom

2021-04-07 Thread Vittorio Giovara
On Wed, Apr 7, 2021 at 12:48 AM Carl Eugen Hoyos wrote: > Am Di., 6. Apr. 2021 um 21:51 Uhr schrieb Vittorio Giovara > : > > > > without my patch the sample is shown at a 16:9 > > AR (which I assume was the original fix), with my patch the sample uses > an > > AR of 1:1 and it is therefore

Re: [FFmpeg-devel] [PATCH] mov: Prioritize aspect ratio values found in pasp atom

2021-04-06 Thread Carl Eugen Hoyos
Am Di., 6. Apr. 2021 um 21:51 Uhr schrieb Vittorio Giovara : > > without my patch the sample is shown at a 16:9 > AR (which I assume was the original fix), with my patch the sample uses an > AR of 1:1 and it is therefore square. > However I tried with a recent > Quicktime, and it displays the

Re: [FFmpeg-devel] [PATCH] mov: Prioritize aspect ratio values found in pasp atom

2021-04-06 Thread Vittorio Giovara
On Tue, Apr 6, 2021 at 6:51 PM Vittorio Giovara wrote: > Here is the proposed patch to address samples like trac/7277. > > This effectively reverts an 11 year old patch > (9044dd83991491309ecb76c389502e410897d7d2) but I wasn't able to identify > the file mentioned in the log. > > If anyone knows

[FFmpeg-devel] [PATCH] mov: Prioritize aspect ratio values found in pasp atom

2021-04-06 Thread Vittorio Giovara
Here is the proposed patch to address samples like trac/7277. This effectively reverts an 11 year old patch (9044dd83991491309ecb76c389502e410897d7d2) but I wasn't able to identify the file mentioned in the log. If anyone knows where to look up the sample in issue 1539 that is not on trac I can