Re: [FFmpeg-devel] [PATCH 1/4] all: Replace if (ARCH_FOO) checks by #if ARCH_FOO, part 2

2022-11-03 Thread Carl Eugen Hoyos
Am Di., 1. Nov. 2022 um 23:00 Uhr schrieb L. E. Segovia : > > Continuation of 40e6575aa3eed64cd32bf28c00ae57edc5acb25a > > Co-authored-by: Nirbheek Chauhan > > Signed-off-by: L. E. Segovia > --- > libavcodec/x86/dcadsp_init.c | 2 + > libavcodec/x86/fdctdsp_init.c| 2 + >

Re: [FFmpeg-devel] [PATCH 1/4] all: Replace if (ARCH_FOO) checks by #if ARCH_FOO, part 2

2022-11-03 Thread Andreas Rheinhardt
L. E. Segovia: > Hi! > > Thanks for the review. The comments will be fixed in the next version of > the patchset. Just a couple remarks: > > re dcadsp_init -- this one comes from 4.4.x having a clause there to > support SSE, which also checks for the x86-32 architecture [1]. I've > removed it

Re: [FFmpeg-devel] [PATCH 1/4] all: Replace if (ARCH_FOO) checks by #if ARCH_FOO, part 2

2022-11-03 Thread L. E. Segovia
Hi! Thanks for the review. The comments will be fixed in the next version of the patchset. Just a couple remarks: re dcadsp_init -- this one comes from 4.4.x having a clause there to support SSE, which also checks for the x86-32 architecture [1]. I've removed it for the current version. re

Re: [FFmpeg-devel] [PATCH 1/4] all: Replace if (ARCH_FOO) checks by #if ARCH_FOO, part 2

2022-11-01 Thread Andreas Rheinhardt
L. E. Segovia: > Continuation of 40e6575aa3eed64cd32bf28c00ae57edc5acb25a > > Co-authored-by: Nirbheek Chauhan > > Signed-off-by: L. E. Segovia > --- > libavcodec/x86/dcadsp_init.c | 2 + > libavcodec/x86/fdctdsp_init.c| 2 + > libavcodec/x86/flacdsp_init.c| 8 +-

[FFmpeg-devel] [PATCH 1/4] all: Replace if (ARCH_FOO) checks by #if ARCH_FOO, part 2

2022-11-01 Thread L. E. Segovia
Continuation of 40e6575aa3eed64cd32bf28c00ae57edc5acb25a Co-authored-by: Nirbheek Chauhan Signed-off-by: L. E. Segovia --- libavcodec/x86/dcadsp_init.c | 2 + libavcodec/x86/fdctdsp_init.c| 2 + libavcodec/x86/flacdsp_init.c| 8 +- libavcodec/x86/hevcdsp_init.c