Re: [FFmpeg-devel] [PATCH v2] libavformat/asfdec: Fix regression bug when reading image attachments

2021-08-08 Thread Carl Eugen Hoyos
Am So., 8. Aug. 2021 um 03:40 Uhr schrieb Soft Works : > When I do this: > > if (value_len < 0 || value_len >= (INT_MAX - LEN) / 2) > return AVERROR_INVALIDDATA; > > Shouldn't we return a different error code? Actually this is not about invalid > data but about a limitation in

Re: [FFmpeg-devel] [PATCH v2] libavformat/asfdec: Fix regression bug when reading image attachments

2021-08-07 Thread Soft Works
> -Original Message- > From: ffmpeg-devel On Behalf Of > James Almer > Sent: Sunday, 8 August 2021 03:19 > To: ffmpeg-devel@ffmpeg.org > Subject: Re: [FFmpeg-devel] [PATCH v2] libavformat/asfdec: Fix regression > bug when reading image attachments > > On 8/

Re: [FFmpeg-devel] [PATCH v2] libavformat/asfdec: Fix regression bug when reading image attachments

2021-08-07 Thread Soft Works
> -Original Message- > From: ffmpeg-devel On Behalf Of > James Almer > Sent: Sunday, 8 August 2021 03:19 > To: ffmpeg-devel@ffmpeg.org > Subject: Re: [FFmpeg-devel] [PATCH v2] libavformat/asfdec: Fix regression > bug when reading image attachments > > On 8/

Re: [FFmpeg-devel] [PATCH v2] libavformat/asfdec: Fix regression bug when reading image attachments

2021-08-07 Thread James Almer
On 8/7/2021 10:00 PM, Soft Works wrote: -Original Message- From: ffmpeg-devel On Behalf Of James Almer Sent: Sunday, 8 August 2021 02:47 To: ffmpeg-devel@ffmpeg.org Subject: Re: [FFmpeg-devel] [PATCH v2] libavformat/asfdec: Fix regression bug when reading image attachments On 8/7/2021

Re: [FFmpeg-devel] [PATCH v2] libavformat/asfdec: Fix regression bug when reading image attachments

2021-08-07 Thread Soft Works
t; From: ffmpeg-devel On Behalf > Of > > > >> Carl Eugen Hoyos > > > >> Sent: Sunday, 8 August 2021 01:58 > > > >> To: FFmpeg development discussions and patches > > >> de...@ffmpeg.org> > > > >>

Re: [FFmpeg-devel] [PATCH v2] libavformat/asfdec: Fix regression bug when reading image attachments

2021-08-07 Thread Carl Eugen Hoyos
Sunday, 8 August 2021 01:58 > > >> To: FFmpeg development discussions and patches > >> de...@ffmpeg.org> > > >> Subject: Re: [FFmpeg-devel] [PATCH v2] libavformat/asfdec: Fix > > >> regression bug when reading image attachments > > >> > > &

Re: [FFmpeg-devel] [PATCH v2] libavformat/asfdec: Fix regression bug when reading image attachments

2021-08-07 Thread Soft Works
> -Original Message- > From: ffmpeg-devel On Behalf Of > James Almer > Sent: Sunday, 8 August 2021 02:47 > To: ffmpeg-devel@ffmpeg.org > Subject: Re: [FFmpeg-devel] [PATCH v2] libavformat/asfdec: Fix regression > bug when reading image attachments > > On 8

Re: [FFmpeg-devel] [PATCH v2] libavformat/asfdec: Fix regression bug when reading image attachments

2021-08-07 Thread James Almer
On 8/7/2021 9:38 PM, Soft Works wrote: -Original Message- From: ffmpeg-devel On Behalf Of Carl Eugen Hoyos Sent: Sunday, 8 August 2021 01:58 To: FFmpeg development discussions and patches Subject: Re: [FFmpeg-devel] [PATCH v2] libavformat/asfdec: Fix regression bug when reading image

Re: [FFmpeg-devel] [PATCH v2] libavformat/asfdec: Fix regression bug when reading image attachments

2021-08-07 Thread Soft Works
> -Original Message- > From: ffmpeg-devel On Behalf Of > Carl Eugen Hoyos > Sent: Sunday, 8 August 2021 01:58 > To: FFmpeg development discussions and patches de...@ffmpeg.org> > Subject: Re: [FFmpeg-devel] [PATCH v2] libavformat/asfdec: Fix regression >

Re: [FFmpeg-devel] [PATCH v2] libavformat/asfdec: Fix regression bug when reading image attachments

2021-08-07 Thread Carl Eugen Hoyos
Am So., 8. Aug. 2021 um 01:53 Uhr schrieb Soft Works : > > Commit c8140fe7324f264faacf7395b27e12531d1f13f7 had introduced a check for > value_len > UINT16_MAX. > As a consequence, attached images of sizes larger than UINT16_MAX could no > longer be read. > > Signed-off-by: softworkz > --- > v2:

Re: [FFmpeg-devel] [PATCH v2] libavformat/asfdec: Fix regression bug when reading image attachments

2021-08-07 Thread Soft Works
> -Original Message- > From: ffmpeg-devel On Behalf Of > Soft Works > Sent: Sunday, 8 August 2021 01:53 > To: ffmpeg-devel@ffmpeg.org > Subject: [FFmpeg-devel] [PATCH v2] libavformat/asfdec: Fix regression bug > when reading image at

[FFmpeg-devel] [PATCH v2] libavformat/asfdec: Fix regression bug when reading image attachments

2021-08-07 Thread Soft Works
Commit c8140fe7324f264faacf7395b27e12531d1f13f7 had introduced a check for value_len > UINT16_MAX. As a consequence, attached images of sizes larger than UINT16_MAX could no longer be read. Signed-off-by: softworkz --- v2: Fix without changing variable type libavformat/asfdec_f.c | 2 +- 1