Re: [FFmpeg-devel] [PATCH v2 1/3] avformat/argo_asf: cleanup and NULL-terminate name field in header

2021-10-14 Thread Zane van Iperen
On 14/10/21 10:45 pm, "zhilizhao(赵志立)" wrote: } ArgoASFFileHeader; I failed to see why null-terminator is needed from the commit message or from the source code. See https://ffmpeg.org/pipermail/ffmpeg-devel/2021-October/286939.html Sorry for the noise, email client doesn’t show the

Re: [FFmpeg-devel] [PATCH v2 1/3] avformat/argo_asf: cleanup and NULL-terminate name field in header

2021-10-14 Thread zhilizhao(赵志立)
> On Oct 14, 2021, at 8:25 PM, Zane van Iperen wrote: > > > > On 14/10/21 10:11 pm, "zhilizhao(赵志立)" wrote: > >>> typedef struct ArgoASFFileHeader { >>> uint32_tmagic; /*< Magic Number, {'A', 'S', 'F', '\0'} */ >>> @@ -40,7 +41,7 @@ typedef struct ArgoASFFileHeader { >>>

Re: [FFmpeg-devel] [PATCH v2 1/3] avformat/argo_asf: cleanup and NULL-terminate name field in header

2021-10-14 Thread Zane van Iperen
On 14/10/21 10:11 pm, "zhilizhao(赵志立)" wrote: typedef struct ArgoASFFileHeader { uint32_tmagic; /*< Magic Number, {'A', 'S', 'F', '\0'} */ @@ -40,7 +41,7 @@ typedef struct ArgoASFFileHeader { uint16_tversion_minor; /*< File Minor Version. */ uint32_t

Re: [FFmpeg-devel] [PATCH v2 1/3] avformat/argo_asf: cleanup and NULL-terminate name field in header

2021-10-14 Thread zhilizhao(赵志立)
> On Oct 12, 2021, at 7:02 PM, Zane van Iperen wrote: > > Signed-off-by: Zane van Iperen > --- > libavformat/argo_asf.c | 8 > libavformat/argo_asf.h | 3 ++- > 2 files changed, 6 insertions(+), 5 deletions(-) > > diff --git a/libavformat/argo_asf.c b/libavformat/argo_asf.c > index

Re: [FFmpeg-devel] [PATCH v2 1/3] avformat/argo_asf: cleanup and NULL-terminate name field in header

2021-10-14 Thread Zane van Iperen
Will apply tomorrow if no objections. Zane On 12/10/21 9:02 pm, Zane van Iperen wrote: Signed-off-by: Zane van Iperen --- libavformat/argo_asf.c | 8 libavformat/argo_asf.h | 3 ++- 2 files changed, 6 insertions(+), 5 deletions(-) diff --git a/libavformat/argo_asf.c

[FFmpeg-devel] [PATCH v2 1/3] avformat/argo_asf: cleanup and NULL-terminate name field in header

2021-10-12 Thread Zane van Iperen
Signed-off-by: Zane van Iperen --- libavformat/argo_asf.c | 8 libavformat/argo_asf.h | 3 ++- 2 files changed, 6 insertions(+), 5 deletions(-) diff --git a/libavformat/argo_asf.c b/libavformat/argo_asf.c index 7e759c7c0c..acf30839b9 100644 --- a/libavformat/argo_asf.c +++