Re: [FFmpeg-devel] [PATCH v2 3/3] lavc/dxv: remove ctx fields that can be derived from texdsp ctxs

2024-02-11 Thread Connor Worley
On Sun, Feb 11, 2024 at 9:41 AM James Almer wrote: > This set broke fate when using slice threading: > > https://fate.ffmpeg.org/report.cgi?slot=x86_64-archlinux-gcc-threads-misc=20240211015448 > https://ffmpeg.org//pipermail/ffmpeg-devel/2024-February/321317.html contains a fix. -- Connor

Re: [FFmpeg-devel] [PATCH v2 3/3] lavc/dxv: remove ctx fields that can be derived from texdsp ctxs

2024-02-11 Thread Connor Worley
On Sun, Feb 11, 2024 at 9:41 AM James Almer wrote: > On 2/11/2024 9:41 AM, Connor Worley wrote: > > "or less than" is wrong -- rather tex_step seems to have been larger than > > necessary in some cases. With the minimal tex_step in those cases, the > new > > tex_size should be equal to the LHS.

Re: [FFmpeg-devel] [PATCH v2 3/3] lavc/dxv: remove ctx fields that can be derived from texdsp ctxs

2024-02-11 Thread James Almer
On 2/11/2024 9:41 AM, Connor Worley wrote: "or less than" is wrong -- rather tex_step seems to have been larger than necessary in some cases. With the minimal tex_step in those cases, the new tex_size should be equal to the LHS. This set broke fate when using slice threading:

Re: [FFmpeg-devel] [PATCH v2 3/3] lavc/dxv: remove ctx fields that can be derived from texdsp ctxs

2024-02-11 Thread Connor Worley
"or less than" is wrong -- rather tex_step seems to have been larger than necessary in some cases. With the minimal tex_step in those cases, the new tex_size should be equal to the LHS. ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org

Re: [FFmpeg-devel] [PATCH v2 3/3] lavc/dxv: remove ctx fields that can be derived from texdsp ctxs

2024-02-11 Thread Connor Worley
On Sun, Feb 11, 2024 at 1:03 AM Andreas Rheinhardt < andreas.rheinha...@outlook.com> wrote: > Connor Worley: > > -{ > > -int w_block = avctx->coded_width / ctx->texture_block_w; > > -int h_block = avctx->coded_height / ctx->texture_block_h; > > -if (w_block * h_block *

Re: [FFmpeg-devel] [PATCH v2 3/3] lavc/dxv: remove ctx fields that can be derived from texdsp ctxs

2024-02-11 Thread Andreas Rheinhardt
Connor Worley: > Signed-off-by: Connor Worley > --- > libavcodec/dxv.c | 53 > 1 file changed, 9 insertions(+), 44 deletions(-) > > diff --git a/libavcodec/dxv.c b/libavcodec/dxv.c > index cd78de3e0d..82c493f1de 100644 > --- a/libavcodec/dxv.c >

Re: [FFmpeg-devel] [PATCH v2 3/3] lavc/dxv: remove ctx fields that can be derived from texdsp ctxs

2024-02-10 Thread Lynne
Feb 10, 2024, 23:59 by connorbwor...@gmail.com: > Signed-off-by: Connor Worley > --- > libavcodec/dxv.c | 53 > 1 file changed, 9 insertions(+), 44 deletions(-) > > diff --git a/libavcodec/dxv.c b/libavcodec/dxv.c > index cd78de3e0d..82c493f1de

[FFmpeg-devel] [PATCH v2 3/3] lavc/dxv: remove ctx fields that can be derived from texdsp ctxs

2024-02-10 Thread Connor Worley
Signed-off-by: Connor Worley --- libavcodec/dxv.c | 53 1 file changed, 9 insertions(+), 44 deletions(-) diff --git a/libavcodec/dxv.c b/libavcodec/dxv.c index cd78de3e0d..82c493f1de 100644 --- a/libavcodec/dxv.c +++ b/libavcodec/dxv.c @@ -39,20