Re: [FFmpeg-devel] [PATCH] [v4] avcodec/vaapi_encode: add customized surface alignment

2024-04-03 Thread Araz
> On Mon, Apr 1, 2024 at 9:33 PM Mark Thompson wrote: > It is not necessary to copy exactly the same field layout. > Are you sure that there is never a meaningful non-power-of-two-bytes case? > Given that this is defining new public API to libavutil we don't want to be artificially constrained to

Re: [FFmpeg-devel] [PATCH] [v4] avcodec/vaapi_encode: add customized surface alignment

2024-04-01 Thread Mark Thompson
On 27/03/2024 11:14, Araz wrote: On Fri, Mar 22, 2024 at 11:35 AM Anton Khirnov wrote: Why this unnecessary complication? Just use two ints, or two uint8_t's if you really need to save space, though that also seems unncessary as this struct is allocated rarely and usually does not live long.

Re: [FFmpeg-devel] [PATCH] [v4] avcodec/vaapi_encode: add customized surface alignment

2024-03-27 Thread Araz
>>On Fri, Mar 22, 2024 at 11:35 AM Anton Khirnov wrote: >>Why this unnecessary complication? Just use two ints, or two uint8_t's >>if you really need to save space, though that also seems unncessary as >>this struct is allocated rarely and usually does not live long.

Re: [FFmpeg-devel] [PATCH] [v4] avcodec/vaapi_encode: add customized surface alignment

2024-03-24 Thread Mark Thompson
On 21/03/2024 17:02, Araz Iusubov wrote: This commit fixes issues with AMD HEVC encoding. By default AMD hevc encoder asks for the alignment 64x16, while FFMPEG VAAPI has 16x16. Adding support for customized surface size from VASurfaceAttribAlignmentSize in VAAPI version 1.21.0 Signed-off-by:

Re: [FFmpeg-devel] [PATCH] [v4] avcodec/vaapi_encode: add customized surface alignment

2024-03-22 Thread Anton Khirnov
Quoting Araz Iusubov (2024-03-21 18:02:19) > diff --git a/libavutil/hwcontext.h b/libavutil/hwcontext.h > index bac30debae..1eb56aff78 100644 > --- a/libavutil/hwcontext.h > +++ b/libavutil/hwcontext.h > @@ -465,6 +465,13 @@ typedef struct AVHWFramesConstraints { > */ > int max_width; >