Re: [FFmpeg-devel] [PATCH] avcodec/jpeg2000dec: Fix mixed declaration and code

Anton Khirnov (12020-04-11): > It is done the way we, as a whole community, decide it is done. In > practice, many people send ALL of their patches to the ML. I am with Anton on this one. Rules are not set in stone, “and even stone changes, anyway”. And I think too it would be much better if all

[FFmpeg-devel] [PATCH v3 6/9] lavc/libopenh264enc: separate svc_encode_init() into several functions

Separate the initialization procedure into different functions. Make it more readable and easier to be extended. Signed-off-by: Linjie Fu --- libavcodec/libopenh264enc.c | 283 +++- 1 file changed, 174 insertions(+), 109 deletions(-) diff --git

[FFmpeg-devel] [PATCH v3 9/9] lavc/libopenh264enc: Add coder option to replace cabac

Set DEPRECATED flag to option cabac, replace with coder. Change the default option to -1 and allow the default cabac to be determined by profile. Add OPENH264_API_CABAC macro for cabac to remove this option after LIBAVCODEC_VERSION_MAJOR = 59. Signed-off-by: Linjie Fu ---

[FFmpeg-devel] [PATCH v3 8/9] lavc/libopenh264enc: allow specifying the profile through AVCodecContext

Signed-off-by: Linjie Fu --- libavcodec/libopenh264enc.c | 16 1 file changed, 16 insertions(+) diff --git a/libavcodec/libopenh264enc.c b/libavcodec/libopenh264enc.c index 3a205b7..df2d6ee 100644 --- a/libavcodec/libopenh264enc.c +++ b/libavcodec/libopenh264enc.c @@ -119,6

[FFmpeg-devel] [PATCH v3 3/9] lavc/libopenh264enc: add bit rate control select support

RC_BITRATE_MODE: set BITS_EXCEEDED to iCurrentBitsLevel and allows QP adjust in RcCalculatePictureQp(). RC_BUFFERBASED_MODE: use buffer status to adjust the video quality. RC_TIMESTAMP_MODE: bit rate control based on timestamp. Default to use RC_QUALITY_MODE. Signed-off-by:

[FFmpeg-devel] [PATCH v3 7/9] lavc/libopenh264enc: add profile high option support

Add support for PRO_HIGH/PRO_BASELINE in SVC Encoding extention mode, which determined by iEntropyCodingModeFlag in ParamTranscode(). Signed-off-by: Linjie Fu --- libavcodec/libopenh264enc.c | 32

[FFmpeg-devel] [PATCH v3 5/9] lavc/libopenh264enc: set slice_mode option to deprecated

"slice mode" seems to be unnecessary since it could be determined by -slices/max_nal_size. default:SM_FIXEDSLCNUM_SLICE mode with cpu-number slices. -slices N: SM_FIXEDSLCNUM_SLICE mode with N slices. -max_nal_size: SM_SIZELIMITED_SLICE mode with limited size slices. Add

Re: [FFmpeg-devel] [PATCH] avcodec/jpeg2000dec: Fix mixed declaration and code

On 4/11/20, Anton Khirnov wrote: > Quoting Paul B Mahol (2020-04-11 11:29:40) >> On 4/11/20, Anton Khirnov wrote: >> > 100%? Meaning you think no patches should go to the mailing list? >> > >> > Or only some specific patches are exempt? Based on what criterion? And >> > who applies it? >> > And

[FFmpeg-devel] [PATCH v2 1/7] lavc: add a new sidedata type for Dolby Vision

From: Jun Zhao add a new sidedata type for Dolby Vision. Signed-off-by: Jun Zhao --- libavcodec/avpacket.c | 1 + libavcodec/packet.h | 9 + 2 files changed, 10 insertions(+) diff --git a/libavcodec/avpacket.c b/libavcodec/avpacket.c index ad020ee..276beeb 100644 ---

[FFmpeg-devel] [PATCH v2 3/7] lavf/mpegts: support DOVIVideo Stream Descriptor

From: vacingfang support DOVIVideo Stream Descriptor from Dolby Vision Streams Within the MPEG-2 Transport Stream Format V1.2 From the spec: https://www.dolby.com/us/en/technologies/\ dolby-vision/dolby-vision-bitstreams-in-mpeg-2-transport-\ stream-multiplex-v1.2.pdf. export the Dolby Vision

Re: [FFmpeg-devel] [PATCH] avcodec/bsf: mention that av_bsf_send_packet() returning EAGAIN is not an error

On 4/11/2020 11:04 AM, Anton Khirnov wrote: > Quoting James Almer (2020-04-11 15:21:24) >> >> Not necessarily better, just in line with the decode API. It would be >> nice to have all our decoupled input/output APIs behaving the same, >> instead of each featuring one small difference here and

Re: [FFmpeg-devel] [PATCH] avcodec/ac3_tab: Zero-terminate ff_ac3_sample_rate_tab

Carl Eugen Hoyos: > Am Sa., 11. Apr. 2020 um 16:41 Uhr schrieb Andreas Rheinhardt > : >> >> This is required to use it as an AVCodec.supported_samplerates array. >> Adding the sentinel has been forgotten in 4679a474. >> Without it e.g. the FATE-test ffmpeg-filter_complex_audio fails with ASAN. >

Re: [FFmpeg-devel] [PATCH] avcodec/v4l2_m2m_enc: Add option to remove ivf container

On Sat, Apr 11, 2020 at 6:43 PM Andriy Gelman wrote: > > On Sat, 11. Apr 15:56, Mark Thompson wrote: > > On 04/04/2020 21:26, Andriy Gelman wrote: > > > From: Andriy Gelman > > > > > > The dequeued packets from vp8 (s5p-mfc) encoder are output in ivf format > > > which breaks the stream when the

Re: [FFmpeg-devel] [PATCH] avcodec/cbs: Allocate more CodedBitstreamUnit at once in cbs_insert_unit()

On Sat, Apr 11, 2020 at 12:29:37AM -0300, James Almer wrote: > On 4/10/2020 11:49 PM, James Almer wrote: > > On 4/10/2020 9:00 PM, James Almer wrote: > >> On 4/10/2020 8:53 PM, Michael Niedermayer wrote: > >>> On Fri, Apr 10, 2020 at 05:44:25PM -0300, James Almer wrote: > On 4/10/2020 5:23

Re: [FFmpeg-devel] [PATCH] avcodec/cbs: Allocate more CodedBitstreamUnit at once in cbs_insert_unit()

Michael Niedermayer: > On Sat, Apr 11, 2020 at 12:29:37AM -0300, James Almer wrote: >> On 4/10/2020 11:49 PM, James Almer wrote: >>> On 4/10/2020 9:00 PM, James Almer wrote: On 4/10/2020 8:53 PM, Michael Niedermayer wrote: > On Fri, Apr 10, 2020 at 05:44:25PM -0300, James Almer wrote:

Re: [FFmpeg-devel] [PATCH] avcodec/jpeg2000dec: Fix mixed declaration and code

Paul B Mahol (12020-04-11): > I never found developer that have coverity in brain or run patches via it. Exactly. And I hope you have the insight to count yourself in these numbers. This is exactly why we need reviews: individually, we are fallible, collectively we are still fallible, but much

Re: [FFmpeg-devel] [PATCH V1 2/4] lavc/hevcdec: fix the HEVC decoder crash when memory over-read

Am Sa., 11. Apr. 2020 um 16:24 Uhr schrieb myp...@gmail.com : > > On Mon, Mar 30, 2020 at 4:52 PM myp...@gmail.com wrote: > > > > On Mon, Mar 30, 2020 at 4:31 PM Jun Zhao wrote: > > > > > > From: qoroliang > > > > > > Fix an occasional crash for hevc decoder in ARM 64 platform, the > >

Re: [FFmpeg-devel] [PATCH 03/10] lavc/libopenh264enc: add default gop size and bit rate

> From: ffmpeg-devel On Behalf Of > Anton Khirnov > Sent: Saturday, April 11, 2020 16:43 > To: FFmpeg development discussions and patches de...@ffmpeg.org> > Subject: Re: [FFmpeg-devel] [PATCH 03/10] lavc/libopenh264enc: add > default gop size and bit rate > > Quoting Fu, Linjie (2020-04-10

Re: [FFmpeg-devel] [PATCH 04/10] lavc/libopenh264enc: add bit rate control select support

> From: ffmpeg-devel On Behalf Of > Anton Khirnov > Sent: Friday, April 10, 2020 18:20 > To: FFmpeg development discussions and patches de...@ffmpeg.org> > Subject: Re: [FFmpeg-devel] [PATCH 04/10] lavc/libopenh264enc: add bit > rate control select support > > Quoting Linjie Fu (2020-04-06

Re: [FFmpeg-devel] [PATCH] avcodec/jpeg2000dec: Fix mixed declaration and code

Quoting Carl Eugen Hoyos (2020-04-11 11:56:40) > > > > Furthermore, I would strongly suggest you stop making such > > > comments that are not helpful. > > > > What about my comment is "not helpful"? > > And how is you expressing your personal opinion different > > from me doing the same? > >

[FFmpeg-devel] [PATCH] avcodec/cbs: use av_fast_realloc() in cbs_insert_unit()

Fixes: Timeout Fixes: 20791/clusterfuzz-testcase-minimized-ffmpeg_BSF_AV1_FRAME_SPLIT_fuzzer-5659537719951360 Fixes: 21214/clusterfuzz-testcase-minimized-ffmpeg_BSF_MPEG2_METADATA_fuzzer-5165560875974656 Fixes:

Re: [FFmpeg-devel] [PATCH] avcodec/v4l2_m2m_enc: Add option to remove ivf container

Apr 11, 2020, 15:56 by s...@jkqxz.net: > On 04/04/2020 21:26, Andriy Gelman wrote: > >> From: Andriy Gelman >> >> The dequeued packets from vp8 (s5p-mfc) encoder are output in ivf format >> which breaks the stream when the packets are muxed in avformat. This commit >> adds an option to remove

Re: [FFmpeg-devel] [PATCH v3 1/2] avcodec: add adpcm_ima_ssi encoder

On Fri, 10 Apr 2020 12:26:50 + "Zane van Iperen" wrote: > Signed-off-by: Zane van Iperen > --- > Changelog | 1 + > doc/general.texi | 2 +- > libavcodec/Makefile| 1 + > libavcodec/adpcmenc.c | 30 ++ > libavcodec/allcodecs.c | 1 + >

[FFmpeg-devel] [PATCH 2/6] dnn-layer-mathbinary-test: add unit test for add

Signed-off-by: Guo, Yejun --- tests/dnn/dnn-layer-mathbinary-test.c | 55 --- 1 file changed, 38 insertions(+), 17 deletions(-) diff --git a/tests/dnn/dnn-layer-mathbinary-test.c b/tests/dnn/dnn-layer-mathbinary-test.c index 1243784..fd8037f 100644 ---

[FFmpeg-devel] [PATCH 4/6] dnn-layer-mathbinary-test: add unit test for 'mul'

Signed-off-by: Guo, Yejun --- tests/dnn/dnn-layer-mathbinary-test.c | 5 + 1 file changed, 5 insertions(+) diff --git a/tests/dnn/dnn-layer-mathbinary-test.c b/tests/dnn/dnn-layer-mathbinary-test.c index fd8037f..3b0f0c5 100644 --- a/tests/dnn/dnn-layer-mathbinary-test.c +++

[FFmpeg-devel] [PATCH 1/6] dnn/native: add native support for 'add'

It can be tested with the model file generated with below python script: import tensorflow as tf import numpy as np import imageio in_img = imageio.imread('input.jpg') in_img = in_img.astype(np.float32)/255.0 in_data = in_img[np.newaxis, :] x = tf.placeholder(tf.float32, shape=[1, None, None,

[FFmpeg-devel] [PATCH 5/6] dnn/native: add native support for divide

it can be tested with model file generated with below python script: import tensorflow as tf import numpy as np import imageio in_img = imageio.imread('input.jpg') in_img = in_img.astype(np.float32)/255.0 in_data = in_img[np.newaxis, :] x = tf.placeholder(tf.float32, shape=[1, None, None, 3],

[FFmpeg-devel] [PATCH 3/6] dnn/native: add native support for 'mul'

it can be tested with model file generated from above python script: import tensorflow as tf import numpy as np import imageio in_img = imageio.imread('input.jpg') in_img = in_img.astype(np.float32)/255.0 in_data = in_img[np.newaxis, :] x = tf.placeholder(tf.float32, shape=[1, None, None, 3],

[FFmpeg-devel] [PATCH 6/6] dnn-layer-mathbinary-test: add unit test for divide

Signed-off-by: Guo, Yejun --- tests/dnn/dnn-layer-mathbinary-test.c | 5 + 1 file changed, 5 insertions(+) diff --git a/tests/dnn/dnn-layer-mathbinary-test.c b/tests/dnn/dnn-layer-mathbinary-test.c index 3b0f0c5..f82d15b 100644 --- a/tests/dnn/dnn-layer-mathbinary-test.c +++

Re: [FFmpeg-devel] [PATCH 03/10] lavc/libopenh264enc: add default gop size and bit rate

Quoting Fu, Linjie (2020-04-10 15:33:04) > > From: ffmpeg-devel On Behalf Of > > Anton Khirnov > > Sent: Friday, April 10, 2020 18:14 > > To: FFmpeg development discussions and patches > de...@ffmpeg.org> > > Subject: Re: [FFmpeg-devel] [PATCH 03/10] lavc/libopenh264enc: add > > default gop size

Re: [FFmpeg-devel] [PATCH] avcodec/jpeg2000dec: Fix mixed declaration and code

Am Sa., 11. Apr. 2020 um 11:27 Uhr schrieb Anton Khirnov : > > Quoting Carl Eugen Hoyos (2020-04-11 11:06:44) > > Am Sa., 11. Apr. 2020 um 10:58 Uhr schrieb Anton Khirnov > > : > > > > Fortunately, this is not how it's done here. > > It is done the way we, as a whole community, decide it is done.

Re: [FFmpeg-devel] [PATCH] avcodec/jpeg2000dec: Fix mixed declaration and code

On 4/11/20, Anton Khirnov wrote: > Quoting Paul B Mahol (2020-04-11 10:59:34) >> On 4/11/20, Anton Khirnov wrote: >> > Quoting Carl Eugen Hoyos (2020-04-09 18:13:53) >> >> Am Do., 9. Apr. 2020 um 14:39 Uhr schrieb Andreas Rheinhardt >> >> : >> >> > >> >> > Signed-off-by: Andreas Rheinhardt >>

Re: [FFmpeg-devel] [PATCH] avcodec/jpeg2000dec: Fix mixed declaration and code

Quoting Paul B Mahol (2020-04-11 11:29:40) > On 4/11/20, Anton Khirnov wrote: > > 100%? Meaning you think no patches should go to the mailing list? > > > > Or only some specific patches are exempt? Based on what criterion? And > > who applies it? > > And most importantly, why? > > Only trivial

Re: [FFmpeg-devel] [PATCH]lavfi/telecine: Mark telecined frames as interlaced

Am So., 5. Apr. 2020 um 02:05 Uhr schrieb Carl Eugen Hoyos : > > Am So., 5. Apr. 2020 um 01:02 Uhr schrieb Carl Eugen Hoyos > : > > > > Am Sa., 4. Apr. 2020 um 00:44 Uhr schrieb Carl Eugen Hoyos > > : > > > > > > Am Sa., 4. Apr. 2020 um 00:40 Uhr schrieb James Almer : > > > > > > > > On 4/3/2020

Re: [FFmpeg-devel] [PATCH v2 2/7] lavutil: add dolby vision related header

On Sat, Apr 11, 2020 at 5:49 PM Carl Eugen Hoyos wrote: > > Am Sa., 11. Apr. 2020 um 16:08 Uhr schrieb Jun Zhao : > > > > From: vacinfang > > > > add dolby vision related header > > Apart from the name of the header file: > Could you explain why it is needed? > > Is the Dolby Vision metadata not

Re: [FFmpeg-devel] [PATCH] avcodec/adpcm: remove unused shift parameter from adpcm_ima_qt_expand_nibble()

Am Sa., 11. Apr. 2020 um 10:12 Uhr schrieb Zane van Iperen : > > Signed-off-by: Zane van Iperen > --- > libavcodec/adpcm.c | 18 +- > 1 file changed, 9 insertions(+), 9 deletions(-) > > diff --git a/libavcodec/adpcm.c b/libavcodec/adpcm.c > index e9abddc43c..ee18875579 100644 >

Re: [FFmpeg-devel] [PATCH] avcodec/v4l2_m2m_enc: Add option to remove ivf container

On Sat, 11. Apr 15:56, Mark Thompson wrote: > On 04/04/2020 21:26, Andriy Gelman wrote: > > From: Andriy Gelman > > > > The dequeued packets from vp8 (s5p-mfc) encoder are output in ivf format > > which breaks the stream when the packets are muxed in avformat. This commit > > adds an option to

Re: [FFmpeg-devel] [PATCH 2/4] avcodec.h: split AVCodecParameters API into its own header

On 4/10/2020 12:41 PM, Anton Khirnov wrote: > --- > Not sure what to do with AVFieldOrder. It gets moved to codec_par.h > since it is used in AVCodecParameters, but it isn't precisely the right > place for it, though it's not horribly wrong either. How about moving it to lavu's pixfmt.h,

Re: [FFmpeg-devel] [PATCH] configure: add MV30 blockdsp dependency

Quoting Peter Ross (2020-04-10 15:43:08) > fix link error introduced in 481ebb1c8b3368e2a1bb9e33bd10b50a8818dbf7 > --- > configure | 1 + > 1 file changed, 1 insertion(+) > Looks ok -- Anton Khirnov ___ ffmpeg-devel mailing list

Re: [FFmpeg-devel] [PATCH] avcodec/jpeg2000dec: Fix mixed declaration and code

On 4/11/20, Anton Khirnov wrote: > Quoting Carl Eugen Hoyos (2020-04-09 18:13:53) >> Am Do., 9. Apr. 2020 um 14:39 Uhr schrieb Andreas Rheinhardt >> : >> > >> > Signed-off-by: Andreas Rheinhardt >> > --- >> > libavcodec/jpeg2000dec.c | 5 +++-- >> > 1 file changed, 3 insertions(+), 2

Re: [FFmpeg-devel] [PATCH] avcodec/jpeg2000dec: Fix mixed declaration and code

Quoting Carl Eugen Hoyos (2020-04-09 18:13:53) > Am Do., 9. Apr. 2020 um 14:39 Uhr schrieb Andreas Rheinhardt > : > > > > Signed-off-by: Andreas Rheinhardt > > --- > > libavcodec/jpeg2000dec.c | 5 +++-- > > 1 file changed, 3 insertions(+), 2 deletions(-) > > > > diff --git

Re: [FFmpeg-devel] [PATCH 05/10] lavc/libopenh264enc: prompt slice number changing according to cpus

> From: ffmpeg-devel On Behalf Of > Anton Khirnov > Sent: Saturday, April 11, 2020 16:38 > To: FFmpeg development discussions and patches de...@ffmpeg.org> > Subject: Re: [FFmpeg-devel] [PATCH 05/10] lavc/libopenh264enc: prompt > slice number changing according to cpus > > Quoting Fu, Linjie

[FFmpeg-devel] [PATCH v3 4/9] lavc/libopenh264enc: prompt slice number changing inside libopenh264

Libopenh264enc would set the slice according to the number of cpu cores if uiSliceNum equals to 0 (auto) in SM_FIXEDSLCNUM_SLICE mode. Prompt a warning for user to catch this. Signed-off-by: Linjie Fu --- libavcodec/libopenh264enc.c | 2 ++ 1 file changed, 2 insertions(+) diff --git

[FFmpeg-devel] [PATCH v3 1/9] lavc/libopenh264enc: Add default qmin/qmax support

Set default QP range to (1, 51) instead of (2, 32). QP = 0 is not well supported currently in libopenh264. If iMaxQp/iMinQp equals 0, the QP range would be changed unexpectedly inside libopenh264 with a warning: Warning:Change QP Range from(0,51) to (12,42) [1]

[FFmpeg-devel] [PATCH v3 0/9] patchset for the enhancement of libopenh264 encoder

Docs will be provided later. Linjie Fu (9): lavc/libopenh264enc: Add default qmin/qmax support lavc/libopenh264enc: add default gop size and bit rate lavc/libopenh264enc: add bit rate control select support lavc/libopenh264enc: prompt slice number changing inside libopenh264

[FFmpeg-devel] [PATCH v3 2/9] lavc/libopenh264enc: add default gop size and bit rate

It would be 200kbps bitrate with gop size = 12 by default which generated too many IDR frames in rather low bit rate. The quality would be poor. Set these default values according to vaapi encoder, and use 2Mbps bitrate if user doesn't set it explicitly as nvenc sugguested. Signed-off-by: Linjie

Re: [FFmpeg-devel] [PATCH]lavc/amrwb: Output silence for frames marked as broken

Am Di., 7. Apr. 2020 um 16:05 Uhr schrieb Anton Khirnov : > > Quoting Carl Eugen Hoyos (2020-04-06 15:32:43) > > Am Mo., 6. Apr. 2020 um 10:42 Uhr schrieb Anton Khirnov : > > > > > > Quoting Carl Eugen Hoyos (2020-04-05 17:37:15) > > > > Am So., 5. Apr. 2020 um 02:01 Uhr schrieb Carl Eugen Hoyos

Re: [FFmpeg-devel] [PATCH] avcodec/cbs: Allocate more CodedBitstreamUnit at once in cbs_insert_unit()

On Sat, Apr 11, 2020 at 12:26:42PM +0200, Andreas Rheinhardt wrote: > Michael Niedermayer: > > On Sat, Apr 11, 2020 at 12:29:37AM -0300, James Almer wrote: > >> On 4/10/2020 11:49 PM, James Almer wrote: > >>> On 4/10/2020 9:00 PM, James Almer wrote: > On 4/10/2020 8:53 PM, Michael Niedermayer

[FFmpeg-devel] [PATCH v2 6/7] fftools/ffprobe: support dolby vision sidedata

From: Jun Zhao support dolby vision sidedata. Signed-off-by: Jun Zhao --- fftools/ffprobe.c | 11 +++ 1 file changed, 11 insertions(+) diff --git a/fftools/ffprobe.c b/fftools/ffprobe.c index e3f221f..108e837 100644 --- a/fftools/ffprobe.c +++ b/fftools/ffprobe.c @@ -36,6 +36,7 @@

[FFmpeg-devel] [PATCH v2 4/7] lavf/mov: support dvcC/dvvC box for Dolby Vision

From: vacingfang support dvcC/dvcC box from spec Dolby Vision Streams Within the ISO Base MediaFile Format Version 2.1.2 (https://www.dolby.com/in/en/technologies/dolby-vision/dolby-vision\ -bitstreams-within-the-iso-base-media-file-format-v2.1.2.pdf) export the Dolby Vision information to

[FFmpeg-devel] [PATCH v2 5/7] lavf/dump: dump dolby vison side data

From: Jun Zhao dump dolby vison side data. Signed-off-by: Jun Zhao --- libavformat/dump.c | 17 + 1 file changed, 17 insertions(+) diff --git a/libavformat/dump.c b/libavformat/dump.c index 220f404..be0028b 100644 --- a/libavformat/dump.c +++ b/libavformat/dump.c @@ -27,6

Re: [FFmpeg-devel] [RFC] Moving ffprobe's writers to lavu

On 4/10/20, Nicolas George wrote: > Hi. > > In the comments on a recent patch to implement statistics outputs for a > specific filter, I noted that this is something that many filters need > to do, and therefore in need of unification. I also observed some JSON > code in a filter, which does not

Re: [FFmpeg-devel] [PATCH] avcodec/bsf: mention that av_bsf_send_packet() returning EAGAIN is not an error

Quoting James Almer (2020-04-11 15:21:24) > > Not necessarily better, just in line with the decode API. It would be > nice to have all our decoupled input/output APIs behaving the same, > instead of each featuring one small difference here and there. We could also change the decode API to be in

Re: [FFmpeg-devel] [PATCH V1 2/4] lavc/hevcdec: fix the HEVC decoder crash when memory over-read

On Mon, Mar 30, 2020 at 4:52 PM myp...@gmail.com wrote: > > On Mon, Mar 30, 2020 at 4:31 PM Jun Zhao wrote: > > > > From: qoroliang > > > > Fix an occasional crash for hevc decoder in ARM 64 platform, the > typo: it's ARM 32 bits platform, not 64, > fixed in local > >

[FFmpeg-devel] [PATCH 2/3] doc/examples/demuxing_decoding: convert to new decoding API

--- doc/examples/demuxing_decoding.c | 177 --- 1 file changed, 91 insertions(+), 86 deletions(-) diff --git a/doc/examples/demuxing_decoding.c b/doc/examples/demuxing_decoding.c index 9bde927321..803e35d25c 100644 --- a/doc/examples/demuxing_decoding.c +++

[FFmpeg-devel] [PATCH 1/3] doc/examples/demuxing_decoding: drop -refcount

Non-refcounted frames are deprecated and there is no good reason to use them. --- doc/examples/demuxing_decoding.c | 28 ++-- 1 file changed, 6 insertions(+), 22 deletions(-) diff --git a/doc/examples/demuxing_decoding.c b/doc/examples/demuxing_decoding.c index

[FFmpeg-devel] [PATCH 3/3] doc/examples/muxing: convert to new encoding API

--- doc/examples/muxing.c | 95 ++- 1 file changed, 39 insertions(+), 56 deletions(-) diff --git a/doc/examples/muxing.c b/doc/examples/muxing.c index 9af9aae483..c1d42303af 100644 --- a/doc/examples/muxing.c +++ b/doc/examples/muxing.c @@ -78,15 +78,45 @@

Re: [FFmpeg-devel] [PATCH v4] avcodec/v4l2_m2m: handle the v4l2 eos event

On Wed, 08. Apr 20:51, Andriy Gelman wrote: > On Wed, 01. Apr 10:38, Ming Qian wrote: > > when the last frame of capture is dequeueed, > > driver may send this V4L2_EVENT_EOS event, > > If this event is received, then the capture buffers have been flushed and > >

Re: [FFmpeg-devel] [PATCH 3/3] lavc/vaapi_encode_h265: add h265 tile encoding support

> From: ffmpeg-devel On Behalf Of Fu, > Linjie > Sent: Saturday, March 28, 2020 23:02 > To: FFmpeg development discussions and patches de...@ffmpeg.org>; myp...@gmail.com > Subject: Re: [FFmpeg-devel] [PATCH 3/3] lavc/vaapi_encode_h265: add h265 > tile encoding support > > > From: ffmpeg-devel

Re: [FFmpeg-devel] [PATCH] avcodec/v4l2_m2m_enc: Add option to remove ivf container

On Sat, 11. Apr 18:56, Jan Ekström wrote: > On Sat, Apr 11, 2020 at 6:43 PM Andriy Gelman wrote: > > > > On Sat, 11. Apr 15:56, Mark Thompson wrote: > > > On 04/04/2020 21:26, Andriy Gelman wrote: > > > > From: Andriy Gelman > > > > > > > > The dequeued packets from vp8 (s5p-mfc) encoder are

Re: [FFmpeg-devel] [PATCH v8 0/2] Pro Pinball Series Soundbank demuxer + decoder.

On Tue, 07 Apr 2020 10:48:53 + "Zane van Iperen" wrote: > Adds support for the soundbank files used by the Pro Pinball series > of games. > > Please CC for review. > > v8: > - change "goto done" to a return + "goto fail" > - Handle truncated files > - Fix potential byte counter

Re: [FFmpeg-devel] [PATCH] avcodec/bsf: mention that av_bsf_send_packet() returning EAGAIN is not an error

Quoting James Almer (2020-04-10 17:42:23) > On 4/10/2020 11:07 AM, Derek Buitenhuis wrote: > > On 10/04/2020 00:09, James Almer wrote: > >> EAGAIN is returned when input is provided but can't be consumed. The > >> filtering > >> process is unaffected in this case, and the function will be able to

Re: [FFmpeg-devel] [PATCH] avcodec/jpeg2000dec: Fix mixed declaration and code

Quoting Carl Eugen Hoyos (2020-04-11 11:06:44) > Am Sa., 11. Apr. 2020 um 10:58 Uhr schrieb Anton Khirnov : > > Fortunately, this is not how it's done here. It is done the way we, as a whole community, decide it is done. In practice, many people send ALL of their patches to the ML. > >

Re: [FFmpeg-devel] [PATCH]lavc/amrwbdec: Do not ignore NO_DATA frames

Am Mi., 30. Jan. 2019 um 21:08 Uhr schrieb Carl Eugen Hoyos : > > 2019-01-30 20:33 GMT+01:00, Paul B Mahol : > > On 1/30/19, Carl Eugen Hoyos wrote: > >> 2019-01-29 22:47 GMT+01:00, Carl Eugen Hoyos : > > >>> Attached patch fixes decoding NO_DATA amr-wb frames. > >> > >> Now with patch. > > > Are

Re: [FFmpeg-devel] [PATCH] avcodec/bsf: mention that av_bsf_send_packet() returning EAGAIN is not an error

On 4/11/2020 5:33 AM, Anton Khirnov wrote: > Quoting James Almer (2020-04-10 17:42:23) >> On 4/10/2020 11:07 AM, Derek Buitenhuis wrote: >>> On 10/04/2020 00:09, James Almer wrote: EAGAIN is returned when input is provided but can't be consumed. The filtering process is unaffected

[FFmpeg-devel] [PATCH v2 7/7] lavf/movenc: enable dvcC/dvvC box support from sidedata

From: Jun Zhao enable dvcC/dvvC box support from sidedata Signed-off-by: Jun Zhao --- libavformat/movenc.c | 26 ++ 1 file changed, 26 insertions(+) diff --git a/libavformat/movenc.c b/libavformat/movenc.c index 6db09b7..bdd4467 100644 --- a/libavformat/movenc.c +++

Re: [FFmpeg-devel] [PATCH] avcodec/cbs: Allocate more CodedBitstreamUnit at once in cbs_insert_unit()

On 11/04/2020 11:18, Michael Niedermayer wrote: > On Sat, Apr 11, 2020 at 12:29:37AM -0300, James Almer wrote: >> On 4/10/2020 11:49 PM, James Almer wrote: >>> On 4/10/2020 9:00 PM, James Almer wrote: On 4/10/2020 8:53 PM, Michael Niedermayer wrote: > On Fri, Apr 10, 2020 at 05:44:25PM

Re: [FFmpeg-devel] [PATCH v2 2/7] lavutil: add dolby vision related header

Am Sa., 11. Apr. 2020 um 16:08 Uhr schrieb Jun Zhao : > > From: vacinfang > > add dolby vision related header Apart from the name of the header file: Could you explain why it is needed? Is the Dolby Vision metadata not a black box that libavformat has to provide to interested decoders? Carl

Re: [FFmpeg-devel] [PATCH 4/4] avcodec.h: split bitstream filters API into its own header

Quoting James Almer (2020-04-10 20:14:17) > On 4/10/2020 12:42 PM, Anton Khirnov wrote: > > --- > > doc/APIchanges | 3 +- > > libavcodec/Makefile| 1 + > > libavcodec/aac_adtstoasc_bsf.c | 2 +- > > libavcodec/av1_frame_merge_bsf.c

[FFmpeg-devel] [PATCH] avcodec/adpcm: remove unused shift parameter from adpcm_ima_qt_expand_nibble()

Signed-off-by: Zane van Iperen --- libavcodec/adpcm.c | 18 +- 1 file changed, 9 insertions(+), 9 deletions(-) diff --git a/libavcodec/adpcm.c b/libavcodec/adpcm.c index e9abddc43c..ee18875579 100644 --- a/libavcodec/adpcm.c +++ b/libavcodec/adpcm.c @@ -348,7 +348,7 @@ static

Re: [FFmpeg-devel] [PATCH] avcodec/jpeg2000dec: Fix mixed declaration and code

On 4/11/20, Nicolas George wrote: > Anton Khirnov (12020-04-11): >> It is done the way we, as a whole community, decide it is done. In >> practice, many people send ALL of their patches to the ML. > > I am with Anton on this one. Rules are not set in stone, “and even stone > changes, anyway”. > >

Re: [FFmpeg-devel] [PATCH] libavformat/oggparsevorbis: Use case-insensitive key compare for vorbis picture

Am Sa., 11. Apr. 2020 um 11:53 Uhr schrieb Mattias Wadman : > > Regression since 8d3630c5402fdda2889fe4f74f7dcdd50ebca654 where keys were > changed > to not be touppered but the picture block strcmp was not changed to be > case-insensitive. > --- > libavformat/oggparsevorbis.c | 2 +- > 1 file

Re: [FFmpeg-devel] [PATCH] libavformat/oggparsevorbis: Use case-insensitive key compare for vorbis picture

Thanks! Strange, bash history says: git format-patch --to=ffmpeg-devel@ffmpeg.org HEAD~..HEAD git send-email *.patch But i do have this gitconfig: [diff] noprefix = true Seems format-patch uses it That was unexpected, removing that config. -Mattias On Sat, Apr 11, 2020 at 12:59 PM Carl Eugen

Re: [FFmpeg-devel] [PATCH] avcodec/jpeg2000dec: Fix mixed declaration and code

On 4/11/20, Nicolas George wrote: > Paul B Mahol (12020-04-11): >> Or they want to force someone into specific nits. > > Respectfully, I think things would go a lot better around here if people > were to assume good will instead of ill intent. We are all working for > the good of FFmpeg, here, or

[FFmpeg-devel] [PATCH v2 0/7] Support Dolby Vision

From: Jun Zhao V2: - used sidedata for Dolby Vision information (tks Jan Ekström's suggestion) - enabled dumping Dolby Vision sidedata for ffmpeg/ffprobe tools - enable dvcC/dvvC box from Dolby Vision sidedata Jun Zhao (4): lavc: add a new sidedata type for Dolby Vision lavf/dump: dump

[FFmpeg-devel] [PATCH v2 2/7] lavutil: add dolby vision related header

From: vacinfang add dolby vision related header Signed-off-by: vacinfang --- libavutil/Makefile| 1 + libavutil/dolby_vision_meta.h | 58 +++ 2 files changed, 59 insertions(+) create mode 100644 libavutil/dolby_vision_meta.h diff --git

Re: [FFmpeg-devel] [RFC] Moving ffprobe's writers to lavu

Hi, On Fri, Apr 10, 2020 at 5:27 PM Nicolas George wrote: > > Hi. > > In the comments on a recent patch to implement statistics outputs for a > specific filter, I noted that this is something that many filters need > to do, and therefore in need of unification. I also observed some JSON > code

Re: [FFmpeg-devel] [PATCH v2 2/7] lavutil: add dolby vision related header

I really do not think it is a good idea to have a header with the name dolby in it. On Sat, Apr 11, 2020, at 15:44, Jun Zhao wrote: > From: vacinfang > > add dolby vision related header > > Signed-off-by: vacinfang > --- > libavutil/Makefile| 1 + >

Re: [FFmpeg-devel] [PATCH] avcodec/v4l2_m2m_enc: Add option to remove ivf container

On 04/04/2020 21:26, Andriy Gelman wrote: > From: Andriy Gelman > > The dequeued packets from vp8 (s5p-mfc) encoder are output in ivf format > which breaks the stream when the packets are muxed in avformat. This commit > adds an option to remove the container and thus support the encoder. > >

Re: [FFmpeg-devel] [PATCH v2 1/7] lavc: add a new sidedata type for Dolby Vision

Am Sa., 11. Apr. 2020 um 15:53 Uhr schrieb Jun Zhao : > > From: Jun Zhao > > add a new sidedata type for Dolby Vision. > > Signed-off-by: Jun Zhao > --- > libavcodec/avpacket.c | 1 + > libavcodec/packet.h | 9 + > 2 files changed, 10 insertions(+) > > diff --git

Re: [FFmpeg-devel] [PATCH]lavfi/telecine: Mark telecined frames as interlaced

Am Sa., 11. Apr. 2020 um 15:10 Uhr schrieb Paul B Mahol : > > On 4/11/20, Carl Eugen Hoyos wrote: > > Am So., 5. Apr. 2020 um 02:05 Uhr schrieb Carl Eugen Hoyos > > : > >> > >> Am So., 5. Apr. 2020 um 01:02 Uhr schrieb Carl Eugen Hoyos > >> : > >> > > >> > Am Sa., 4. Apr. 2020 um 00:44 Uhr

Re: [FFmpeg-devel] [PATCH 05/10] lavc/libopenh264enc: prompt slice number changing according to cpus

Quoting Fu, Linjie (2020-04-10 15:49:30) > > From: ffmpeg-devel On Behalf Of > > Anton Khirnov > > Sent: Friday, April 10, 2020 18:23 > > To: FFmpeg development discussions and patches > de...@ffmpeg.org> > > Subject: Re: [FFmpeg-devel] [PATCH 05/10] lavc/libopenh264enc: prompt > > slice number

Re: [FFmpeg-devel] [PATCH] avcodec/jpeg2000dec: Fix mixed declaration and code

Am Sa., 11. Apr. 2020 um 10:58 Uhr schrieb Anton Khirnov : > > Quoting Carl Eugen Hoyos (2020-04-09 18:13:53) > > Am Do., 9. Apr. 2020 um 14:39 Uhr schrieb Andreas Rheinhardt > > : > > > > > > Signed-off-by: Andreas Rheinhardt > > > --- > > > libavcodec/jpeg2000dec.c | 5 +++-- > > > 1 file

Re: [FFmpeg-devel] [PATCH] avcodec/jpeg2000dec: Fix mixed declaration and code

Quoting Paul B Mahol (2020-04-11 10:59:34) > On 4/11/20, Anton Khirnov wrote: > > Quoting Carl Eugen Hoyos (2020-04-09 18:13:53) > >> Am Do., 9. Apr. 2020 um 14:39 Uhr schrieb Andreas Rheinhardt > >> : > >> > > >> > Signed-off-by: Andreas Rheinhardt > >> > --- > >> > libavcodec/jpeg2000dec.c |

[FFmpeg-devel] [PATCH] libavformat/oggparsevorbis: Use case-insensitive key compare for vorbis picture

Regression since 8d3630c5402fdda2889fe4f74f7dcdd50ebca654 where keys were changed to not be touppered but the picture block strcmp was not changed to be case-insensitive. --- libavformat/oggparsevorbis.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

Re: [FFmpeg-devel] [PATCH] avcodec/aacdec: fix compilation under soft float MIPS

Am Mo., 6. Apr. 2020 um 07:29 Uhr schrieb Rosen Penev : > > Place HAVE_MIPSFPU further up so that functions that use floating point > ASM are defined away. Otherwise compilation failures result when soft > float in enabled on the toolchain. Patch applied. Thank you, Carl Eugen

Re: [FFmpeg-devel] [PATCH] avcodec/jpeg2000dec: Fix mixed declaration and code

On 4/11/20, Nicolas George wrote: > Paul B Mahol (12020-04-11): >> I never found developer that have coverity in brain or run patches via >> it. > > Exactly. And I hope you have the insight to count yourself in these > numbers. > > This is exactly why we need reviews: individually, we are

Re: [FFmpeg-devel] [PATCH] avcodec/ac3_tab: Zero-terminate ff_ac3_sample_rate_tab

Am Sa., 11. Apr. 2020 um 16:41 Uhr schrieb Andreas Rheinhardt : > > This is required to use it as an AVCodec.supported_samplerates array. > Adding the sentinel has been forgotten in 4679a474. > Without it e.g. the FATE-test ffmpeg-filter_complex_audio fails with ASAN. lgtm Thank you, Carl Eugen

Re: [FFmpeg-devel] [PATCH v4 1/2] libavcodec/libaomenc.c: Support gray input

Hi! I would like to discuss this patch, but I can't find who is the maintainer of this codec. https://github.com/FFmpeg/FFmpeg/blob/master/MAINTAINERS Does anyone know? If something was BAD, I would like to rewrite it better. If splitting this patch into gray support and lossless support patch

Re: [FFmpeg-devel] [PATCH] avcodec/dpcm: clip exponent into supported range in XAN DPCM

Quoting Michael Niedermayer (2020-04-09 20:12:11) > Fixes: shift exponent 32 is too large for 32-bit type 'int' > Fixes: > 21200/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_XAN_DPCM_fuzzer-5754704894361600 > > Found-by: continuous fuzzing process >

Re: [FFmpeg-devel] [PATCH]lavfi/telecine: Mark telecined frames as interlaced

On 4/11/20, Carl Eugen Hoyos wrote: > Am So., 5. Apr. 2020 um 02:05 Uhr schrieb Carl Eugen Hoyos > : >> >> Am So., 5. Apr. 2020 um 01:02 Uhr schrieb Carl Eugen Hoyos >> : >> > >> > Am Sa., 4. Apr. 2020 um 00:44 Uhr schrieb Carl Eugen Hoyos >> > : >> > > >> > > Am Sa., 4. Apr. 2020 um 00:40 Uhr

Re: [FFmpeg-devel] [PATCH] avcodec/jpeg2000dec: Fix mixed declaration and code

Paul B Mahol (12020-04-11): > Or they want to force someone into specific nits. Respectfully, I think things would go a lot better around here if people were to assume good will instead of ill intent. We are all working for the good of FFmpeg, here, or at least we are. As for the merits of

[FFmpeg-devel] [PATCH] avcodec/ac3_tab: Zero-terminate ff_ac3_sample_rate_tab

This is required to use it as an AVCodec.supported_samplerates array. Adding the sentinel has been forgotten in 4679a474. Without it e.g. the FATE-test ffmpeg-filter_complex_audio fails with ASAN. Signed-off-by: Andreas Rheinhardt --- libavcodec/ac3tab.c | 2 +- libavcodec/ac3tab.h | 2 +- 2

Re: [FFmpeg-devel] [PATCH]lavfi/telecine: Mark telecined frames as interlaced

On 4/11/20, Carl Eugen Hoyos wrote: > Am Sa., 11. Apr. 2020 um 15:10 Uhr schrieb Paul B Mahol : >> >> On 4/11/20, Carl Eugen Hoyos wrote: >> > Am So., 5. Apr. 2020 um 02:05 Uhr schrieb Carl Eugen Hoyos >> > : >> >> >> >> Am So., 5. Apr. 2020 um 01:02 Uhr schrieb Carl Eugen Hoyos >> >> : >> >> >

Re: [FFmpeg-devel] [PATCH]lavu/mem: Make alloc array functions more similar to av_malloc

Am So., 5. Apr. 2020 um 14:03 Uhr schrieb Michael Niedermayer : > > On Sat, Apr 04, 2020 at 12:46:36AM +0200, Carl Eugen Hoyos wrote: > > Hi! > > > > Attached patch makes the alloc array functions more similar to > > av_malloc, depending on max_alloc_size instead of INT_MAX. > > > > Allows a

Re: [FFmpeg-devel] [PATCH]lavu/mem: Make alloc array functions more similar to av_malloc

Am So., 12. Apr. 2020 um 00:44 Uhr schrieb Carl Eugen Hoyos : > > Am So., 5. Apr. 2020 um 14:03 Uhr schrieb Michael Niedermayer > : > > > > On Sat, Apr 04, 2020 at 12:46:36AM +0200, Carl Eugen Hoyos wrote: > > > Hi! > > > > > > Attached patch makes the alloc array functions more similar to > > >

[FFmpeg-devel] [PATCH v2 1/6] avformat/mux: Make uncoded frames av_packet_unref() compatible

Currently uncoded frames (i.e. packets whose data actually points to an AVFrame) are not refcounted. As a consequence, calling av_packet_unref() on them will not free them, but may simply make sure that they leak by losing the pointer to the frame. This commit changes this by actually making

[FFmpeg-devel] [PATCH v2 2/6] avformat/mux: Fix leaks on error when writing noninterleaved uncoded frames

If writing uncoded frames in noninterleaved mode fails at the preparatory steps (i.e. before it reaches write_packet()), the packet would not be unreferenced and the frame would leak. This is fixed by unreferencing the packet in write_uncoded_frame_internal() instead. This also makes it possible

Re: [FFmpeg-devel] [PATCH] avcodec/dpcm: clip exponent into supported range in XAN DPCM

On Sat, Apr 11, 2020 at 10:55:04AM +0200, Anton Khirnov wrote: > Quoting Michael Niedermayer (2020-04-09 20:12:11) > > Fixes: shift exponent 32 is too large for 32-bit type 'int' > > Fixes: > > 21200/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_XAN_DPCM_fuzzer-5754704894361600 > > > >

Re: [FFmpeg-devel] [PATCH 3/3] libavcodec/jpeg2000: fix precinct coordinate calculation

On Sat, Apr 11, 2020 at 12:10:09PM +0530, gautamr...@gmail.com wrote: > From: Gautam Ramakrishnan > > The calculation of precinct boundaries has been > fixed. The precinct boundaries were calculated > as an offset to the band boundary, but must > instead be calculated as an offset from the >

  1   2   >