[FFmpeg-devel] [PATCH v3 9/9] lavc/libopenh264enc: Add coder option to replace cabac

2020-04-11 Thread Linjie Fu
Set DEPRECATED flag to option cabac, replace with coder. Change the default option to -1 and allow the default cabac to be determined by profile. Add OPENH264_API_CABAC macro for cabac to remove this option after LIBAVCODEC_VERSION_MAJOR = 59. Signed-off-by: Linjie Fu ---

[FFmpeg-devel] [PATCH v3 8/9] lavc/libopenh264enc: allow specifying the profile through AVCodecContext

2020-04-11 Thread Linjie Fu
Signed-off-by: Linjie Fu --- libavcodec/libopenh264enc.c | 16 1 file changed, 16 insertions(+) diff --git a/libavcodec/libopenh264enc.c b/libavcodec/libopenh264enc.c index 3a205b7..df2d6ee 100644 --- a/libavcodec/libopenh264enc.c +++ b/libavcodec/libopenh264enc.c @@ -119,6

[FFmpeg-devel] [PATCH v3 3/9] lavc/libopenh264enc: add bit rate control select support

2020-04-11 Thread Linjie Fu
RC_BITRATE_MODE: set BITS_EXCEEDED to iCurrentBitsLevel and allows QP adjust in RcCalculatePictureQp(). RC_BUFFERBASED_MODE: use buffer status to adjust the video quality. RC_TIMESTAMP_MODE: bit rate control based on timestamp. Default to use RC_QUALITY_MODE. Signed-off-by:

[FFmpeg-devel] [PATCH v3 7/9] lavc/libopenh264enc: add profile high option support

2020-04-11 Thread Linjie Fu
Add support for PRO_HIGH/PRO_BASELINE in SVC Encoding extention mode, which determined by iEntropyCodingModeFlag in ParamTranscode(). Signed-off-by: Linjie Fu --- libavcodec/libopenh264enc.c | 32

[FFmpeg-devel] [PATCH v3 5/9] lavc/libopenh264enc: set slice_mode option to deprecated

2020-04-11 Thread Linjie Fu
"slice mode" seems to be unnecessary since it could be determined by -slices/max_nal_size. default:SM_FIXEDSLCNUM_SLICE mode with cpu-number slices. -slices N: SM_FIXEDSLCNUM_SLICE mode with N slices. -max_nal_size: SM_SIZELIMITED_SLICE mode with limited size slices. Add

[FFmpeg-devel] [PATCH v3 1/9] lavc/libopenh264enc: Add default qmin/qmax support

2020-04-11 Thread Linjie Fu
Set default QP range to (1, 51) instead of (2, 32). QP = 0 is not well supported currently in libopenh264. If iMaxQp/iMinQp equals 0, the QP range would be changed unexpectedly inside libopenh264 with a warning: Warning:Change QP Range from(0,51) to (12,42) [1]

[FFmpeg-devel] [PATCH v3 0/9] patchset for the enhancement of libopenh264 encoder

2020-04-11 Thread Linjie Fu
Docs will be provided later. Linjie Fu (9): lavc/libopenh264enc: Add default qmin/qmax support lavc/libopenh264enc: add default gop size and bit rate lavc/libopenh264enc: add bit rate control select support lavc/libopenh264enc: prompt slice number changing inside libopenh264

[FFmpeg-devel] [PATCH v3 4/9] lavc/libopenh264enc: prompt slice number changing inside libopenh264

2020-04-11 Thread Linjie Fu
Libopenh264enc would set the slice according to the number of cpu cores if uiSliceNum equals to 0 (auto) in SM_FIXEDSLCNUM_SLICE mode. Prompt a warning for user to catch this. Signed-off-by: Linjie Fu --- libavcodec/libopenh264enc.c | 2 ++ 1 file changed, 2 insertions(+) diff --git

[FFmpeg-devel] [PATCH v3 2/9] lavc/libopenh264enc: add default gop size and bit rate

2020-04-11 Thread Linjie Fu
It would be 200kbps bitrate with gop size = 12 by default which generated too many IDR frames in rather low bit rate. The quality would be poor. Set these default values according to vaapi encoder, and use 2Mbps bitrate if user doesn't set it explicitly as nvenc sugguested. Signed-off-by: Linjie

Re: [FFmpeg-devel] [PATCH] avcodec/jpeg2000dec: Fix mixed declaration and code

2020-04-11 Thread Paul B Mahol
On 4/11/20, Nicolas George wrote: > Anton Khirnov (12020-04-11): >> It is done the way we, as a whole community, decide it is done. In >> practice, many people send ALL of their patches to the ML. > > I am with Anton on this one. Rules are not set in stone, “and even stone > changes, anyway”. > >

Re: [FFmpeg-devel] [PATCH] avcodec/jpeg2000dec: Fix mixed declaration and code

2020-04-11 Thread Nicolas George
Anton Khirnov (12020-04-11): > It is done the way we, as a whole community, decide it is done. In > practice, many people send ALL of their patches to the ML. I am with Anton on this one. Rules are not set in stone, “and even stone changes, anyway”. And I think too it would be much better if all

Re: [FFmpeg-devel] [PATCH] avcodec/jpeg2000dec: Fix mixed declaration and code

2020-04-11 Thread Carl Eugen Hoyos
Am Sa., 11. Apr. 2020 um 11:27 Uhr schrieb Anton Khirnov : > > Quoting Carl Eugen Hoyos (2020-04-11 11:06:44) > > Am Sa., 11. Apr. 2020 um 10:58 Uhr schrieb Anton Khirnov > > : > > > > Fortunately, this is not how it's done here. > > It is done the way we, as a whole community, decide it is done.

[FFmpeg-devel] [PATCH] libavformat/oggparsevorbis: Use case-insensitive key compare for vorbis picture

2020-04-11 Thread Mattias Wadman
Regression since 8d3630c5402fdda2889fe4f74f7dcdd50ebca654 where keys were changed to not be touppered but the picture block strcmp was not changed to be case-insensitive. --- libavformat/oggparsevorbis.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

Re: [FFmpeg-devel] [PATCH 04/10] lavc/libopenh264enc: add bit rate control select support

2020-04-11 Thread Fu, Linjie
> From: ffmpeg-devel On Behalf Of > Anton Khirnov > Sent: Friday, April 10, 2020 18:20 > To: FFmpeg development discussions and patches de...@ffmpeg.org> > Subject: Re: [FFmpeg-devel] [PATCH 04/10] lavc/libopenh264enc: add bit > rate control select support > > Quoting Linjie Fu (2020-04-06

Re: [FFmpeg-devel] [PATCH 05/10] lavc/libopenh264enc: prompt slice number changing according to cpus

2020-04-11 Thread Fu, Linjie
> From: ffmpeg-devel On Behalf Of > Anton Khirnov > Sent: Saturday, April 11, 2020 16:38 > To: FFmpeg development discussions and patches de...@ffmpeg.org> > Subject: Re: [FFmpeg-devel] [PATCH 05/10] lavc/libopenh264enc: prompt > slice number changing according to cpus > > Quoting Fu, Linjie

Re: [FFmpeg-devel] [PATCH 03/10] lavc/libopenh264enc: add default gop size and bit rate

2020-04-11 Thread Fu, Linjie
> From: ffmpeg-devel On Behalf Of > Anton Khirnov > Sent: Saturday, April 11, 2020 16:43 > To: FFmpeg development discussions and patches de...@ffmpeg.org> > Subject: Re: [FFmpeg-devel] [PATCH 03/10] lavc/libopenh264enc: add > default gop size and bit rate > > Quoting Fu, Linjie (2020-04-10

Re: [FFmpeg-devel] [PATCH] avcodec/jpeg2000dec: Fix mixed declaration and code

2020-04-11 Thread Anton Khirnov
Quoting Carl Eugen Hoyos (2020-04-11 11:06:44) > Am Sa., 11. Apr. 2020 um 10:58 Uhr schrieb Anton Khirnov : > > Fortunately, this is not how it's done here. It is done the way we, as a whole community, decide it is done. In practice, many people send ALL of their patches to the ML. > >

Re: [FFmpeg-devel] [PATCH] avcodec/jpeg2000dec: Fix mixed declaration and code

2020-04-11 Thread Anton Khirnov
Quoting Paul B Mahol (2020-04-11 10:59:34) > On 4/11/20, Anton Khirnov wrote: > > Quoting Carl Eugen Hoyos (2020-04-09 18:13:53) > >> Am Do., 9. Apr. 2020 um 14:39 Uhr schrieb Andreas Rheinhardt > >> : > >> > > >> > Signed-off-by: Andreas Rheinhardt > >> > --- > >> > libavcodec/jpeg2000dec.c |

Re: [FFmpeg-devel] [PATCH] avcodec/jpeg2000dec: Fix mixed declaration and code

2020-04-11 Thread Carl Eugen Hoyos
Am Sa., 11. Apr. 2020 um 10:58 Uhr schrieb Anton Khirnov : > > Quoting Carl Eugen Hoyos (2020-04-09 18:13:53) > > Am Do., 9. Apr. 2020 um 14:39 Uhr schrieb Andreas Rheinhardt > > : > > > > > > Signed-off-by: Andreas Rheinhardt > > > --- > > > libavcodec/jpeg2000dec.c | 5 +++-- > > > 1 file

Re: [FFmpeg-devel] [PATCH] avcodec/jpeg2000dec: Fix mixed declaration and code

2020-04-11 Thread Paul B Mahol
On 4/11/20, Anton Khirnov wrote: > Quoting Carl Eugen Hoyos (2020-04-09 18:13:53) >> Am Do., 9. Apr. 2020 um 14:39 Uhr schrieb Andreas Rheinhardt >> : >> > >> > Signed-off-by: Andreas Rheinhardt >> > --- >> > libavcodec/jpeg2000dec.c | 5 +++-- >> > 1 file changed, 3 insertions(+), 2

Re: [FFmpeg-devel] [PATCH] avcodec/jpeg2000dec: Fix mixed declaration and code

2020-04-11 Thread Anton Khirnov
Quoting Carl Eugen Hoyos (2020-04-09 18:13:53) > Am Do., 9. Apr. 2020 um 14:39 Uhr schrieb Andreas Rheinhardt > : > > > > Signed-off-by: Andreas Rheinhardt > > --- > > libavcodec/jpeg2000dec.c | 5 +++-- > > 1 file changed, 3 insertions(+), 2 deletions(-) > > > > diff --git

Re: [FFmpeg-devel] [PATCH] avcodec/dpcm: clip exponent into supported range in XAN DPCM

2020-04-11 Thread Anton Khirnov
Quoting Michael Niedermayer (2020-04-09 20:12:11) > Fixes: shift exponent 32 is too large for 32-bit type 'int' > Fixes: > 21200/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_XAN_DPCM_fuzzer-5754704894361600 > > Found-by: continuous fuzzing process >

Re: [FFmpeg-devel] [PATCH] configure: add MV30 blockdsp dependency

2020-04-11 Thread Anton Khirnov
Quoting Peter Ross (2020-04-10 15:43:08) > fix link error introduced in 481ebb1c8b3368e2a1bb9e33bd10b50a8818dbf7 > --- > configure | 1 + > 1 file changed, 1 insertion(+) > Looks ok -- Anton Khirnov ___ ffmpeg-devel mailing list

Re: [FFmpeg-devel] [PATCH 03/10] lavc/libopenh264enc: add default gop size and bit rate

2020-04-11 Thread Anton Khirnov
Quoting Fu, Linjie (2020-04-10 15:33:04) > > From: ffmpeg-devel On Behalf Of > > Anton Khirnov > > Sent: Friday, April 10, 2020 18:14 > > To: FFmpeg development discussions and patches > de...@ffmpeg.org> > > Subject: Re: [FFmpeg-devel] [PATCH 03/10] lavc/libopenh264enc: add > > default gop size

[FFmpeg-devel] [PATCH 5/6] dnn/native: add native support for divide

2020-04-11 Thread Guo, Yejun
it can be tested with model file generated with below python script: import tensorflow as tf import numpy as np import imageio in_img = imageio.imread('input.jpg') in_img = in_img.astype(np.float32)/255.0 in_data = in_img[np.newaxis, :] x = tf.placeholder(tf.float32, shape=[1, None, None, 3],

[FFmpeg-devel] [PATCH 3/6] dnn/native: add native support for 'mul'

2020-04-11 Thread Guo, Yejun
it can be tested with model file generated from above python script: import tensorflow as tf import numpy as np import imageio in_img = imageio.imread('input.jpg') in_img = in_img.astype(np.float32)/255.0 in_data = in_img[np.newaxis, :] x = tf.placeholder(tf.float32, shape=[1, None, None, 3],

[FFmpeg-devel] [PATCH 6/6] dnn-layer-mathbinary-test: add unit test for divide

2020-04-11 Thread Guo, Yejun
Signed-off-by: Guo, Yejun --- tests/dnn/dnn-layer-mathbinary-test.c | 5 + 1 file changed, 5 insertions(+) diff --git a/tests/dnn/dnn-layer-mathbinary-test.c b/tests/dnn/dnn-layer-mathbinary-test.c index 3b0f0c5..f82d15b 100644 --- a/tests/dnn/dnn-layer-mathbinary-test.c +++

[FFmpeg-devel] [PATCH 1/6] dnn/native: add native support for 'add'

2020-04-11 Thread Guo, Yejun
It can be tested with the model file generated with below python script: import tensorflow as tf import numpy as np import imageio in_img = imageio.imread('input.jpg') in_img = in_img.astype(np.float32)/255.0 in_data = in_img[np.newaxis, :] x = tf.placeholder(tf.float32, shape=[1, None, None,

[FFmpeg-devel] [PATCH 2/6] dnn-layer-mathbinary-test: add unit test for add

2020-04-11 Thread Guo, Yejun
Signed-off-by: Guo, Yejun --- tests/dnn/dnn-layer-mathbinary-test.c | 55 --- 1 file changed, 38 insertions(+), 17 deletions(-) diff --git a/tests/dnn/dnn-layer-mathbinary-test.c b/tests/dnn/dnn-layer-mathbinary-test.c index 1243784..fd8037f 100644 ---

[FFmpeg-devel] [PATCH 4/6] dnn-layer-mathbinary-test: add unit test for 'mul'

2020-04-11 Thread Guo, Yejun
Signed-off-by: Guo, Yejun --- tests/dnn/dnn-layer-mathbinary-test.c | 5 + 1 file changed, 5 insertions(+) diff --git a/tests/dnn/dnn-layer-mathbinary-test.c b/tests/dnn/dnn-layer-mathbinary-test.c index fd8037f..3b0f0c5 100644 --- a/tests/dnn/dnn-layer-mathbinary-test.c +++

Re: [FFmpeg-devel] [PATCH 05/10] lavc/libopenh264enc: prompt slice number changing according to cpus

2020-04-11 Thread Anton Khirnov
Quoting Fu, Linjie (2020-04-10 15:49:30) > > From: ffmpeg-devel On Behalf Of > > Anton Khirnov > > Sent: Friday, April 10, 2020 18:23 > > To: FFmpeg development discussions and patches > de...@ffmpeg.org> > > Subject: Re: [FFmpeg-devel] [PATCH 05/10] lavc/libopenh264enc: prompt > > slice number

Re: [FFmpeg-devel] [PATCH] avcodec/bsf: mention that av_bsf_send_packet() returning EAGAIN is not an error

2020-04-11 Thread Anton Khirnov
Quoting James Almer (2020-04-10 17:42:23) > On 4/10/2020 11:07 AM, Derek Buitenhuis wrote: > > On 10/04/2020 00:09, James Almer wrote: > >> EAGAIN is returned when input is provided but can't be consumed. The > >> filtering > >> process is unaffected in this case, and the function will be able to

[FFmpeg-devel] [PATCH] avcodec/adpcm: remove unused shift parameter from adpcm_ima_qt_expand_nibble()

2020-04-11 Thread Zane van Iperen
Signed-off-by: Zane van Iperen --- libavcodec/adpcm.c | 18 +- 1 file changed, 9 insertions(+), 9 deletions(-) diff --git a/libavcodec/adpcm.c b/libavcodec/adpcm.c index e9abddc43c..ee18875579 100644 --- a/libavcodec/adpcm.c +++ b/libavcodec/adpcm.c @@ -348,7 +348,7 @@ static

Re: [FFmpeg-devel] [PATCH 4/4] avcodec.h: split bitstream filters API into its own header

2020-04-11 Thread Anton Khirnov
Quoting James Almer (2020-04-10 20:14:17) > On 4/10/2020 12:42 PM, Anton Khirnov wrote: > > --- > > doc/APIchanges | 3 +- > > libavcodec/Makefile| 1 + > > libavcodec/aac_adtstoasc_bsf.c | 2 +- > > libavcodec/av1_frame_merge_bsf.c

Re: [FFmpeg-devel] [PATCH v2 1/2] avcodec/libaomenc.c: Add a libaom command-line option 'tune'

2020-04-11 Thread James Zern
On Fri, Apr 3, 2020 at 2:07 PM Wang Cao wrote: > > Signed-off-by: Wang Cao > --- > doc/encoders.texi | 9 + > libavcodec/libaomenc.c | 7 +++ > libavcodec/version.h | 2 +- > 3 files changed, 17 insertions(+), 1 deletion(-) > lgtm. I'll apply this soon.

Re: [FFmpeg-devel] [PATCH] libavformat/mov: restore use of mfra time as dts

2020-04-11 Thread Gyan Doshi
On 10-04-2020 09:20 pm, Gyan Doshi wrote: On 10-04-2020 08:04 pm, John Stebbins wrote: On Thu, 2020-04-09 at 10:56 +0530, Gyan Doshi wrote: On 06-04-2020 11:12 pm, John Stebbins wrote: This was inadvertantly removed in 4a9d32baca ---    libavformat/mov.c | 5 +    1 file changed, 5

Re: [FFmpeg-devel] [PATCH 1/2] avfilter/delogo: remove deprecated options

2020-04-11 Thread Gyan Doshi
On 11-04-2020 02:17 am, James Almer wrote: On 4/10/2020 4:30 PM, Gyan Doshi wrote: Deprecated in 2015 in 8bc708fcee1 --- libavfilter/vf_delogo.c | 15 +-- 1 file changed, 1 insertion(+), 14 deletions(-) diff --git a/libavfilter/vf_delogo.c b/libavfilter/vf_delogo.c index

[FFmpeg-devel] [PATCH 1/3] libavcodec/jpeg2000: fix cblk decode error check

2020-04-11 Thread gautamramk
From: Gautam Ramakrishnan bpno becoming negative is not an error. This check has been verified with openjpeg, where the loop ends safely when bpno becomes negative, instead of returning an error. This patch must resolve ticket #5630. --- libavcodec/jpeg2000dec.c | 6 +- 1 file changed, 1

[FFmpeg-devel] [PATCH 2/3] libavcodec/jpeg2000dec.c: fix error in cod marker

2020-04-11 Thread gautamramk
From: Gautam Ramakrishnan This patch fixes an error where the COC marker overrides all data of the SPcod field of the COD marker. It must override only one bit of SPcod field. This now allows p0_08.j2k to be decoded correctly (mentioned in #4679). --- libavcodec/jpeg2000dec.c | 3 +++ 1 file

[FFmpeg-devel] [PATCH 3/3] libavcodec/jpeg2000: fix precinct coordinate calculation

2020-04-11 Thread gautamramk
From: Gautam Ramakrishnan The calculation of precinct boundaries has been fixed. The precinct boundaries were calculated as an offset to the band boundary, but must instead be calculated as an offset from the reslevel. This patch fixes #4669 and #4679. --- libavcodec/jpeg2000.c | 4 ++-- 1 file

Re: [FFmpeg-devel] [PATCH 2/2] avcodec/zerocodec: use init cleanup internal cap

2020-04-11 Thread Vittorio Giovara
On Thu, Apr 9, 2020 at 5:21 AM Paul B Mahol wrote: > Signed-off-by: Paul B Mahol > --- > libavcodec/zerocodec.c | 7 +++ > 1 file changed, 3 insertions(+), 4 deletions(-) > > diff --git a/libavcodec/zerocodec.c b/libavcodec/zerocodec.c > index b0fab91004..1051fdaa45 100644 > ---

Re: [FFmpeg-devel] [PATCH v2 1/2] avcodec/libaomenc.c: Add a libaom command-line option 'tune'

2020-04-11 Thread James Zern
On Fri, Apr 10, 2020 at 10:50 PM James Zern wrote: > > On Fri, Apr 3, 2020 at 2:07 PM Wang Cao wrote: > > > > Signed-off-by: Wang Cao > > --- > > doc/encoders.texi | 9 + > > libavcodec/libaomenc.c | 7 +++ > > libavcodec/version.h | 2 +- > > 3 files changed, 17

Re: [FFmpeg-devel] [PATCH v2 2/2] avcodec/libaomenc.c: Add super-resolution options to libaom wrapper

2020-04-11 Thread James Zern
On Fri, Apr 3, 2020 at 2:10 PM Wang Cao wrote: > > Signed-off-by: Wang Cao > --- > doc/encoders.texi | 39 +++ > libavcodec/libaomenc.c | 47 ++ > libavcodec/version.h | 2 +- > 3 files changed, 87 insertions(+), 1

<    1   2