[FFmpeg-devel] [PATCH 07/10] avcodec/bfi: Remove unused AVCodecContext* from context

2024-03-24 Thread Andreas Rheinhardt
Signed-off-by: Andreas Rheinhardt --- libavcodec/bfi.c | 1 - 1 file changed, 1 deletion(-) diff --git a/libavcodec/bfi.c b/libavcodec/bfi.c index a7dd29a4e8..58158f6eee 100644 --- a/libavcodec/bfi.c +++ b/libavcodec/bfi.c @@ -33,7 +33,6 @@ #include "decode.h" typedef struct BFIContext { -

[FFmpeg-devel] [PATCH 05/10] avcodec/wmaprodec: Explicitly return 0 on success

2024-03-24 Thread Andreas Rheinhardt
Signed-off-by: Andreas Rheinhardt --- libavcodec/wmaprodec.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavcodec/wmaprodec.c b/libavcodec/wmaprodec.c index 2afdcb2b52..a6c4a75632 100644 --- a/libavcodec/wmaprodec.c +++ b/libavcodec/wmaprodec.c @@ -2024,7 +2024,7 @@

[FFmpeg-devel] [PATCH 06/10] avcodec/ratecontrol: Avoid function pointer casts

2024-03-24 Thread Andreas Rheinhardt
It is undefined behaviour to call a function with a different signature for the call than the actual function signature; there are no exceptions for void* and RateControlEntry*. Signed-off-by: Andreas Rheinhardt --- libavcodec/ratecontrol.c | 14 -- 1 file changed, 12 insertions(+),

[FFmpeg-devel] [PATCH 09/10] avcodec/magicyuvenc: Don't call functions twice due to macro

2024-03-24 Thread Andreas Rheinhardt
Signed-off-by: Andreas Rheinhardt --- libavcodec/magicyuvenc.c | 10 +++--- 1 file changed, 7 insertions(+), 3 deletions(-) diff --git a/libavcodec/magicyuvenc.c b/libavcodec/magicyuvenc.c index 3ae1ee2c71..93eabb9f9a 100644 --- a/libavcodec/magicyuvenc.c +++ b/libavcodec/magicyuvenc.c @@

[FFmpeg-devel] [PATCH 08/10] avcodec/mjpegenc: Inline chroma subsampling

2024-03-24 Thread Andreas Rheinhardt
Signed-off-by: Andreas Rheinhardt --- libavcodec/mjpegenc.c | 5 + 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/libavcodec/mjpegenc.c b/libavcodec/mjpegenc.c index 51bce103da..b6de50edce 100644 --- a/libavcodec/mjpegenc.c +++ b/libavcodec/mjpegenc.c @@ -33,7 +33,6 @@

[FFmpeg-devel] [PATCH 10/10] avcodec/profiles: Don't include avcodec.h

2024-03-24 Thread Andreas Rheinhardt
Forgotten in 8238bc0b5e3dba271217b1223a901b3f9713dc6e. Signed-off-by: Andreas Rheinhardt --- libavcodec/profiles.c | 3 ++- libavcodec/profiles.h | 3 ++- 2 files changed, 4 insertions(+), 2 deletions(-) diff --git a/libavcodec/profiles.c b/libavcodec/profiles.c index 5bb8f150e6..052b77926e

Re: [FFmpeg-devel] [RFC] 7.0 blocking issues

2024-03-24 Thread Michael Niedermayer
On Sun, Mar 24, 2024 at 09:35:29PM -0300, James Almer wrote: > On 3/24/2024 9:03 PM, Michael Niedermayer wrote: > > Hi all > > > > Should i wait till all issues marked as blocking 7.0 on trac are fixed > > before branching ? > > > > btw if you click on "VIEW TICKETS" theres a link "{16} Release

[FFmpeg-devel] [PATCH v2] doc: Add libtoch backend option to dnn_processing

2024-03-24 Thread wenbin . chen-at-intel . com
From: Wenbin Chen Signed-off-by: Wenbin Chen --- doc/filters.texi | 12 +++- 1 file changed, 11 insertions(+), 1 deletion(-) diff --git a/doc/filters.texi b/doc/filters.texi index 18f0d1c5a7..bfa8ccec8b 100644 --- a/doc/filters.texi +++ b/doc/filters.texi @@ -12073,11 +12073,21 @@

[FFmpeg-devel] [PATCH 2/2] avformat/iamf_reader: Check len before summing

2024-03-24 Thread Michael Niedermayer
Fixes: integer overflow Fixes: 67275/clusterfuzz-testcase-minimized-ffmpeg_dem_IAMF_fuzzer-5438920751906816 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-by: Michael Niedermayer --- libavformat/iamf_reader.c | 4 ++-- 1 file

[FFmpeg-devel] [PATCH 1/2] avformat/mov: Check edit list for overflow

2024-03-24 Thread Michael Niedermayer
Fixes: 67492/clusterfuzz-testcase-minimized-ffmpeg_dem_MOV_fuzzer-5778297231310848 Fixes: signed integer overflow: 2314885530818453536 + 7782220156096217088 cannot be represented in type 'long' Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg

[FFmpeg-devel] [RFC] 7.0 blocking issues

2024-03-24 Thread Michael Niedermayer
Hi all Should i wait till all issues marked as blocking 7.0 on trac are fixed before branching ? btw if you click on "VIEW TICKETS" theres a link "{16} Release Blocking Issues" ATM there are 2 again after i run into a new regression thx -- Michael GnuPG fingerprint:

Re: [FFmpeg-devel] Fixes #10509

2024-03-24 Thread Marton Balint
On Sun, 24 Mar 2024, Poorva wrote: From 0874a55ad33bb4df2789cbafc5247c0ae3d97e6a Mon Sep 17 00:00:00 2001 From: PoorvaGaikar Date: Sat, 9 Mar 2024 00:27:25 +0530 Subject: [PATCH v2] avfilter/f_select.c: add support for iw and ih constants You should mention the fixed ticket number in the

Re: [FFmpeg-devel] [PATCH] avfilter/af_volumedetect.c: Add 32bit float audio support

2024-03-24 Thread Yiğithan Yiğit
Fixed some bugs that I not realized on previous commits. v2-0001-avfilter-af_volumedetect.c-Add-32bit-float-audio-sup.patch Description: Binary data ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org

Re: [FFmpeg-devel] [PATCH v2] avfilter: propagate colorspace and color_range from buffer filter and between AVFilterLink.

2024-03-24 Thread Damiano Galassi
On Sun, Mar 24, 2024 at 6:53 PM Niklas Haas wrote: > But wait - aren't all filter's lists set to the same reference? Isn't that > the > point of the design? If they share the same format list, they will all > inherit the correct setting (via pick_format). Except for filters like > vf_scale which

[FFmpeg-devel] [PATCH] avutil/hwcontext_qsv: Fix mixed declaration and code

2024-03-24 Thread Andreas Rheinhardt
Signed-off-by: Andreas Rheinhardt --- libavutil/hwcontext_qsv.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/libavutil/hwcontext_qsv.c b/libavutil/hwcontext_qsv.c index e5e043d2d1..c7c7878644 100644 --- a/libavutil/hwcontext_qsv.c +++ b/libavutil/hwcontext_qsv.c @@

Re: [FFmpeg-devel] [PATCH] avformat/dvdvideodec: add explicit inttypes.h include

2024-03-24 Thread Marth64
Will send v2 with fix. I actually prefer it, I wasn't sure if it would be seen the same way. ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email

Re: [FFmpeg-devel] [PATCH 11/31] fftools/ffmpeg_dec: override video SAR with AVCodecParameters value

2024-03-24 Thread Michael Niedermayer
On Wed, Jan 24, 2024 at 09:16:41AM +0100, Anton Khirnov wrote: > Rather than access the AVStream one. > > This is a step towards decoupling Decoder and InputStream. > --- > fftools/ffmpeg_dec.c | 9 +++-- > fftools/ffmpeg_demux.c | 3 +++ > 2 files changed, 10 insertions(+), 2 deletions(-)

Re: [FFmpeg-devel] [PATCH] avformat/mux: Remove check for AVFMT_ALLOW_FLUSH

2024-03-24 Thread Andreas Rheinhardt
Andreas Rheinhardt: > Due to the bump it is now certain that all devices > that support flushing have the proper internal flag set. > (Notice that the check for LIBAVFORMAT_VERSION was wrong.) > > Signed-off-by: Andreas Rheinhardt > --- > libavformat/mux.c | 6 -- > 1 file changed, 6

Re: [FFmpeg-devel] [PATCH 1/2] avcodec/mpegutils: Avoid allocations when using AVBPrint

2024-03-24 Thread Andreas Rheinhardt
Andreas Rheinhardt: > Signed-off-by: Andreas Rheinhardt > --- > libavcodec/mpegutils.c | 21 + > 1 file changed, 5 insertions(+), 16 deletions(-) > > diff --git a/libavcodec/mpegutils.c b/libavcodec/mpegutils.c > index fc3e270631..7f499b3d0f 100644 > ---

Re: [FFmpeg-devel] [PATCH 01/15] configure: Make hls demuxer select AAC, AC3 and EAC3 demuxers

2024-03-24 Thread Andreas Rheinhardt
Andreas Rheinhardt: > The code relies on their presence and would presumably crash > when retrieving in_fmt->name if an encrypted stream with a codec id > without demuxer were encountered. > > Signed-off-by: Andreas Rheinhardt > --- > configure | 2 +- > 1 file changed, 1 insertion(+), 1

Re: [FFmpeg-devel] [PATCH 1/2] avformat/file: Constify android content protocol

2024-03-24 Thread Andreas Rheinhardt
Andreas Rheinhardt: > (The discrepancy between the definition and the declaration > in protocols.c is actually UB.) > > Signed-off-by: Andreas Rheinhardt > --- > This and the next patch have not been tested (apart from "it compiles > when the android content protocol is disabled"). > >

Re: [FFmpeg-devel] [RFC] clarifying the TC conflict of interest rule

2024-03-24 Thread Michael Niedermayer
Hi Anton On Sun, Mar 24, 2024 at 12:40:52PM +0100, Anton Khirnov wrote: > Quoting Michael Niedermayer (2024-03-24 03:21:50) > > On Fri, Mar 22, 2024 at 01:52:55PM +0100, Anton Khirnov wrote: > > > Michael, > > > > > following up on the previous discussion in this thread - if you, > > >

Re: [FFmpeg-devel] [RFC] 7.0 blocking issues

2024-03-24 Thread James Almer
On 3/24/2024 9:03 PM, Michael Niedermayer wrote: Hi all Should i wait till all issues marked as blocking 7.0 on trac are fixed before branching ? btw if you click on "VIEW TICKETS" theres a link "{16} Release Blocking Issues" ATM there are 2 again after i run into a new regression Ticket

[FFmpeg-devel] [PATCH 02/10] avutil/fifo, file: Remove unused headers

2024-03-24 Thread Andreas Rheinhardt
Forgotten in 4105899245d79976b4a1a230455066417f3f194d, 4c92fc02f850f4f813e8cef8f8f8ed37d498e090. Signed-off-by: Andreas Rheinhardt --- libavutil/fifo.h | 4 libavutil/file.h | 1 - 2 files changed, 5 deletions(-) diff --git a/libavutil/fifo.h b/libavutil/fifo.h index

[FFmpeg-devel] [PATCH 04/10] fftools/ffmpeg_sched: Explicitly return 0 on sch_enc_send() success

2024-03-24 Thread Andreas Rheinhardt
Do not return the return value of the last enc_send_to_dst() call, as this would treat the last call differently from the earlier calls; furthermore, sch_enc_send() explicitly documents to always return 0 on success. Signed-off-by: Andreas Rheinhardt --- fftools/ffmpeg_sched.c | 6 ++ 1

[FFmpeg-devel] [PATCH 01/10] doc/examples: Always use <> includes

2024-03-24 Thread Andreas Rheinhardt
Signed-off-by: Andreas Rheinhardt --- doc/examples/filter_audio.c | 18 +- doc/examples/qsv_decode.c| 16 doc/examples/transcode_aac.c | 20 ++-- 3 files changed, 27 insertions(+), 27 deletions(-) diff --git a/doc/examples/filter_audio.c

[FFmpeg-devel] [PATCH] avcodec/x86/h264_idct: Fix incorrect xmm spilling on win64

2024-03-24 Thread Henrik Gramner via ffmpeg-devel
Broken in afa471d0efed1df5dca6eeeb2fcdd211ae4cad4e. It just happened to work before due to x86inc.asm previously performing XMM spills in INIT_MMX mode which was more of a bug than an intentional feature. x86_h264_idct_spill_xmm.patch Description: Binary data

[FFmpeg-devel] [PATCH v2] avfilter: propagate colorspace and color_range from buffer filter and between AVFilterLink.

2024-03-24 Thread Damiano Galassi
There two new fields were never sent down the filter chain, and no filter after the first had colorspace and color_range set, causing breakage in zscale and possible other filters. --- libavfilter/avfilter.c | 4 libavfilter/buffersrc.c | 2 ++ 2 files changed, 6 insertions(+) diff --git

Re: [FFmpeg-devel] [PATCH v2 08/12] lavc/frame_thread_encoder: avoid assigning a whole AVCodecContext

2024-03-24 Thread Anton Khirnov
Quoting Andreas Rheinhardt (2024-03-23 15:11:59) > 1. The earlier code would just work in case the user used a smaller > number of elements for the matrices if these matrices were not used at > all (which happens for the majority of encoders). This is no longer true > with this patch. So? --

[FFmpeg-devel] [PATCH v3 08/12] lavc/frame_thread_encoder: avoid assigning a whole AVCodecContext

2024-03-24 Thread Anton Khirnov
It is highly unsafe, as AVCodecContext contains many allocated fields. Everything needed by worked threads should be covered by * routing through AVCodecParameters * av_opt_copy() * copying quantisation matrices manually avcodec_free_context() can now be used for per-thread contexts. ---

Re: [FFmpeg-devel] [PATCH v2 08/12] lavc/frame_thread_encoder: avoid assigning a whole AVCodecContext

2024-03-24 Thread Anton Khirnov
Quoting Andreas Rheinhardt (2024-03-24 11:19:19) > Anton Khirnov: > > Quoting Andreas Rheinhardt (2024-03-23 15:11:59) > >> 1. The earlier code would just work in case the user used a smaller > >> number of elements for the matrices if these matrices were not used at > >> all (which happens for

Re: [FFmpeg-devel] [PATCH v2 08/12] lavc/frame_thread_encoder: avoid assigning a whole AVCodecContext

2024-03-24 Thread Anton Khirnov
Quoting Andreas Rheinhardt (2024-03-24 12:10:24) > Anton Khirnov: > > Quoting Andreas Rheinhardt (2024-03-24 11:19:19) > >> Anton Khirnov: > >>> Quoting Andreas Rheinhardt (2024-03-23 15:11:59) > 1. The earlier code would just work in case the user used a smaller > number of elements for

Re: [FFmpeg-devel] [PATCH v3 08/12] lavc/frame_thread_encoder: avoid assigning a whole AVCodecContext

2024-03-24 Thread Anton Khirnov
Quoting Andreas Rheinhardt (2024-03-24 12:25:53) > Anton Khirnov: > > It is highly unsafe, as AVCodecContext contains many allocated fields. > > Everything needed by worked threads should be covered by > > * routing through AVCodecParameters > > * av_opt_copy() > > * copying quantisation matrices

Re: [FFmpeg-devel] [PATCH v2] avfilter: propagate colorspace and color_range from buffer filter and between AVFilterLink.

2024-03-24 Thread Niklas Haas
On Sun, 24 Mar 2024 13:23:28 +0100 Niklas Haas wrote: > diff --git a/tests/ref/fate/rgb24-mkv b/tests/ref/fate/rgb24-mkv > index 1cbed136dde..99234f10523 100644 > --- a/tests/ref/fate/rgb24-mkv > +++ b/tests/ref/fate/rgb24-mkv > @@ -1,5 +1,5 @@ > -7d767e8238c674ecfa80458cb281c09e

Re: [FFmpeg-devel] [PATCH v2 08/12] lavc/frame_thread_encoder: avoid assigning a whole AVCodecContext

2024-03-24 Thread Andreas Rheinhardt
Anton Khirnov: > Quoting Andreas Rheinhardt (2024-03-23 15:11:59) >> 1. The earlier code would just work in case the user used a smaller >> number of elements for the matrices if these matrices were not used at >> all (which happens for the majority of encoders). This is no longer true >> with

Re: [FFmpeg-devel] [PATCH v2 08/12] lavc/frame_thread_encoder: avoid assigning a whole AVCodecContext

2024-03-24 Thread Andreas Rheinhardt
Anton Khirnov: > Quoting Andreas Rheinhardt (2024-03-24 11:19:19) >> Anton Khirnov: >>> Quoting Andreas Rheinhardt (2024-03-23 15:11:59) 1. The earlier code would just work in case the user used a smaller number of elements for the matrices if these matrices were not used at all

Re: [FFmpeg-devel] [PATCH v3 08/12] lavc/frame_thread_encoder: avoid assigning a whole AVCodecContext

2024-03-24 Thread Andreas Rheinhardt
Anton Khirnov: > It is highly unsafe, as AVCodecContext contains many allocated fields. > Everything needed by worked threads should be covered by > * routing through AVCodecParameters > * av_opt_copy() > * copying quantisation matrices manually > > avcodec_free_context() can now be used for

Re: [FFmpeg-devel] [RFC] clarifying the TC conflict of interest rule

2024-03-24 Thread Anton Khirnov
Quoting Michael Niedermayer (2024-03-24 03:21:50) > On Fri, Mar 22, 2024 at 01:52:55PM +0100, Anton Khirnov wrote: > > Michael, > > > following up on the previous discussion in this thread - if you, > > personally, would like to vote for a different option than those > > suggested so far, please

Re: [FFmpeg-devel] [PATCH v2] avfilter: propagate colorspace and color_range from buffer filter and between AVFilterLink.

2024-03-24 Thread Niklas Haas
On Sun, 24 Mar 2024 10:26:35 +0100 Damiano Galassi wrote: > There two new fields were never sent down the filter chain, > and no filter after the first had colorspace and color_range set, > causing breakage in zscale and possible other filters. > --- > libavfilter/avfilter.c | 4 >

Re: [FFmpeg-devel] [PATCH v2] avfilter: propagate colorspace and color_range from buffer filter and between AVFilterLink.

2024-03-24 Thread Niklas Haas
On Sun, 24 Mar 2024 13:49:04 +0100 Damiano Galassi wrote: > AVFilterLink colorspace and color_range are first set in > avfiltergraph.c pick_format(), > so in ff_filter_config_links() they will never be AVCOL_SPC_NONE or > AVCOL_SPC_NONE. Wait, now I'm confused what this patch even accomplishes

Re: [FFmpeg-devel] [PATCH] avcodec, avformat/ffjni: fix duplicate JNI symbols

2024-03-24 Thread Matthieu Bouron
On Sun, Mar 24, 2024 at 01:17:41AM -0400, Leo Izen wrote: > Use SHLIBOBJS and STLIBOBJS in the Makefiles for avcodec and avformat, > and add a stub ffjni.c to libavformat, which allows the symbols to be > duplicated for shared builds but not static builds. > > Signed-off-by: Leo Izen > --- >

[FFmpeg-devel] [PATCH 1/2] fftools/ffmpeg_filter: remove unused struct from InputFilterPriv

2024-03-24 Thread James Almer
It's already in InputFilterOptions. Signed-off-by: James Almer --- fftools/ffmpeg_filter.c | 16 1 file changed, 16 deletions(-) diff --git a/fftools/ffmpeg_filter.c b/fftools/ffmpeg_filter.c index 3d88482d07..171e47be9e 100644 --- a/fftools/ffmpeg_filter.c +++

[FFmpeg-devel] [PATCH 2/2] fftools/ffmpeg_filter: remove prototype for non existent function

2024-03-24 Thread James Almer
Signed-off-by: James Almer --- fftools/ffmpeg.h | 7 --- 1 file changed, 7 deletions(-) diff --git a/fftools/ffmpeg.h b/fftools/ffmpeg.h index 7454089c2d..6394cca1e7 100644 --- a/fftools/ffmpeg.h +++ b/fftools/ffmpeg.h @@ -698,13 +698,6 @@ const FrameData *frame_data_c(AVFrame *frame);

Re: [FFmpeg-devel] [PATCH v2] avfilter: propagate colorspace and color_range from buffer filter and between AVFilterLink.

2024-03-24 Thread Damiano Galassi
On Sun, Mar 24, 2024 at 2:14 PM Niklas Haas wrote: > On Sun, 24 Mar 2024 13:49:04 +0100 Damiano Galassi > wrote: > > AVFilterLink colorspace and color_range are first set in > > avfiltergraph.c pick_format(), > > so in ff_filter_config_links() they will never be AVCOL_SPC_NONE or > >

Re: [FFmpeg-devel] [PATCH] x86: Update x86inc.asm

2024-03-24 Thread Henrik Gramner via ffmpeg-devel
On Tue, Mar 19, 2024 at 11:20 AM Henrik Gramner wrote: > > Will push in a few days if there are no comments. Pushed. ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link

Re: [FFmpeg-devel] Fixes #10509

2024-03-24 Thread Poorva
> On Mon, Mar 18, 2024 at 10:34 PM Poorva <2003gaikarpoo...@gmail.com> wrote: > > > > > On Sun, Mar 17, 2024 at 12:26 AM Marton Balint wrote: > > > > > > > > On Sun, 17 Mar 2024, Poorva wrote: > > > > > On Mon, Mar 11, 2024 at 1:10 AM Leo Izen wrote: > > >> > > >> On 3/9/24 15:49, Poorva wrote:

Re: [FFmpeg-devel] [PATCH] libavformat\file:Fix duplicate JNI symbols

2024-03-24 Thread Zhao Zhili
On 2024/3/24 21:23, Andreas Rheinhardt wrote: ad...@shaoxia.xyz: From: 联盟少侠 The errors indicate that there are multiple definitions of several JNI (Java Native Interface) symbols in the FFmpeg library. Specifically, the linker ld.lld has found duplicate definitions for the following

Re: [FFmpeg-devel] [PATCH] [v4] avcodec/vaapi_encode: add customized surface alignment

2024-03-24 Thread Mark Thompson
On 21/03/2024 17:02, Araz Iusubov wrote: This commit fixes issues with AMD HEVC encoding. By default AMD hevc encoder asks for the alignment 64x16, while FFMPEG VAAPI has 16x16. Adding support for customized surface size from VASurfaceAttribAlignmentSize in VAAPI version 1.21.0 Signed-off-by:

Re: [FFmpeg-devel] [PATCH] avformat/dvdvideodec: add explicit inttypes.h include

2024-03-24 Thread Leo Izen
On 3/23/24 22:24, Marth64 wrote: Since log statements printing int64 were made portable in 4464b7eeb194e98ac115f18d2b6be67361407c8a, let us include inttypes.h explicitly (as it is unclear where PRId64 and such are coming from now). Reported-by: Traneptora Signed-off-by: Marth64 ---

Re: [FFmpeg-devel] [PATCH v2] avfilter: propagate colorspace and color_range from buffer filter and between AVFilterLink.

2024-03-24 Thread Niklas Haas
On Sun, 24 Mar 2024 14:47:27 +0100 Damiano Galassi wrote: > On Sun, Mar 24, 2024 at 2:14 PM Niklas Haas wrote: > > > On Sun, 24 Mar 2024 13:49:04 +0100 Damiano Galassi > > wrote: > > > AVFilterLink colorspace and color_range are first set in > > > avfiltergraph.c pick_format(), > > > so in