Re: [FFmpeg-devel] [PATCH] avcodec/vvcdec: frame_context_setup, set fc->ref to NULL

2024-02-13 Thread Nuo Mi
On Tue, Feb 13, 2024 at 6:39 PM Frank Plowman wrote: > On 13/02/2024 02:30, Nuo Mi wrote: > > fc->ref points to an old VVCFrame, which cannot be used after > frame_context_setup. > > This prevents crashes in decode_nal_units-->ff_vvc_report_frame_finished. > > > > Signed-off-by: Frank Plowman >

Re: [FFmpeg-devel] [PATCH v5] lavc/libvpxenc: add screen-content-mode option

2024-02-13 Thread James Zern via ffmpeg-devel
On Mon, Feb 12, 2024 at 10:34 PM Dariusz Marcinkiewicz via ffmpeg-devel wrote: > > This exposes VP8E_SET_SCREEN_CONTENT_MODE option from libvpx. > > Co-authored-by: Erik Språng > Signed-off-by: Dariusz Marcinkiewicz > --- > doc/encoders.texi | 6 ++ > libavcodec/libvpxenc.c | 13

Re: [FFmpeg-devel] [PATCH] vvcdec: Mark as experimental

2024-02-13 Thread Nuo Mi
> > >>> >>> If there are no objections, I'll push it tomorrow. > thank you, Kieran and Paul. > Hi Kieran, Patchwork didn't get your patch. I've checked the fate status locally, and it indicates that "make fate-vvc" will fail. Could you please send a new one to the patchwork? Thank you.

Re: [FFmpeg-devel] [PATCH 1/9] libavutil: add hwcontext_amf.

2024-02-13 Thread James Almer
On 2/13/2024 10:55 PM, Dmitrii Ovchinnikov wrote: +const FormatMap format_map[] = +{ +{ AV_PIX_FMT_NONE, AMF_SURFACE_UNKNOWN }, +{ AV_PIX_FMT_NV12, AMF_SURFACE_NV12 }, +{ AV_PIX_FMT_BGR0, AMF_SURFACE_BGRA }, +{ AV_PIX_FMT_RGB0, AMF_SURFACE_RGBA

Re: [FFmpeg-devel] [PATCH v4] lavc/libvpxenc: add screen-content-mode option

2024-02-13 Thread Dariusz Marcinkiewicz via ffmpeg-devel
Hello. On Tue, Feb 13, 2024 at 12:12 AM James Zern wrote: > [...] > > +@item screen-content-mode > > +Screen content mode, one of: off (0), screen (1), screen with more > > aggressive rate control (2). > > + > > Move this above 'VP9-specific options' and add a section for VP8. Also > reword

[FFmpeg-devel] [PATCH 9/9] doc/filters: Add documentation for AMF filters

2024-02-13 Thread Dmitrii Ovchinnikov
From: Evgeny Pavlov Signed-off-by: Evgeny Pavlov --- doc/filters.texi | 238 +++ 1 file changed, 238 insertions(+) diff --git a/doc/filters.texi b/doc/filters.texi index e0436a5755..4c5b9c1f63 100644 --- a/doc/filters.texi +++ b/doc/filters.texi @@

[FFmpeg-devel] [PATCH 8/9] avfilter/scale_amf: Add AMF HW scaler & color converter

2024-02-13 Thread Dmitrii Ovchinnikov
From: Evgeny Pavlov This commit adds two AMF filters: scale_amf & scale_amf_hq. Both filters are using AMF hardware acceleration. scale_amf supports simple scaling algorithms & color conversion. scale_amf_hq supports advanced scaling algorithms & might be used for upscaling only. Signed-off-by:

[FFmpeg-devel] [PATCH 7/9] libavcodec/amfenc: redesign to use hwcontext_amf.

2024-02-13 Thread Dmitrii Ovchinnikov
Co-authored-by: Evgeny Pavlov --- libavcodec/amfenc.c | 560 libavcodec/amfenc.h | 23 +- 2 files changed, 158 insertions(+), 425 deletions(-) diff --git a/libavcodec/amfenc.c b/libavcodec/amfenc.c index f1b76bd6aa..e6e5302cca 100644 ---

[FFmpeg-devel] [PATCH 6/9] avcodec/amfenc: add smart access video option

2024-02-13 Thread Dmitrii Ovchinnikov
From: Evgeny Pavlov This commit adds option for enabling SmartAccess Video (SAV) in AMF encoders. SAV is an AMD hardware-specific feature which enables the parallelization of encode and decode streams across multiple Video Codec Engine (VCN) hardware instances. Signed-off-by: Evgeny Pavlov ---

[FFmpeg-devel] [PATCH 5/9] avcodec/amfenc: add 10 bit encoding in av1_amf

2024-02-13 Thread Dmitrii Ovchinnikov
From: Evgeny Pavlov v2: refactored after review Signed-off-by: Evgeny Pavlov Co-authored-by: Dmitrii Ovchinnikov --- libavcodec/amfenc.c | 2 ++ libavcodec/amfenc_av1.c | 22 ++ 2 files changed, 24 insertions(+) diff --git a/libavcodec/amfenc.c b/libavcodec/amfenc.c

[FFmpeg-devel] [PATCH 4/9] avcodec/amfenc: HDR metadata.

2024-02-13 Thread Dmitrii Ovchinnikov
From: nyanmisaka v2: fixes for indentation --- libavcodec/amfenc.c | 83 + 1 file changed, 83 insertions(+) diff --git a/libavcodec/amfenc.c b/libavcodec/amfenc.c index 0bd15dd812..068bb53002 100644 --- a/libavcodec/amfenc.c +++ b/libavcodec/amfenc.c

[FFmpeg-devel] [PATCH 3/9] avcodec/amfenc: Fixes the color information in the output.

2024-02-13 Thread Dmitrii Ovchinnikov
From: Michael Fabian 'Xaymar' Dirks added 10 bit support for amf hevc. before: command - ffmpeg.exe -hide_banner -y -hwaccel d3d11va -hwaccel_output_format d3d11 -i test_10bit_file.mkv -an -c:v h264_amf res.dx11_hw_h264.mkv output - Format of input frames context (p010le) is not supported by

[FFmpeg-devel] [PATCH 2/9] libavcodec: add amfdec.

2024-02-13 Thread Dmitrii Ovchinnikov
From: Evgeny Pavlov Added AMF based h264, hevc, av1 decoders. Co-authored-by: Dmitrii Ovchinnikov --- libavcodec/Makefile | 4 +- libavcodec/allcodecs.c | 3 + libavcodec/amfdec.c | 667 libavcodec/amfdec.h | 75 +

[FFmpeg-devel] [PATCH 1/9] libavutil: add hwcontext_amf.

2024-02-13 Thread Dmitrii Ovchinnikov
Adds hwcontext_amf, which allows to use shared AMF context for the encoder, decoder and AMF-based filters, without copy to the host memory. It will also allow you to use some optimizations in the interaction of components (for example, SAV) and make a more manageable and optimal setup for using

Re: [FFmpeg-devel] [PATCH] avcodec/hevcdsp: Offset ff_hevc_.pel_filters to simplify addressing

2024-02-13 Thread James Almer
On 2/12/2024 11:54 PM, Nuo Mi wrote: On Sun, Feb 11, 2024 at 4:21 PM Andreas Rheinhardt < andreas.rheinha...@outlook.com> wrote: Besides simplifying address computations (it saves 432B of .text in hevcdsp.o alone here) it also fixes undefined behaviour that occurs if mx or my are 0 (happens

[FFmpeg-devel] [PATCH 7/7] avcodec/mediacodec_wrapper: remove unnecessary NULL checks before calling Delete{Global, Local}Ref()

2024-02-13 Thread Matthieu Bouron
Delete{Global,Local}Ref already handle NULL. --- libavcodec/mediacodec_wrapper.c | 189 1 file changed, 47 insertions(+), 142 deletions(-) diff --git a/libavcodec/mediacodec_wrapper.c b/libavcodec/mediacodec_wrapper.c index 536b5b8e81..19d63e2ba0 100644 ---

[FFmpeg-devel] [PATCH 5/7] avutil/jni: remove unnecessary NULL checks before calling DeleteLocalRef()

2024-02-13 Thread Matthieu Bouron
Delete{Global,Local}Ref() already handle NULL. --- libavutil/jniutils.c | 14 +++--- 1 file changed, 3 insertions(+), 11 deletions(-) diff --git a/libavutil/jniutils.c b/libavutil/jniutils.c index 89623af3f8..beedf24c0d 100644 --- a/libavutil/jniutils.c +++ b/libavutil/jniutils.c @@

[FFmpeg-devel] [PATCH 6/7] avcodec/mediacodec_wrapper: use an OFFSET() macro where relevant

2024-02-13 Thread Matthieu Bouron
Reduces a bit the horizontal spacing. --- libavcodec/mediacodec_wrapper.c | 138 +--- 1 file changed, 72 insertions(+), 66 deletions(-) diff --git a/libavcodec/mediacodec_wrapper.c b/libavcodec/mediacodec_wrapper.c index bc3eb0a80d..536b5b8e81 100644 ---

[FFmpeg-devel] [PATCH 4/7] avutil/jni: use size_t to store structure offsets

2024-02-13 Thread Matthieu Bouron
--- libavutil/jniutils.h | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/libavutil/jniutils.h b/libavutil/jniutils.h index 2be401c974..01f3acb88d 100644 --- a/libavutil/jniutils.h +++ b/libavutil/jniutils.h @@ -24,6 +24,7 @@ #define AVUTIL_JNIUTILS_H #include +#include

[FFmpeg-devel] [PATCH 3/7] avformat: add Android content resolver protocol support

2024-02-13 Thread Matthieu Bouron
Handles Android content-uri starting with content://. --- configure | 2 + doc/APIchanges | 3 + libavformat/Makefile| 1 + libavformat/file.c | 157 libavformat/protocols.c | 1 + 5 files changed, 164 insertions(+)

[FFmpeg-devel] [PATCH 2/7] avutil: add av_jni_{get, set}_android_app_ctx helper

2024-02-13 Thread Matthieu Bouron
This will allow users to pass the Android ApplicationContext which is mandatory to retrieve the ContentResolver responsible to resolve/open Android content-uri. --- libavutil/jni.c | 28 libavutil/jni.h | 17 + 2 files changed, 45 insertions(+) diff

[FFmpeg-devel] [PATCH 1/7] avcodec: move ffjni to avutil/jniutils

2024-02-13 Thread Matthieu Bouron
This will allow to use the jni utils in libavformat. This will be mostly useful to add Android content-uri support. This deprecates avcodec/jni.h functions in favor of the ones from avutil/jni.h. --- doc/APIchanges | 6 + libavcodec/Makefile|

[FFmpeg-devel] Add protocol for Android content providers

2024-02-13 Thread Matthieu Bouron
Hi, On Android, content providers are used for accessing files through shared mechanisms. One typical case would be an app willing to open a video from Google Photos, gallery apps, TikTok, Instagram or some other providers. A content URI looks something like "content://authority/path/id", see:

Re: [FFmpeg-devel] [PATCH v2] libavfi/dnn: add LibTorch as one of DNN backend

2024-02-13 Thread Jean-Baptiste Kempf
Hello, On Fri, 2 Feb 2024, at 08:26, wenbin.chen-at-intel@ffmpeg.org wrote: > +static void infer_completion_callback(void *args) { > +THRequestItem *request = (THRequestItem*)args; > +LastLevelTaskItem *lltask = request->lltask; > +TaskItem *task = lltask->task; > +DNNData

[FFmpeg-devel] [PATCH 3/3] avcodec/pngenc: write eXIf chunks

2024-02-13 Thread Leo Izen
Write EXIF metadata exposed AV_FRAME_DATA_EXIF as an eXIf chunk to PNG files, if present. Signed-off-by: Leo Izen --- libavcodec/pngenc.c | 4 1 file changed, 4 insertions(+) diff --git a/libavcodec/pngenc.c b/libavcodec/pngenc.c index 50689cb50c..a302c879da 100644 ---

[FFmpeg-devel] [PATCH 2/3] avcodec/pngdec: parse eXIf chunk

2024-02-13 Thread Leo Izen
Add support to parse eXIf chunks using the new EXIF framework. Signed-off-by: Leo Izen --- libavcodec/pngdec.c | 35 +++ 1 file changed, 35 insertions(+) diff --git a/libavcodec/pngdec.c b/libavcodec/pngdec.c index 026da30c25..e7951d1802 100644 ---

[FFmpeg-devel] [PATCH 1/3] various: change EXIF metadata into AVFrameSideData

2024-02-13 Thread Leo Izen
This patch centralizes much of the EXIF parsing and handling code for libavcodec, and delegates its own AVFrameSideData type to containing the buffer that holds EXIF metadata. This patch also adds exposes the exif parsing routing so it can be called by ffprobe, and updates the corresponding FATE

[FFmpeg-devel] [PATCH 0/3] [RFC] EXIF overhaul

2024-02-13 Thread Leo Izen
A few notes: - This includes an avpriv_ removal, so it won't be able to be merged until the ABI is bumped. Alternatively, I could add that avipriv_ back in as a wrapper around the actual API so it's not a blocker, and then we can remove it when the time comes to bump the ABI. - MakerNote

Re: [FFmpeg-devel] [PATCH 2/5] avutil/channel_layout: add AV_CHANNEL_ORDER_NB

2024-02-13 Thread Marton Balint
On Tue, 13 Feb 2024, James Almer wrote: On 2/12/2024 6:15 PM, Marton Balint wrote: Signed-off-by: Marton Balint --- libavutil/channel_layout.h | 4 1 file changed, 4 insertions(+) diff --git a/libavutil/channel_layout.h b/libavutil/channel_layout.h index

Re: [FFmpeg-devel] [TC] Decision on FF_INTERNAL_FIELDS in libavfilter

2024-02-13 Thread Nicolas George
Rémi Denis-Courmont (12024-02-13): > Speaking as an elected member of another OSS project's TC, I believe > that the experienced adult developers on the FFmpeg TC are perfectly > capable of reading mailing archives and Trac comments as necessary. In > fact, I think it is preferable that they stick

Re: [FFmpeg-devel] [TC] Decision on FF_INTERNAL_FIELDS in libavfilter

2024-02-13 Thread Rémi Denis-Courmont
Hi, Le 13 février 2024 18:22:46 GMT+02:00, Nicolas George a écrit  : >Martin Storsjo (12024-02-13): >> The main arguments raised were about API consistency, prevention of >> accidental inclusions, as well as explicitness in marking a field as >> public or private. > >Too bad the committee

[FFmpeg-devel] [PATCH] avutil/channel_layout: print known layout names in custom layout

2024-02-13 Thread James Almer
If a custom layout is equivalent to a native one, check if it matches one of the known layout names and print that instead. Signed-off-by: James Almer --- Should be applied after the patch this one is a reply to. libavutil/channel_layout.c| 68 +--

Re: [FFmpeg-devel] [PATCH 32/35] avfilter/af_hdcd: Drop a redundant log

2024-02-13 Thread Andreas Rheinhardt
Andreas Rheinhardt: > avfilter_insert_filter() already reports (also with AV_LOG_VERBOSE) > when a filter is auto-inserted. > > Signed-off-by: Andreas Rheinhardt > --- > Can be applied at any time. > > libavfilter/af_hdcd.c | 3 --- > 1 file changed, 3 deletions(-) > > diff --git

Re: [FFmpeg-devel] [PATCH 2/5] avutil/channel_layout: add AV_CHANNEL_ORDER_NB

2024-02-13 Thread James Almer
On 2/12/2024 6:15 PM, Marton Balint wrote: Signed-off-by: Marton Balint --- libavutil/channel_layout.h | 4 1 file changed, 4 insertions(+) diff --git a/libavutil/channel_layout.h b/libavutil/channel_layout.h index b8bff6f365..db0c005e87 100644 --- a/libavutil/channel_layout.h +++

Re: [FFmpeg-devel] [PATCH v2 1/2] avcodec/s302m: enable non-PCM decoding

2024-02-13 Thread Gyan Doshi
On 2024-01-27 04:08 pm, Gyan Doshi wrote: Set up framework for non-PCM decoding in-place and add support for Dolby-E decoding. Useful for direct transcoding of non-PCM audio in live inputs. Plan to push in 3 days, barring objections. Regards, Gyan --- configure | 1 +

Re: [FFmpeg-devel] [TC] Decision on FF_INTERNAL_FIELDS in libavfilter

2024-02-13 Thread Nicolas George
Martin Storsjo (12024-02-13): > The main arguments raised were about API consistency, prevention of > accidental inclusions, as well as explicitness in marking a field as > public or private. Too bad the committee neglected to ask for the arguments of the people who opposed this. Like having a

[FFmpeg-devel] [TC] Decision on FF_INTERNAL_FIELDS in libavfilter

2024-02-13 Thread FFmpeg Technical Committee
Hi, Last year, Anton raised the conflict on his patch "lavfi: get rid of FF_INTERNAL_FIELDS", https://lists.ffmpeg.org//pipermail/ffmpeg-devel/2023-January/306102.html, to the TC to decide on. At the time, the TC did not come to any conclusion on the matter. Recently, Anton raised the

Re: [FFmpeg-devel] [FFmpeg-cvslog] lavf/assenc: normalize line endings to \n

2024-02-13 Thread Martin Storsjö
On Tue, 13 Feb 2024, Ridley Combs wrote: It looks like checkout has different behavior from reset, and fate uses a hard reset. To test, I committed the change adding tests/ref/** -text, unix2dos'd tests/ref/fate/sub-scc, then ran git -c core.autocrlf=true reset --quiet --hard; this dos2unix'd

Re: [FFmpeg-devel] [PATCH] fate/subtitles: Ignore line endings for sub-scc test

2024-02-13 Thread Martin Storsjö via ffmpeg-devel
On Tue, 13 Feb 2024, Andreas Rheinhardt wrote: Since 7bf1b9b35769b37684dd2f18a54f01d852a540c8, the test produces ordinary \n, yet this is not what the reference file used for the most time, leading to test failures. Signed-off-by: Andreas Rheinhardt --- tests/fate/subtitles.mak | 1 + 1 file

Re: [FFmpeg-devel] [PATCH] avformat/matroska: Add support for A_ATRAC/AT1

2024-02-13 Thread Andreas Rheinhardt
asivery via ffmpeg-devel: > I've attached the updated patch. Both new entries are now placed in an > alphabetically correct way in their appropriate lists. > Applied. - Andreas ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org

Re: [FFmpeg-devel] [PATCH] avcodec/avcodec: don't print coded dimensions if not set

2024-02-13 Thread James Almer
On 2/10/2024 2:39 PM, James Almer wrote: The avctx passed to avcodec_string() may have unset coded dimensions, as is the case when called by av_dump_format() where the streams had all the needed information at the container level, and as such no frames were decoded internally. Signed-off-by:

Re: [FFmpeg-devel] [FFmpeg-cvslog] lavf/assenc: normalize line endings to \n

2024-02-13 Thread Martin Storsjö
On Tue, 13 Feb 2024, Ridley Combs wrote: It looks like checkout has different behavior from reset, and fate uses a hard reset. To test, I committed the change adding tests/ref/** -text, unix2dos'd tests/ref/fate/sub-scc, then ran git -c core.autocrlf=true reset --quiet --hard; this dos2unix'd

[FFmpeg-devel] [PATCH] fate/subtitles: Ignore line endings for sub-scc test

2024-02-13 Thread Andreas Rheinhardt
Since 7bf1b9b35769b37684dd2f18a54f01d852a540c8, the test produces ordinary \n, yet this is not what the reference file used for the most time, leading to test failures. Signed-off-by: Andreas Rheinhardt --- tests/fate/subtitles.mak | 1 + 1 file changed, 1 insertion(+) diff --git

[FFmpeg-devel] [PATCH] avformat/dump: Fix use of undeclared variables

2024-02-13 Thread Andreas Rheinhardt
Broken in ec2036454bcdc6c12382961d4ab539c2f9b70ec8. Signed-off-by: Andreas Rheinhardt --- libavformat/dump.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/libavformat/dump.c b/libavformat/dump.c index 9bf1695d96..42b1909bd7 100644 --- a/libavformat/dump.c +++

Re: [FFmpeg-devel] [FFmpeg-cvslog] lavf/assenc: normalize line endings to \n

2024-02-13 Thread Ridley Combs via ffmpeg-devel
> On Feb 13, 2024, at 04:33, Martin Storsjö wrote: > > On Tue, 13 Feb 2024, Ridley Combs via ffmpeg-devel wrote: > >>> On Feb 13, 2024, at 01:28, Anton Khirnov wrote: >>> Quoting Martin Storsjö (2024-02-12 12:31:29) On Mon, 12 Feb 2024, Hendrik Leppkes wrote: > On Mon, Feb 12, 2024

Re: [FFmpeg-devel] [FFmpeg-cvslog] lavf/assenc: normalize line endings to \n

2024-02-13 Thread Martin Storsjö
On Tue, 13 Feb 2024, Ridley Combs via ffmpeg-devel wrote: On Feb 13, 2024, at 01:28, Anton Khirnov wrote: Quoting Martin Storsjö (2024-02-12 12:31:29) On Mon, 12 Feb 2024, Hendrik Leppkes wrote: On Mon, Feb 12, 2024 at 11:22 AM Martin Storsjö wrote: diff --git a/.gitattributes

[FFmpeg-devel] [PATCH] avcodec/x86/simple_idct: Empty MMX state in ff_simple_idct_mmx

2024-02-13 Thread Andreas Rheinhardt
We currently mostly do not empty the MMX state in our MMX DSP functions; instead we only do so before code that might be using x87 code. This is a violation of the System V i386 ABI (and maybe of other ABIs, too): "The CPU shall be in x87 mode upon entry to a function. Therefore, every function

Re: [FFmpeg-devel] [PATCH] avformat/avformat: Remove reference to removed setter

2024-02-13 Thread Andreas Rheinhardt
Andreas Rheinhardt: > Removed in 704017d91ec8fbade0de072d222018c1a6013b70. > > Signed-off-by: Andreas Rheinhardt > --- > libavformat/avformat.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/libavformat/avformat.h b/libavformat/avformat.h > index

Re: [FFmpeg-devel] [PATCH] avcodec/cri, tdsc, tiff: Don't forward AVCodecContext.dct_algo

2024-02-13 Thread Andreas Rheinhardt
Andreas Rheinhardt: > It is unused for decoders. > > Signed-off-by: Andreas Rheinhardt > --- > libavcodec/cri.c | 1 - > libavcodec/tdsc.c | 1 - > libavcodec/tiff.c | 1 - > 3 files changed, 3 deletions(-) > > diff --git a/libavcodec/cri.c b/libavcodec/cri.c > index 0380a0c665..c4eb468610

Re: [FFmpeg-devel] [PATCH] avfilter/vf_(bwdif|yadif)_cuda: Remove unused variables

2024-02-13 Thread Andreas Rheinhardt
Andreas Rheinhardt: > Forgotten in 268062fa15e1c05310f9c3977e0b95ac07eca274. > > Signed-off-by: Andreas Rheinhardt > --- > libavfilter/vf_bwdif_cuda.c | 1 - > libavfilter/vf_yadif_cuda.c | 1 - > 2 files changed, 2 deletions(-) > > diff --git a/libavfilter/vf_bwdif_cuda.c

[FFmpeg-devel] [PATCH 24/24] avutil/hwcontext_cuda: Allocate public and internal device ctx jointly

2024-02-13 Thread Andreas Rheinhardt
Signed-off-by: Andreas Rheinhardt --- libavutil/hwcontext_cuda.c | 43 +++--- 1 file changed, 22 insertions(+), 21 deletions(-) diff --git a/libavutil/hwcontext_cuda.c b/libavutil/hwcontext_cuda.c index b430b42f62..3de3847399 100644 ---

Re: [FFmpeg-devel] [PATCH v4 2/2] lavc/vulkan_av1: port to the new stable API

2024-02-13 Thread James Almer
On 2/13/2024 9:10 AM, Lynne wrote: Feb 13, 2024, 01:59 by ffmpeg-devel@ffmpeg.org: On Sun Feb 11, 2024 at 10:15 AM EST, Lynne wrote: From: Lynne Date: Fri, 19 Jan 2024 10:49:02 +1000 Subject: [PATCH v4 2/2] lavc/vulkan_av1: port to the new stable API Most of this patch was written by Dave

Re: [FFmpeg-devel] [PATCH v4 2/2] lavc/vulkan_av1: port to the new stable API

2024-02-13 Thread Lynne
Feb 13, 2024, 01:59 by ffmpeg-devel@ffmpeg.org: > On Sun Feb 11, 2024 at 10:15 AM EST, Lynne wrote: > >> From: Lynne >> Date: Fri, 19 Jan 2024 10:49:02 +1000 >> Subject: [PATCH v4 2/2] lavc/vulkan_av1: port to the new stable API >> >> Most of this patch was written by Dave Airlie , >> with some

Re: [FFmpeg-devel] [FFmpeg-cvslog] lavf/assenc: normalize line endings to \n

2024-02-13 Thread Ridley Combs via ffmpeg-devel
> On Feb 13, 2024, at 01:28, Anton Khirnov wrote: > > Quoting Martin Storsjö (2024-02-12 12:31:29) >> On Mon, 12 Feb 2024, Hendrik Leppkes wrote: >> >>> On Mon, Feb 12, 2024 at 11:22 AM Martin Storsjö wrote: > > diff --git a/.gitattributes b/.gitattributes > index

Re: [FFmpeg-devel] [PATCH] avcodec/vvcdec: frame_context_setup, set fc->ref to NULL

2024-02-13 Thread Frank Plowman
On 13/02/2024 02:30, Nuo Mi wrote: > fc->ref points to an old VVCFrame, which cannot be used after > frame_context_setup. > This prevents crashes in decode_nal_units-->ff_vvc_report_frame_finished. > > Signed-off-by: Frank Plowman > --- > libavcodec/vvc/vvcdec.c | 2 ++ > 1 file changed, 2

[FFmpeg-devel] [PATCH v2] avcodec/h2645_parse: Don't treat 0x000002 as a start code and truncate

2024-02-13 Thread Mattias Wadman
According to ITU-T H.265 7.4.2.1 this byte sequence should not appear in a NAL unit but in practice in rare cases it seems it does, possibly due to buggy encoders. Other players like VLC and Quicktime seem to be fine with it. Currently when this sequence is found it is treated as if the next

Re: [FFmpeg-devel] [PATCH 1/2] avdevice: deprecate opengl outdev

2024-02-13 Thread Marton Balint
On Tue, 13 Feb 2024, J. Dekker wrote: Signed-off-by: J. Dekker --- These devices are fundamentally broken and usecases should be switched away from output devices in general. Discussion in the thread tended towards deprecation rather than immediate removal to give time for users to figure

Re: [FFmpeg-devel] [PATCH 1/4] checkasm/rv34dsp: add rv34_inv_transform_dc test

2024-02-13 Thread flow gg
it was due to a testing , not MMX. fixed it in this reply. flow gg 于2024年2月13日周二 10:37写道: > I sended "[FFmpeg-devel] [PATCH] x86: Remove MMX assembly > rv34_inv_transform_dc in rv34dsp" > > Rémi Denis-Courmont 于2024年2月13日周二 03:37写道: > >> Le perjantaina 2. helmikuuta 2024, 2.47.16 EET flow gg

Re: [FFmpeg-devel] [PATCH] x86: Remove MMX assembly rv34_inv_transform_dc in rv34dsp

2024-02-13 Thread flow gg
I made a mistake. It can be fixed your way. Please ignore this reply. flow gg 于2024年2月13日周二 17:47写道: > Thank you for your guidance. Do you mean that it should be modified test > like this? > > - declare_func(void, uint8_t *dst, ptrdiff_t stride, int dc); > + declare_func_emms(AV_CPU_FLAG_MMX,

Re: [FFmpeg-devel] [PATCH] x86: Remove MMX assembly rv34_inv_transform_dc in rv34dsp

2024-02-13 Thread flow gg
Thank you for your guidance. Do you mean that it should be modified test like this? - declare_func(void, uint8_t *dst, ptrdiff_t stride, int dc); + declare_func_emms(AV_CPU_FLAG_MMX, void, uint8_t *, ptrdiff_t, int); I tried to do it this way, but the test still failed. not sure why ...

Re: [FFmpeg-devel] [FFmpeg-cvslog] lavf/assenc: normalize line endings to \n

2024-02-13 Thread Anton Khirnov
Quoting Martin Storsjö (2024-02-12 12:31:29) > On Mon, 12 Feb 2024, Hendrik Leppkes wrote: > > > On Mon, Feb 12, 2024 at 11:22 AM Martin Storsjö wrote: > >> > > >> > diff --git a/.gitattributes b/.gitattributes > >> > index 5a19b963b6..a900528e47 100644 > >> > --- a/.gitattributes > >> > +++

Re: [FFmpeg-devel] [PATCH] x86: Remove MMX assembly rv34_inv_transform_dc in rv34dsp

2024-02-13 Thread Andreas Rheinhardt
flow gg: > Subject: [PATCH] x86: Remove MMX assembly rv34_inv_transform_dc in rv34dsp > > This asm will cause checkasm to fail. > --- > libavcodec/x86/rv34dsp.asm| 12 > libavcodec/x86/rv34dsp_init.c | 2 -- Of course your checkasm test will fail: You used declare_func and not