Re: [FFmpeg-devel] [PATCH] avformat/mxfdec: signal channel layouts using the new channel layout api

2024-03-08 Thread Anton Khirnov
Quoting Marton Balint (2024-03-08 21:13:59) > +ret = av_channel_layout_retype(ch_layout, AV_CHANNEL_ORDER_NATIVE, > AV_CHANNEL_LAYOUT_RETYPE_FLAG_LOSSLESS); > +if (ret == AVERROR(ENOSYS)) > +ret = av_channel_layout_retype(ch_layout, AV_CHANNEL_ORDER_UNSPEC, >

Re: [FFmpeg-devel] [PATCH] avformat/mxfdec: signal channel layouts using the new channel layout api

2024-03-08 Thread Marton Balint
On Fri, 8 Mar 2024, James Almer wrote: On 3/8/2024 5:13 PM, Marton Balint wrote: Signed-off-by: Marton Balint --- libavformat/mxfdec.c | 129 ++- 1 file changed, 53 insertions(+), 76 deletions(-) diff --git a/libavformat/mxfdec.c

[FFmpeg-devel] [PATCH] doc/examples/qsv_decode.c: remove unused config.h header file

2024-03-08 Thread hung kuishing
Signed-off-by: clarkh mailto:hungkuish...@outlook.com>> --- doc/examples/qsv_decode.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/doc/examples/qsv_decode.c b/doc/examples/qsv_decode.c index cc2662d5bd..901eac3b27 100644 --- a/doc/examples/qsv_decode.c +++ b/doc/examples/qsv_decode.c @@

Re: [FFmpeg-devel] Did FATE have an unhappy accident?

2024-03-08 Thread Michael Niedermayer
On Fri, Mar 08, 2024 at 10:17:04AM -0500, Sean McGovern wrote: > It's been unreachable since yesterday. fixed by baptsite some issue related to maintaince that left disk mounted read only thx [...] -- Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB He who knows, does

Re: [FFmpeg-devel] [PATCH] avfilter/fifo: Remove (a)fifo filters

2024-03-08 Thread Muhammad Faiz
On Fri, Mar 8, 2024 at 10:30 PM Paul B Mahol wrote: > On Fri, Mar 8, 2024 at 4:18 PM Muhammad Faiz wrote: > > > On Fri, Mar 8, 2024 at 5:40 PM Andreas Rheinhardt < > > andreas.rheinha...@outlook.com> wrote: > > > > > Muhammad Faiz: > > > > On Tue, Feb 6, 2024 at 3:58 PM Andreas Rheinhardt < > >

Re: [FFmpeg-devel] [PATCH] avfilter/fifo: Remove (a)fifo filters

2024-03-08 Thread Muhammad Faiz
On Fri, Mar 8, 2024 at 10:46 PM Andreas Rheinhardt < andreas.rheinha...@outlook.com> wrote: > Muhammad Faiz: > > On Fri, Mar 8, 2024 at 5:40 PM Andreas Rheinhardt < > > andreas.rheinha...@outlook.com> wrote: > > > >> Muhammad Faiz: > >>> On Tue, Feb 6, 2024 at 3:58 PM Andreas Rheinhardt < > >>>

Re: [FFmpeg-devel] [PATCH] avformat/mxfdec: signal channel layouts using the new channel layout api

2024-03-08 Thread James Almer
On 3/8/2024 5:13 PM, Marton Balint wrote: Signed-off-by: Marton Balint --- libavformat/mxfdec.c | 129 ++- 1 file changed, 53 insertions(+), 76 deletions(-) diff --git a/libavformat/mxfdec.c b/libavformat/mxfdec.c index 289db9833c..e2f4a22983 100644

[FFmpeg-devel] [PATCH 2/2 v2] fftools/ffprobe: export IAMF Stream Group parameters

2024-03-08 Thread James Almer
Signed-off-by: James Almer --- doc/ffprobe.xsd | 39 ++ fftools/ffprobe.c | 160 +++- tests/fate/iamf.mak | 12 +- tests/fate/mov.mak | 8 +- tests/ref/fate/iamf-5_1_4

[FFmpeg-devel] [PATCH 1/2 v3] fftools/ffprobe: export Tile Grid Stream Group parameters

2024-03-08 Thread James Almer
Signed-off-by: James Almer --- doc/ffprobe.xsd | 50 + fftools/ffprobe.c | 53 --- tests/fate/mov.mak| 6 +-- .../ref/fate/mov-heic-demux-still-image-grid | 29 ++

[FFmpeg-devel] [PATCH] avformat/mxfdec: signal channel layouts using the new channel layout api

2024-03-08 Thread Marton Balint
Signed-off-by: Marton Balint --- libavformat/mxfdec.c | 129 ++- 1 file changed, 53 insertions(+), 76 deletions(-) diff --git a/libavformat/mxfdec.c b/libavformat/mxfdec.c index 289db9833c..e2f4a22983 100644 --- a/libavformat/mxfdec.c +++

Re: [FFmpeg-devel] [PATCH 2/3] lavc: replace ff_thread_get_buffer() with ff_get_buffer()

2024-03-08 Thread Vittorio Giovara
On Fri, Mar 8, 2024 at 6:01 PM Kieran Kunhya wrote: > On Fri, 8 Mar 2024 at 16:50, Nicolas George wrote: > > > Kieran Kunhya (12024-03-08): > > > New contributors are not interested in your biased history lessons. > They > > > want to write code and have a modern, well run project, not a > >

Re: [FFmpeg-devel] [PATCH 2/3] lavc: replace ff_thread_get_buffer() with ff_get_buffer()

2024-03-08 Thread Kieran Kunhya
On Fri, 8 Mar 2024 at 16:50, Nicolas George wrote: > Kieran Kunhya (12024-03-08): > > New contributors are not interested in your biased history lessons. They > > want to write code and have a modern, well run project, not a > dysfunctional > > mess. > > And we go back to the core question: does

Re: [FFmpeg-devel] [PATCH 2/3] lavc: replace ff_thread_get_buffer() with ff_get_buffer()

2024-03-08 Thread Nicolas George
Kieran Kunhya (12024-03-08): > New contributors are not interested in your biased history lessons. They > want to write code and have a modern, well run project, not a dysfunctional > mess. And we go back to the core question: does the strength of this project come from paid-for contributors

Re: [FFmpeg-devel] [PATCH 2/3] lavc: replace ff_thread_get_buffer() with ff_get_buffer()

2024-03-08 Thread Kieran Kunhya
On Fri, 8 Mar 2024 at 16:41, Nicolas George wrote: > Kieran Kunhya (12024-03-08): > > Several recent contributors were in nappies during that piece of ancient > > history. Do you really need to bring it up incessantly and use it as your > > prism on every issue you disagree with? > > Yes, it is

Re: [FFmpeg-devel] [PATCH 2/3] lavc: replace ff_thread_get_buffer() with ff_get_buffer()

2024-03-08 Thread Nicolas George
Kieran Kunhya (12024-03-08): > Several recent contributors were in nappies during that piece of ancient > history. Do you really need to bring it up incessantly and use it as your > prism on every issue you disagree with? Yes, it is necessary, because the same thing is happening again. “Those who

Re: [FFmpeg-devel] [PATCH 2/3] lavc: replace ff_thread_get_buffer() with ff_get_buffer()

2024-03-08 Thread Nicolas George
Ronald S. Bultje (12024-03-08): > I hope you realize that is what reconciliation looks like. No, it is not. It is what a takeover disguised as reconciliation looks like. -- Nicolas George ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org

Re: [FFmpeg-devel] [PATCH 2/3] lavc: replace ff_thread_get_buffer() with ff_get_buffer()

2024-03-08 Thread Ronald S. Bultje
Hi Nicolas, On Fri, Mar 8, 2024 at 10:46 AM Nicolas George wrote: > [..] you can see they have in the recent years gained a > lot of influence in FFmpeg [..] > I hope you realize that is what reconciliation looks like. In other words: this was always the goal - from both "sides". You seem to

Re: [FFmpeg-devel] [PATCH 2/3] lavc: replace ff_thread_get_buffer() with ff_get_buffer()

2024-03-08 Thread Kieran Kunhya
On Fri, 8 Mar 2024 at 15:46, Nicolas George wrote: > Sean McGovern (12024-03-08): > > It is really mean-spirited to make such comments about a project that is > no > > longer in operation. Can't we look forward instead of behind us? > > The project libav might be dead, but the people who made it

Re: [FFmpeg-devel] [PATCH] avfilter/fifo: Remove (a)fifo filters

2024-03-08 Thread Andreas Rheinhardt
Muhammad Faiz: > On Fri, Mar 8, 2024 at 5:40 PM Andreas Rheinhardt < > andreas.rheinha...@outlook.com> wrote: > >> Muhammad Faiz: >>> On Tue, Feb 6, 2024 at 3:58 PM Andreas Rheinhardt < >>> andreas.rheinha...@outlook.com> wrote: >>> Andreas Rheinhardt: > Obsolete since

Re: [FFmpeg-devel] [PATCH 2/3] lavc: replace ff_thread_get_buffer() with ff_get_buffer()

2024-03-08 Thread Nicolas George
Sean McGovern (12024-03-08): > It is really mean-spirited to make such comments about a project that is no > longer in operation. Can't we look forward instead of behind us? The project libav might be dead, but the people who made it are not, not even retired, just look who signed its manifest.

Re: [FFmpeg-devel] [PATCH 2/3] lavc: replace ff_thread_get_buffer() with ff_get_buffer()

2024-03-08 Thread Sean McGovern
On Fri, Mar 8, 2024, 10:37 Vittorio Giovara wrote: > On Fri, Mar 8, 2024 at 4:34 PM Sean McGovern wrote: > > > On Fri, Mar 8, 2024, 10:31 Paul B Mahol wrote: > > > > > On Fri, Mar 8, 2024 at 4:21 PM Vittorio Giovara < > > > vittorio.giov...@gmail.com> > > > wrote: > > > > > > > On Fri, Mar 8,

Re: [FFmpeg-devel] FFmpeg 7.0 blocking issues

2024-03-08 Thread Kieran Kunhya
On Fri, 8 Mar 2024 at 15:04, Frank Plowman wrote: > On 08/03/2024 14:04, James Almer wrote: > > On 3/8/2024 11:02 AM, Kieran Kunhya wrote: > >> On Fri, 8 Mar 2024 at 14:00, James Almer wrote: > >> > >>> On 3/3/2024 4:35 AM, Jean-Baptiste Kempf wrote: > > n Sat, 2 Mar 2024, at 23:55,

Re: [FFmpeg-devel] [PATCH 2/3] lavc: replace ff_thread_get_buffer() with ff_get_buffer()

2024-03-08 Thread Vittorio Giovara
On Fri, Mar 8, 2024 at 4:34 PM Sean McGovern wrote: > On Fri, Mar 8, 2024, 10:31 Paul B Mahol wrote: > > > On Fri, Mar 8, 2024 at 4:21 PM Vittorio Giovara < > > vittorio.giov...@gmail.com> > > wrote: > > > > > On Fri, Mar 8, 2024 at 4:10 PM Sean McGovern > wrote: > > > > > > > On Fri, Mar 8,

Re: [FFmpeg-devel] [PATCH 2/3] lavc: replace ff_thread_get_buffer() with ff_get_buffer()

2024-03-08 Thread Sean McGovern
On Fri, Mar 8, 2024, 10:31 Paul B Mahol wrote: > On Fri, Mar 8, 2024 at 4:21 PM Vittorio Giovara < > vittorio.giov...@gmail.com> > wrote: > > > On Fri, Mar 8, 2024 at 4:10 PM Sean McGovern wrote: > > > > > On Fri, Mar 8, 2024, 08:20 Nicolas George wrote: > > > > > > > Andreas Rheinhardt

Re: [FFmpeg-devel] [PATCH 2/3] lavc: replace ff_thread_get_buffer() with ff_get_buffer()

2024-03-08 Thread Paul B Mahol
On Fri, Mar 8, 2024 at 4:21 PM Vittorio Giovara wrote: > On Fri, Mar 8, 2024 at 4:10 PM Sean McGovern wrote: > > > On Fri, Mar 8, 2024, 08:20 Nicolas George wrote: > > > > > Andreas Rheinhardt (12024-03-08): > > > > What maintenance cost and complexity are you referring to? I checked > > and >

Re: [FFmpeg-devel] [PATCH] avfilter/fifo: Remove (a)fifo filters

2024-03-08 Thread Paul B Mahol
On Fri, Mar 8, 2024 at 4:18 PM Muhammad Faiz wrote: > On Fri, Mar 8, 2024 at 5:40 PM Andreas Rheinhardt < > andreas.rheinha...@outlook.com> wrote: > > > Muhammad Faiz: > > > On Tue, Feb 6, 2024 at 3:58 PM Andreas Rheinhardt < > > > andreas.rheinha...@outlook.com> wrote: > > > > > >> Andreas

Re: [FFmpeg-devel] [PATCH 2/3] lavc: replace ff_thread_get_buffer() with ff_get_buffer()

2024-03-08 Thread Sean McGovern
On Fri, Mar 8, 2024, 10:19 Nicolas George wrote: > Sean McGovern (12024-03-08): > > Everybody can we *please* keep the responses civil/professional on the > ML. > > Civil, certainly, provided others are civil to me. > > Professional, not a chance. This is Libre Software, not a job. > > -- >

Re: [FFmpeg-devel] [PATCH 2/3] lavc: replace ff_thread_get_buffer() with ff_get_buffer()

2024-03-08 Thread Vittorio Giovara
On Fri, Mar 8, 2024 at 4:10 PM Sean McGovern wrote: > On Fri, Mar 8, 2024, 08:20 Nicolas George wrote: > > > Andreas Rheinhardt (12024-03-08): > > > What maintenance cost and complexity are you referring to? I checked > and > > > could not find a single commit where one had to fix an

Re: [FFmpeg-devel] [PATCH 2/3] lavc: replace ff_thread_get_buffer() with ff_get_buffer()

2024-03-08 Thread Nicolas George
Sean McGovern (12024-03-08): > Everybody can we *please* keep the responses civil/professional on the ML. Civil, certainly, provided others are civil to me. Professional, not a chance. This is Libre Software, not a job. -- Nicolas George ___

Re: [FFmpeg-devel] [PATCH] avfilter/fifo: Remove (a)fifo filters

2024-03-08 Thread Muhammad Faiz
On Fri, Mar 8, 2024 at 5:40 PM Andreas Rheinhardt < andreas.rheinha...@outlook.com> wrote: > Muhammad Faiz: > > On Tue, Feb 6, 2024 at 3:58 PM Andreas Rheinhardt < > > andreas.rheinha...@outlook.com> wrote: > > > >> Andreas Rheinhardt: > >>> Obsolete since

[FFmpeg-devel] Did FATE have an unhappy accident?

2024-03-08 Thread Sean McGovern
It's been unreachable since yesterday. -- Sean McGovern ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subject

Re: [FFmpeg-devel] [PATCH] fate: fix sub2video_{basic, time_limited} on big-endian targets

2024-03-08 Thread Sean McGovern
On Wed, Mar 6, 2024, 18:48 Sean McGovern wrote: > The reference file uses BGRA pixel format, so request it here. > --- > tests/fate/ffmpeg.mak | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/tests/fate/ffmpeg.mak b/tests/fate/ffmpeg.mak > index 669c878c7f..77e93693b9 100644 > ---

Re: [FFmpeg-devel] [PATCH 2/3] lavc: replace ff_thread_get_buffer() with ff_get_buffer()

2024-03-08 Thread Sean McGovern
On Fri, Mar 8, 2024, 08:20 Nicolas George wrote: > Andreas Rheinhardt (12024-03-08): > > What maintenance cost and complexity are you referring to? I checked and > > could not find a single commit where one had to fix an ff_get_buffer() > > to ff_thread_get_buffer() because it has been forgotten

Re: [FFmpeg-devel] FFmpeg 7.0 blocking issues

2024-03-08 Thread Frank Plowman
On 08/03/2024 14:04, James Almer wrote: > On 3/8/2024 11:02 AM, Kieran Kunhya wrote: >> On Fri, 8 Mar 2024 at 14:00, James Almer wrote: >> >>> On 3/3/2024 4:35 AM, Jean-Baptiste Kempf wrote: n Sat, 2 Mar 2024, at 23:55, Michael Niedermayer wrote: > On Tue, Jan 23, 2024 at 08:22:41PM

Re: [FFmpeg-devel] [PATCH 2/3] lavc: replace ff_thread_get_buffer() with ff_get_buffer()

2024-03-08 Thread Vittorio Giovara
On Fri, Mar 8, 2024 at 12:18 PM Andreas Rheinhardt < andreas.rheinha...@outlook.com> wrote: > >> > >> -1: This adds avoidable runtime checks. > > > > What checks and why is that a problem? > > > It adds a runtime check to every call to ff_get_buffer() by every >

Re: [FFmpeg-devel] FFmpeg 7.0 blocking issues

2024-03-08 Thread James Almer
On 3/8/2024 11:02 AM, Kieran Kunhya wrote: On Fri, 8 Mar 2024 at 14:00, James Almer wrote: On 3/3/2024 4:35 AM, Jean-Baptiste Kempf wrote: n Sat, 2 Mar 2024, at 23:55, Michael Niedermayer wrote: On Tue, Jan 23, 2024 at 08:22:41PM +0100, Michael Niedermayer wrote: Hi all As it was a

Re: [FFmpeg-devel] FFmpeg 7.0 blocking issues

2024-03-08 Thread Kieran Kunhya
On Fri, 8 Mar 2024 at 14:00, James Almer wrote: > On 3/3/2024 4:35 AM, Jean-Baptiste Kempf wrote: > > > > n Sat, 2 Mar 2024, at 23:55, Michael Niedermayer wrote: > >> On Tue, Jan 23, 2024 at 08:22:41PM +0100, Michael Niedermayer wrote: > >>> Hi all > >>> > >>> As it was a little difficult for me

Re: [FFmpeg-devel] FFmpeg 7.0 blocking issues

2024-03-08 Thread James Almer
On 3/3/2024 4:35 AM, Jean-Baptiste Kempf wrote: n Sat, 2 Mar 2024, at 23:55, Michael Niedermayer wrote: On Tue, Jan 23, 2024 at 08:22:41PM +0100, Michael Niedermayer wrote: Hi all As it was a little difficult for me to not loose track of what is blocking a release. I suggest that for all

Re: [FFmpeg-devel] [PATCH] avformat/aea: Add aea muxer

2024-03-08 Thread asivery via ffmpeg-devel
Thank you for your incredibly thorough and fast response. I've applied all the corrections you requested. Please let me know if there's anything else wrong with my patch, and thank you for your time. - asivery On Friday, March 8th, 2024 at 1:06 PM, Andreas Rheinhardt wrote: > asivery via

Re: [FFmpeg-devel] [PATCH v2 1/4] avcodec/aom_film_grain: add AOM film grain synthesis

2024-03-08 Thread Niklas Haas
On Fri, 08 Mar 2024 10:31:28 -0300 James Almer wrote: > On 3/8/2024 10:21 AM, Niklas Haas wrote: > > From: Niklas Haas > > > > Implementation copied wholesale from dav1d, sans SIMD, under permissive > > license. This implementation was extensively verified to be bit-exact, > > so it serves as a

Re: [FFmpeg-devel] [PATCH] fate/flvenc: force the av1 decoder in all steps for fate-enhanced-flv-av1

2024-03-08 Thread Steven Liu
James Almer 于2024年3月8日周五 21:19写道: > > Signed-off-by: James Almer > --- > tests/fate-run.sh | 5 +++-- > tests/fate/flvenc.mak | 2 +- > tests/fate/mpegps.mak | 2 +- > 3 files changed, 5 insertions(+), 4 deletions(-) > > diff --git a/tests/fate-run.sh b/tests/fate-run.sh > index

Re: [FFmpeg-devel] [PATCH] avcodec/libaomdec: decode extradata in aom_init

2024-03-08 Thread Steven Liu
James Almer 于2024年3月8日周五 21:13写道: > > On 3/8/2024 10:07 AM, Andreas Rheinhardt wrote: > > Steven Liu: > >> before patch: > >> test failed when using libaomdec. > >> TESTenhanced-flv-av1 > >> --- src/tests/ref/fate/enhanced-flv-av1 2024-03-08 11:27:13.577935587 > >> +0800 > >> +++

Re: [FFmpeg-devel] [PATCH 2/3] lavc: replace ff_thread_get_buffer() with ff_get_buffer()

2024-03-08 Thread Paul B Mahol
On Fri, Mar 8, 2024 at 2:20 PM Nicolas George wrote: > Andreas Rheinhardt (12024-03-08): > > What maintenance cost and complexity are you referring to? I checked and > > could not find a single commit where one had to fix an ff_get_buffer() > > to ff_thread_get_buffer() because it has been

Re: [FFmpeg-devel] [PATCH v2 2/4] avcodec/aom_film_grain: implement AFGS1

2024-03-08 Thread Niklas Haas
On Fri, 08 Mar 2024 14:21:06 +0100 Niklas Haas wrote: > From: Niklas Haas > > Changes from v1: > - fixed interpretation of num_sets_minus1 (missing +1) Also removed the 'Note:' from the commit message, as I have received clarification from the spec authors confirming that our implementation

[FFmpeg-devel] [PATCH v2 4/4] avcodec/hevcdec: apply AOM film grain synthesis

2024-03-08 Thread Niklas Haas
From: Niklas Haas Following the usual logic for H.274 film grain. --- libavcodec/Makefile | 2 +- libavcodec/hevcdec.c | 24 2 files changed, 21 insertions(+), 5 deletions(-) diff --git a/libavcodec/Makefile b/libavcodec/Makefile index 68e5394d84e..67faf620742 100644

[FFmpeg-devel] [PATCH v2 3/4] avcodec/h2645_sei: decode AFGS1 T.35 SEI

2024-03-08 Thread Niklas Haas
From: Niklas Haas Changes from v1: - fixed field size of provider_oriented_code (8 instead of 16 bits) --- I restricted this SEI to HEVC for now, until I see a H.264 sample. --- libavcodec/Makefile| 2 +- libavcodec/h2645_sei.c | 38 ++

[FFmpeg-devel] [PATCH v2 2/4] avcodec/aom_film_grain: implement AFGS1

2024-03-08 Thread Niklas Haas
From: Niklas Haas Changes from v1: - fixed interpretation of num_sets_minus1 (missing +1) --- Based on the AOMedia Film Grain Synthesis 1 (AFGS1) spec: https://aomediacodec.github.io/afgs1-spec/ The parsing has been changed substantially relative to the AV1 film grain OBU. In particular: 1.

[FFmpeg-devel] [PATCH v2 1/4] avcodec/aom_film_grain: add AOM film grain synthesis

2024-03-08 Thread Niklas Haas
From: Niklas Haas Implementation copied wholesale from dav1d, sans SIMD, under permissive license. This implementation was extensively verified to be bit-exact, so it serves as a much better starting point than trying to re-engineer this from scratch for no reason. (I also authored the original

Re: [FFmpeg-devel] [PATCH 2/3] lavc: replace ff_thread_get_buffer() with ff_get_buffer()

2024-03-08 Thread Nicolas George
Andreas Rheinhardt (12024-03-08): > What maintenance cost and complexity are you referring to? I checked and > could not find a single commit where one had to fix an ff_get_buffer() > to ff_thread_get_buffer() because it has been forgotten when the decoder > has been declared to support frame

[FFmpeg-devel] [PATCH] fate/flvenc: force the av1 decoder in all steps for fate-enhanced-flv-av1

2024-03-08 Thread James Almer
Signed-off-by: James Almer --- tests/fate-run.sh | 5 +++-- tests/fate/flvenc.mak | 2 +- tests/fate/mpegps.mak | 2 +- 3 files changed, 5 insertions(+), 4 deletions(-) diff --git a/tests/fate-run.sh b/tests/fate-run.sh index 2de560354f..0fead78c58 100755 --- a/tests/fate-run.sh +++

Re: [FFmpeg-devel] [RFC] clarifying the TC conflict of interest rule

2024-03-08 Thread Paul B Mahol
On Thu, Mar 7, 2024 at 3:01 PM Vittorio Giovara wrote: > On Thu, Mar 7, 2024 at 12:25 AM Michael Niedermayer via ffmpeg-devel < > ffmpeg-devel@ffmpeg.org> wrote: > > > > instead of backroom deals, for a > > > change. > > > > iam sorry, but these accusations are not acceptable > > The application

Re: [FFmpeg-devel] [PATCH] avcodec/libaomdec: decode extradata in aom_init

2024-03-08 Thread James Almer
On 3/8/2024 10:07 AM, Andreas Rheinhardt wrote: Steven Liu: before patch: test failed when using libaomdec. TESTenhanced-flv-av1 --- src/tests/ref/fate/enhanced-flv-av1 2024-03-08 11:27:13.577935587 +0800 +++ tests/data/fate/enhanced-flv-av12024-03-08 17:38:25.810152322 +0800 @@ -3,7

Re: [FFmpeg-devel] [PATCH] avcodec/libaomdec: decode extradata in aom_init

2024-03-08 Thread Andreas Rheinhardt
Steven Liu: > before patch: > test failed when using libaomdec. > TESTenhanced-flv-av1 > --- src/tests/ref/fate/enhanced-flv-av1 2024-03-08 11:27:13.577935587 > +0800 > +++ tests/data/fate/enhanced-flv-av1 2024-03-08 17:38:25.810152322 +0800 > @@ -3,7 +3,7 @@ > #media_type 0: video >

Re: [FFmpeg-devel] [PATCH] avcodec/libaomdec: decode extradata in aom_init

2024-03-08 Thread James Almer
On 3/8/2024 6:49 AM, Steven Liu wrote: before patch: test failed when using libaomdec. TESTenhanced-flv-av1 --- src/tests/ref/fate/enhanced-flv-av1 2024-03-08 11:27:13.577935587 +0800 +++ tests/data/fate/enhanced-flv-av12024-03-08 17:38:25.810152322 +0800 @@ -3,7 +3,7 @@ #media_type 0:

Re: [FFmpeg-devel] [PATCH] avcodec/xbmenc: Avoid snprintf() for data->hex conversion

2024-03-08 Thread Andreas Rheinhardt
Marton Balint: > > > On Fri, 8 Mar 2024, Andreas Rheinhardt wrote: > >> Marton Balint: >>> >>> >>> On Fri, 8 Mar 2024, Andreas Rheinhardt wrote: >>> Andreas Rheinhardt: > Use a small LUT instead. Improves performance. > > Signed-off-by: Andreas Rheinhardt > --- >  

Re: [FFmpeg-devel] [PATCH] avformat/aea: Add aea muxer

2024-03-08 Thread Andreas Rheinhardt
asivery via ffmpeg-devel: > +typedef struct { > +int block_count; > +} AeaMuxerContext; > + > +static int aea_init(AVFormatContext *s) > +{ > +AeaMuxerContext *c = s->priv_data; > +c->block_count = 0; Unnecessary: A muxer's priv_data is always pre-zeroed. > + > +return 0; >

[FFmpeg-devel] [PATCH] Fix for Incorrect Parameter in ff_filter_config_links Function Call

2024-03-08 Thread admin
From: 联盟少侠 src/libavfilter/internal.h:255:45: note: passing argument to parameter 'filter' here int ff_filter_config_links(AVFilterContext *filter); --- libavfilter/avfilter.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavfilter/avfilter.c b/libavfilter/avfilter.c

Re: [FFmpeg-devel] [PATCH] avformat/aea: Add aea muxer

2024-03-08 Thread asivery via ffmpeg-devel
Apologies for my oversight. I've attached the new patch. - asivery On Friday, March 8th, 2024 at 12:22 PM, Andreas Rheinhardt wrote: > asivery via ffmpeg-devel: > > > diff --git a/libavformat/allformats.c b/libavformat/allformats.c > > index b04b43cab3..1a50181447 100644 > > ---

Re: [FFmpeg-devel] [PATCH] avformat/aea: Add aea muxer

2024-03-08 Thread Andreas Rheinhardt
asivery via ffmpeg-devel: > diff --git a/libavformat/allformats.c b/libavformat/allformats.c > index b04b43cab3..1a50181447 100644 > --- a/libavformat/allformats.c > +++ b/libavformat/allformats.c > @@ -46,6 +46,7 @@ extern const FFOutputFormat ff_adts_muxer; > extern const AVInputFormat

[FFmpeg-devel] [PATCH] avformat/aea: Add aea muxer

2024-03-08 Thread asivery via ffmpeg-devel
Empty MessageFrom 955fc035abbb5cfc1a52b1a5ea6900e4a21cef12 Mon Sep 17 00:00:00 2001 From: asivery Date: Fri, 8 Mar 2024 11:17:51 +0100 Subject: [PATCH] avformat/aea: Add aea muxer Signed-off-by: asivery --- libavformat/Makefile| 3 +- libavformat/{aea.c => aeadec.c} | 0

Re: [FFmpeg-devel] [PATCH 2/3] lavc: replace ff_thread_get_buffer() with ff_get_buffer()

2024-03-08 Thread Andreas Rheinhardt
Anton Khirnov: > Quoting Andreas Rheinhardt (2024-03-08 11:44:12) >> Anton Khirnov: >>> Quoting Andreas Rheinhardt (2024-03-08 11:19:59) Anton Khirnov: > Quoting Andreas Rheinhardt (2024-03-08 11:03:18) >> Anton Khirnov: >>> ff_thread_get_buffer() has exactly the same semantics as

Re: [FFmpeg-devel] [PATCH 2/3] lavc: replace ff_thread_get_buffer() with ff_get_buffer()

2024-03-08 Thread Anton Khirnov
Quoting Andreas Rheinhardt (2024-03-08 11:44:12) > Anton Khirnov: > > Quoting Andreas Rheinhardt (2024-03-08 11:19:59) > >> Anton Khirnov: > >>> Quoting Andreas Rheinhardt (2024-03-08 11:03:18) > Anton Khirnov: > > ff_thread_get_buffer() has exactly the same semantics as > >

Re: [FFmpeg-devel] [PATCH 2/3] lavc: replace ff_thread_get_buffer() with ff_get_buffer()

2024-03-08 Thread Andreas Rheinhardt
Anton Khirnov: > Quoting Andreas Rheinhardt (2024-03-08 11:19:59) >> Anton Khirnov: >>> Quoting Andreas Rheinhardt (2024-03-08 11:03:18) Anton Khirnov: > ff_thread_get_buffer() has exactly the same semantics as > ff_get_buffer(), except it is supposed to be used in frame-threaded

Re: [FFmpeg-devel] [PATCH] avfilter/fifo: Remove (a)fifo filters

2024-03-08 Thread Andreas Rheinhardt
Muhammad Faiz: > On Tue, Feb 6, 2024 at 3:58 PM Andreas Rheinhardt < > andreas.rheinha...@outlook.com> wrote: > >> Andreas Rheinhardt: >>> Obsolete since 4ca1fb9d2a91757c8c4c34dd456abf340e3f765f. >>> >>> Signed-off-by: Andreas Rheinhardt >>> --- >>> doc/filters.texi | 9 --- >>>

Re: [FFmpeg-devel] [PATCH 2/3] lavc: replace ff_thread_get_buffer() with ff_get_buffer()

2024-03-08 Thread Anton Khirnov
Quoting Andreas Rheinhardt (2024-03-08 11:19:59) > Anton Khirnov: > > Quoting Andreas Rheinhardt (2024-03-08 11:03:18) > >> Anton Khirnov: > >>> ff_thread_get_buffer() has exactly the same semantics as > >>> ff_get_buffer(), except it is supposed to be used in frame-threaded > >>> decoders. Since

Re: [FFmpeg-devel] [PATCH 2/3] lavc: replace ff_thread_get_buffer() with ff_get_buffer()

2024-03-08 Thread Andreas Rheinhardt
Anton Khirnov: > Quoting Andreas Rheinhardt (2024-03-08 11:03:18) >> Anton Khirnov: >>> ff_thread_get_buffer() has exactly the same semantics as >>> ff_get_buffer(), except it is supposed to be used in frame-threaded >>> decoders. Since the decoder instance knows whether frame threading is in >>>

Re: [FFmpeg-devel] [PATCH 2/3] lavc: replace ff_thread_get_buffer() with ff_get_buffer()

2024-03-08 Thread Anton Khirnov
Quoting Andreas Rheinhardt (2024-03-08 11:03:18) > Anton Khirnov: > > ff_thread_get_buffer() has exactly the same semantics as > > ff_get_buffer(), except it is supposed to be used in frame-threaded > > decoders. Since the decoder instance knows whether frame threading is in > > use, there is no

Re: [FFmpeg-devel] [PATCH] libavdevice: Fix the avfoundation device after switching to FFInputFormat

2024-03-08 Thread Andreas Rheinhardt
Martin Storsjö: > This was missed in b800327f4c7233d09baca958121722a04c2035ff. > --- > libavdevice/avfoundation.m | 11 ++- > 1 file changed, 6 insertions(+), 5 deletions(-) > > diff --git a/libavdevice/avfoundation.m b/libavdevice/avfoundation.m > index a0ef87edff..d9b17ccdae 100644 >

Re: [FFmpeg-devel] [PATCH 2/3] lavc: replace ff_thread_get_buffer() with ff_get_buffer()

2024-03-08 Thread Andreas Rheinhardt
Anton Khirnov: > ff_thread_get_buffer() has exactly the same semantics as > ff_get_buffer(), except it is supposed to be used in frame-threaded > decoders. Since the decoder instance knows whether frame threading is in > use, there is no point in forcing decoder implementations to use a >

[FFmpeg-devel] [PATCH] avcodec/libaomdec: decode extradata in aom_init

2024-03-08 Thread Steven Liu
before patch: test failed when using libaomdec. TESTenhanced-flv-av1 --- src/tests/ref/fate/enhanced-flv-av1 2024-03-08 11:27:13.577935587 +0800 +++ tests/data/fate/enhanced-flv-av12024-03-08 17:38:25.810152322 +0800 @@ -3,7 +3,7 @@ #media_type 0: video #codec_id 0: av1 #dimensions 0:

Re: [FFmpeg-devel] [PATCH 2/2] lavc/vc1dsp: R-V V mspel_pixels

2024-03-08 Thread flow gg
Alright, using m8, but for now don't add code to address dependencies in loops that have a minor impact. Updated in the reply Rémi Denis-Courmont 于2024年3月8日周五 17:08写道: > > > Le 8 mars 2024 02:45:46 GMT+02:00, flow gg a > écrit : > >> Isn't it also faster to max LMUL for the adds here? > > >

Re: [FFmpeg-devel] [PATCH 2/2] lavc/vc1dsp: R-V V mspel_pixels

2024-03-08 Thread Rémi Denis-Courmont
Le 8 mars 2024 02:45:46 GMT+02:00, flow gg a écrit : >> Isn't it also faster to max LMUL for the adds here? > >It requires the use of one more vset, making the time slightly longer: >147.7 (m1), 148.7 (m8 + vset). A variation of 0.6% on a single set of kernels will end up below measurement

[FFmpeg-devel] [PATCH v2 2/2] lavc/vaapi_encode_h265: Set general_*_constriaint flags with profile

2024-03-08 Thread fei . w . wang-at-intel . com
From: Fei Wang According to Table A.2 in spec. Signed-off-by: Fei Wang --- libavcodec/vaapi_encode_h265.c | 181 +++-- 1 file changed, 128 insertions(+), 53 deletions(-) diff --git a/libavcodec/vaapi_encode_h265.c b/libavcodec/vaapi_encode_h265.c index

[FFmpeg-devel] [PATCH v2 1/2] lavc/vaapi_encode_h265: Map HEVC AV REXT profile to VA REXT profile

2024-03-08 Thread fei . w . wang-at-intel . com
From: Fei Wang There is no Main8/10 profile defined in HEVC REXT profiles. Use Main12 which is compatible with 8/10bit. Signed-off-by: Fei Wang --- update: Add more explanation in commit log. libavcodec/vaapi_encode_h265.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git

Re: [FFmpeg-devel] [PATCH] avfilter/fifo: Remove (a)fifo filters

2024-03-08 Thread Muhammad Faiz
On Tue, Feb 6, 2024 at 3:58 PM Andreas Rheinhardt < andreas.rheinha...@outlook.com> wrote: > Andreas Rheinhardt: > > Obsolete since 4ca1fb9d2a91757c8c4c34dd456abf340e3f765f. > > > > Signed-off-by: Andreas Rheinhardt > > --- > > doc/filters.texi | 9 --- > > libavfilter/Makefile |

[FFmpeg-devel] [PATCH v3] lavc/vaapi_encode: Enable block level bitrate control

2024-03-08 Thread fei . w . wang-at-intel . com
From: Fei Wang Signed-off-by: Fei Wang --- doc/encoders.texi | 4 libavcodec/vaapi_encode.c | 13 - libavcodec/vaapi_encode.h | 9 - 3 files changed, 24 insertions(+), 2 deletions(-) diff --git a/doc/encoders.texi b/doc/encoders.texi index

[FFmpeg-devel] [PATCH 2/2] libavcodec: Don't include libavcodec/x86/vvc/Makefile on any architecture

2024-03-08 Thread Martin Storsjö
This currently builds files in the libavcodec/x86/{vvc,h26x} subdirectories, which is somewhat unexpected when building for another architecture than x86. The regular arch subdirectories are handled with -include $(SRC_PATH)/$(1)/$(ARCH)/Makefile in the toplevel Makefile. Switch this to a

[FFmpeg-devel] [PATCH 1/2] makefile: Clean up missed object files with "make clean"

2024-03-08 Thread Martin Storsjö
In some builds, the following object files could be left behind after make clean: ./libavfilter/metal/utils.o ./libavfilter/metal/vf_yadif_videotoolbox.metallib.o ./libavcodec/x86/h26x/h2656dsp.o ./libavcodec/neon/mpegvideo.o ./ffbuild/bin2c_host.o --- ffbuild/common.mak | 2 +-

[FFmpeg-devel] [PATCH 3/3] lavc/thread.h: drop unnecessary includes

2024-03-08 Thread Anton Khirnov
--- libavcodec/thread.h | 22 ++ 1 file changed, 10 insertions(+), 12 deletions(-) diff --git a/libavcodec/thread.h b/libavcodec/thread.h index 5a00b32619..111010b27f 100644 --- a/libavcodec/thread.h +++ b/libavcodec/thread.h @@ -27,11 +27,9 @@ #ifndef AVCODEC_THREAD_H

[FFmpeg-devel] [PATCH 2/3] lavc: replace ff_thread_get_buffer() with ff_get_buffer()

2024-03-08 Thread Anton Khirnov
ff_thread_get_buffer() has exactly the same semantics as ff_get_buffer(), except it is supposed to be used in frame-threaded decoders. Since the decoder instance knows whether frame threading is in use, there is no point in forcing decoder implementations to use a different function merely because

[FFmpeg-devel] [PATCH 1/3] lavc/thread: move generic-layer API to avcodec_internal.h

2024-03-08 Thread Anton Khirnov
thread.h currently contains both API for decoder use and functions internal to lavc generic layer. Move the latter to avcodec_internal.h, which is a more appropriate place for them. --- libavcodec/avcodec_internal.h | 24 libavcodec/pthread.c | 1 +

[FFmpeg-devel] [PATCH] libavdevice: Fix the avfoundation device after switching to FFInputFormat

2024-03-08 Thread Martin Storsjö
This was missed in b800327f4c7233d09baca958121722a04c2035ff. --- libavdevice/avfoundation.m | 11 ++- 1 file changed, 6 insertions(+), 5 deletions(-) diff --git a/libavdevice/avfoundation.m b/libavdevice/avfoundation.m index a0ef87edff..d9b17ccdae 100644 --- a/libavdevice/avfoundation.m