Re: [FFmpeg-devel] [PATCH] hwcontext_videotoolbox: add vt_device_derive

2024-02-23 Thread Gnattu OC via ffmpeg-devel
I’ve tested and confirmed to work, and `reverse=1` also works for chaining to other videotoolbox filters. > On Feb 23, 2024, at 22:25, Zhao Zhili wrote: > > ___ > ffmpeg-devel mailing list > ffmpeg-devel@ffmpeg.org >

Re: [FFmpeg-devel] [PATCH] hwcontext_videotoolbox: add vt_device_derive

2024-02-23 Thread Zhao Zhili
___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".

Re: [FFmpeg-devel] [PATCH] hwcontext_videotoolbox: add vt_device_derive

2024-02-22 Thread Zhao Zhili
> 在 2024年2月23日,上午9:20,Zhao Zhili 写道: > >  >> 在 2024年2月23日,上午4:19,Gnattu OC via ffmpeg-devel 写道: >> >> Actually, if you examine the `hwcontext_videotoolbox.c` file, you will find >> that the current function for `vt_device_create` is essentially a no-op: it >> only returns an error if a

Re: [FFmpeg-devel] [PATCH] hwcontext_videotoolbox: add vt_device_derive

2024-02-22 Thread Zhao Zhili
> 在 2024年2月23日,上午4:19,Gnattu OC via ffmpeg-devel 写道: > > Actually, if you examine the `hwcontext_videotoolbox.c` file, you will find > that the current function for `vt_device_create` is essentially a no-op: it > only returns an error if a user attempts to select a device, otherwise it >

Re: [FFmpeg-devel] [PATCH] hwcontext_videotoolbox: add vt_device_derive

2024-02-22 Thread Gnattu OC via ffmpeg-devel
Actually, if you examine the `hwcontext_videotoolbox.c` file, you will find that the current function for `vt_device_create` is essentially a no-op: it only returns an error if a user attempts to select a device, otherwise it just returns. This is generally how VideoToolbox works. If the

Re: [FFmpeg-devel] [PATCH] hwcontext_videotoolbox: add vt_device_derive

2024-02-22 Thread Mark Thompson
On 22/02/2024 19:39, ChenLiucheng via ffmpeg-devel wrote: On Feb 23, 2024, at 03:28, Mark Thompson wrote: On 22/02/2024 18:46, gnattu via ffmpeg-devel wrote: There is no device context to be setup, nor devices to be selected with VideoToolbox. Just a simple return would allow us to use

Re: [FFmpeg-devel] [PATCH] hwcontext_videotoolbox: add vt_device_derive

2024-02-22 Thread ChenLiucheng via ffmpeg-devel
Well this does make sense. If only one type of hardware device is in use, then `-init_hw_device` will suffice. However, if we use hardware filters with different device types, such as OpenCL, and we want to switch to a VideoToolbox filter later in the chain, we will have a issue. Since there

Re: [FFmpeg-devel] [PATCH] hwcontext_videotoolbox: add vt_device_derive

2024-02-22 Thread Mark Thompson
On 22/02/2024 18:46, gnattu via ffmpeg-devel wrote: There is no device context to be setup, nor devices to be selected with VideoToolbox. Just a simple return would allow us to use derived device in filters like `hwupload=derive_device=videotoolbox` Signed-off-by: Gnattu OC ---

[FFmpeg-devel] [PATCH] hwcontext_videotoolbox: add vt_device_derive

2024-02-22 Thread gnattu via ffmpeg-devel
There is no device context to be setup, nor devices to be selected with VideoToolbox. Just a simple return would allow us to use derived device in filters like `hwupload=derive_device=videotoolbox` Signed-off-by: Gnattu OC --- libavutil/hwcontext_videotoolbox.c | 9 + 1 file changed, 9