Re: [FFmpeg-devel] [PATCH 1/6] avformat/mux: Make uncoded frames av_packet_unref() compatible

2020-04-11 Thread Andreas Rheinhardt
Marton Balint: > > > On Sat, 11 Apr 2020, James Almer wrote: > >> On 4/11/2020 6:35 PM, Andreas Rheinhardt wrote: >>> James Almer: On 4/11/2020 6:19 PM, Andreas Rheinhardt wrote: > Currently uncoded frames (i.e. packets whose data actually points > to an > AVFrame) are not

Re: [FFmpeg-devel] [PATCH 1/6] avformat/mux: Make uncoded frames av_packet_unref() compatible

2020-04-11 Thread Marton Balint
On Sat, 11 Apr 2020, James Almer wrote: On 4/11/2020 6:35 PM, Andreas Rheinhardt wrote: James Almer: On 4/11/2020 6:19 PM, Andreas Rheinhardt wrote: Currently uncoded frames (i.e. packets whose data actually points to an AVFrame) are not refcounted. As a consequence, calling

Re: [FFmpeg-devel] [PATCH 1/6] avformat/mux: Make uncoded frames av_packet_unref() compatible

2020-04-11 Thread James Almer
On 4/11/2020 6:35 PM, Andreas Rheinhardt wrote: > James Almer: >> On 4/11/2020 6:19 PM, Andreas Rheinhardt wrote: >>> Currently uncoded frames (i.e. packets whose data actually points to an >>> AVFrame) are not refcounted. As a consequence, calling av_packet_unref() >>> on them will not free them,

Re: [FFmpeg-devel] [PATCH 1/6] avformat/mux: Make uncoded frames av_packet_unref() compatible

2020-04-11 Thread Andreas Rheinhardt
James Almer: > On 4/11/2020 6:19 PM, Andreas Rheinhardt wrote: >> Currently uncoded frames (i.e. packets whose data actually points to an >> AVFrame) are not refcounted. As a consequence, calling av_packet_unref() >> on them will not free them, but may simply make sure that they leak by >> losing

Re: [FFmpeg-devel] [PATCH 1/6] avformat/mux: Make uncoded frames av_packet_unref() compatible

2020-04-11 Thread James Almer
On 4/11/2020 6:19 PM, Andreas Rheinhardt wrote: > Currently uncoded frames (i.e. packets whose data actually points to an > AVFrame) are not refcounted. As a consequence, calling av_packet_unref() > on them will not free them, but may simply make sure that they leak by > losing the pointer to the

[FFmpeg-devel] [PATCH 1/6] avformat/mux: Make uncoded frames av_packet_unref() compatible

2020-04-11 Thread Andreas Rheinhardt
Currently uncoded frames (i.e. packets whose data actually points to an AVFrame) are not refcounted. As a consequence, calling av_packet_unref() on them will not free them, but may simply make sure that they leak by losing the pointer to the frame. This commit changes this by mimicking what is