Re: [FFmpeg-soc] [soc]: r5570 - in amr: amrnbdata.h amrnbdec.c

2010-01-10 Thread Colin McQuillan
2010/1/9 Ronald S. Bultje rsbul...@gmail.com: Hi, On Fri, Jan 8, 2010 at 10:19 PM, Vitor Sessak vitor1...@gmail.com wrote: I think that this is only guaranteed to work if you declare the AMRNBFrame struct as packed, since the spec allows the compiler to add some padding space inside structs

Re: [FFmpeg-soc] [soc]: r5570 - in amr: amrnbdata.h amrnbdec.c

2010-01-10 Thread Vitor Sessak
Colin McQuillan wrote: 2010/1/9 Ronald S. Bultje rsbul...@gmail.com: Hi, On Fri, Jan 8, 2010 at 10:19 PM, Vitor Sessak vitor1...@gmail.com wrote: I think that this is only guaranteed to work if you declare the AMRNBFrame struct as packed, since the spec allows the compiler to add some padding

Re: [FFmpeg-soc] [soc]: r5570 - in amr: amrnbdata.h amrnbdec.c

2010-01-09 Thread Michael Niedermayer
On Fri, Jan 08, 2010 at 10:19:54PM -0500, Vitor Sessak wrote: cmcq wrote: Author: cmcq Date: Fri Jan 8 18:16:25 2010 New Revision: 5570 Log: Save about 1KB of space using a field-to-bit lookup instead of bit-to-field. Modified: amr/amrnbdata.h amr/amrnbdec.c Modified:

Re: [FFmpeg-soc] [soc]: r5570 - in amr: amrnbdata.h amrnbdec.c

2010-01-09 Thread Vitor Sessak
Michael Niedermayer wrote: On Fri, Jan 08, 2010 at 10:19:54PM -0500, Vitor Sessak wrote: cmcq wrote: Author: cmcq Date: Fri Jan 8 18:16:25 2010 New Revision: 5570 Log: Save about 1KB of space using a field-to-bit lookup instead of bit-to-field. Modified: amr/amrnbdata.h amr/amrnbdec.c

Re: [FFmpeg-soc] [soc]: r5570 - in amr: amrnbdata.h amrnbdec.c

2010-01-09 Thread Michael Niedermayer
On Sat, Jan 09, 2010 at 09:29:47AM -0500, Vitor Sessak wrote: Michael Niedermayer wrote: On Fri, Jan 08, 2010 at 10:19:54PM -0500, Vitor Sessak wrote: cmcq wrote: Author: cmcq Date: Fri Jan 8 18:16:25 2010 New Revision: 5570 Log: Save about 1KB of space using a field-to-bit lookup instead

Re: [FFmpeg-soc] [soc]: r5570 - in amr: amrnbdata.h amrnbdec.c

2010-01-09 Thread Vitor Sessak
Michael Niedermayer wrote: On Sat, Jan 09, 2010 at 09:29:47AM -0500, Vitor Sessak wrote: Michael Niedermayer wrote: On Fri, Jan 08, 2010 at 10:19:54PM -0500, Vitor Sessak wrote: cmcq wrote: Author: cmcq Date: Fri Jan 8 18:16:25 2010 New Revision: 5570 Log: Save about 1KB of space using a

Re: [FFmpeg-soc] [soc]: r5570 - in amr: amrnbdata.h amrnbdec.c

2010-01-09 Thread Ronald S. Bultje
Hi, On Fri, Jan 8, 2010 at 10:19 PM, Vitor Sessak vitor1...@gmail.com wrote: I think that this is only guaranteed to work if you declare the AMRNBFrame struct as packed, since the spec allows the compiler to add some padding space inside structs otherwise. I'm not sure that's true (at least

Re: [FFmpeg-soc] [soc]: r5570 - in amr: amrnbdata.h amrnbdec.c

2010-01-08 Thread Vitor Sessak
cmcq wrote: Author: cmcq Date: Fri Jan 8 18:16:25 2010 New Revision: 5570 Log: Save about 1KB of space using a field-to-bit lookup instead of bit-to-field. Modified: amr/amrnbdata.h amr/amrnbdec.c Modified: amr/amrnbdata.h