Re: [Firebird-devel] classes\InternalMessageBuffer.h

2014-04-09 Thread Dmitry Yemanov
09.04.2014 09:56, Alex wrote: On 04/09/2014 10:14 AM, Claudio Valderrama C. wrote: Folks, sorry for nitpicking, but I don't like this alias in classes\InternalMessageBuffer.h: typedef ArrayUCHAR Buffer; // May be it will become a class in the future, but now it is just a plain array

Re: [Firebird-devel] classes\InternalMessageBuffer.h

2014-04-09 Thread Dimitry Sibiryakov
09.04.2014 8:32, Dmitry Yemanov wrote: Is it really necessary at all? We already have UCharBuffer (both better named and serving the same goal). This buffer is not any UChar buffer, but message data buffer. It could implement data access methods. Though, I agree, that name 'Buffer' is too

Re: [Firebird-devel] Implemented STEP for generators / sequences

2014-04-09 Thread James Starkey
OK, I'll take the responsibility for the increment value for generators/sequences. It seemed like a good idea at the time. But is it actually useful for anything? Based on 25 years of experience, I have to say that the ability to set back a generator is a terrible idea that has led to more

Re: [Firebird-devel] User mapping changes

2014-04-09 Thread Leyne, Sean
I'd suggest at least RDB$USER_MAP and UserMapping.cpp instead. Maybe someone else will have a better suggestion. What is the object supposed to represent? (to make sure everyone is one the same page) It's a tool to map various names received from auth plugin (first of all logon name,