Re: [Firebird-devel] [Firebird-checkins] SF.net SVN: firebird:[62991] firebird/trunk

And how do you describe your changes in relation to cmake? воскресенье, 21 февраля 2016 г. пользователь Dimitry Sibiryakov написал: > 20.02.2016 22:58, Egor Pugin wrote: > > In other words you replaced autogenerated file with hand-written one. > >No, I didn't. > > -- >WBR, SD. > > >

Re: [Firebird-devel] [Firebird-checkins] SF.net SVN: firebird:[62991] firebird/trunk

20.02.2016 22:58, Egor Pugin wrote: > In other words you replaced autogenerated file with hand-written one. No, I didn't. -- WBR, SD. -- Site24x7 APM Insight: Get Deep Visibility into Application Performance APM

Re: [Firebird-devel] [Firebird-checkins] SF.net SVN: firebird:[62991] firebird/trunk

In other words you replaced autogenerated file with hand-written one. What is not so good. воскресенье, 21 февраля 2016 г. пользователь Dimitry Sibiryakov написал: > 20.02.2016 22:42, Egor Pugin wrote: > > So, cmake+msvc is broken, isn't it? > >I guess it still work fine. > > -- >WBR,

Re: [Firebird-devel] [Firebird-checkins] SF.net SVN: firebird:[62991] firebird/trunk

20.02.2016 22:42, Egor Pugin wrote: > So, cmake+msvc is broken, isn't it? I guess it still work fine. -- WBR, SD. -- Site24x7 APM Insight: Get Deep Visibility into Application Performance APM + Mobile APM + RUM:

Re: [Firebird-devel] [Firebird-checkins] SF.net SVN: firebird:[62991] firebird/trunk

So, cmake+msvc is broken, isn't it? воскресенье, 21 февраля 2016 г. пользователь Dimitry Sibiryakov написал: > 20.02.2016 21:52, Egor Pugin wrote: > > The original commit also breaks cmake build as it generates > autoconfig.h and not > > autoconfig_msvc.h. > >If you didn't notice that,

Re: [Firebird-devel] [Firebird-checkins] SF.net SVN: firebird:[62991] firebird/trunk

20.02.2016 21:52, Egor Pugin wrote: > The original commit also breaks cmake build as it generates autoconfig.h and > not > autoconfig_msvc.h. If you didn't notice that, build still use autoconfig.h with any compiler except MS VC. -- WBR, SD.

Re: [Firebird-devel] [Firebird-checkins] SF.net SVN: firebird:[62991] firebird/trunk

The original commit also breaks cmake build as it generates autoconfig.h and not autoconfig_msvc.h. суббота, 20 февраля 2016 г. пользователь Dimitry Sibiryakov написал: > 20.02.2016 17:57, Adriano dos Santos Fernandes wrote: > > Do you want me to say "put a space, remove a space, trim trailing

Re: [Firebird-devel] [Firebird-checkins] SF.net SVN: firebird:[62991] firebird/trunk

20.02.2016 17:57, Adriano dos Santos Fernandes wrote: > Do you want me to say "put a space, remove a space, trim trailing spaces"? No, I don't. For me that's perfectly ok, but it is Vlad who insisted on commit comments explaining what issues they address. BTW, following commit was not

Re: [Firebird-devel] [Firebird-checkins] SF.net SVN: firebird:[62991] firebird/trunk

20.02.2016 18:39, Dimitry Sibiryakov wrote: > 20.02.2016 17:36, Vlad Khorsun wrote: >> Next time i will undo such "clear" changes not wasting time on >> confirmation. > > Will you do it for Adriano's "Misc" as well? It doesn't concern you. Vlad

Re: [Firebird-devel] [Firebird-checkins] SF.net SVN: firebird:[62991] firebird/trunk

Em 20/02/2016 14:39, Dimitry Sibiryakov escreveu: > 20.02.2016 17:36, Vlad Khorsun wrote: >> Next time i will undo such "clear" changes not wasting time on >> confirmation. > >Will you do it for Adriano's "Misc" as well? > Do you want me to say "put a space, remove a space, trim

Re: [Firebird-devel] [Firebird-checkins] SF.net SVN: firebird:[62991] firebird/trunk

20.02.2016 17:36, Vlad Khorsun wrote: > Next time i will undo such "clear" changes not wasting time on > confirmation. Will you do it for Adriano's "Misc" as well? -- WBR, SD. -- Site24x7 APM Insight: Get

Re: [Firebird-devel] [Firebird-checkins] SF.net SVN: firebird:[62991] firebird/trunk

20.02.2016 18:25, Dimitry Sibiryakov wrote: > 20.02.2016 17:22, Vlad Khorsun wrote: >> Is it too hard to write useful comment when committing not waiting for >> someone to ask you ? > > Everything is clear in code. Next time i will undo such "clear" changes not wasting time on

Re: [Firebird-devel] [Firebird-checkins] SF.net SVN: firebird:[62991] firebird/trunk

20.02.2016 17:22, Vlad Khorsun wrote: >Is it too hard to write useful comment when committing not waiting for > someone to ask you ? Everything is clear in code. -- WBR, SD. -- Site24x7 APM Insight: Get Deep

Re: [Firebird-devel] [Firebird-checkins] SF.net SVN: firebird:[62991] firebird/trunk

20.02.2016 17:56, Dimitry Sibiryakov wrote: > 20.02.2016 16:49, Vlad Khorsun wrote: >> What issue this commit going to solve ? > > 1) Changes made in autoconfig_msvc.h aren't visible to the rest of sources > without manual > copying of the file or running boot_build.bat. > 2) Windows build

Re: [Firebird-devel] [Firebird-checkins] SF.net SVN: firebird:[62991] firebird/trunk

20.02.2016 16:49, Vlad Khorsun wrote: > What issue this commit going to solve ? 1) Changes made in autoconfig_msvc.h aren't visible to the rest of sources without manual copying of the file or running boot_build.bat. 2) Windows build and posix build are fighting with each other overwriting

Re: [Firebird-devel] [Firebird-checkins] SF.net SVN: firebird:[62991] firebird/trunk

20.02.2016 17:34, aaf...@users.sourceforge.net wrote: > Revision: 62991 >http://sourceforge.net/p/firebird/code/62991 > Author: aafemt > Date: 2016-02-20 15:34:20 + (Sat, 20 Feb 2016) > Log Message: > --- > Use autoconfig_msvc.h from where it is What issue this

Re: [Firebird-devel] Srp username charset

Oh, I thought user name and password are us-ascii encoding. I don't know these encoding. 2016-02-20 22:03 GMT+09:00 Jiří Činčura : > Hi *, > > the username in Srp auth is expected to be in UTF8, right? > > -- > Mgr. Jiří Činčura > Independent IT Specialist > > >

[Firebird-devel] Srp username charset

Hi *, the username in Srp auth is expected to be in UTF8, right? -- Mgr. Jiří Činčura Independent IT Specialist -- Site24x7 APM Insight: Get Deep Visibility into Application Performance APM + Mobile APM + RUM: Monitor