Re: [Firebird-devel] IExternalEngineImpl and references from IPluginFactoryImpl (eventual AV)

2021-06-21 Thread Jiří Činčura
This https://github.com/FirebirdSQL/firebird/commit/9491bc1a46728eb4e57c8f77e77fb62287a55036#diff-7825c87bb1e585c93d6710d23be7e0b912ad5cc2e51b42b985273c6f3206c4d9 commit seems to be interesting. Also on FB 4.0.0.2496 I seems to have balanced count of `addRef` and `release` counts. Is this a

[Firebird-devel] IExternalEngineImpl and references from IPluginFactoryImpl (eventual AV)

2021-06-20 Thread Jiří Činčura
Hi *, My IPluginFactoryImpl implementation is a simple code that I saw used in Firebird's codebase. IPluginBase* Factory::createPlugin(ThrowStatusWrapper* status, IPluginConfig* factoryParameter) { auto p = new Plugin(); p->addRef();