Re: [Firebird-devel] Retrieving statement BLR for debug and test

2021-07-28 Thread Adriano dos Santos Fernandes
I've rolled back the feature after Pavel Zotov noted to not working (with remote protocol). Unfortunately I've only tested this with embedded but prepare flags are passed as info codes to engine and that seems incompatible with the feature. I want this feature to work with v4 too and don't want

Re: [Firebird-devel] Retrieving statement BLR for debug and test

2021-07-21 Thread Adriano dos Santos Fernandes
On 16/07/2021 09:38, Vlad Khorsun wrote: > 16.07.2021 15:22, Dimitry Sibiryakov wrote: >> 16.07.2021 14:19, Adriano dos Santos Fernandes wrote: >>> Instead of isc_info_sql_blr_bytes/isc_info_sql_blr_text, we can add >>> single top level info code with sub code for raw/blr / dsql/jrd parse >>>

Re: [Firebird-devel] Retrieving statement BLR for debug and test

2021-07-16 Thread Vlad Khorsun
16.07.2021 15:22, Dimitry Sibiryakov wrote: 16.07.2021 14:19, Adriano dos Santos Fernandes wrote: Instead of isc_info_sql_blr_bytes/isc_info_sql_blr_text, we can add single top level info code with sub code for raw/blr / dsql/jrd parse trees.   Info request cannot have subcodes, it'll break

Re: [Firebird-devel] Retrieving statement BLR for debug and test

2021-07-16 Thread Dimitry Sibiryakov
16.07.2021 14:19, Adriano dos Santos Fernandes wrote: Instead of isc_info_sql_blr_bytes/isc_info_sql_blr_text, we can add single top level info code with sub code for raw/blr / dsql/jrd parse trees. Info request cannot have subcodes, it'll break its design. -- WBR, SD. Firebird-Devel

Re: [Firebird-devel] Retrieving statement BLR for debug and test

2021-07-16 Thread Adriano dos Santos Fernandes
On 16/07/2021 06:25, Vlad Khorsun wrote: > 15.07.2021 22:34, Adriano dos Santos Fernandes wrote: >> Hi! >> >> Currently it's possible to set TraceDSQL config parameter in dev build >> to have formatted statement BLR in firebird.log, but that is not >> sufficient for automated tests. >> >> I want

Re: [Firebird-devel] Retrieving statement BLR for debug and test

2021-07-16 Thread Adriano dos Santos Fernandes
On 16/07/2021 05:50, Alex Peshkoff via Firebird-devel wrote: > On 7/15/21 10:56 PM, Dimitry Sibiryakov wrote: >> 15.07.2021 21:34, Adriano dos Santos Fernandes wrote: >>> Comments? >> >>   I see no point in the new interface. > > Not new iface, just extension of old one. > Just a new const as

Re: [Firebird-devel] Retrieving statement BLR for debug and test

2021-07-16 Thread Vlad Khorsun
16.07.2021 13:03, Dimitry Sibiryakov wrote: 16.07.2021 11:52, Vlad Khorsun wrote:    We need a way to know when application uses BLR API directly.   Direct BLR compilation won't have DSQL prepare event with the same statement ID. Isn't it enough for this topic's purpose?.. There are

Re: [Firebird-devel] Retrieving statement BLR for debug and test

2021-07-16 Thread Dimitry Sibiryakov
16.07.2021 11:52, Vlad Khorsun wrote:   We need a way to know when application uses BLR API directly. Direct BLR compilation won't have DSQL prepare event with the same statement ID. Isn't it enough for this topic's purpose?.. I.e. trace_blr_compile is very different from

Re: [Firebird-devel] Retrieving statement BLR for debug and test

2021-07-16 Thread Vlad Khorsun
16.07.2021 12:26, Dimitry Sibiryakov wrote: 16.07.2021 11:21, Vlad Khorsun wrote: Second, we need separate trace event to show generated BLR.   Isn't trace_blr_compile enough? We need a way to know when application uses BLR API directly. I.e. trace_blr_compile is very different from

Re: [Firebird-devel] Retrieving statement BLR for debug and test

2021-07-16 Thread Dimitry Sibiryakov
16.07.2021 11:21, Vlad Khorsun wrote: Second, we need separate trace event to show generated BLR. Isn't trace_blr_compile enough? -- WBR, SD. Firebird-Devel mailing list, web interface at https://lists.sourceforge.net/lists/listinfo/firebird-devel

Re: [Firebird-devel] Retrieving statement BLR for debug and test

2021-07-16 Thread Vlad Khorsun
15.07.2021 22:34, Adriano dos Santos Fernandes wrote: Hi! Currently it's possible to set TraceDSQL config parameter in dev build to have formatted statement BLR in firebird.log, but that is not sufficient for automated tests. I want to add facility to make it possible to applications request

Re: [Firebird-devel] Retrieving statement BLR for debug and test

2021-07-16 Thread Dimitry Sibiryakov
16.07.2021 11:21, Vlad Khorsun wrote:   First, existing BLR-related trace events are not unused. Right, I mixed them up with DYN events. -- WBR, SD. Firebird-Devel mailing list, web interface at https://lists.sourceforge.net/lists/listinfo/firebird-devel

Re: [Firebird-devel] Retrieving statement BLR for debug and test

2021-07-16 Thread Vlad Khorsun
15.07.2021 22:56, Dimitry Sibiryakov wrote: 15.07.2021 21:34, Adriano dos Santos Fernandes wrote: Comments? ...   It would be simpler to raise trace BLR event from SQL prepare and let anyone interested to watch generated BLR using existing (currently unused) trace parameter. First,

Re: [Firebird-devel] Retrieving statement BLR for debug and test

2021-07-16 Thread Dimitry Sibiryakov
16.07.2021 10:50, Alex Peshkoff via Firebird-devel wrote: The only problem is that longterm we have plan to remove BLR support at all If I'm not mistaken, these were plans to remove BLR as an intermediate language from DSQL, not "at all". BLR was going still to be a part of Message API for

Re: [Firebird-devel] Retrieving statement BLR for debug and test

2021-07-16 Thread Alex Peshkoff via Firebird-devel
On 7/15/21 10:56 PM, Dimitry Sibiryakov wrote: 15.07.2021 21:34, Adriano dos Santos Fernandes wrote: Comments?   I see no point in the new interface. Not new iface, just extension of old one. It would be simpler to raise trace BLR event from SQL prepare and let anyone interested to watch

Re: [Firebird-devel] Retrieving statement BLR for debug and test

2021-07-15 Thread Dimitry Sibiryakov
15.07.2021 21:34, Adriano dos Santos Fernandes wrote: Comments? I see no point in the new interface. It would be simpler to raise trace BLR event from SQL prepare and let anyone interested to watch generated BLR using existing (currently unused) trace parameter. -- WBR, SD.

[Firebird-devel] Retrieving statement BLR for debug and test

2021-07-15 Thread Adriano dos Santos Fernandes
Hi! Currently it's possible to set TraceDSQL config parameter in dev build to have formatted statement BLR in firebird.log, but that is not sufficient for automated tests. I want to add facility to make it possible to applications request individual statements BLR for debug and test purposes