Re: [Firebird-devel] SVN: firebird:[59943] firebird/trunk/src/yvalve/why.cpp

2014-08-04 Thread Alex Peshkoff
On 08/03/14 19:33, Dimitry Sibiryakov wrote: 03.08.2014 17:28, Dmitry Yemanov wrote: I've just left it to the author to fix. I don't have commit rights, you know... I couldn't run tpcc with this assert activated. This tpc-c must do something crazy to activate the assert like

Re: [Firebird-devel] SVN: firebird:[59943] firebird/trunk/src/yvalve/why.cpp

2014-08-04 Thread Dimitry Sibiryakov
04.08.2014 9:29, Alex Peshkoff wrote: But it worked in 2.5 and before... The assert wasn't there. I put the assert there in assumption that application use NULL when there is no input or output parameters. Zero-length SQLDA is out of my imagination. You should either move the assertion

[Firebird-devel] SVN: firebird:[59943] firebird/trunk/src/yvalve/why.cpp

2014-08-03 Thread Dimitry Sibiryakov
Commented out the annoying (thus supposedly wrong?) assertion. Without this assert following code will crash with segfault on using offsets array. If this assert is activated on queries without output parameters, it should be changed to fb_assert(count == 0 || offsets), not just

Re: [Firebird-devel] SVN: firebird:[59943] firebird/trunk/src/yvalve/why.cpp

2014-08-03 Thread Dmitry Yemanov
03.08.2014 18:29, Dimitry Sibiryakov wrote: Commented out the annoying (thus supposedly wrong?) assertion. Without this assert following code will crash with segfault on using offsets array. If this assert is activated on queries without output parameters, it should be changed to

Re: [Firebird-devel] SVN: firebird:[59943] firebird/trunk/src/yvalve/why.cpp

2014-08-03 Thread Dimitry Sibiryakov
03.08.2014 17:28, Dmitry Yemanov wrote: I've just left it to the author to fix. I don't have commit rights, you know... I couldn't run tpcc with this assert activated. This tpc-c must do something crazy to activate the assert like fetching from statement without output parameters or