Re: [Firebird-devel] Tackling CORE-4526 (OFFSET FETCH)

2014-12-09 Thread Mark Rotteveel
On 29-11-2014 16:48, Mark Rotteveel wrote: On 27-11-2014 22:21, Dmitry Yemanov wrote: 28.11.2014 00:15, Mark Rotteveel wrote: Interesting, I assume that is for dialect 1 as it doesn't have quoting? Supposedly, yes. This trick was inherited from InterBase and we try to maintain it (when it's

Re: [Firebird-devel] Tackling CORE-4526 (OFFSET FETCH)

2014-12-09 Thread Dmitry Yemanov
09.12.2014 22:01, Mark Rotteveel wrote: Dmitry, can you resolve the ticket for me? Done. Dmitry -- Download BIRT iHub F-Type - The Free Enterprise-Grade BIRT Server from Actuate! Instantly Supercharge Your

Re: [Firebird-devel] Tackling CORE-4526 (OFFSET FETCH)

2014-11-30 Thread Dmitry Yemanov
30.11.2014 15:37, Mark Rotteveel wrote: Well, that was quick ;) Should I go and implement it anyway, or do we leave this until it is reported against an actual 3.0 release? So far it's about pure artificial testing, not something really used in production. So I'd wait a bit more ;-) Dmitry

Re: [Firebird-devel] Tackling CORE-4526 (OFFSET FETCH)

2014-11-29 Thread Mark Rotteveel
On 26-11-2014 10:40, Dmitry Yemanov wrote: 3) New reserved words (OFFSET and ROW) should be added to the keyword_or_column rule to simplify migration. That said, I'm wondering why ROWS wasn't added there too in v2.0. Probably my oversight. Just checked, ROWS was already in keyword_or_column.

Re: [Firebird-devel] Tackling CORE-4526 (OFFSET FETCH)

2014-11-26 Thread Dmitry Yemanov
Mark, I'm looking at the patch, please be patient ;-) Any news on this? I don't have any major problems with the patch. Just a few questions: 1) Why have you decided to extend select_expr via duplication rather than using something like this: %type selectExprNode select_expr select_expr :

Re: [Firebird-devel] Tackling CORE-4526 (OFFSET FETCH)

2014-11-22 Thread Mark Rotteveel
On 11-11-2014 19:05, Dmitry Yemanov wrote: 11.11.2014 21:02, Mark Rotteveel wrote: Anyone? I'm looking at the patch, please be patient ;-) Any news on this? Mark -- Mark Rotteveel -- Download BIRT iHub F-Type -

Re: [Firebird-devel] Tackling CORE-4526 (OFFSET FETCH)

2014-11-11 Thread Mark Rotteveel
On 9-11-2014 12:01, Mark Rotteveel wrote: On 22-8-2014 16:54, Mark Rotteveel wrote: Are there any objections if I try to come up with a patch to add OFFSET and FETCH to the select syntax (CORE-4526)? Attached you will find my patch for this feature. The grammar matches the SQL definition. I

Re: [Firebird-devel] Tackling CORE-4526 (OFFSET FETCH)

2014-11-11 Thread Dmitry Yemanov
11.11.2014 21:02, Mark Rotteveel wrote: Anyone? I'm looking at the patch, please be patient ;-) Dmitry -- Comprehensive Server Monitoring with Site24x7. Monitor 10 servers for $9/Month. Get alerted through email,

Re: [Firebird-devel] Tackling CORE-4526 (OFFSET FETCH)

2014-11-09 Thread Mark Rotteveel
On 22-8-2014 16:54, Mark Rotteveel wrote: Are there any objections if I try to come up with a patch to add OFFSET and FETCH to the select syntax (CORE-4526)? Attached you will find my patch for this feature. The grammar matches the SQL definition. I have made the existing rows_clause

Re: [Firebird-devel] Tackling CORE-4526 (OFFSET FETCH)

2014-11-03 Thread Mark Rotteveel
On 22-8-2014 19:29, Dmitry Yemanov wrote: 22.08.2014 18:54, Mark Rotteveel wrote: Are there any objections if I try to come up with a patch to add OFFSET and FETCH to the select syntax (CORE-4526)? Feel free. I am working on it now, however I have a question: For implementing this I need

Re: [Firebird-devel] Tackling CORE-4526 (OFFSET FETCH)

2014-11-03 Thread Dmitry Yemanov
03.11.2014 23:14, Mark Rotteveel wrote: For implementing this I need to add two keywords: ROW and OFFSET (note: defined as reserved in SQL standard), but looking at the definition in keywords.cpp, I wonder what I need to use for version (1 or 2, or maybe a different value. Version 2.

[Firebird-devel] Tackling CORE-4526 (OFFSET FETCH)

2014-08-22 Thread Mark Rotteveel
Are there any objections if I try to come up with a patch to add OFFSET and FETCH to the select syntax (CORE-4526)? Mark -- Mark Rotteveel -- Slashdot TV. Video for Nerds. Stuff that matters. http://tv.slashdot.org/

Re: [Firebird-devel] Tackling CORE-4526 (OFFSET FETCH)

2014-08-22 Thread Dmitry Yemanov
22.08.2014 18:54, Mark Rotteveel wrote: Are there any objections if I try to come up with a patch to add OFFSET and FETCH to the select syntax (CORE-4526)? Feel free. Dmitry -- Slashdot TV. Video for Nerds.