Re: [flac-dev] PATCH: FLAC__U64L definition

2014-01-07 Thread Erik de Castro Lopo
lvqcl wrote: It defines FLAC__U64L(x) simply as x##ULL. Applied. Thanks. Erik -- -- Erik de Castro Lopo http://www.mega-nerd.com/ ___ flac-dev mailing list flac-dev@xiph.org

Re: [flac-dev] Exact FLAC subset constraints

2014-01-07 Thread Erik de Castro Lopo
Brian Willoughby wrote: I think you've found a bug, Bart. flac 1.2.1 did not have any FLAC__format_blocksize_is_subset() function, so the source you're seeing in format.c must be new. If the format documentation you linked to is correct, then either the specifications are

Re: [flac-dev] PATCH: match calls and returns

2014-01-07 Thread Erik de Castro Lopo
lvqcl wrote: According to Agner Fog, ...you must make sure that all calls are matched with returns. Never jump out of a subroutine without a return and never use a return as an indirect jump. Applied Thanks. Erik -- -- Erik

Re: [flac-dev] PATCH: FLAC__ prefix to precompute_partition_info_sums_...

2014-01-07 Thread Erik de Castro Lopo
lvqcl wrote: All(?) non-static functions have FLAC__ prefix. But precompute_partition_info_sums_32bit_asm_ia32_() and ..._intrin_sse2() and ..._intrin_ssse3() don't have it. This patch adds the prefix to them. Applied thanks. Erik --

Re: [flac-dev] Windows linking problems

2014-01-07 Thread lvqcl
Brendan Bolles wrote: If someone would be so kind as to take a look, I have a branch set up, ready to show you the problem (after you download the Premiere SDK). I've posted this as a GitHub issue here: It looks like the linker cannot find libFLAC_static.lib and libFLAC++_static.lib. By

[flac-dev] Why Rice order in --best switch is limited to 6?

2014-01-07 Thread Барт Гопник
The --best switch currently synonymous with -8 that synonymous with --compression-level-8 that synonymous with -l 12 -b 4096 -m -e -r 6. Why value of -r switch in --best is limited to 6? The maximum Rice order is 8 (not 6) for the stream to be Subset compatible. -r 8 (-l 12 -b 4096 -m -e -r 8)

Re: [flac-dev] Why Rice order in --best switch is limited to 6?

2014-01-07 Thread lvqcl
Барт Гопник wrote: Why value of -r switch in --best is limited to 6? The maximum Rice order is 8 (not 6) for the stream to be Subset compatible. Because -r 8 is noticeable slower? The size difference is 0,0003%, the speed difference is 30...40%. BTW, you can also use -A=... options to

Re: [flac-dev] Why Rice order in --best switch is limited to 6?

2014-01-07 Thread lvqcl
Барт Гопник wrote: I think -r 8 is highest reasonable. E.g. from 5 to 12 values of -compression_level switch in FFMPEG uses value 8 of Rice order parameter. But FFMPEG uses flake encoder, not libFLAC. So their optimal values may differ. ___ flac-dev