ok, last night I checked in changes that I think should totally fix
the problem.
before, the process routines would encode a frame as soon as it
got a complete block. so it could not really tell when it had
reached the end of the input and would rely on the total samples
estimate to set the EOS
--- Erik de Castro Lopo [EMAIL PROTECTED] wrote:
Erik de Castro Lopo wrote:
Josh et al,
I've been tracking down a problem with generating OggFlac files.
snip
I have looked into this and suspect that the
FLAC__stream_encoder_finish()
function needs to finish off the stream using
Josh Coalson wrote:
thanks Erik, can you confirm that this is happening only because
the total_samples_estimate is 0? (so the e_o_s setting in the
existing code is never triggered).
In the Ogg code, I believe that there are two things that must be
satisfied to correctly write an end of
On Tue, Nov 07, 2006 at 06:31:04AM +1100, Erik de Castro Lopo wrote:
I haven't tested it, but I don't think just setting packet.e_o_s
is sufficient to close the stream. The forced ogg_stream_flush()
is required.
libogg checks the e_o_s flag (and has always done so, according to svn)
so you
Erik de Castro Lopo wrote:
Josh et al,
I've been tracking down a problem with generating OggFlac files.
snip
I have looked into this and suspect that the FLAC__stream_encoder_finish()
function needs to finish off the stream using a call to ogg_stream_flush()
instead of the standard
