Re: [Flightgear-devel] FGPositioned refactoring

2008-08-20 Thread Martin Spott
James Turner wrote: > I'd quite like to move forwards on this tonight, but I'd appreciate a > bit more assent or criticism before I get too much further into the > code. I'd say, if people don't care about responding for several days, they loose their qualification to criticize afterwards ...

Re: [Flightgear-devel] FGPositioned refactoring

2008-08-19 Thread James Turner
On 16 Aug 2008, at 03:10, James Turner wrote: > I'm planning to do a slightly intensive re-factoring - creating a > base class where one didn't exist before. The (draft) base class is > attached - it will become a base for the following: I'd quite like to move forwards on this tonight, but I

Re: [Flightgear-devel] FGPositioned refactoring

2008-08-17 Thread James Turner
On 17 Aug 2008, at 16:44, James Turner wrote: > Well, there's a motive here: because I'm using consecutive numbers for > the types, I can implement things like 'all airports' or 'all ATC > frequencies' as range compares, by doing lower_bound and upper_bound > queries against appropriate sets and

Re: [Flightgear-devel] FGPositioned refactoring

2008-08-17 Thread James Turner
On 16 Aug 2008, at 23:29, Tim Moore wrote: > I don't find this use of type enums in a base class to be clean at > all. I have > nothing against having a type field in a base, but with an enum > approach the > base has to have knowledge of all the derived classes, and any time > you add a >

Re: [Flightgear-devel] FGPositioned refactoring

2008-08-16 Thread Tim Moore
James Turner wrote: > So, I actively *want* the base class. It allows replacing various > 'type-testing' code with a single unified enum, which cleans up > various other places - right now there's code that is looking at > FGNavRecord's type directly (which is a integer code from Robin's DB)

Re: [Flightgear-devel] FGPositioned refactoring

2008-08-16 Thread James Turner
On 16 Aug 2008, at 11:37, Melchior FRANZ wrote: ftp://ftp.uni-duisburg.de/FlightGear/Misc_maf/SGHTMMap-20060223/SGHTMMap-first-take.diff Mathias will know more about it. :-) Gave this a quick eyeball and it seems pretty nice - and straightforward to integrate with my proposed base class

Re: [Flightgear-devel] FGPositioned refactoring

2008-08-16 Thread Melchior FRANZ
* Thomas Förster -- Saturday 16 August 2008: > As far as I know, Mathias Fröhlich has written a general > templated spatial index for simgear. ftp://ftp.uni-duisburg.de/FlightGear/Misc_maf/SGHTMMap-20060223/SGHTMMap-first-take.diff Mathias will know more about it. :-) m. --

Re: [Flightgear-devel] FGPositioned refactoring

2008-08-16 Thread James Turner
On 16 Aug 2008, at 09:50, Thomas Förster wrote: > while I'm pretty much in favour of spatial indices, note that a lot > of work in > that direction has been done already. As far as I know, Mathias > Fröhlich has > written a general templated spatial index for simgear. I've the code > with m

Re: [Flightgear-devel] FGPositioned refactoring

2008-08-16 Thread Thomas Förster
James, while I'm pretty much in favour of spatial indices, note that a lot of work in that direction has been done already. As far as I know, Mathias Fröhlich has written a general templated spatial index for simgear. I've the code with me, but haven't found time to look at it yet (Sorry Mathia

[Flightgear-devel] FGPositioned refactoring

2008-08-15 Thread James Turner
I'm planning to do a slightly intensive re-factoring - creating a base class where one didn't exist before. The (draft) base class is attached - it will become a base for the following: FGAirport FGRunway FGFix FGNavRecord ATCData The members are pretty