Re: [Flightgear-devel] Patch to perform airport searches case-insensitively

2008-06-03 Thread Melchior FRANZ
* Stuart Buchanan -- Monday 02 June 2008: ... and here's the patch, based on Fred's original patch. Assuming it passes muster, could someone review and commit please? I fixed the bug[1] and committed it, thanks Fred Stuart! Though Fred's way to display the entries in upper case hides the

Re: [Flightgear-devel] Patch to perform airport searches case-insensitively

2008-06-02 Thread Stuart Buchanan
--- On Sun, 1/6/08, Frederic Bouvier wrote: I confirm there in no strcasestr or equivalent in MS runtime. The patch below should be portable, although more convoluted. From reading the patch, I don't think this does quite what we want either. My reading is that this ensures that the

Re: [Flightgear-devel] Patch to perform airport searches case-insensitively

2008-06-02 Thread Stuart Buchanan
--- On Mon, 2/6/08, Melchior FRANZ wrote: * Stuart Buchanan -- Monday 02 June 2008: Nevertheless, I think these are acceptable numbers for a 3 character string. The user can easily perform a more specific search on receiving a large number of results. As I told on IRC already, the

Re: [Flightgear-devel] Patch to perform airport searches case-insensitively

2008-06-02 Thread Torsten Dreyer
Am Montag, 2. Juni 2008 schrieb Melchior FRANZ: * Stuart Buchanan -- Monday 02 June 2008: Nevertheless, I think these are acceptable numbers for a 3 character string. The user can easily perform a more specific search on receiving a large number of results. As I told on IRC already, the

Re: [Flightgear-devel] Patch to perform airport searches case-insensitively

2008-06-02 Thread Melchior FRANZ
* Torsten Dreyer -- Tuesday 03 June 2008: Maybe a litte checkbox named Case sensitive search might give the user the freedom of choice? This adds one option without dropping the other. Widgets are associated with one single property, and they read from it after getting a dialog-update and

Re: [Flightgear-devel] Patch to perform airport searches case-insensitively

2008-06-02 Thread Stuart Buchanan
--- On Mon, 2/6/08, Stuart Buchanan wrote: I will continue looking at this, though if anyone else would like to jump in with suggestions, that would be very welcome. ... and here's the patch, based on Fred's original patch. Assuming it passes muster, could someone review and commit please?

Re: [Flightgear-devel] Patch to perform airport searches case-insensitively

2008-06-02 Thread Melchior FRANZ
* Stuart Buchanan -- Monday 02 June 2008: Assuming it passes muster, [...] It doesn't. You are adding 2-space spaghetti code indentation to a file that uses 4 spaces. m. - This SF.net email is sponsored by: Microsoft Defy

Re: [Flightgear-devel] Patch to perform airport searches case-insensitively

2008-06-02 Thread Curtis Olson
Torsten Dreyer -- Tuesday 03 June 2008: Maybe a litte checkbox named Case sensitive search might give the user the freedom of choice? This adds one option without dropping the other. On Mon, Jun 2, 2008 at 4:07 PM, Melchior FRANZ wrote: Widgets are associated with one single property,

Re: [Flightgear-devel] Patch to perform airport searches case-insensitively

2008-06-02 Thread Melchior FRANZ
* Curtis Olson -- Monday 02 June 2008: I may be completely misunderstanding this whole thread, but could we add another widget to the search dialog window that is tied to a boolean property. We could, but it would IMHO also be a bit unclean, as it would influence all airport-search widgets.

Re: [Flightgear-devel] Patch to perform airport searches case-insensitively

2008-06-02 Thread Melchior FRANZ
* Melchior FRANZ -- Monday 02 June 2008: And before we do anything like that we should first decide if we *really* want and need the case sensitivity configurable. ... especially considering that we are having the discussion exactly because case-sensitivity turned out to be useless given the

Re: [Flightgear-devel] Patch to perform airport searches case-insensitively

2008-06-02 Thread Curtis Olson
On Mon, Jun 2, 2008 at 4:55 PM, Melchior FRANZ [EMAIL PROTECTED] wrote: * Melchior FRANZ -- Monday 02 June 2008: And before we do anything like that we should first decide if we *really* want and need the case sensitivity configurable. ... especially considering that we are having the

Re: [Flightgear-devel] Patch to perform airport searches case-insensitively

2008-06-02 Thread Melchior FRANZ
* Curtis Olson -- Tuesday 03 June 2008: Well assuming that we have agreed to switch over to a case insensitive search, I think we have. Takes another hour until I have compiled OSG 2.5.1 and the newest sg/fg changes, but then I'll commit Stuart's patch (after having fixed indendation and

Re: [Flightgear-devel] Patch to perform airport searches case-insensitively

2008-06-01 Thread Melchior FRANZ
* Stuart Buchanan -- Saturday 31 May 2008: +if (!_filter.empty() (strcasestr(entry.c_str(), _filter.c_str()) == NULL)) quote from 'man strcasestr': The strcasestr() function is a non-standard extension. I doubt that it's available on all supported platforms. m.

Re: [Flightgear-devel] Patch to perform airport searches case-insensitively

2008-06-01 Thread Frederic Bouvier
Melchior FRANZ a écrit : * Stuart Buchanan -- Saturday 31 May 2008: +if (!_filter.empty() (strcasestr(entry.c_str(), _filter.c_str()) == NULL)) quote from 'man strcasestr': The strcasestr() function is a non-standard extension. I doubt that it's available on all

[Flightgear-devel] Patch to perform airport searches case-insensitively

2008-05-31 Thread Stuart Buchanan
Hi All, Someone on the Forum (or was it here?) mentioned a problem where they couldn't use the Airport Search dialog easily because some airports in apt.dat are named in mixed case while some are in all-caps. Rather than attempt to fix apt.dat (I'm not completely mad ;) ), I've created a