Re: [Flightgear-devel] JSBSim Synch with FlightGear
On Mon, 10 Jun 2013, Erik Hofman wrote:
On 06/10/2013 10:12 AM, Anders Gidenstam wrote:
On Sun, 9 Jun 2013, Jon S. Berndt wrote:
Can I request that the current version of JSBSim that is in our cvs as of
this moment be synched to FlightGear as early as convenient for the
synch-er? What's the proper procedure?
Usually Erik does the synchronization. However, if he doesn't have time
(please, let us know if that's the case) I could take care of it.
Yes I do have priorities higher on my list, so it would be great if
someone else takes care of it.
Ok. Here is the first version:
http://www.gidenstam.org/users/anders/FlightGear/test/jsbsim-synch-2013-06-10.diff
I have, so far, (very) briefly tested it in FG with the c172p, ZLT-NT,
Short_Empire and MTB_20m (not in fgdata) aircraft and they seem to work,
including resets.
Additionally, my JSBSim/standalone performance tuning scripts for
Short_Empire still produce the same result as at the last FG release.
There are (at least :) two code issues:
1.
In src/FDM/JSBSim/models/FGPropagate.h there is a inline:d member function
that most probably should be moved to the .cpp file instead.
GCC posts a warning about returning a reference to a temporary variable
for it, which indeed does not sound like a good idea (the other similar
looking member functions return a reference to a /member/ variable).
Additionally, calling the * operator for FGColumnVector3 is probably not
going to be inlined so there'll be at least one call anyway. Input from
someone C++ current appreciated.. :)
const FGColumnVector3 GetEulerDeg(void) const { return
VState.qAttitudeLocal.GetEuler() * radtodeg; }
2.
The JSBSim class FGPropertyManager was previously derived from
SGPropertyNode, but isn't now. This affects the creation of the
main JSBSim object (FGFDMExec) since it requires a FGPropertyManager
instance to access the property tree.
I have currently changed the FG JSBSim driver, JSBSim.cxx, like this:
-fdmex = new FGFDMExec( (FGPropertyManager*)globals-get_props() );
+// FIXME: The FGPropertyManager object must be freed somewhere!
+fdmex = new FGFDMExec( new FGPropertyManager(
(FGPropertyNode*)globals-get_props() ) );
but this will leak a FGPropertyManager object on each reset.
Hopefully there is no problem to just keep track of the FGPropertyManager
object and delete it at reset. I have not tried that yet.
(The somewhat dubious cast of a SGPropertyNode pointer to one to its
(JSBSim) subclass FGPropertyNode mirrors that of the previous code that
has apparently worked ok.)
Cheers,
Anders
--
---
Anders Gidenstam
WWW: http://gitorious.org/anders-hangar
http://www.gidenstam.org/FlightGear/
--
This SF.net email is sponsored by Windows:
Build for Windows Store.
http://p.sf.net/sfu/windows-dev2dev
___
Flightgear-devel mailing list
Flightgear-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/flightgear-devel
Re: [Flightgear-devel] JSBSim Synch with FlightGear
Anders Gidenstam anders-...@gidenstam.org writes: 2. The JSBSim class FGPropertyManager was previously derived from SGPropertyNode, but isn't now. This affects the creation of the main JSBSim object (FGFDMExec) since it requires a FGPropertyManager instance to access the property tree. I have currently changed the FG JSBSim driver, JSBSim.cxx, like this: -fdmex = new FGFDMExec( (FGPropertyManager*)globals-get_props() ); +// FIXME: The FGPropertyManager object must be freed somewhere! + fdmex = new FGFDMExec( new FGPropertyManager( (FGPropertyNode*)globals-get_props() ) ); but this will leak a FGPropertyManager object on each reset. Hopefully there is no problem to just keep track of the FGPropertyManager object and delete it at reset. I have not tried that yet. wouldn't it better to have something like this: FGPropertyManager pm = FGPropertyManager((FGPropertyNode*)globals-get_props() ); fdmex = new FGFDMExec(pm); that way we don't leak an FGPropertyManager object on each reset. seems to work for me. --alex-- -- | I believe the moment is at hand when, by a paranoiac and active | | advance of the mind, it will be possible (simultaneously with | | automatism and other passive states) to systematize confusion | | and thus to help to discredit completely the world of reality. | -- This SF.net email is sponsored by Windows: Build for Windows Store. http://p.sf.net/sfu/windows-dev2dev ___ Flightgear-devel mailing list Flightgear-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/flightgear-devel
Re: [Flightgear-devel] JSBSim Synch with FlightGear
On Tue, 11 Jun 2013, Alex Romosan wrote: wouldn't it better to have something like this: FGPropertyManager pm = FGPropertyManager((FGPropertyNode*)globals-get_props() ); fdmex = new FGFDMExec(pm); that way we don't leak an FGPropertyManager object on each reset. seems to work for me. That certainly does not look right. That way the FGPropertyManager instance is a local variable in the FGJSBsim object's constructor. Hence it's address ought to refer to stack memory that could (most likely will) be reused after the constructor has returned. Adding a FGPropertyManager member variable to the JSBSim class, on the other hand, may well be a solution. I do need to double check what JSBSim does with the property tree when the FGFDMExec object is deleted (as it is on each reset). Cheers, Anders -- --- Anders Gidenstam WWW: http://gitorious.org/anders-hangar http://www.gidenstam.org/FlightGear/ -- This SF.net email is sponsored by Windows: Build for Windows Store. http://p.sf.net/sfu/windows-dev2dev ___ Flightgear-devel mailing list Flightgear-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/flightgear-devel
Re: [Flightgear-devel] JSBSim Synch with FlightGear
Ok, I have pushed the current JSBSim/CVS version to FlightGear git. Please check for and report breakages. In case of aircraft breakages compare aircraft behaviour before and after the JSBSim update, if possible, to determine if the breakage is new or not. Cheers, Anders -- --- Anders Gidenstam WWW: http://gitorious.org/anders-hangar http://www.gidenstam.org/FlightGear/ -- This SF.net email is sponsored by Windows: Build for Windows Store. http://p.sf.net/sfu/windows-dev2dev ___ Flightgear-devel mailing list Flightgear-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/flightgear-devel
Re: [Flightgear-devel] JSBSim Synch with FlightGear
Hi Anders, Ok, I have pushed the current JSBSim/CVS version to FlightGear git. a very quick test flight with the 747-400 showed no different behaviour than yesterday. I'll do some more thorough testing later this week, but so far all looks fine. Thanks for taking care of the update! Gijs -- This SF.net email is sponsored by Windows: Build for Windows Store. http://p.sf.net/sfu/windows-dev2dev___ Flightgear-devel mailing list Flightgear-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/flightgear-devel
Re: [Flightgear-devel] JSBSim Synch with FlightGear
Ditto here with my WIP Thanks Alan From: Gijs de Rooy Sent: Tuesday, June 11, 2013 10:08 PM To: FlightGear Development list Subject: Re: [Flightgear-devel] JSBSim Synch with FlightGear Hi Anders, Ok, I have pushed the current JSBSim/CVS version to FlightGear git. a very quick test flight with the 747-400 showed no different behaviour than yesterday. I'll do some more thorough testing later this week, but so far all looks fine. Thanks for taking care of the update! Gijs -- This SF.net email is sponsored by Windows: Build for Windows Store. http://p.sf.net/sfu/windows-dev2dev ___ Flightgear-devel mailing list Flightgear-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/flightgear-devel -- This SF.net email is sponsored by Windows: Build for Windows Store. http://p.sf.net/sfu/windows-dev2dev___ Flightgear-devel mailing list Flightgear-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/flightgear-devel
Re: [Flightgear-devel] JSBSim Synch with FlightGear
Ok, I have pushed the current JSBSim/CVS version to FlightGear git. Please check for and report breakages. In case of aircraft breakages compare aircraft behaviour before and after the JSBSim update, if possible, to determine if the breakage is new or not. Cheers, Anders That's great, thanks, Anders! Jon -- This SF.net email is sponsored by Windows: Build for Windows Store. http://p.sf.net/sfu/windows-dev2dev ___ Flightgear-devel mailing list Flightgear-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/flightgear-devel
Re: [Flightgear-devel] JSBSim Synch with FlightGear
On Sun, 9 Jun 2013, Jon S. Berndt wrote: Can I request that the current version of JSBSim that is in our cvs as of this moment be synched to FlightGear as early as convenient for the synch-er? What's the proper procedure? Usually Erik does the synchronization. However, if he doesn't have time (please, let us know if that's the case) I could take care of it. Cheers, Anders -- --- Anders Gidenstam WWW: http://gitorious.org/anders-hangar http://www.gidenstam.org/FlightGear/ -- How ServiceNow helps IT people transform IT departments: 1. A cloud service to automate IT design, transition and operations 2. Dashboards that offer high-level views of enterprise services 3. A single system of record for all IT processes http://p.sf.net/sfu/servicenow-d2d-j ___ Flightgear-devel mailing list Flightgear-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/flightgear-devel
Re: [Flightgear-devel] JSBSim Synch with FlightGear
On 06/10/2013 10:12 AM, Anders Gidenstam wrote: On Sun, 9 Jun 2013, Jon S. Berndt wrote: Can I request that the current version of JSBSim that is in our cvs as of this moment be synched to FlightGear as early as convenient for the synch-er? What's the proper procedure? Usually Erik does the synchronization. However, if he doesn't have time (please, let us know if that's the case) I could take care of it. Yes I do have priorities higher on my list, so it would be great if someone else takes care of it. Erik -- http://www.adalin.com - Hardware accelerated AeonWave and OpenAL for Windows and Linux - AeonWave Audio Effects software for DJ, Instrumentalist and Vocalist -- How ServiceNow helps IT people transform IT departments: 1. A cloud service to automate IT design, transition and operations 2. Dashboards that offer high-level views of enterprise services 3. A single system of record for all IT processes http://p.sf.net/sfu/servicenow-d2d-j ___ Flightgear-devel mailing list Flightgear-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/flightgear-devel
Re: [Flightgear-devel] JSBSim Synch with FlightGear
Can I request that the current version of JSBSim that is in our cvs as of this moment be synched to FlightGear as early as convenient for the synch-er? What's the proper procedure? Jon From: James Turner [mailto:zakal...@mac.com] Sent: Monday, January 14, 2013 1:22 AM To: FlightGear developers discussions Subject: Re: [Flightgear-devel] JSBSim Synch with FlightGear On 14 Jan 2013, at 02:57, Jon S. Berndt jonsber...@comcast.net wrote: When's the next released scheduled after the upcoming one? http://wiki.flightgear.org/Release_plan So, 7 months from now. While it would be good to have a new version of JSBSim, the whole purpose of the freeze is to give a stable target for testing against - replacing one of the FDMs with a significantly changed version definitely doesn't fit with that! I see Torsten has already updated that page with a new task to sync JSBSim when entering feature freeze - as he said, the process improves! Regards, James -- How ServiceNow helps IT people transform IT departments: 1. A cloud service to automate IT design, transition and operations 2. Dashboards that offer high-level views of enterprise services 3. A single system of record for all IT processes http://p.sf.net/sfu/servicenow-d2d-j___ Flightgear-devel mailing list Flightgear-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/flightgear-devel
Re: [Flightgear-devel] JSBSim Synch with FlightGear
On 14 Jan 2013, at 02:57, Jon S. Berndt jonsber...@comcast.net wrote: When's the next released scheduled after the upcoming one? http://wiki.flightgear.org/Release_plan So, 7 months from now. While it would be good to have a new version of JSBSim, the whole purpose of the freeze is to give a stable target for testing against - replacing one of the FDMs with a significantly changed version definitely doesn't fit with that! I see Torsten has already updated that page with a new task to sync JSBSim when entering feature freeze - as he said, the process improves! Regards, James -- Master Visual Studio, SharePoint, SQL, ASP.NET, C# 2012, HTML5, CSS, MVC, Windows 8 Apps, JavaScript and much more. Keep your skills current with LearnDevNow - 3,200 step-by-step video tutorials by Microsoft MVPs and experts. SALE $99.99 this month only -- learn more at: http://p.sf.net/sfu/learnmore_122412___ Flightgear-devel mailing list Flightgear-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/flightgear-devel
Re: [Flightgear-devel] JSBSim Synch with FlightGear
Am 14.01.2013 03:57, schrieb Jon S. Berndt: Outerra will be more up to date than FlightGear with respect to JSBSim. It's hard to be the best all the times ;-) Torsten -- Master Visual Studio, SharePoint, SQL, ASP.NET, C# 2012, HTML5, CSS, MVC, Windows 8 Apps, JavaScript and much more. Keep your skills current with LearnDevNow - 3,200 step-by-step video tutorials by Microsoft MVPs and experts. SALE $99.99 this month only -- learn more at: http://p.sf.net/sfu/learnmore_122412 ___ Flightgear-devel mailing list Flightgear-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/flightgear-devel
Re: [Flightgear-devel] JSBSim Synch with FlightGear
On Sun, Jan 6, 2013 at 11:35 AM, Torsten Dreye wrote: Hi JSBSim and FlightGear lists, should we sync the latest JSBSim code into FlightGear for the next release, scheduled for February this year? My vote is not to sync at this point. I'd consider a JSBSim sync to be similar to feature development, particularly given the possible impact on a large portion of the FG fleet. Perhaps if it was only a day or so after the feature freeze we might be flexible, but 4 days before the release branch is cut is too late IMO. -Stuart -- Master Visual Studio, SharePoint, SQL, ASP.NET, C# 2012, HTML5, CSS, MVC, Windows 8 Apps, JavaScript and much more. Keep your skills current with LearnDevNow - 3,200 step-by-step video tutorials by Microsoft MVPs and experts. ON SALE this month only -- learn more at: http://p.sf.net/sfu/learnmore_123012 ___ Flightgear-devel mailing list Flightgear-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/flightgear-devel
Re: [Flightgear-devel] JSBSim Synch with FlightGear
On 13 Jan 2013, at 19:33, Stuart Buchanan stuar...@gmail.com wrote: On Sun, Jan 6, 2013 at 11:35 AM, Torsten Dreye wrote: Hi JSBSim and FlightGear lists, should we sync the latest JSBSim code into FlightGear for the next release, scheduled for February this year? My vote is not to sync at this point. I'd consider a JSBSim sync to be similar to feature development, particularly given the possible impact on a large portion of the FG fleet. Perhaps if it was only a day or so after the feature freeze we might be flexible, but 4 days before the release branch is cut is too late IMO. Agreed. We could have a release schedule item to sync with JSBSIm just before the code is feature frozen, but anyway it's too late for this release. James -Stuart -- Master Visual Studio, SharePoint, SQL, ASP.NET, C# 2012, HTML5, CSS, MVC, Windows 8 Apps, JavaScript and much more. Keep your skills current with LearnDevNow - 3,200 step-by-step video tutorials by Microsoft MVPs and experts. ON SALE this month only -- learn more at: http://p.sf.net/sfu/learnmore_123012 ___ Flightgear-devel mailing list Flightgear-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/flightgear-devel -- Master Visual Studio, SharePoint, SQL, ASP.NET, C# 2012, HTML5, CSS, MVC, Windows 8 Apps, JavaScript and much more. Keep your skills current with LearnDevNow - 3,200 step-by-step video tutorials by Microsoft MVPs and experts. ON SALE this month only -- learn more at: http://p.sf.net/sfu/learnmore_123012 ___ Flightgear-devel mailing list Flightgear-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/flightgear-devel
Re: [Flightgear-devel] JSBSim Synch with FlightGear
On Sun, Jan 6, 2013 at 11:35 AM, Torsten Dreye wrote: Hi JSBSim and FlightGear lists, should we sync the latest JSBSim code into FlightGear for the next release, scheduled for February this year? My vote is not to sync at this point. I'd consider a JSBSim sync to be similar to feature development, particularly given the possible impact on a large portion of the FG fleet. Perhaps if it was only a day or so after the feature freeze we might be flexible, but 4 days before the release branch is cut is too late IMO. -Stuart I had hoped that we could do this a couple of months ago, but not synching JSBSim with the latest FlightGear would be very, very unfortunate. I'm not sure when the last sync occurred (does anyone know?), but there have been a lot of new features and bug fixes. Development has been very active. FlightGear will be very much behind the curve relative to the current JSBSim state if we don't synch. I've been driving FlightGear as an external visuals application from JSBSim lately, but I'd prefer to run sims fully integrated. I've got another reason for it to be integrated, but I need to discuss that with Curt offline, first. Jon -- Master Visual Studio, SharePoint, SQL, ASP.NET, C# 2012, HTML5, CSS, MVC, Windows 8 Apps, JavaScript and much more. Keep your skills current with LearnDevNow - 3,200 step-by-step video tutorials by Microsoft MVPs and experts. ON SALE this month only -- learn more at: http://p.sf.net/sfu/learnmore_123012 ___ Flightgear-devel mailing list Flightgear-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/flightgear-devel
Re: [Flightgear-devel] JSBSim Synch with FlightGear
Am 13.01.2013 20:33, schrieb Stuart Buchanan: On Sun, Jan 6, 2013 at 11:35 AM, Torsten Dreye wrote: Hi JSBSim and FlightGear lists, should we sync the latest JSBSim code into FlightGear for the next release, scheduled for February this year? My vote is not to sync at this point. I'd consider a JSBSim sync to be similar to feature development, particularly given the possible impact on a large portion of the FG fleet. Perhaps if it was only a day or so after the feature freeze we might be flexible, but 4 days before the release branch is cut is too late IMO. Agreed. Unless there is no major bug fixed, we should merge soon after the branch day and just before the next feature freeze. I have just added this to the lessons learned of our release plan. Thanks, Torsten -- Master Visual Studio, SharePoint, SQL, ASP.NET, C# 2012, HTML5, CSS, MVC, Windows 8 Apps, JavaScript and much more. Keep your skills current with LearnDevNow - 3,200 step-by-step video tutorials by Microsoft MVPs and experts. ON SALE this month only -- learn more at: http://p.sf.net/sfu/learnmore_123012 ___ Flightgear-devel mailing list Flightgear-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/flightgear-devel
Re: [Flightgear-devel] JSBSim Synch with FlightGear
I had hoped that we could do this a couple of months ago, but not synching JSBSim with the latest FlightGear would be very, very unfortunate. I'm not sure when the last sync occurred (does anyone know?), but there have been a lot of new features and bug fixes. Development has been very active. FlightGear will be very much behind the curve relative to the current JSBSim state if we don't synch. I've been driving FlightGear as an external visuals application from JSBSim lately, but I'd prefer to run sims fully integrated. I've got another reason for it to be integrated, but I need to discuss that with Curt offline, first. Yes, i had hoped, too. However, as you mentioned, many new features have been developed and that violates our feature freeze rule, unfortunately. That rule has been introduced for exactly this situation: not to raise some last minute issues (to avoid bugs here). Sorry - but as we improve our plan with every release, this most likely will not happen again ;-) Torsten -- Master Visual Studio, SharePoint, SQL, ASP.NET, C# 2012, HTML5, CSS, MVC, Windows 8 Apps, JavaScript and much more. Keep your skills current with LearnDevNow - 3,200 step-by-step video tutorials by Microsoft MVPs and experts. ON SALE this month only -- learn more at: http://p.sf.net/sfu/learnmore_123012 ___ Flightgear-devel mailing list Flightgear-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/flightgear-devel
Re: [Flightgear-devel] JSBSim Synch with FlightGear
Yes, i had hoped, too. However, as you mentioned, many new features have been developed and that violates our feature freeze rule, unfortunately. That rule has been introduced for exactly this situation: not to raise some last minute issues (to avoid bugs here). Sorry - but as we improve our plan with every release, this most likely will not happen again ;-) Torsten When was the last time that JSBSim was synched with FlightGear? Jon -- Master Visual Studio, SharePoint, SQL, ASP.NET, C# 2012, HTML5, CSS, MVC, Windows 8 Apps, JavaScript and much more. Keep your skills current with LearnDevNow - 3,200 step-by-step video tutorials by Microsoft MVPs and experts. ON SALE this month only -- learn more at: http://p.sf.net/sfu/learnmore_123012 ___ Flightgear-devel mailing list Flightgear-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/flightgear-devel
Re: [Flightgear-devel] JSBSim Synch with FlightGear
On Sunday 13 January 2013 16:38:29 Jon S. Berndt wrote: Yes, i had hoped, too. However, as you mentioned, many new features have been developed and that violates our feature freeze rule, unfortunately. That rule has been introduced for exactly this situation: not to raise some last minute issues (to avoid bugs here). Sorry - but as we improve our plan with every release, this most likely will not happen again ;-) Torsten When was the last time that JSBSim was synched with FlightGear? Jon We synced about six months ago just before the last release of FGFS. -- Master Visual Studio, SharePoint, SQL, ASP.NET, C# 2012, HTML5, CSS, MVC, Windows 8 Apps, JavaScript and much more. Keep your skills current with LearnDevNow - 3,200 step-by-step video tutorials by Microsoft MVPs and experts. SALE $99.99 this month only -- learn more at: http://p.sf.net/sfu/learnmore_122412 ___ Flightgear-devel mailing list Flightgear-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/flightgear-devel
Re: [Flightgear-devel] JSBSim Synch with FlightGear
Sorry - but as we improve our plan with every release, this most likely will not happen again ;-) Torsten When was the last time that JSBSim was synched with FlightGear? Jon We synced about six months ago just before the last release of FGFS. Outerra will be more up to date than FlightGear with respect to JSBSim. :-( When's the next released scheduled after the upcoming one? JB -- Master Visual Studio, SharePoint, SQL, ASP.NET, C# 2012, HTML5, CSS, MVC, Windows 8 Apps, JavaScript and much more. Keep your skills current with LearnDevNow - 3,200 step-by-step video tutorials by Microsoft MVPs and experts. SALE $99.99 this month only -- learn more at: http://p.sf.net/sfu/learnmore_122412 ___ Flightgear-devel mailing list Flightgear-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/flightgear-devel
