Re: svn commit: r556112 - in /xmlgraphics/fop/trunk/src/java/org/apache/fop: fonts/truetype/TTFFile.java util/IntMap.java

2007-07-18 Thread Vincent Hennebert
Hi, Manuel Mall a écrit : On Wednesday 18 July 2007 02:58, Andreas L Delmelle wrote: snip/ Interestingly Java 1.5 has added the Integer.valueOf(int) method with the following comment: Flyweight pattern. That's what I was looking for before replying to Andreas' commit, and I was surprised to

Re: Remove Useless Comments

2007-07-18 Thread Vincent Hennebert
Hi Andreas, Andreas L Delmelle a écrit : On Jul 14, 2007, at 15:59, Vincent Hennebert wrote: Vincent Andreas L Delmelle a écrit : Tested locally, and is OK here. If you'd like, I can run a sanity diff later tonight, and commit the changes sometime tomorrow. Thanks, Andreas. We should

DO NOT REPLY [Bug 37157] - Port fox:destination to FOP Trunk

2007-07-18 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG· RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT http://issues.apache.org/bugzilla/show_bug.cgi?id=37157. ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND· INSERTED IN THE BUG DATABASE.

Re: FontSources

2007-07-18 Thread Jeremias Maerki
On 17.07.2007 11:36:42 Vincent Hennebert wrote: Hi Adrian, I'm not really a specialist of the font handling stuff in FOP, but having worked a bit in this area I can drop a few ideas (and ask a few naive questions), in the hope they will be useful. In the process of looking at this bug

Re: Plan for the 0.94 release

2007-07-18 Thread Jeremias Maerki
On 13.07.2007 17:08:22 Vincent Hennebert wrote: Jeremias Maerki a écrit : On 13.07.2007 15:45:01 Vincent Hennebert wrote: snip/ Speaking of branches, I noticed that there are many (very) old branches on Subversion. What about removing them? -1. If you want to clean up, please

Re: IntMap.java

2007-07-18 Thread J.Pietschmann
Vincent Hennebert wrote: Shall we launch a poll on fop-user about abandoning support for 1.4 and require 1.5 as a minimum? :-] A poll: maybe. Abandoning 1.3: Not yet. If the usage of those hash maps is only in a few places, we could provide JDK dependent code and tell people that FOP runs

Re: svn commit: r556112 - in /xmlgraphics/fop/trunk/src/java/org/apache/fop: fonts/truetype/TTFFile.java util/IntMap.java

2007-07-18 Thread Peter B. West
Vincent Hennebert wrote: Hi, Manuel Mall a écrit : On Wednesday 18 July 2007 02:58, Andreas L Delmelle wrote: snip/ Interestingly Java 1.5 has added the Integer.valueOf(int) method with the following comment: Flyweight pattern. That's what I was looking for before replying to Andreas'

Re: svn commit: r556112 - in /xmlgraphics/fop/trunk/src/java/org/apache/fop: fonts/truetype/TTFFile.java util/IntMap.java

2007-07-18 Thread Andreas L Delmelle
On Jul 18, 2007, at 14:28, Peter B. West wrote: Hi Peter alt-design always cached _all_ the Integer instances it needed. Another startling new idea. FWIW, I did not presume my idea to be startling or new. Just was a bit bugged by the number of places in the current trunk where

Re: FOP 0.94 : font auto detection test

2007-07-18 Thread Jeremias Maerki
To your question: Where are the xml metrics files ? They are not needed anymore. Today, we have a resonable well working font loading mechanism which makes metric files unnecessary since manual tweaking of the values is not needed anymore. Well, that's the theory. Auto-configuration still is a

Re: IntMap.java

2007-07-18 Thread Peter B. West
J.Pietschmann wrote: Vincent Hennebert wrote: Shall we launch a poll on fop-user about abandoning support for 1.4 and require 1.5 as a minimum? :-] A poll: maybe. Abandoning 1.3: Not yet. If the usage of those hash maps is only in a few places, we could provide JDK dependent code and tell

Re: svn commit: r554092 - in /xmlgraphics/fop/trunk/src/java/org/apache/fop/render/txt: TXTFOEventHandlerMaker.java TXTHandler.java

2007-07-18 Thread Jeremias Maerki
Unused, yes, because I seem to have screwed up. The TXTHandler was added as part of Sergey Simonchik's patch #37253, applied with revision: http://svn.apache.org/viewvc?view=revrevision=332141 Then, during refactoring for dynamic Renderer and FOEventHandler configuration, the TXTHandler got

Re: svn commit: r557035 - in /xmlgraphics/fop/trunk/src/java/org/apache/fop: fonts/truetype/ util/

2007-07-18 Thread Jeremias Maerki
On 17.07.2007 21:29:43 adelmelle wrote: Author: adelmelle Date: Tue Jul 17 12:29:40 2007 New Revision: 557035 URL: http://svn.apache.org/viewvc?view=revrev=557035 Log: Undo changes of r556112 snip/ Modified: xmlgraphics/fop/trunk/src/java/org/apache/fop/util/DataURIResolver.java

Re: IntMap.java

2007-07-18 Thread Chris Bowditch
J.Pietschmann wrote: Vincent Hennebert wrote: Shall we launch a poll on fop-user about abandoning support for 1.4 and require 1.5 as a minimum? :-] A poll: maybe. Abandoning 1.3: Not yet. Did you mean 1.4 here? I thought we had all agreed to drop support for 1.3 now? I have long argued

Re: svn commit: r557035 - in /xmlgraphics/fop/trunk/src/java/org/apache/fop: fonts/truetype/ util/

2007-07-18 Thread Andreas L Delmelle
On Jul 18, 2007, at 16:07, Jeremias Maerki wrote: - * @see a href=http://www.ietf.org/rfc/rfc2397;RFC 2397/a + * @inheritDoc a href=http://www.ietf.org/rfc/rfc2397;RFC 2397/a ^ Careful Sorry, but no need to worry. If the correct [EMAIL PROTECTED] syntax

Re: Lines breaking on '/' and '-'

2007-07-18 Thread Manuel Mall
On Wednesday 18 July 2007 23:15, Manuel Mall wrote: On Wednesday 18 July 2007 19:01, Andreas L Delmelle wrote: On Jul 18, 2007, at 10:15, Vincent Hennebert wrote: J.Pietschmann a écrit : Brad Smith wrote: snip/ Turned out adding basic support for keep-together.within-line=always was

Re: Lines breaking on '/' and '-'

2007-07-18 Thread Andreas L Delmelle
On Jul 18, 2007, at 17:44, Manuel Mall wrote: Hi Manuel snip / This proposed patch seems to cause a side-effect I would like a clarification on. The following fo snippet fo:block keep-together=alwayssome long text/fo:block used to have the effect of keeping some long text on a single page.

Re: Lines breaking on '/' and '-'

2007-07-18 Thread Jeremias Maerki
On 18.07.2007 18:00:57 Andreas L Delmelle wrote: On Jul 18, 2007, at 17:44, Manuel Mall wrote: Hi Manuel snip / This proposed patch seems to cause a side-effect I would like a clarification on. The following fo snippet fo:block keep-together=alwayssome long text/fo:block used

Re: svn commit: r557337 [1/8] - in /xmlgraphics/fop/trunk/src/java/org/apache/fop: apps/ area/ area/inline/ cli/ datatypes/ fo/ fo/expr/ fo/extensions/ fo/extensions/destination/ fo/extensions/svg/ fo

2007-07-18 Thread Jeremias Maerki
Thank you, Andreas!!! On 18.07.2007 19:51:04 Andreas L Delmelle wrote: On Jul 18, 2007, at 19:38, [EMAIL PROTECTED] wrote: Hi all Author: adelmelle Date: Wed Jul 18 10:37:14 2007 New Revision: 557337 URL: http://svn.apache.org/viewvc?view=revrev=557337 Log: * Javadoc update:

Re: svn commit: r557347 - in /xmlgraphics/fop/trunk: ./ src/documentation/content/xdocs/ src/java/org/apache/fop/fo/ src/java/org/apache/fop/layoutmgr/inline/ test/layoutengine/ test/layoutengine/stan

2007-07-18 Thread Andreas L Delmelle
On Jul 18, 2007, at 20:06, [EMAIL PROTECTED] wrote: Hi Manuel others Author: manuel Date: Wed Jul 18 11:06:09 2007 New Revision: 557347 URL: http://svn.apache.org/viewvc?view=revrev=557347 Log: Added support for keep-togther.within-line=always Cool to see this implemented so quickly! On

The effect of the property cache (or: playing around with a new toy)

2007-07-18 Thread Jeremias Maerki
I read this week about SAP publishing a free Memory Analyzer. I first tried it on a OutOfMemory heap dump of an commercial formatter which we use in that project that consumed so much of my time lately. It was an immediate eye opener. So I wanted to play with this really great tool a little more

Re: The effect of the property cache (or: playing around with a new toy)

2007-07-18 Thread Andreas L Delmelle
On Jul 18, 2007, at 22:17, Jeremias Maerki wrote: So I wanted to play with this really great tool a little more and ran a big document which I knew would cause an OutOfMemoryError at 64MB heap size. Here's what came out: snip / Interesting figures! Did you have any chance to run a

Re: The effect of the property cache (or: playing around with a new toy)

2007-07-18 Thread Jeremias Maerki
Some additional thoughts before going to bed: - I think the static synchronized WeakHashMap should be avoided. There's a lot of synchronization that is performed. I suspect this will have a bad effect on performance. It may make more sense to have a FlyWeightFactory (per object) per rendering

Re: The effect of the property cache (or: playing around with a new toy)

2007-07-18 Thread Jeremias Maerki
On 18.07.2007 23:05:57 Andreas L Delmelle wrote: On Jul 18, 2007, at 22:17, Jeremias Maerki wrote: So I wanted to play with this really great tool a little more and ran a big document which I knew would cause an OutOfMemoryError at 64MB heap size. Here's what came out: snip /

Re: FOP 0.94 : font auto detection test

2007-07-18 Thread HLeonardi
Hugues Leonardi wrote: Auto-configuration still is a step backwards for a few minor points: - TrueType collections are not supported with auto-config, yet. - Some special fonts like Symbol may not be handled correctly. Hi Jeremias, I didn't know this. I haven't read the whole of fop

Re: The effect of the property cache (or: playing around with a new toy)

2007-07-18 Thread Andreas L Delmelle
On Jul 18, 2007, at 23:18, Jeremias Maerki wrote: Some additional thoughts before going to bed: - I think the static synchronized WeakHashMap should be avoided. There's a lot of synchronization that is performed. I suspect this will have a bad effect on performance. I have always assumed

Re: The effect of the property cache (or: playing around with a new toy)

2007-07-18 Thread Andreas L Delmelle
On Jul 18, 2007, at 23:31, Jeremias Maerki wrote: snip / [Me:] All we really need to uniquely identify a NumberProperty is the number-member, I think... I dont' think that works, since Number doesn't implement hashCode (), for example. Right, but its concrete subclasses in the java.lang

Re: The effect of the property cache (or: playing around with a new toy)

2007-07-18 Thread Andreas L Delmelle
On Jul 19, 2007, at 01:10, Andreas L Delmelle wrote: snip / Hmm, made me wonder: Number oneInt = new Integer(1); Number oneDouble = new Double(1.0); boolean check = (oneInt.hashCode() != oneDouble.hashCode()); = (check == true) Can this be relied upon? BTW: the following is

Re: svn commit: r557347 - in /xmlgraphics/fop/trunk: ./ src/documentation/content/xdocs/ src/java/org/apache/fop/fo/ src/java/org/apache/fop/layoutmgr/inline/ test/layoutengine/ test/layoutengine/stan

2007-07-18 Thread Manuel Mall
On Thursday 19 July 2007 02:31, Andreas L Delmelle wrote: On Jul 18, 2007, at 20:06, [EMAIL PROTECTED] wrote: Hi Manuel others Author: manuel Date: Wed Jul 18 11:06:09 2007 New Revision: 557347 URL: http://svn.apache.org/viewvc?view=revrev=557347 Log: Added support for

Re: svn commit: r557347 - in /xmlgraphics/fop/trunk: ./ src/documentation/content/xdocs/ src/java/org/apache/fop/fo/ src/java/org/apache/fop/layoutmgr/inline/ test/layoutengine/ test/layoutengine/stan

2007-07-18 Thread Andreas L Delmelle
On Jul 19, 2007, at 01:31, Manuel Mall wrote: snip / I don't quite understand what you are trying to say here. The test case in question checks the use of keep-together.within-line=always in the context of fo:block, fo:inline and fo:marker. Nope. For the sake of completeness, this is

Re: svn commit: r557347 - in /xmlgraphics/fop/trunk: ./ src/documentation/content/xdocs/ src/java/org/apache/fop/fo/ src/java/org/apache/fop/layoutmgr/inline/ test/layoutengine/ test/layoutengine/stan

2007-07-18 Thread Manuel Mall
On Thursday 19 July 2007 08:39, Andreas L Delmelle wrote: On Jul 19, 2007, at 01:31, Manuel Mall wrote: snip / I don't quite understand what you are trying to say here. The test case in question checks the use of keep-together.within-line=always in the context of fo:block, fo:inline