Initial Values of Variables [was: Re: svn commit: r825875 - in /xmlgraphics/fop/trunk/src/java/org/apache/fop/cli: CommandLineOptions.java InputHandler.java]

2009-10-20 Thread Vincent Hennebert
Hi, Just a nit: +private boolean useCatalogResolver = false; +private EntityResolver entityResolver = null; +private URIResolver uriResolver = null; Those fields are being initialized to their default values. The Java Language Specification states [1] that every field must be

Re: Initial Values of Variables [was: Re: svn commit: r825875 - in /xmlgraphics/fop/trunk/src/java/org/apache/fop/cli: CommandLineOptions.java InputHandler.java]

2009-10-20 Thread Peter B. West
Yep, they sure are. Does it hurt to spell it out? Like redundant parentheses, it does no harm, and makes the code just that little bit more explicit, for the dodos like me. Peter On 20/10/2009, at 8:13 PM, Vincent Hennebert wrote: Hi, Just a nit: +private boolean useCatalogResolver

DO NOT REPLY [Bug 47941] AFP Renderer Truncates TLE Values

2009-10-20 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=47941 --- Comment #8 from Venkat Reddy vanukuri.ven...@googlemail.com 2009-10-20 07:12:49 UTC --- It is better to warn the user atleast when used more than 254 bytes for the TLE value, so that he will get an idea about the truncation happened

TLE value truncation (AFP extension)

2009-10-20 Thread Venkat Reddy
Hi, Please help me in finding the code related to this TLE value truncation happening for more than 254 bytes. The corresponding bug is already raised... https://issues.apache.org/bugzilla/show_bug.cgi?id=47941 The MODCA documentation clearly states that 254 bytes allowed for the TLE

License Headers in Test Files? [was: Re: svn commit: r827725 - in /xmlgraphics/fop/branches/Temp_Accessibility/test: accessibility/ accessibility/pdf/ resources/images/]

2009-10-20 Thread Vincent Hennebert
Hi, In doubt, I added them, but is it actually necessary to put license headers in such test files? The header is bigger than the actual content... Vincent Added: xmlgraphics/fop/branches/Temp_Accessibility/test/accessibility/background-image_jpg_repeat.fo URL:

Re: svn commit: r827023 - /xmlgraphics/fop/trunk/src/java/org/apache/fop/cli/InputHandler.java

2009-10-20 Thread Simon Pepping
On Tue, Oct 20, 2009 at 10:04:09AM -, vhenneb...@apache.org wrote: Author: vhennebert Date: Tue Oct 20 10:04:09 2009 New Revision: 827023 URL: http://svn.apache.org/viewvc?rev=827023view=rev Log: Fixed checkstyle issues. Factorized duplicated code into getXMLReader method.