Re: svn commit: r670341 - in /xmlgraphics/fop/trunk/src/java/org/apache/fop/fo: FONode.java FOText.java FOTreeBuilder.java FObjMixed.java

2008-07-28 Thread Jeremias Maerki
Almost forgot this but then again stumbled over the left-over bugs a couple of times. So this is fixed now as discussed: http://svn.apache.org/viewvc?rev=680378view=rev As long as external extensions derive from FONode or XMLObj everything should work as before. Otherwise, the change might still

Re: svn commit: r670341 - in /xmlgraphics/fop/trunk/src/java/org/apache/fop/fo: FONode.java FOText.java FOTreeBuilder.java FObjMixed.java

2008-07-10 Thread Peter B. West
Andreas Delmelle wrote: On Jul 9, 2008, at 09:39, Peter B. West wrote: Jeremias Maerki wrote: Am I the only one concerned about backwards-compatibility here? It's not my *concern*, but deliberately breaking compatibility does seem pretty silly. Yeah, so one night I thought: Let's see

Re: svn commit: r670341 - in /xmlgraphics/fop/trunk/src/java/org/apache/fop/fo: FONode.java FOText.java FOTreeBuilder.java FObjMixed.java

2008-07-09 Thread Max Berger
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Jeremias, Jeremias Maerki schrieb: Am I the only one concerned about backwards-compatibility here? No. I am also concerned about backwards-compatibility, but in a different way: This change changed the semantics without changing the API, therefore

Re: svn commit: r670341 - in /xmlgraphics/fop/trunk/src/java/org/apache/fop/fo: FONode.java FOText.java FOTreeBuilder.java FObjMixed.java

2008-07-09 Thread Jeremias Maerki
On 09.07.2008 10:45:35 Max Berger wrote: Jeremias, Jeremias Maerki schrieb: Am I the only one concerned about backwards-compatibility here? No. I am also concerned about backwards-compatibility, but in a different way: This change changed the semantics without changing the API,

Re: svn commit: r670341 - in /xmlgraphics/fop/trunk/src/java/org/apache/fop/fo: FONode.java FOText.java FOTreeBuilder.java FObjMixed.java

2008-07-09 Thread Adrian Cumiskey
Sounds like a fine approach, +1 from me. Adrian. Jeremias Maerki wrote: On 09.07.2008 10:45:35 Max Berger wrote: Jeremias, Jeremias Maerki schrieb: Am I the only one concerned about backwards-compatibility here? No. I am also concerned about backwards-compatibility, but in a different way:

Re: svn commit: r670341 - in /xmlgraphics/fop/trunk/src/java/org/apache/fop/fo: FONode.java FOText.java FOTreeBuilder.java FObjMixed.java

2008-07-09 Thread Andreas Delmelle
On Jul 9, 2008, at 09:26, Jeremias Maerki wrote: Am I the only one concerned about backwards-compatibility here? Not really. There's always Microsoft... :-) Seriously, if I had made the change in 0.95, I would completely agree (and would probably already have reverted the change). Since

Re: svn commit: r670341 - in /xmlgraphics/fop/trunk/src/java/org/apache/fop/fo: FONode.java FOText.java FOTreeBuilder.java FObjMixed.java

2008-07-09 Thread Andreas Delmelle
On Jul 9, 2008, at 09:39, Peter B. West wrote: Jeremias Maerki wrote: Am I the only one concerned about backwards-compatibility here? It's not my *concern*, but deliberately breaking compatibility does seem pretty silly. Yeah, so one night I thought: Let's see if we can annoy everyone

Re: svn commit: r670341 - in /xmlgraphics/fop/trunk/src/java/org/apache/fop/fo: FONode.java FOText.java FOTreeBuilder.java FObjMixed.java

2008-07-09 Thread Andreas Delmelle
On Jul 9, 2008, at 11:06, Jeremias Maerki wrote: On 09.07.2008 10:45:35 Max Berger wrote: My favorite solution would be: Provide the new semantics with a new signature (or method name), and keep the old one as deprecated for at least 1 release (Then all plugin developers have enough time to

Re: svn commit: r670341 - in /xmlgraphics/fop/trunk/src/java/org/apache/fop/fo: FONode.java FOText.java FOTreeBuilder.java FObjMixed.java

2008-07-07 Thread Jeremias Maerki
I know I'm late on this one but I've only just stumbled over it while playing with the AFP renderer in the GOCA branch. This change is very dangerous as it essentially breaks every FOP extension that uses character content, especially those not developed inside the FOP project. I'm lucky it

Re: svn commit: r670341 - in /xmlgraphics/fop/trunk/src/java/org/apache/fop/fo: FONode.java FOText.java FOTreeBuilder.java FObjMixed.java

2008-07-07 Thread Andreas Delmelle
On Jul 7, 2008, at 15:22, Jeremias Maerki wrote: I know I'm late on this one but I've only just stumbled over it while playing with the AFP renderer in the GOCA branch. This change is very dangerous as it essentially breaks every FOP extension that uses character content, especially those not

Re: svn commit: r670341 - in /xmlgraphics/fop/trunk/src/java/org/apache/fop/fo: FONode.java FOText.java FOTreeBuilder.java FObjMixed.java

2008-07-07 Thread Andreas Delmelle
On Jul 7, 2008, at 18:09, Andreas Delmelle wrote: On Jul 7, 2008, at 15:22, Jeremias Maerki wrote: I know I'm late on this one but I've only just stumbled over it while playing with the AFP renderer in the GOCA branch. This change is very dangerous as it essentially breaks every FOP extension