Re: [fossil-users] Support for commonmark markdown in fossil

2017-03-14 Thread Jan Nijtmans
2017-03-14 16:27 GMT+01:00 Mark Janssen: > Or in patch form: ... http://fossil-scm.org/index.html/info/dd41f85acf57290a Thanks! Jan Nijtmans ___ fossil-users mailing list fossil-users@lists.fossil-scm.org

Re: [fossil-users] Support for commonmark markdown in fossil

2017-03-14 Thread Mark Janssen
Or in patch form: @@ -460,15 +460,16 @@ while( i=size ) return 0; -if( data[i]==c ) return i; /* not counting escaped chars */ if( i && data[i-1]=='\\' ){ i++; continue; } + +if( data[i]==c ) return i; /* skipping a code span */ if(

Re: [fossil-users] Support for commonmark markdown in fossil

2017-03-14 Thread Natacha Porté
Hello, on Tuesday 14 March 2017 at 15:44, Mark Janssen wrote: > I did notice a (IMO) bug during the conversion: > > $ cat markdown-test2.md > _test\_embedded_ > *test\*embedded* > $ fossil test-markdown-render markdown-test2.md > > > testembedded_ > testembedded* > > > > The escaped

Re: [fossil-users] Support for commonmark markdown in fossil

2017-03-14 Thread Mark Janssen
On Sat, Mar 11, 2017 at 6:18 PM, Natacha Porté wrote: > > > I should really clarify that it was about *fenced* code blocks, since > traditional markdown code blocks are correctly supported (unless there > is a serious bug in there). > > I do understand the use of code

Re: [fossil-users] Support for commonmark markdown in fossil

2017-03-13 Thread Warren Young
On Mar 13, 2017, at 12:57 PM, Martin S. Weber wrote: > > On 03/13/17 19:00, Warren Young wrote: >> On Mar 13, 2017, at 10:32 AM, Natacha Porté wrote: >>> Or do you expect it to count parentheses and prevent you from ever >>> linking to a URL with

Re: [fossil-users] Support for commonmark markdown in fossil

2017-03-13 Thread David Vines
On 13/03/2017 15:50, Warren Young wrote: A related wish that comes up here now and then is some kind of pretty-printer support, so that common programming languages are colored nicely. Google’s code-prettify JS library would work for this: https://github.com/google/code-prettify

Re: [fossil-users] Support for commonmark markdown in fossil

2017-03-13 Thread Martin S. Weber
On 03/13/17 19:00, Warren Young wrote: On Mar 13, 2017, at 10:32 AM, Natacha Porté wrote: Or do you expect it to count parentheses and prevent you from ever linking to a URL with unbalanced parentheses? Yes. Other Markdown processors do that. It doesn't necessarily

Re: [fossil-users] Support for commonmark markdown in fossil

2017-03-13 Thread Warren Young
On Mar 13, 2017, at 10:32 AM, Natacha Porté wrote: > > on Monday 13 March 2017 at 09:50, Warren Young wrote: >> I have found bugs in Fossil’s Markdown implementation. For example, it >> doesn’t deal properly with hyperlinks to Wikipedia documents that end in a >>

Re: [fossil-users] Support for commonmark markdown in fossil

2017-03-13 Thread Natacha Porté
Hello, on Monday 13 March 2017 at 09:50, Warren Young wrote: > I have found bugs in Fossil’s Markdown implementation. For example, it > doesn’t deal properly with hyperlinks to Wikipedia documents that end in a > parenthesis, as when the Wikipedia topic needs disambiguation: > >I like

Re: [fossil-users] Support for commonmark markdown in fossil

2017-03-13 Thread Warren Young
On Mar 11, 2017, at 7:07 AM, Mark Janssen wrote: > > the fossil markdown support is fairly limited (for example there are no code > blocks) We must have different definitions of “code block.” This is a Fossil wiki page with a very large code block down at the end:

Re: [fossil-users] Support for commonmark markdown in fossil

2017-03-11 Thread Natacha Porté
Hello, on Saturday 11 March 2017 at 16:23, Mark Janssen wrote: > I wasn't aware that the author of the current implementation was a fossil > user as well :) Being the author really helps integrating the code into fossil paradigm, deal with licencing stuff, and adding new features efficiently. It

Re: [fossil-users] Support for commonmark markdown in fossil

2017-03-11 Thread Mark Janssen
I wasn't aware that the author of the current implementation was a fossil user as well :) On Sat, 11 Mar 2017, 16:22 Natacha Porté, wrote: > > I never understood the appeal for code blocks, but if it's only that > it's very easy to add to the existing implementation. >

Re: [fossil-users] Support for commonmark markdown in fossil

2017-03-11 Thread Natacha Porté
Hello, on Saturday 11 March 2017 at 15:07, Mark Janssen wrote: > Recently I have been looking to use fossil as a backend for managing the > Tcl tip collection. > An obvious format for the new tip format would be markdown, but currently > the fossil markdown support is fairly limited (for example

Re: [fossil-users] Support for commonmark markdown in fossil

2017-03-11 Thread Scott Robison
On Sat, Mar 11, 2017 at 8:08 AM, Mark Janssen wrote: > Good questions. Currently it replaces the existing markdown parser which > can break existing files. This is why I suggested the repo wide setting. > Sorry, I missed that part. > There are other possible solutions

Re: [fossil-users] Support for commonmark markdown in fossil

2017-03-11 Thread Mark Janssen
Good questions. Currently it replaces the existing markdown parser which can break existing files. This is why I suggested the repo wide setting. There are other possible solutions (switch on extension being one as well) but having different markdown flavours in one repo just feels wrong to me.

Re: [fossil-users] Support for commonmark markdown in fossil

2017-03-11 Thread Scott Robison
On Sat, Mar 11, 2017 at 7:07 AM, Mark Janssen wrote: > > My question to you all is, would there be any interest in adding > commonmark support? > I like the idea of a more fully featured markdown implementation. Would this replace the existing markdown support or be in

[fossil-users] Support for commonmark markdown in fossil

2017-03-11 Thread Mark Janssen
Recently I have been looking to use fossil as a backend for managing the Tcl tip collection. An obvious format for the new tip format would be markdown, but currently the fossil markdown support is fairly limited (for example there are no code blocks) I have made a version of fossil which