Re: [fossil-users] Fix for stash-next pointer (fix for the fix)

[Warren Young]

On Aug 17, 2016, at 12:33 PM, Kain Abel  wrote:
> 
> Hi Warren,
> 
> 2016-08-17 17:43 GMT+02:00 Warren Young :
>> On Aug 16, 2016, at 6:45 AM, Kain Abel  wrote:
>>> Oh, that surprises me now. This implicit behavior is not explicit
>>> documented. There is no warning that all stashed changes will be also
>>> dropped when repository will be closed. Neither in 'stash --help' nor
>>> in 'close --help’.
>> 
>>$ f close
>>closing the checkout will delete your stash
> 
> Uh, reading is also not my forte and I wasted your time. :(

I wouldn’t say that.  It would indeed be nice if Fossil told you up front, as 
you said.  I was just pointing out that it warns you before deleting the stash, 
and requires that you give --force to close it anyway, or that you manually 
empty the stash first.

The documentation for --force doesn’t explain this second usage, either.  It 
only talks about “uncommitted changes,” which is not quite the same thing as 
stashed changes, at least to my mind.  “Uncommitted” implies that committing 
them is the intent, whereas stashed changes may never be committed; if I was 
certain about keeping these changes or throwing them away, they wouldn’t be in 
the stash, they’d be committed or reverted.

So, maybe you want to prepare a documentation patch rather than a functionality 
patch.
___
fossil-users mailing list
fossil-users@lists.fossil-scm.org
http://lists.fossil-scm.org:8080/cgi-bin/mailman/listinfo/fossil-users

Re: [fossil-users] Fix for stash-next pointer (fix for the fix)

[Warren Young]

On Aug 16, 2016, at 6:45 AM, Kain Abel  wrote:
> 
> 2016-08-15 17:58 GMT+02:00 Warren Young :
>> 
>> [...] All stashes go away when you close the repo.
> 
> Oh, that surprises me now. This implicit behavior is not explicit
> documented. There is no warning that all stashed changes will be also
> dropped when repository will be closed. Neither in 'stash --help' nor
> in 'close --help’.

$ f close
closing the checkout will delete your stash

___
fossil-users mailing list
fossil-users@lists.fossil-scm.org
http://lists.fossil-scm.org:8080/cgi-bin/mailman/listinfo/fossil-users

Re: [fossil-users] Fix for stash-next pointer (fix for the fix)

[Kain Abel]

Hi Warren,

2016-08-17 17:43 GMT+02:00 Warren Young :
> On Aug 16, 2016, at 6:45 AM, Kain Abel  wrote:
>> Oh, that surprises me now. This implicit behavior is not explicit
>> documented. There is no warning that all stashed changes will be also
>> dropped when repository will be closed. Neither in 'stash --help' nor
>> in 'close --help’.
>
> $ f close
> closing the checkout will delete your stash

Uh, reading is also not my forte and I wasted your time. :(
___
fossil-users mailing list
fossil-users@lists.fossil-scm.org
http://lists.fossil-scm.org:8080/cgi-bin/mailman/listinfo/fossil-users

Re: [fossil-users] Fix for stash-next pointer (fix for the fix)

[Ross Berteig]

On 8/17/2016 1:01 PM, Warren Young wrote:

 It would indeed be nice if Fossil told you up front, as you said.

The documentation for --force doesn’t explain this second usage,
either. It only talks about “uncommitted changes,” which is not quite
the same thing as stashed changes, at least to my mind.
“Uncommitted” implies that committing them is the intent, whereas
stashed changes may never be committed; if I was certain about
keeping these changes or throwing them away, they wouldn’t be in the
stash, they’d be committed or reverted.

So, maybe you want to prepare a documentation patch rather than a functionality 
patch.


The current (tip of trunk) help text for fossil close reads:

$ fossil close --help
Usage: fossil close ?OPTIONS?

The opposite of "open".  Close the current database connection.
Require a -f or --force flag if there are unsaved changes in the
current check-out or if there is non-empty stash.

Options:
  --force|-f  necessary to close a check out with uncommitted
  changes

See also: open

The text "or if there is a non-empty stash" was added by check-in 
[c6aedbd0] on 2013-06-22.


I could see rewording the text for --force to be a little more succinct 
and not imply something that contradicts the paragraph above it. But all 
in all, this is pretty clear, IMHO.


--
Ross Berteig   r...@cheshireeng.com
Cheshire Engineering Corp.   http://www.CheshireEng.com/
+1 626 303 1602
___
fossil-users mailing list
fossil-users@lists.fossil-scm.org
http://lists.fossil-scm.org:8080/cgi-bin/mailman/listinfo/fossil-users

Re: [fossil-users] Fix for stash-next pointer (fix for the fix)

[Kain Abel]

Just a crude thought:

I know, fossil is not git ... but both was designed to preserve
informations and to track their changes. (That is a absolute
simplification.)

Git has no open and close, but also stash. A former ;) git user would
lose the stash without asking if he uses close (out of whichever
reasons) w/o RTfineM. The loss of stashed changes (== working time)
could be a disappointment (as an user experience).
The key aspect is the loss of information and not the omission of
reading the manual.

With regards,
Kain
___
fossil-users mailing list
fossil-users@lists.fossil-scm.org
http://lists.fossil-scm.org:8080/cgi-bin/mailman/listinfo/fossil-users