Re: [fossil-users] More timeline changes

2017-11-25 Thread Zakero
To help make the ellipses more visible, you could put them in their own and let the skin figure out what looks best. Also, instead of using "...", what about "[+]"? Something that I consider a functional inconsistency with the current implementation is that after the "..." is clicked on, there

Re: [fossil-users] More timeline changes

2017-11-25 Thread bytevolcano
On Sat, 25 Nov 2017 18:46:52 -0600 Zakero wrote: > To help make the ellipses more visible, you could put them in their > own and let the skin figure out what looks best. Also, > instead of using "...", what about "[+]"? If it's going at the end of the text, how about ">>>"?

Re: [fossil-users] More timeline changes

2017-11-25 Thread sky5walk
Ok, the current behavior is cool, but renders the ellipses superfluous. Clicking anywhere in a line expands/contracts the info. Any chance to drop the many many ⋯'s after all my comments? On Sat, Nov 25, 2017 at 8:47 PM, Richard Hipp wrote: > On 11/25/17, David Mason

Re: [fossil-users] More timeline changes

2017-11-25 Thread David Mason
function cancelProp(event){ if (event.stopPropagation) {event.stopPropagation()} //w3c else {event.cancelBubble = true } // ie } http://google.ca; onclick="cancelProp(event)" title=" "> google blah blah Suppressing the title on the link is tricky the above works on

Re: [fossil-users] More timeline changes

2017-11-25 Thread David Mason
What you have seems to handle the ellipsis properly (by my definition of properly). But you really should use title/tooltip. On 25 November 2017 at 21:45, Richard Hipp wrote: > On 11/25/17, Richard Hipp wrote: > > On 11/25/17, sky5w...@gmail.com

Re: [fossil-users] More timeline changes

2017-11-25 Thread sky5walk
I will try smallest scaling of the ellipsis, if it really must remain... And I can live with .timelineEllipsis { display: 'none'; }, since the Advanced button will override if I want extra info. Thanks for the options. On Sat, Nov 25, 2017 at 9:52 PM, David Mason wrote: >

Re: [fossil-users] More timeline changes

2017-11-25 Thread Jungle Boogie
On Sat 25 Nov 2017 6:46 PM, Zakero wrote: > To help make the ellipses more visible, you could put them in their own > and let the skin figure out what looks best. Also, instead of > using "...", what about "[+]"? > Yes, I support this suggestion. Most sites I've seen that can expand/shrink

Re: [fossil-users] A-B comparison of proposed timeline changes

2017-11-25 Thread Andy Bradford
Thus said Richard Hipp on Fri, 24 Nov 2017 11:12:14 -0500: > Now fixed. Verified. > Other changes on https://www.fossil-scm.org/b/timeline since the > original comparison request: > > (1) The "details" section is shown on a separate line below the > check-in comment. I just

Re: [fossil-users] More timeline changes

2017-11-25 Thread Richard Hipp
On 11/25/17, sky5w...@gmail.com wrote: > Ok, the current behavior is cool, but renders the ellipses superfluous. > Clicking anywhere in a line expands/contracts the info. > Any chance to drop the many many ⋯'s after all my comments? > I think the following CSS will do that

Re: [fossil-users] More timeline changes

2017-11-25 Thread Richard Hipp
On 11/25/17, Tony Papadimitriou wrote: > But the ellipses are indeed barely visible. I replaced the "..." text with "". I think it is better now. I'm still not 100% happy with it, though. -- D. Richard Hipp d...@sqlite.org ___

Re: [fossil-users] More timeline changes

2017-11-25 Thread Richard Hipp
On 11/25/17, David Mason wrote: > > When I did that, I made clicking on anywhere in that div expand it. > I've done that in the latest. Actually, I made it click-to-toggle. That seems to work a lot better than trying to click on the ellipsis. But there is a subtle problem.

Re: [fossil-users] A-B comparison of proposed timeline changes

2017-11-25 Thread Andy Bradford
Thus said Jacob MacDonald on Fri, 24 Nov 2017 18:52:41 +: > Seems like I'm in the minority, but I prefer the A version. I tend to > like compact UIs and having all the relevant information close > together and the commit hash prominently displayed is nice. The only reason why I

Re: [fossil-users] More timeline changes

2017-11-25 Thread bch
On Sat, Nov 25, 2017 at 7:26 AM wrote: > "​(2) Decluttered should be the default." > I agree clutter should not be default?​ > I would drop that term altogether. > Simplified vs detailed would probably be more appropriate words. I do like the “files” toggle in the

Re: [fossil-users] More timeline changes

2017-11-25 Thread Tony Papadimitriou
The idea looks very good to me. But the ellipses are indeed barely visible. How about replacing ... with [*] as a generic (foot)note mark? -Original Message- From: Richard Hipp Timelines now come up in Basic mode, which means only the check-in comment shows. There are ellipses at

Re: [fossil-users] Trolling GitHub for ideas

2017-11-25 Thread Offray Vladimir Luna Cárdenas
On 25/11/17 09:17, Richard Hipp wrote: > The SQLite project is mirrored on GitHub (not by me). This mirror > provides a good opportunity to compare the interfaces of GitHub and > Fossil using the same underlying data. > > https://sqlite.org/srcx/timeline?basic >

Re: [fossil-users] More timeline changes

2017-11-25 Thread sky5walk
Man, are those ellipses absolutely necessary? (So close with the previous uncluttered timeline.) Is it possible to make the 1st word/sentence of the checkin comment a hyperlink to the extra info? On Sat, Nov 25, 2017 at 5:51 PM, Marc Simpson wrote: > One other (potential)

Re: [fossil-users] More timeline changes

2017-11-25 Thread Richard Hipp
The names of the of the buttons are now "Advanced" and "Basic". And they work by setting .style.display using JS. Timelines now come up in Basic mode, which means only the check-in comment shows. There are ellipses at the end of each comment. If you click on the ellipsis for one comment, it

Re: [fossil-users] More timeline changes

2017-11-25 Thread David Mason
Looks good. When I did that, I made clicking on anywhere in that div expand it. You should also add a title that says "Click to expand" so that they don't have to know/infer that the ellipsis is an active link. I also like being able to shrink it back... right now there isn't that much extra

Re: [fossil-users] More timeline changes

2017-11-25 Thread Marc Simpson
One other (potential) problem: without the hash prefix, descriptions run together. Example: http://www.sqlite.org/src/timeline, 2017-11-24. The graph nodes are flushed to the left, so descriptions appear as: Add the "^" syntax from fts3/4 to fts5. ... Enhance the configure script to detect

[fossil-users] Trolling GitHub for ideas

2017-11-25 Thread Richard Hipp
The SQLite project is mirrored on GitHub (not by me). This mirror provides a good opportunity to compare the interfaces of GitHub and Fossil using the same underlying data. https://sqlite.org/srcx/timeline?basic https://github.com/mackyle/sqlite/commits/master Your suggestions for

Re: [fossil-users] Interface improvement ideas from GitHub

2017-11-25 Thread David Mason
1) Add/remove a class to an enclosing DIV. You can see a very simple version that I wrote in action on https://programmingfortherestofus.com click on the bullets under Elevator Pitch. 2) Include all the content, just don't display it by default... dynamically downloading additional content is

Re: [fossil-users] Interface improvement ideas from GitHub

2017-11-25 Thread Olivier R.
Le 25/11/2017 à 14:53, Richard Hipp a écrit : I notice on diff pages of GitHub (ex: https://github.com/mackyle/sqlite/commit/028307ebcc953ee944d389fe359d146ab4893d16) that above and below each diff chunk there is a light-blue block on the left with an icon in the middle. If you hover over this

Re: [fossil-users] Interface improvement ideas from GitHub

2017-11-25 Thread David Mason
To extract the relevant bits: HTML: JS: function toggleExpand(node,shrink,expand) { if (node.classList.contains(shrink)) { node.classList.remove(shrink); expand && node.classList.add(expand); node.setAttribute('title','Click to '+shrink); } else { expand &&

Re: [fossil-users] More timeline changes

2017-11-25 Thread sky5walk
"​(2) Decluttered should be the default." I agree clutter should not be default?​ I would drop that term altogether. On Sat, Nov 25, 2017 at 8:47 AM, Richard Hipp wrote: > In the latest code on https://www.fossil-scm.org/fossil/timeline and > at https://sqlite.org/srcx/timeline

[fossil-users] [PATCH] Improve symlink following of file_wd_isdir()

2017-11-25 Thread bytevolcano
On OpenBSD 6.1, running "fossil uv edit" will result in the following error: unable to create directory /var/tmp Upon digging through this, I found Fossil was following the "/var/tmp" symlink that recent OpenBSD versions create: lrwxrwx--- 1 root wheel 6 Apr 1 2017 /var/tmp -> ../tmp Of

Re: [fossil-users] [PATCH] Improve symlink following offile_wd_isdir()

2017-11-25 Thread bytevolcano
Fixed a typo resulting in absolute cases not being picked up well. Index: src/file.c == --- src/file.c +++ src/file.c @@ -327,24 +327,30 @@ ** zFilename is a directory -OR- a symlink that points to a directory. ** Return 0 if

[fossil-users] More timeline changes

2017-11-25 Thread Richard Hipp
In the latest code on https://www.fossil-scm.org/fossil/timeline and at https://sqlite.org/srcx/timeline has a "Declutter" button on the sub-menu bar to simplify the screen. In the simplified timeline, there is a "Details" button to get all the details back again. I'm not done with this

Re: [fossil-users] [PATCH] Improve symlink following of file_wd_isdir()

2017-11-25 Thread bytevolcano
Fixed patch, an '{' had escaped the other patch somehow. Index: src/file.c == --- src/file.c +++ src/file.c @@ -327,24 +327,30 @@ ** zFilename is a directory -OR- a symlink that points to a directory. ** Return 0 if zFilename does

[fossil-users] Interface improvement ideas from GitHub

2017-11-25 Thread Richard Hipp
I notice on diff pages of GitHub (ex: https://github.com/mackyle/sqlite/commit/028307ebcc953ee944d389fe359d146ab4893d16) that above and below each diff chunk there is a light-blue block on the left with an icon in the middle. If you hover over this area, you get a pop-up hint that says "Expand".