Re: [fossil-users] committing to a *new* branch from a closed branch not currently possible?

2014-07-19 Thread Jan Nijtmans
2014-07-19 5:12 GMT+02:00 Ron W ronw.m...@gmail.com: How about, defining a new branch closed tag and add: (Yes, I know are more details, but this is the general idea) Sorry, but I don't think this is a good idea. The details are important, and the implications are not clear to me at all.

Re: [fossil-users] committing to a *new* branch from a closed branch not currently possible?

2014-07-19 Thread Andy Bradford
Thus said Jan Nijtmans on Fri, 18 Jul 2014 23:58:09 +0200: I interpret this message as: http://fossil-scm.org/index.html/info/2b79c600d5 And to cover the corner-case, please consider: http://www.fossil-scm.org/index.html/info/d1b5fd8738e $ f stat repository: /tmp/test/../test.fossil

Re: [fossil-users] committing to a *new* branch from a closed branch not currently possible?

2014-07-19 Thread Ron W
On Sat, Jul 19, 2014 at 4:40 AM, Jan Nijtmans jan.nijtm...@gmail.com wrote: 2014-07-19 5:12 GMT+02:00 Ron W ronw.m...@gmail.com: How about, defining a new branch closed tag and add: (Yes, I know are more details, but this is the general idea) Sorry, but I don't think this is a good

Re: [fossil-users] committing to a *new* branch from a closed branch not currently possible?

2014-07-19 Thread Andy Bradford
Thus said Ron W on Sat, 19 Jul 2014 14:12:32 -0400: I think that if a branch from a closed branch feature is going to be added, it should be exactly that and not a back door on closed leafs. This raises the question of just what the intended use of a ``closed leaf'' is supposed to

[fossil-users] committing to a *new* branch from a closed branch not currently possible?

2014-07-18 Thread Matt Welland
It seems it is not possible to commit to a new branch from a closed branch. this is version 1.28. I think this should be allowed. Closing a branch only implies to me that no more commits are to be made to that branch. -- Matt -=- 90% of the nations wealth is held by 2% of the people. Bummer to

Re: [fossil-users] committing to a *new* branch from a closed branch not currently possible?

2014-07-18 Thread Stephan Beal
On Fri, Jul 18, 2014 at 6:06 PM, Matt Welland estifo...@gmail.com wrote: It seems it is not possible to commit to a new branch from a closed branch. this is version 1.28. I think this should be allowed. Closing a branch only implies to me that no more commits are to be made to that branch.

Re: [fossil-users] committing to a *new* branch from a closed branch not currently possible?

2014-07-18 Thread Eric Rubin-Smith
Stephan Beal wrote: On Fri, Jul 18, 2014 at 6:06 PM, Matt Welland estifo...@gmail.com wrote: It seems it is not possible to commit to a new branch from a closed branch. this is version 1.28. I think this should be allowed. Closing a branch only implies to me that no more commits are

Re: [fossil-users] committing to a *new* branch from a closed branch not currently possible?

2014-07-18 Thread Matt Welland
On Fri, Jul 18, 2014 at 10:23 AM, Eric Rubin-Smith eas@gmail.com wrote: Stephan Beal wrote: On Fri, Jul 18, 2014 at 6:06 PM, Matt Welland estifo...@gmail.com wrote: It seems it is not possible to commit to a new branch from a closed branch. this is version 1.28. I think

Re: [fossil-users] committing to a *new* branch from a closed branch not currently possible?

2014-07-18 Thread Eric Rubin-Smith
Matt Welland wrote: From http://www.fossil-scm.org/index.html/doc/tip/www/branching.wiki: == Closed Leaf A closed leaf is any leaf with the closed tag. These leaves are intended to never be extended with descendants and hence are omitted from lists of leaves in the

Re: [fossil-users] committing to a *new* branch from a closed branch not currently possible?

2014-07-18 Thread Ron W
On Fri, Jul 18, 2014 at 1:16 PM, Stephan Beal sgb...@googlemail.com wrote: On Fri, Jul 18, 2014 at 6:06 PM, Matt Welland estifo...@gmail.com wrote: It seems it is not possible to commit to a new branch from a closed branch. this is version 1.28. I think this should be allowed. Closing a

Re: [fossil-users] committing to a *new* branch from a closed branch not currently possible?

2014-07-18 Thread Stephan Beal
On Fri, Jul 18, 2014 at 8:23 PM, Ron W ronw.m...@gmail.com wrote: To get the feature Matt suggested, I suggested adding a new Fossil defined tag and adding the the following after the code cited above (inserting the needed conditional in the new if): /* ** If not creating a new branch, do

Re: [fossil-users] committing to a *new* branch from a closed branch not currently possible?

2014-07-18 Thread Matt Welland
The scenario I'd like to see supported is roughly as follows: Work on a release is done. The release manager closes the branch so no one can accidentally merge or commit to it. A bug fix is needed. The developer branches off the closed node and fixes the bug and runs QA. The release manager can

Re: [fossil-users] committing to a *new* branch from a closed branch not currently possible?

2014-07-18 Thread Ron W
On Fri, Jul 18, 2014 at 2:17 PM, Eric Rubin-Smith eas@gmail.com wrote: Matt Welland wrote: In that case I'd suggest a new mechanism - locked with the behavior I described. I dunno. In my mind one of fossil's big advantages is that stays out of your way because it has a limited number

Re: [fossil-users] committing to a *new* branch from a closed branch not currently possible?

2014-07-18 Thread Ron W
On Fri, Jul 18, 2014 at 2:33 PM, Stephan Beal sgb...@googlemail.com wrote: On Fri, Jul 18, 2014 at 8:23 PM, Ron W ronw.m...@gmail.com wrote: To get the feature Matt suggested, I suggested adding a new Fossil defined tag and adding the the following after the code cited above (inserting the

Re: [fossil-users] committing to a *new* branch from a closed branch not currently possible?

2014-07-18 Thread Richard Hipp
On Fri, Jul 18, 2014 at 2:23 PM, Ron W ronw.m...@gmail.com wrote: /* ** If not creating a new branch, do not allow a commit against a closed branch */ if( /* not creating new branch */ ){ I think if you wanted to be pedantic, you should also check to make sure that the new branch name

Re: [fossil-users] committing to a *new* branch from a closed branch not currently possible?

2014-07-18 Thread Eric Rubin-Smith
Matt Welland wrote: The scenario I'd like to see supported is roughly as follows: Work on a release is done. The release manager closes the branch so no one can accidentally merge or commit to it. A bug fix is needed. The developer branches off the closed node and fixes the bug

Re: [fossil-users] committing to a *new* branch from a closed branch not currently possible?

2014-07-18 Thread Stephan Beal
On Fri, Jul 18, 2014 at 9:03 PM, Eric Rubin-Smith eas@gmail.com wrote: in Fossil. For example, perhaps you wish that you could say user A can create check-ins but cannot open or close branches. That would break down if someone tried checking in with the --close, --branch, or --integrate

Re: [fossil-users] committing to a *new* branch from a closed branch not currently possible?

2014-07-18 Thread Matt Welland
Personally I see limited usefulness in closing a leaf. It is branches that need to be closed (albeit by closing a leaf). I'll let the developers that are requesting this know that it ain't gonna happen. As was suggested they can open/re-close the node as needed. On Fri, Jul 18, 2014 at 12:09

Re: [fossil-users] committing to a *new* branch from a closed branch not currently possible?

2014-07-18 Thread Andy Bradford
Thus said Matt Welland on Fri, 18 Jul 2014 12:41:55 -0700: Personally I see limited usefulness in closing a leaf. It is branches that need to be closed (albeit by closing a leaf). I think this brings up a fine distinction. The behavior of disallowing a descendent checkin applies to a leaf,

Re: [fossil-users] committing to a *new* branch from a closed branch not currently possible?

2014-07-18 Thread Jan Nijtmans
2014-07-18 20:53 GMT+02:00 Richard Hipp d...@sqlite.org: On Fri, Jul 18, 2014 at 2:23 PM, Ron W ronw.m...@gmail.com wrote: /* ** If not creating a new branch, do not allow a commit against a closed branch */ if( /* not creating new branch */ ){ I think if you wanted to be pedantic,

Re: [fossil-users] committing to a *new* branch from a closed branch not currently possible?

2014-07-18 Thread Andy Bradford
Thus said Jan Nijtmans on Fri, 18 Jul 2014 23:58:09 +0200: I interpret this message as: http://fossil-scm.org/index.html/info/2b79c600d5 What if I do: fossil up closedbranchname fossil ci --branch closedbranchname Andy -- TAI64 timestamp: 400053c99bca

Re: [fossil-users] committing to a *new* branch from a closed branch not currently possible?

2014-07-18 Thread Ron W
On Fri, Jul 18, 2014 at 5:58 PM, Jan Nijtmans jan.nijtm...@gmail.com wrote: 2014-07-18 20:53 GMT+02:00 Richard Hipp d...@sqlite.org: On Fri, Jul 18, 2014 at 2:23 PM, Ron W ronw.m...@gmail.com wrote: /* ** If not creating a new branch, do not allow a commit against a closed branch

Re: [fossil-users] committing to a *new* branch from a closed branch not currently possible?

2014-07-18 Thread Jan Nijtmans
2014-07-19 1:02 GMT+02:00 Ron W ronw.m...@gmail.com: Also, I had suggested separate tests for closed leaf and closed branch. Fossil doesn't have the concept of a 'closed branch', it's only the final leaf that can be closed. So I really don't know how to implement that. Regards, Jan

Re: [fossil-users] committing to a *new* branch from a closed branch not currently possible?

2014-07-18 Thread Ron W
On Fri, Jul 18, 2014 at 7:12 PM, Jan Nijtmans jan.nijtm...@gmail.com wrote: 2014-07-19 1:02 GMT+02:00 Ron W ronw.m...@gmail.com: Also, I had suggested separate tests for closed leaf and closed branch. Fossil doesn't have the concept of a 'closed branch', it's only the final leaf that can