Re: [fossil-users] proposed patch: symlinks appear as regular files even when allow-symlinks is on

2014-10-31 Thread Stephan Beal
On Fri, Oct 31, 2014 at 8:17 AM, Stephan Beal sgb...@googlemail.com wrote: + char zValue[4] = {0,0,0,0}; + int i; + snprintf(zValue, sizeof(zValue), %s, blob_str(content)); Minor nitpick: snprintf() is not c89. i would recommend using another blob for zValue, and

Re: [fossil-users] proposed patch: symlinks appear as regular files even when allow-symlinks is on

2014-10-31 Thread Matt Welland
Since you all are looking at symlinks someone reported to me that there are problems when a symlink is replaced with a directory or vice versa. Here is the script that he generated to illustrate the issue: ## Create repo and initial population fossil init bare.repo mkdir link_target_dir touch

Re: [fossil-users] proposed patch: symlinks appear as regular files even when allow-symlinks is on

2014-10-31 Thread Eric Rubin-Smith
Richard Hipp wrote: sqlite3_snprintf() is guaranteed to be available. Note, though, that the first two parameters are reversed. :-\ Well, I only really want to copy up to 3 bytes, so we can keep it simple, stupid and just not make a function call. The revised patch is below. But in

Re: [fossil-users] proposed patch: symlinks appear as regular files even when allow-symlinks is on

2014-10-31 Thread Eric Rubin-Smith
Another iteration. We need to add an extra byte in case the true value is the string true. I've re-expressed the loop as a 'for' loop while I was at it. Sorry for the spam. Again, please treat the below with caution until I have (or someone else has) a chance to exercise it better. Index:

[fossil-users] proposed patch: symlinks appear as regular files even when allow-symlinks is on

2014-10-30 Thread Eric Rubin-Smith
Even when I have the versionable 'allow-symlinks' setting on, 'fossil open' initially creates symlinks as regular files (as if .fossil-settings/allow-symlinks did not exist or were set to 'off'). I have to first delete the symlink files and then run 'fossil update' in order for the setting to

Re: [fossil-users] proposed patch: symlinks appear as regular files even when allow-symlinks is on

2014-10-30 Thread David Mason
Excellent! I reported on the bug here some time ago, but didn't provide a fix. I hope this gets into trunk soon. ../Dave ___ fossil-users mailing list fossil-users@lists.fossil-scm.org