Re: [fossil-users] diff for browse.c

2017-07-12 Thread jungle Boogie
On 10 July 2017 at 16:56, Richard Hipp  wrote:
> On 7/10/17, jungle Boogie  wrote:
>> Hi All,
>>
>> One very minor update to browse.c to add a comma:
>
> I don't think that comma is correct.  The most important comma rule I
> was taught in 8th grade was "if in doubt, leave it out".  And I don't
> see a compelling reason to include that comma.
>

Best commit message!
Reword the header to the /fileage page to avoid disputes of commas.
___
fossil-users mailing list
fossil-users@lists.fossil-scm.org
http://lists.fossil-scm.org:8080/cgi-bin/mailman/listinfo/fossil-users


Re: [fossil-users] diff for browse.c

2017-07-11 Thread Warren Young
On Jul 11, 2017, at 3:58 PM, Warren Young  wrote:
> 
>https://en.wiktionary.org/wiki/actual (noun sense 1)

2!
___
fossil-users mailing list
fossil-users@lists.fossil-scm.org
http://lists.fossil-scm.org:8080/cgi-bin/mailman/listinfo/fossil-users


Re: [fossil-users] diff for browse.c

2017-07-11 Thread Warren Young
On Jul 11, 2017, at 1:52 AM, Stephan Beal  wrote:
> 
> Related trivia: native German speakers, regardless of whether they're 
> functionally fluent in English, can often be identified in internet forums 
> via their overuse of commas

Another telltale is the implicit subject in sentences meant to refer to the 
reader, as in “This feature allows to set the framistating rate.”  Idiomatic 
English requires a definite subject here, but apparently German does not, since 
I’ve seen this across multiple native German speakers writing in English.

I haven’t bothered to try and associate it with any specific language family, 
but another oddity I’ve frequently seen from ESL[*] types is to use “software” 
as a singular noun: “I wrote a new software today.”  In idiomatic English, the 
singular of “software” is “program.”  Ain’t English fun? :)


[*] English as a Second Language

> and their use of the word "actual", which is used differently in German - if 
> someone writes "the actual version of the software is ..." when you would 
> have said "current version" then they're most likely a native German speaker

That word has a lot of strange uses, as in “Galactica Actual.”

https://en.wiktionary.org/wiki/actual (noun sense 1)

And if you don’t get that reference, turn in your nerd card right now. ;)
___
fossil-users mailing list
fossil-users@lists.fossil-scm.org
http://lists.fossil-scm.org:8080/cgi-bin/mailman/listinfo/fossil-users


Re: [fossil-users] diff for browse.c

2017-07-11 Thread jungle Boogie
On 10 July 2017 at 19:19, Warren Young  wrote:
> On Jul 10, 2017, at 5:56 PM, Richard Hipp  wrote:
>>
>> On 7/10/17, jungle Boogie  wrote:
>>> Hi All,
>>>
>>> One very minor update to browse.c to add a comma:
>>
>> I don't think that comma is correct.  The most important comma rule I
>> was taught in 8th grade was "if in doubt, leave it out".  And I don't
>> see a compelling reason to include that comma.
>
> The comma belongs:
>
> https://www.grammarly.com/blog/comma-before-which/
> http://grammar.ccc.commnet.edu/Grammar/commas.htm  (item 4)
>
> Because the “which” clause only adds information and does not change the 
> essential meaning of the remaining sentence if dropped, you need the comma.
>

Exactly my thoughts - restrictive vs. non-restrictive.
___
fossil-users mailing list
fossil-users@lists.fossil-scm.org
http://lists.fossil-scm.org:8080/cgi-bin/mailman/listinfo/fossil-users


Re: [fossil-users] diff for browse.c

2017-07-11 Thread Johan Kuuse
On Tue, Jul 11, 2017 at 10:33 AM, Aaron Elkins  wrote:
>
> On Jul 11, 2017, at 15:52, Stephan Beal  wrote:
>
> On Tue, Jul 11, 2017 at 4:19 AM, Warren Young  wrote:
>>
>> You are right that commas are often overused, drh.  I catch myself doing
>> it occasionally.
>
>
> Related trivia: native German speakers, regardless of whether they're
> functionally fluent in English, can often be identified in internet forums
> via their overuse of commas (and their use of the word "actual", which is
> used differently in German - if someone writes "the actual version of the
> software is ..." when you would have said "current version" then they're
> most likely a native German speaker).

.. or, although less likely, a native Swedish, Norwegian, or
Luxembourgish speaker:
https://en.wiktionary.org/wiki/aktuell
With "less likely", I don not mean that we are less linguistically
error prone than the Germans, but we are simply less (about a tenth of
them).
And, yes, we also do love commas. :-)

/J

>
>
> Interesting saying.
>
> -Aaron
>
> ___
> fossil-users mailing list
> fossil-users@lists.fossil-scm.org
> http://lists.fossil-scm.org:8080/cgi-bin/mailman/listinfo/fossil-users
>
___
fossil-users mailing list
fossil-users@lists.fossil-scm.org
http://lists.fossil-scm.org:8080/cgi-bin/mailman/listinfo/fossil-users


Re: [fossil-users] diff for browse.c

2017-07-11 Thread Aaron Elkins

> On Jul 11, 2017, at 15:52, Stephan Beal  wrote:
> 
> On Tue, Jul 11, 2017 at 4:19 AM, Warren Young  > wrote:
> You are right that commas are often overused, drh.  I catch myself doing it 
> occasionally.
> 
> Related trivia: native German speakers, regardless of whether they're 
> functionally fluent in English, can often be identified in internet forums 
> via their overuse of commas (and their use of the word "actual", which is 
> used differently in German - if someone writes "the actual version of the 
> software is ..." when you would have said "current version" then they're most 
> likely a native German speaker).
> 

Interesting saying.

-Aaron___
fossil-users mailing list
fossil-users@lists.fossil-scm.org
http://lists.fossil-scm.org:8080/cgi-bin/mailman/listinfo/fossil-users


Re: [fossil-users] diff for browse.c

2017-07-11 Thread Stephan Beal
On Tue, Jul 11, 2017 at 4:19 AM, Warren Young  wrote:

> You are right that commas are often overused, drh.  I catch myself doing
> it occasionally.
>

Related trivia: native German speakers, regardless of whether they're
functionally fluent in English, can often be identified in internet forums
via their overuse of commas (and their use of the word "actual", which is
used differently in German - if someone writes "the actual version of the
software is ..." when you would have said "current version" then they're
most likely a native German speaker).

-- 
- stephan beal
http://wanderinghorse.net/home/stephan/
"Freedom is sloppy. But since tyranny's the only guaranteed byproduct of
those who insist on a perfect world, freedom will have to do." -- Bigby Wolf
___
fossil-users mailing list
fossil-users@lists.fossil-scm.org
http://lists.fossil-scm.org:8080/cgi-bin/mailman/listinfo/fossil-users


Re: [fossil-users] diff for browse.c

2017-07-10 Thread Warren Young
On Jul 10, 2017, at 5:56 PM, Richard Hipp  wrote:
> 
> On 7/10/17, jungle Boogie  wrote:
>> Hi All,
>> 
>> One very minor update to browse.c to add a comma:
> 
> I don't think that comma is correct.  The most important comma rule I
> was taught in 8th grade was "if in doubt, leave it out".  And I don't
> see a compelling reason to include that comma.

The comma belongs:

https://www.grammarly.com/blog/comma-before-which/
http://grammar.ccc.commnet.edu/Grammar/commas.htm  (item 4)

Because the “which” clause only adds information and does not change the 
essential meaning of the remaining sentence if dropped, you need the comma.

Another way of reasoning this out is to speak the sentence.  If you briefly 
pause before saying “which,” you need the comma.  I did, and I paused. :)

You are right that commas are often overused, drh.  I catch myself doing it 
occasionally.
___
fossil-users mailing list
fossil-users@lists.fossil-scm.org
http://lists.fossil-scm.org:8080/cgi-bin/mailman/listinfo/fossil-users


Re: [fossil-users] diff for browse.c

2017-07-10 Thread Stephan Beal
On Tue, Jul 11, 2017 at 1:56 AM, Richard Hipp  wrote:

> On 7/10/17, jungle Boogie  wrote:
> > Hi All,
> >
> > One very minor update to browse.c to add a comma:
>
> I don't think that comma is correct.  The most important comma rule I
> was taught in 8th grade was "if in doubt, leave it out".  And I don't
> see a compelling reason to include that comma.
>

In related news, i stumbled across this some weeks ago and found it
interesting:

http://www.nbcnews.com/news/us-news/oxford-comma-defenders-rejoice-judge-bases-ruling-punctuation-n734371

Summary: a Judge ruled that the lack of a single comma changed the meaning
of a union workers' contract, ruling that the contract (for want of a
single comma) provided workers with some sort of overtime pay benefits
which were not intended by the contract's authors.

"The court concludes that at best the phrase is ambiguous. In other words,
the text by itself just doesn’t tell us the right answer syntactically,"
Samuel said. "So we have to rely on a substantive presumption in favor of
workers, which the court says is used in Maine law to resolve ambiguities
like this."

-- 
- stephan beal
http://wanderinghorse.net/home/stephan/
"Freedom is sloppy. But since tyranny's the only guaranteed byproduct of
those who insist on a perfect world, freedom will have to do." -- Bigby Wolf
___
fossil-users mailing list
fossil-users@lists.fossil-scm.org
http://lists.fossil-scm.org:8080/cgi-bin/mailman/listinfo/fossil-users


Re: [fossil-users] diff for browse.c

2017-07-10 Thread Richard Hipp
On 7/10/17, jungle Boogie  wrote:
> Hi All,
>
> One very minor update to browse.c to add a comma:

I don't think that comma is correct.  The most important comma rule I
was taught in 8th grade was "if in doubt, leave it out".  And I don't
see a compelling reason to include that comma.

>
> Index: src/browse.c
> ==
> --- src/browse.c
> +++ src/browse.c
> @@ -1098,11 +1098,11 @@
>  @ that match "%h(zGlob)" and
>}
>@ ordered by check-in time
>@
>@ Times are relative to the check-in time for
> -  @ %z(href("%R/ci/%!S",zUuid))[%S(zUuid)] which is
> +  @ %z(href("%R/ci/%!S",zUuid))[%S(zUuid)], which is
>@ %z(href("%R/timeline?c=%t",zNow))%s(zNow).
>@
>@ 
>@ TimeFilesCheck-in
>db_prepare(,
>
> Thanks for the consideration!
>
>
> --
> ---
> inum: 883510009027723
> sip: jungleboo...@sip2sip.info
> ___
> fossil-users mailing list
> fossil-users@lists.fossil-scm.org
> http://lists.fossil-scm.org:8080/cgi-bin/mailman/listinfo/fossil-users
>


-- 
D. Richard Hipp
d...@sqlite.org
___
fossil-users mailing list
fossil-users@lists.fossil-scm.org
http://lists.fossil-scm.org:8080/cgi-bin/mailman/listinfo/fossil-users