Re: [fpc-devel] XML node dump feature

2019-02-06 Thread J. Gareth Moreton
You're welcome.  We just have to hope it's quality is acceptable for Florian to merge it into the trunk! Gareth aka. Kit On Thu 07/02/19 05:36 , "Christo Crause" christo.cra...@gmail.com sent: On Thu, 7 Feb 2019, 03:16 J. Gareth Moreton ___

Re: [fpc-devel] XML node dump feature

2019-02-06 Thread Christo Crause
On Thu, 7 Feb 2019, 03:16 J. Gareth Moreton I hope it proves useful. It's at least giving me some insight into how > some things are set up. > > Gareth aka. Kit > This sounds useful, especially for someone like me who isn't that familiar with the compiler but poke around in the compiler

Re: [fpc-devel] XML node dump feature

2019-02-06 Thread J. Gareth Moreton
I made a few extra bug fixes and tweaks over at #35017: - When displaying the value of string constants, it will change characters like < into < etc.  You can't trick it by putting "http://lists.freepascal.org/cgi-bin/mailman/listinfo/fpc-devel ___

Re: [fpc-devel] Suspicion about TThread.Synchronize

2019-02-06 Thread Martin Frb
On 06/02/2019 23:38, Luca Olivetti wrote: and the exception logged (though the logging in turn uses synchronize). What OS? On Windows you can use  LazLogger.  (in Laz 2.0.0) It uses TThread.Queue by default, but you can replace TLazLoggerFileHandleMainThread with

Re: [fpc-devel] Suspicion about TThread.Synchronize

2019-02-06 Thread Luca Olivetti
El 6/2/19 a les 22:26, Martin Frb ha escrit: On 06/02/2019 22:04, Martin Frb wrote: Actually from a further review of the source, there may be another issue: https://bugs.freepascal.org/view.php?id=35027 The fact that FSynchronizeEntry^.Next was set to nil after the call to

Re: [fpc-devel] Suspicion about TThread.Synchronize

2019-02-06 Thread Martin Frb
On 06/02/2019 22:04, Martin Frb wrote: Actually from a further review of the source, there may be another issue: https://bugs.freepascal.org/view.php?id=35027 ___ fpc-devel maillist - fpc-devel@lists.freepascal.org

Re: [fpc-devel] Suspicion about TThread.Synchronize

2019-02-06 Thread Martin Frb
Actually from a further review of the source, there may be another issue: TThread.Synchronize will call   ThreadQueueAppend(AThread.FSynchronizeEntry); AThread.FSynchronizeEntry is the re-usable entry (which is fine, only one synchronize call can be active in any given thread. (Unless you are

Re: [fpc-devel] Suspicion about TThread.Synchronize

2019-02-06 Thread Luca Olivetti
El 6/2/19 a les 19:19, Luca Olivetti ha escrit: El 6/2/19 a les 18:51, Sven Barth via fpc-devel ha escrit: Would you nevertheless try with 3.2, please? Just in case it happens to be the problem I had fixed in regards to Queue(). The branch is fixes_3_2? Apart from the issue reported by

Re: [fpc-devel] Suspicion about TThread.Synchronize

2019-02-06 Thread Luca Olivetti
El 6/2/19 a les 19:29, Martin Frb ha escrit: On 06/02/2019 16:19, Luca Olivetti wrote: . In my case the problem is with Synchronize, the synchronized method is never called and the thread gets stuck there. "synchronized method is never called" So is the main thread running, and either idle,

Re: [fpc-devel] Suspicion about TThread.Synchronize

2019-02-06 Thread Luca Olivetti
El 6/2/19 a les 18:51, Sven Barth via fpc-devel ha escrit: Would you nevertheless try with 3.2, please? Just in case it happens to be the problem I had fixed in regards to Queue(). The branch is fixes_3_2? Apart from the issue reported by Martin

Re: [fpc-devel] Suspicion about TThread.Synchronize

2019-02-06 Thread Martin Frb
On 06/02/2019 16:19, Luca Olivetti wrote: . In my case the problem is with Synchronize, the synchronized method is never called and the thread gets stuck there. "synchronized method is never called" So is the main thread running, and either idle, app.ProcessMessages, or CheckSynchronize? The

Re: [fpc-devel] Suspicion about TThread.Synchronize

2019-02-06 Thread Sven Barth via fpc-devel
Am Mi., 6. Feb. 2019, 18:45 hat Luca Olivetti geschrieben: > El 6/2/19 a les 17:05, Sven Barth via fpc-devel ha escrit: > > Am Mi., 6. Feb. 2019, 11:27 hat Luca Olivetti > > geschrieben: > > > > Of course I cannot reproduce the issue with a simpler test program >

Re: [fpc-devel] Suspicion about TThread.Synchronize

2019-02-06 Thread Luca Olivetti
El 6/2/19 a les 17:05, Sven Barth via fpc-devel ha escrit: Am Mi., 6. Feb. 2019, 11:27 hat Luca Olivetti > geschrieben: Of course I cannot reproduce the issue with a simpler test program :-/ Without a way to test it I can't do anything. So either you need to find

Re: [fpc-devel] Suspicion about TThread.Synchronize

2019-02-06 Thread Sven Barth via fpc-devel
Am Mi., 6. Feb. 2019, 11:27 hat Luca Olivetti geschrieben: > Of course I cannot reproduce the issue with a simpler test program :-/ > Without a way to test it I can't do anything. So either you need to find the issue yourself or you need to manage to create a simpler example. Regards, Sven >

Re: [fpc-devel] Suspicion about TThread.Synchronize

2019-02-06 Thread Luca Olivetti
El 6/2/19 a les 14:08, Martin Frb ha escrit: On 06/02/2019 09:01, Luca Olivetti wrote: I still think there's something wrong with thread in fpc 3.0.4. There is https://bugs.freepascal.org/view.php?id=34640 FIxed in 3.2 branch I'm not sure it's the same issue. The comment in the commit

Re: [fpc-devel] Suspicion about TThread.Synchronize

2019-02-06 Thread Martin Frb
On 06/02/2019 09:01, Luca Olivetti wrote: I still think there's something wrong with thread in fpc 3.0.4. There is https://bugs.freepascal.org/view.php?id=34640 FIxed in 3.2 branch If you can compile your app for linux, run it under valgrind, especially the helgrind tool.

Re: [fpc-devel] Suspicion about TThread.Synchronize

2019-02-06 Thread Luca Olivetti
El 6/2/19 a les 9:01, Luca Olivetti ha escrit: Debugging the program here, I see the thread is stopped inside a synchronize call that is never executed. [] so that, by putting a breakpoint in the main program when it checks if the thread has finished its job, I can examine the thread

Re: [fpc-devel] Suspicion about TThread.Synchronize

2019-02-06 Thread Martin Frb
On 06/02/2019 09:01, Luca Olivetti wrote: I still think there's something wrong with thread in fpc 3.0.4. There is https://bugs.freepascal.org/view.php?id=34640 FIxed in 3.2 branch If you can compile your app for linux, run it under valgrind, especially the helgrind tool.

Re: [fpc-devel] Suspicion about TThread.Synchronize

2019-02-06 Thread Luca Olivetti
El 4/2/18 a les 20:17, Sven Barth via fpc-devel ha escrit: What happens if - thread 1, has just finished the line ThreadQueueAppend(AThread.FSynchronizeEntry); - thread 2 now calls synchronize, and    - as soon as thread1 leaves the CriticalSection in ThreadQueueAppend => thread2 enters that

Re: [fpc-devel] Issue with Compiler output for shr on Cortex-M4

2019-02-06 Thread Michael Ring
Your patch did the trick, assembler Code is looking good now:    pByte(@DR)^ := (aWord shr 8); 0800 187E  LDR  R0, [R11, #-0x38] 0800 1882  ADD.W    R1, R0, #0xC 0800 1886  LDRH R0, [R11, #-0x30] 0800 188A  UXTB R0, R0, ROR #8 0800 188E  STRB