Re: [fpc-devel] TRegistry fixes

2019-02-11 Thread Michael Van Canneyt
On Tue, 12 Feb 2019, Pierre Muller wrote: Hi Bart, Le 11/02/2019 à 15:29, Bart a écrit : Hi, I am one of the rare regular users of Windows OS in the core team, but I must also confess that I am neither knowledgeable in TRegistry fields, nor in all what concerns UniCode matters, which

Re: [fpc-devel] TRegistry fixes

2019-02-11 Thread Pierre Muller
Hi Bart, Le 11/02/2019 à 15:29, Bart a écrit : > Hi, > > The new (W-API based) TRegistry in trunk and 3.2 fixes has some > problems on Windows, amongst which at least one regression. > > https://bugs.freepascal.org/view.php?id=35060 > The use of Utf8Decode on strings that are not guaranteed

[fpc-devel] [Suggestion] Disable "inline" on -O1 and -O-.

2019-02-11 Thread J. Gareth Moreton
I would like to make a suggestion that when compiling on a debug build, which is usually -O1 and below, that procedures marked as "inline" are not inlined and instead treated as regular subroutines.  The reason why I suggest this is that "inline" makes it very difficult to debug the actual

Re: [fpc-devel] Fppkg

2019-02-11 Thread Joost van der Sluis
Op 05-02-19 om 21:55 schreef Ben Grasset: On Mon, Feb 4, 2019 at 9:53 AM Martok > wrote: the first-ever fppkg.exe invocation on a machine Do people actually use fppkg for anything? More specifically what is the point of integrating it with Lazarus, which

Re: [fpc-devel] commits for merging to 3.2 ?

2019-02-11 Thread Sven Barth via fpc-devel
Am Mo., 11. Feb. 2019, 15:13 hat Marco van de Voort < c...@pascalprogramming.org> geschrieben: > Op 2/11/2019 om 2:38 PM schreef Sven Barth via fpc-devel: > > > If Sven says to merge them, I will. >> > > If the testsuite isn't saying otherwise you have a green light for that > (I'd first need to

[fpc-devel] TRegistry fixes

2019-02-11 Thread Bart
Hi, The new (W-API based) TRegistry in trunk and 3.2 fixes has some problems on Windows, amongst which at least one regression. https://bugs.freepascal.org/view.php?id=35060 The use of Utf8Decode on strings that are not guaranteed to be CP_UTF8 is wrong. As a result Keys with unicode characters

Re: [fpc-devel] commits for merging to 3.2 ?

2019-02-11 Thread Sven Barth via fpc-devel
Am Mo., 11. Feb. 2019, 10:07 hat Marco van de Voort < c...@pascalprogramming.org> geschrieben: > > Op 2/10/2019 om 9:47 PM schreef Martin: > > I am not sure if there is a place for the indent to merge (or absent > > thereof) can be checked? > > > > Once merged, the svn log, but before? Will the

Re: [fpc-devel] commits for merging to 3.2 ?

2019-02-11 Thread Marco van de Voort
Op 2/10/2019 om 9:47 PM schreef Martin: I am not sure  if there is a place for the indent to merge (or absent thereof) can be checked? Once merged, the svn log, but before?  Will the target on mantis always indicate the decision made? Can the following 2 be merged?