Re: [fpc-devel] Possible bug in "chmreader"

2024-02-21 Thread Christo Crause via fpc-devel
Hi Kit, fwindowslist is created in the constructor, which may explain why this bug is dormant. I assume this is supposed to be a defensive check, although fwindowslist is also accessed later in this method without a safety check. Perhaps the "if not? assigned()" check can be omitted since it

[fpc-devel] Possible bug in "chmreader"

2024-02-21 Thread J. Gareth Moreton via fpc-devel
Hi everyone, While evaluating a new peephole optimisation, I came across a null pointer dereference in the assembly language.  After looking at the original Pascal code, I came across this starting at line 525 of packages/chm/src/chmreader.pas: procedure