Re: [fpc-devel] Attn. Generics.Collections and rev. 39345 and speed slowdown

2018-07-01 Thread Maciej Izak
2018-06-30 11:03 GMT+02:00 Sven Barth via fpc-devel < fpc-devel@lists.freepascal.org>: > mORMot is a third party project that can be used with FPC while Delphi is > essentially a template and base line for compatibility, so there is a > difference between the two. Though if you have a formal name

Re: [fpc-devel] Attn. Generics.Collections and rev. 39345 and speed slowdown

2018-06-30 Thread Michael Van Canneyt
On Sat, 30 Jun 2018, Maciej Izak wrote: 2018-06-30 8:55 GMT+02:00 Sven Barth via fpc-devel < fpc-devel@lists.freepascal.org>: No, the bad taste is too have a class that appears to be named specifically to fit a specific third party project inside a general purpose library. Ok, I agree

Re: [fpc-devel] Attn. Generics.Collections and rev. 39345 and speed slowdown

2018-06-30 Thread Sven Barth via fpc-devel
Am 30.06.2018 um 09:52 schrieb Maciej Izak: 2018-06-30 8:55 GMT+02:00 Sven Barth via fpc-devel mailto:fpc-devel@lists.freepascal.org>>: No, the bad taste is too have a class that appears to be named specifically to fit a specific third party project inside a general purpose

Re: [fpc-devel] Attn. Generics.Collections and rev. 39345 and speed slowdown

2018-06-30 Thread Michael Van Canneyt
On Sat, 30 Jun 2018, Maciej Izak wrote: But not problem, please advise on the changes needed to a) fix the mentioned example so it actually compiles. b) Speed up the default hash. I (or someone else) will be happy to change it. Ok, but in the future you should ask for such important

Re: [fpc-devel] Attn. Generics.Collections and rev. 39345 and speed slowdown

2018-06-30 Thread Maciej Izak
2018-06-30 8:55 GMT+02:00 Sven Barth via fpc-devel < fpc-devel@lists.freepascal.org>: > No, the bad taste is too have a class that appears to be named > specifically to fit a specific third party project inside a general purpose > library. > Ok, I agree here, but why Michael Van Canneyt decide

Re: [fpc-devel] Attn. Generics.Collections and rev. 39345 and speed slowdown

2018-06-30 Thread Maciej Izak
2018-06-30 8:33 GMT+02:00 Michael Van Canneyt : > As noted in the bugreport, your own examples did not compile with your > supplied code. > Next time, please test that too. > The most important was to finish new collections, deep refactoring and proper tests suite than testing all examples.

Re: [fpc-devel] Attn. Generics.Collections and rev. 39345 and speed slowdown

2018-06-30 Thread Sven Barth via fpc-devel
Maciej Izak schrieb am Sa., 30. Juni 2018, 08:16: > Hi, > > renaming for TMormotHashFactory to TGenericsHashFactory is somehow > acceptable (but IMO bad taste) but change for default hashing algorithm in > such important library is really really really bad idea. > No, the bad taste is too have

Re: [fpc-devel] Attn. Generics.Collections and rev. 39345 and speed slowdown

2018-06-30 Thread Michael Van Canneyt
On Sat, 30 Jun 2018, Maciej Izak wrote: Hi, renaming for TMormotHashFactory to TGenericsHashFactory is somehow acceptable (but IMO bad taste) but change for default hashing algorithm in such important library is really really really bad idea. As noted in the bugreport, your own examples

[fpc-devel] Attn. Generics.Collections and rev. 39345 and speed slowdown

2018-06-30 Thread Maciej Izak
Hi, renaming for TMormotHashFactory to TGenericsHashFactory is somehow acceptable (but IMO bad taste) but change for default hashing algorithm in such important library is really really really bad idea. This was not consulted, change like that or proposition should be reported here :