Re: [fpc-devel] TCollection.FOwner

2017-12-27 Thread Juha Manninen
On Wed, Dec 27, 2017 at 6:39 PM, Michael Van Canneyt wrote: > I don't want to burden TCollection with a field that will rarely be used. > > The proper solution is to implement GetOwner correctly for all cases that > need it. That's why it is there. > > So if you report all

Re: [fpc-devel] TCollection.FOwner

2017-12-27 Thread Michael Van Canneyt
On Wed, 27 Dec 2017, Juha Manninen wrote: I am proposing to add a private FOwner: TPersistent; to TCollection and remove it from derived classes which already have it. At least TParams has it but it is not used. I don't want to burden TCollection with a field that will rarely be used. The

Re: [fpc-devel] TCollection.FOwner

2017-12-27 Thread Martin Schreiber
On 12/27/2017 04:15 PM, Juha Manninen wrote: > I am proposing to add a private > FOwner: TPersistent; > to TCollection and remove it from derived classes which already have it. Just a warning which does not necessarily apply to the TCollection issue you report: Be very careful to change

[fpc-devel] TCollection.FOwner

2017-12-27 Thread Juha Manninen
I am proposing to add a private FOwner: TPersistent; to TCollection and remove it from derived classes which already have it. At least TParams has it but it is not used. The next step would be to assign a proper owner for derived TCollection instances, case by case. Lazarus has code to go up in