Re: [fpc-devel] Object checks

2017-05-06 Thread Pierre Muller 


Le 06/05/2017 à 09:56, C Western a écrit :
> On 05/05/17 12:54, Pierre Muller wrote:
>>
>>I applied a patch in commit 36113 to trunk that
>> substitutes RunError with HandleError.
>> It has been applied to three functions:
>> fpc_help_destructor, fpc_check_object and fpc_check_object_ext
>>
> Thank you for doing this. In the meantime I put a slightly updated patch 
> in 31745 in the bug tracker, which gives slightly better stack traces.
  Hi Colin,

  thanks for this improvement,
I committed it in rev 36134.

Pierre
___
fpc-devel maillist  -  fpc-devel@lists.freepascal.org
http://lists.freepascal.org/cgi-bin/mailman/listinfo/fpc-devel

Re: [fpc-devel] Object checks

2017-05-06 Thread C Western 

On 05/05/17 12:54, Pierre Muller wrote:


   I applied a patch in commit 36113 to trunk that
substitutes RunError with HandleError.
It has been applied to three functions:
fpc_help_destructor, fpc_check_object and fpc_check_object_ext

Thank you for doing this. In the meantime I put a slightly updated patch 
in 31745 in the bug tracker, which gives slightly better stack traces.


Colin
___
fpc-devel maillist  -  fpc-devel@lists.freepascal.org
http://lists.freepascal.org/cgi-bin/mailman/listinfo/fpc-devel

Re: [fpc-devel] Object checks

2017-05-05 Thread Pierre Muller 
Hi Colin,

Le 30/04/2017 à 10:53, C Western a écrit :
> If I may, a couple of queries about code generated for object checking 
> when range checks are on (-Cr):
> 
> An explicit check for nil is generated, which seems redundant, as any 
> attempt to use the value will generate a SIGSEGV anyway on most 
> platforms, or am I missing something?
> 
> If the fpc_check_object fails it calls RunError, which forces the 
> application to terminate, whereas a SIGSEGV will raise an exception and 
> give the user the option of continuing (at least in an LCL app). Is 
> there any reason why fpc_check_object does not call HandleError?

  Thanks for the suggestion,

  I applied a patch in commit 36113 to trunk that
substitutes RunError with HandleError.
It has been applied to three functions:
fpc_help_destructor, fpc_check_object and fpc_check_object_ext



Pierre
___
fpc-devel maillist  -  fpc-devel@lists.freepascal.org
http://lists.freepascal.org/cgi-bin/mailman/listinfo/fpc-devel