Adding a new member to m_pkthdr

2022-05-27 Thread John Baldwin
th raising the conversation more broadly. The change to add this field is in https://reviews.freebsd.org/D35339. Drew has tested this isolated change under load at Netflix and found no impact on performance. -- John Baldwin

RFC: KTLS RX software support

2020-04-29 Thread John Baldwin
at https://reviews.freebsd.org/D24628 -- John Baldwin ___ freebsd-net@freebsd.org mailing list https://lists.freebsd.org/mailman/listinfo/freebsd-net To unsubscribe, send any mail to "freebsd-net-unsubscr...@freebsd.org"

Re: panic on invalid ifp pointer in iflib drivers

2019-10-17 Thread John Baldwin
n't reproducible on some other drivers. I wonder if other drivers would also provoke this if you just ran them in a detach/attach loop long enough. -- John Baldwin ___ freebsd-net@freebsd.org mailing list https://lists.freebsd.org/mailman/listinfo/freebsd-

Re: panic on invalid ifp pointer in iflib drivers

2019-10-17 Thread John Baldwin
the thread running detach. After that you can release device resources, destroy mutexes, free the ifp, etc. Note that drivers have to be prepared for ether_ifdetach to invoke if_ioctl (e.g. when detaching bpf), but of the drivers I've looked at this has generally been a non-issue. It sounds like iflib s

Re: mmap kernel chunk into user space

2019-07-29 Thread John Baldwin
s to return. A fancier version would be to build an sglist describing your buffer and create an OBJT_SG VM object that you returned from the d_mmap_single callback, but if you only ever have a single object that is never freed, the simple version will work fine. -- John Baldwin __

[Differential] D19422: if_vxlan(4) Allow set MTU more than 1500 bytes.

2019-07-15 Thread jhb (John Baldwin)
jhb accepted this revision. jhb added a comment. This revision is now accepted and ready to land. Thanks! CHANGES SINCE LAST ACTION https://reviews.freebsd.org/D19422/new/ REVISION DETAIL https://reviews.freebsd.org/D19422 EMAIL PREFERENCES

[Differential] D19422: if_vxlan(4) Allow set MTU more than 1500 bytes.

2019-07-12 Thread jhb (John Baldwin)
jhb added a comment. I agree that we can't handle this in ether_ioctl as it varies too much by real hardware. INLINE COMMENTS > if_vxlan.c:90 > + */ > +#define VXLAN_MAX_MTU65435 > + If it was possible to make this derived from other constants that would be ideal. has

[Differential] D9058: alc: Add Killer E2500 support.

2017-01-06 Thread jhb (John Baldwin)
jhb accepted this revision. This revision has a positive review. REVISION DETAIL https://reviews.freebsd.org/D9058 EMAIL PREFERENCES https://reviews.freebsd.org/settings/panel/emailpreferences/ To: sepherosa_gmail.com, decui_microsoft.com, jhb Cc: freebsd-net-list

[Differential] D8905: if: Defer the if_up until the ifnet.if_ioctl is called.

2016-12-29 Thread jhb (John Baldwin)
jhb added a comment. I would suggest rewording the message a bit to something like: Defer if_up() until after the interface's if_ioctl method is called. This ensures the interface is initialized by the interface driver before it can be used by the rest of the system.

Re: cxgbe's native netmap support broken since r307394

2016-12-29 Thread John Baldwin
On Thursday, December 29, 2016 10:02:32 AM Vincenzo Maffione wrote: > Ok, thanks for the clarification. I change the lock type to MTX_DEF > (and did a test). I attached the new patch. Looks good to me, thanks! > Cheers, > Vincenzo > > 2016-12-29 2:06 GMT+01:00 John Baldwin

Re: cxgbe's native netmap support broken since r307394

2016-12-28 Thread John Baldwin
if_input or m_freem that can't be invoked from a filter either). > > Cheers, > Vincenzo > > 2016-12-28 19:06 GMT+01:00 John Baldwin <j...@freebsd.org>: > > Why are you using MTX_SPIN? Changing the lock type to MTX_DEF would seem to > > be a smaller patch and pro

aio_write and PRUS_MORETOCOME

2016-12-28 Thread John Baldwin
://reviews.freebsd.org/D8955 if you'd like to comment/review. -- John Baldwin ___ freebsd-net@freebsd.org mailing list https://lists.freebsd.org/mailman/listinfo/freebsd-net To unsubscribe, send any mail to "freebsd-net-unsubscr...@freebsd.org"

Re: cxgbe's native netmap support broken since r307394

2016-12-28 Thread John Baldwin
;>>>>>> Why is IFNET_WLOCK needed here? It seems like a regression to > >>>>>>>>> disallow > >>>>>>>>> sleep on the control path. > >>>>>>>>> > >>>>>>>>> Regards, > >>>>>>>>> Navdeep > >>>>>>>>> > >>>>>>>>> begin_synchronized_op with the following non-sleepable locks held: > >>>>>>>>> exclusive rw ifnet_rw (ifnet_rw) r = 0 (0x8271d680) locked @ > >>>>>>>>> /root/ws/head/sys/dev/netmap/netmap_freebsd.c:95 > >>>>>>>>> stack backtrace: > >>>>>>>>> #0 0x810837a5 at witness_debugger+0xe5 > >>>>>>>>> #1 0x81084d88 at witness_warn+0x3b8 > >>>>>>>>> #2 0x83ef2bcc at begin_synchronized_op+0x6c > >>>>>>>>> #3 0x83f14beb at cxgbe_netmap_reg+0x5b > >>>>>>>>> #4 0x809846f1 at netmap_hw_reg+0x81 > >>>>>>>>> #5 0x809806de at netmap_do_regif+0x19e > >>>>>>>>> #6 0x8098121d at netmap_ioctl+0x7ad > >>>>>>>>> #7 0x8098682f at freebsd_netmap_ioctl+0x5f > >>>>>>>> > >>>>>>>> > >>>>>>>> > >>>>>>>> -- > >>>>>>>> Vincenzo Maffione > >>>>>>>> ___ > >>>>>>>> freebsd-net@freebsd.org mailing list > >>>>>>>> https://lists.freebsd.org/mailman/listinfo/freebsd-net > >>>>>>>> To unsubscribe, send any mail to > >>>>>>>> "freebsd-net-unsubscr...@freebsd.org" > >>>>>> > >>>>>> > >>>>>> > >>>>>> -- > >>>>>> Vincenzo Maffione > >>>>>> ___ > >>>>>> freebsd-net@freebsd.org mailing list > >>>>>> https://lists.freebsd.org/mailman/listinfo/freebsd-net > >>>>>> To unsubscribe, send any mail to "freebsd-net-unsubscr...@freebsd.org" > >>>> > >>>> > >>>> > >>>> -- > >>>> Vincenzo Maffione > >>> > >>> > >>> > >>> -- > >>> -+--- > >>> Prof. Luigi RIZZO, ri...@iet.unipi.it . Dip. di Ing. dell'Informazione > >>> http://www.iet.unipi.it/~luigi/. Universita` di Pisa > >>> TEL +39-050-2217533 . via Diotisalvi 2 > >>> Mobile +39-338-6809875 . 56122 PISA (Italy) > >>> -+--- > >> > >> > >> > >> -- > >> Vincenzo Maffione > > > > -- John Baldwin ___ freebsd-net@freebsd.org mailing list https://lists.freebsd.org/mailman/listinfo/freebsd-net To unsubscribe, send any mail to "freebsd-net-unsubscr...@freebsd.org"

[Differential] [Accepted] D5853: dhclient: Log a warning instead of bailing upon "illegal" options

2016-04-18 Thread jhb (John Baldwin)
jhb accepted this revision. REVISION DETAIL https://reviews.freebsd.org/D5853 EMAIL PREFERENCES https://reviews.freebsd.org/settings/panel/emailpreferences/ To: sepherosa_gmail.com, network, secteam, delphij, glebius, adrian, honzhan_microsoft.com, howard0su_gmail.com, decui_microsoft.com,

Re: Some MSI are not routed correctly

2015-10-21 Thread John Baldwin
12971 igb1:que 2 > 13032 igb1:que 3 > > So I guess interrupts are routed correctly after all, but for some reason > driver takes some 5 times less time to process it on cpus 4-7 > (per-interrupt). Weird. Are the pps rates the same? It seems like the interrupt rates on igb0 are d

Re: Some MSI are not routed correctly

2015-10-21 Thread John Baldwin
51 5 >11 100086 intr irq271: igb1:que 61 6 >11 100088 intr irq272: igb1:que 71 7 These are clearly what you want, and you can see that the last CPU they ran on is the CPU you want as well. If you run 'top -SHz' do you see the threads running

Re: Question on mbufs

2015-10-20 Thread John Baldwin
and that most things will only check for M_PKTHDR and look for the fields in the first mbuf in the chain. -- John Baldwin ___ freebsd-net@freebsd.org mailing list https://lists.freebsd.org/mailman/listinfo/freebsd-net To unsubscribe, send any mail to

Re: Some MSI are not routed correctly

2015-10-19 Thread John Baldwin
ppysoft.com/haswell_bug/good.dmesg > http://sobomax.sippysoft.com/haswell_bug/lstopo_good.png > http://sobomax.sippysoft.com/haswell_bug/systat_vm_good.png > http://sobomax.sippysoft.com/haswell_bug/top_P_good.png > > Any ideas on how to debug th

Re: Can tcp_close() be called in INP_TIMEWAIT case

2015-09-25 Thread John Baldwin
simpler by avoiding an extra condition. Please just document it via assertions in tcp_close() (or is this the assertion that fired and triggered the reported panic? If so, then you obviously don't need to add it. :-P) -- John Baldwin ___ freebsd-net@freebsd.org mailing list https://lists.freebsd.org/mailman/listinfo/freebsd-net To unsubscribe, send any mail to "freebsd-net-unsubscr...@freebsd.org"

Re: Locking Memory Question

2015-07-30 Thread John Baldwin
, but is fine for a one-time copy. -- John Baldwin ___ freebsd-net@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-net To unsubscribe, send any mail to freebsd-net-unsubscr...@freebsd.org

Re: Locking Memory Question

2015-07-29 Thread John Baldwin
or something else to avoid leaking the kernel mappings. This has the advantage over the first approach that it will keep the pages around until all mappings are gone, though once all the kernel mappings are gone the pages will no longer be wired (though they will be swap-backed). -- John Baldwin

Re: Adding new media types to if_media.h

2015-03-12 Thread John Baldwin
On Thursday, March 12, 2015 04:07:54 PM Hans Petter Selasky wrote: On 02/28/15 13:28, John Baldwin wrote: On Friday, February 27, 2015 10:23:10 PM Gleb Smirnoff wrote: On Thu, Feb 26, 2015 at 08:25:59PM -0800, Adrian Chadd wrote: A [snip] A A I think Mike's approach is good - it makes

Re: Adding new media types to if_media.h

2015-02-28 Thread John Baldwin
be out until 2016, that is far, far too long to wait for more media types. The stuff we need to support is already shipping in products today. We can't not support these in 10 (and possibly 9). -- John Baldwin ___ freebsd-net@freebsd.org mailing list

Re: Accessing socket APIs soon after accept

2015-02-27 Thread John Baldwin
. That's almost exactly the approach we were considering. - Ryan Q From: John Baldwin j...@freebsd.org Sent: Friday, February 27, 2015 10:20 AM To: freebsd-net@freebsd.org Cc: Quattlebaum, Ryan; Adrian Chadd Subject: Re: Accessing socket APIs

Re: Accessing socket APIs soon after accept

2015-02-27 Thread John Baldwin
problem. -- John Baldwin ___ freebsd-net@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-net To unsubscribe, send any mail to freebsd-net-unsubscr...@freebsd.org

Re: Accessing socket APIs soon after accept

2015-02-27 Thread John Baldwin
On Friday, February 27, 2015 10:32:17 AM Adrian Chadd wrote: On 27 February 2015 at 10:07, John Baldwin j...@freebsd.org wrote: On Friday, February 27, 2015 10:03:33 AM Adrian Chadd wrote: Is this also a bug on -9 and -10? Yes. I may merge just the tcp_syncache.c part of this change

Re: Adding new media types to if_media.h

2015-02-17 Thread John Baldwin
to support the new 40 Gb/s media types until someone wants to design an improved but non-backward- compatible interface. I think it meets the goal of suitability for back-porting; it could be MFCed. Seems like a reasonable next step to me. -- John Baldwin

[Differential] [Updated] D1777: Associated fix for arp/nd6 timer usage.

2015-02-04 Thread jhb (John Baldwin)
jhb added a comment. This is just How It Works. You are always supposed to do a callout_drain() before freeing the storage belonging to a callout. I don't understand how you are preventing the callout/lock being freed out from under the callout routine in this version either. Now you can

[Differential] [Commented On] D1711: Changes to the callout code to restore active semantics and also add a test-framework and test to validate thecallout code (and potentially for use by other tests)

2015-01-29 Thread jhb (John Baldwin)
jhb added a comment. To be clear, I'm fine with updating my tests to a different framework, but I think it's worth discussing what that looked like. I also had to explicitly drop Giant in my test module handler. I do think it's probably better to explicitly ask tests to run instead of having

[Differential] [Changed Subscribers] D1711: Changes to the callout code to restore active semantics and also add a test-framework and test to validate thecallout code (and potentially for use by other

2015-01-29 Thread jhb (John Baldwin)
jhb added a subscriber: jhb. jhb added a comment. Hmm, I do think the idea of a kernel test framework should be discussed in its own right. I have implemented a much simpler one on my own for unit tests of locking primitives that you can see here. These worked by declaring tests in linker

Re: Issue with forwarding when creates new interface [was USB Tethering and forwarding]

2015-01-13 Thread John Baldwin
that then fiddles with the setting ignoring whats in sysctl.conf ? Yes, devd is running /etc/rc.d/netif start foo which probably checks gateway_enable and sets the sysctl based on that overriding what it in sysctl.conf. Just set gateway_enable=YES in rc.conf instead. -- John Baldwin

Re: compiling on nfs directories

2014-12-16 Thread John Baldwin
. You can make this precise on the NFS server by setting the vfs.timestamp_precision sysctl to 3. We should probably be using that by default for at least server-class systems. -- John Baldwin ___ freebsd-net@freebsd.org mailing list http

Re: Adding new media types to if_media.h

2014-12-12 Thread John Baldwin
. A backport could simply define the new subtypes as other, and the KPI would still be compatible. Thoughts? Mike -- John Baldwin ___ freebsd-net@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-net

Re: ixgbe(4) spin lock held too long

2014-10-24 Thread John Baldwin
On Thursday, October 23, 2014 02:12:44 PM Jason Wolfe wrote: On Sat, Oct 18, 2014 at 4:42 AM, John Baldwin j...@freebsd.org wrote: On Friday, October 17, 2014 11:32:13 PM Jason Wolfe wrote: Producing 10G of random traffic against a server with this assertion added took about 2 hours

Re: ixgbe(4) spin lock held too long

2014-10-18 Thread John Baldwin
); break; case TT_KEEP: t_callout = tp-t_timers-tt_keep; -- John Baldwin ___ freebsd-net@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-net To unsubscribe, send any mail to freebsd

Re: ixgbe(4) spin lock held too long

2014-10-18 Thread John Baldwin
is doing? This is not a NULL tcp timer pointer. Instead, the retransmit timer is being armed while the persist timer is still armed. -- John Baldwin ___ freebsd-net@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-net

Re: ixgbe(4) spin lock held too long

2014-10-16 Thread John Baldwin
On Saturday, October 11, 2014 2:19:19 am Jason Wolfe wrote: On Fri, Oct 10, 2014 at 8:53 AM, John Baldwin j...@freebsd.org wrote: On Thursday, October 09, 2014 02:31:32 PM Jason Wolfe wrote: On Wed, Oct 8, 2014 at 12:29 PM, John Baldwin j...@freebsd.org wrote: My only other thought

Re: ixgbe(4) spin lock held too long

2014-10-08 Thread John Baldwin
On Wednesday, October 08, 2014 10:56:56 AM Jason Wolfe wrote: On Tue, Oct 7, 2014 at 11:28 AM, John Baldwin j...@freebsd.org wrote: On Tuesday, October 07, 2014 2:06:42 pm Jason Wolfe wrote: Hey John, Happy to do this, but the pool of boxes is about 500 large, which is the reason

Re: [PATCH] Only lock send buffer in sopoll() if needed

2014-10-06 Thread John Baldwin
tree and was curious what other folks thought of the idea. I do not have any workloads I am working with where this is a factor. -- John Baldwin ___ freebsd-net@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-net

Re: ixgbe(4) spin lock held too long

2014-10-03 Thread John Baldwin
On Thursday, October 02, 2014 06:40:21 PM Jason Wolfe wrote: On Wed, Sep 10, 2014 at 8:24 AM, John Baldwin j...@freebsd.org wrote: On Monday, September 08, 2014 03:34:02 PM Eric van Gyzen wrote: On 09/08/2014 15:19, Sean Bruno wrote: On Mon, 2014-09-08 at 12:09 -0700, Sean Bruno wrote

Re: Choice of private ioctl approach

2014-09-30 Thread John Baldwin
. dedicated char device with its own ioctl's Is there any recommendations on which way is preferred? I would be inclined towards 2). It is more flexible if you need to add more custom ioctls in the future. -- John Baldwin ___ freebsd-net@freebsd.org

Re: getting factory MAC address

2014-09-30 Thread John Baldwin
at that patch? -- John Baldwin ___ freebsd-net@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-net To unsubscribe, send any mail to freebsd-net-unsubscr...@freebsd.org

[PATCH] Only lock send buffer in sopoll() if needed

2014-09-30 Thread John Baldwin
); } -- John Baldwin ___ freebsd-net@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-net To unsubscribe, send any mail to freebsd-net-unsubscr...@freebsd.org

Re: ixgbe(4) spin lock held too long

2014-09-10 Thread John Baldwin
. Can you enable WITNESS (without WITNESS_SKIPSPIN) on this box? Also, do 'tid 13' and 'bt' in kgdb to see what the thread holding the lock was doing. -- John Baldwin ___ freebsd-net@freebsd.org mailing list http://lists.freebsd.org/mailman

Re: [Bug 193246] Bug in IPv6 multicast join(), uncovered by Jenkins

2014-09-04 Thread John Baldwin
on an AF_INET6 socket) will work on FreeBSD. I'm not sure how hard it would be to fix in6_mcast.c to support IPv4 groups. bms@ might know. -- John Baldwin ___ freebsd-net@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-net

Re: [PATCH] Packet loss when 'control' messages are present with large data (sendmsg(2))

2014-08-26 Thread John Baldwin
On Tuesday, August 26, 2014 11:05:12 am Alan Somers wrote: On Mon, Aug 25, 2014 at 1:52 PM, John Baldwin j...@freebsd.org wrote: On Friday, August 22, 2014 01:34:28 PM Harald Schmalzbauer wrote: Bezüglich Yuri's Nachricht vom 02.09.2013 06:54 (localtime): Please check in this patch

Re: [PATCH] Packet loss when 'control' messages are present with large data (sendmsg(2))

2014-08-25 Thread John Baldwin
Hello, I guess this fix should make it into 10.1. Can someone check please? A fix has to make into HEAD first. I've cc'd Alan who responded to the bug. Alan, note that glebius@ already committed the test case to HEAD a while ago. -- John Baldwin

Re: Question about tcp keep-alive timer

2014-08-11 Thread John Baldwin
a tradeoff between having the timer run at all. However, I suspect that with high packet rates it probably is cheaper to have the timer run periodically and reschedule itself if it notices it isn't needed as you suggested. Do you want to write up a patch and test it? -- John Baldwin

Re: NFS client READ performance on -current

2014-08-11 Thread John Baldwin
On Saturday, July 19, 2014 1:28:19 pm John Baldwin wrote: On Thursday 17 July 2014 19:45:56 Julian Elischer wrote: On 7/15/14, 10:34 PM, John Baldwin wrote: On Saturday, July 12, 2014 5:14:00 pm Rick Macklem wrote: Yonghyeon Pyun wrote: On Fri, Jul 11, 2014 at 09:54:23AM -0400, John

Re: zero window and persist timer not set

2014-08-11 Thread John Baldwin
is correct, but please file this as a bug report so we can hopefully wrangle another person to review this. -- John Baldwin ___ freebsd-net@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-net To unsubscribe, send any mail

Re: Multicast races on vlan lagg

2014-08-11 Thread John Baldwin
instead of IF_ADDR_WLOCK? Also, strictly speaking it might be best to use if_maddr_rlock() instead of directly using IF_ADDR_RLOCK(). -- John Baldwin ___ freebsd-net@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-net

Re: NFS client READ performance on -current

2014-07-21 Thread John Baldwin
invalid. Return the new mbuf chain on success, NULL on fail- ure (the mbuf chain is freed in this case). Note: It does not allocate any mbuf clusters, so len must be less than or equal to MHLEN. -- John Baldwin ___ freebsd

Re: NFS client READ performance on -current

2014-07-20 Thread John Baldwin
On Thursday 17 July 2014 19:45:56 Julian Elischer wrote: On 7/15/14, 10:34 PM, John Baldwin wrote: On Saturday, July 12, 2014 5:14:00 pm Rick Macklem wrote: Yonghyeon Pyun wrote: On Fri, Jul 11, 2014 at 09:54:23AM -0400, John Baldwin wrote: On Thursday, July 10, 2014 6:31:43 pm Rick

Re: NFS client READ performance on -current

2014-07-15 Thread John Baldwin
On Saturday, July 12, 2014 5:14:00 pm Rick Macklem wrote: Yonghyeon Pyun wrote: On Fri, Jul 11, 2014 at 09:54:23AM -0400, John Baldwin wrote: On Thursday, July 10, 2014 6:31:43 pm Rick Macklem wrote: John Baldwin wrote: On Thursday, July 03, 2014 8:51:01 pm Rick Macklem wrote

Re: NFS client READ performance on -current

2014-07-11 Thread John Baldwin
On Thursday, July 10, 2014 6:31:43 pm Rick Macklem wrote: John Baldwin wrote: On Thursday, July 03, 2014 8:51:01 pm Rick Macklem wrote: Russell L. Carter wrote: On 07/02/14 19:09, Rick Macklem wrote: Could you please post the dmesg stuff for the network interface

Re: NFS client READ performance on -current

2014-07-10 Thread John Baldwin
) + m = m_defrag(*m_headp, M_NOWAIT); if (m == NULL) { adapter-mbuf_alloc_failed++; m_freem(*m_headp); -- John Baldwin ___ freebsd-net@freebsd.org mailing list http://lists.freebsd.org/mailman

Re: r256920 missing in stable/9 and releng/9.3

2014-07-10 Thread John Baldwin
don't see any obvious reason. If nobody objects on -net@, I can do it. I think this looks fine to merge. -- John Baldwin ___ freebsd-net@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-net To unsubscribe, send any mail

Re: System Booting Kernel from Secondary Drive

2014-07-10 Thread John Baldwin
is mounted. but the system is running the old kernel. Pulling the 2nd fixed the problem. What can cause this to happen? Is it a supermicro problem (it's a 5017R-MTF superserver) or is it something with FreeBSD. Are you using a software RAID between the two disks? -- John Baldwin

Re: Add netbw option to systat

2014-07-10 Thread John Baldwin
the code to use humanize_number? (It might not, but if it does, I think that would be preferable.) -- John Baldwin ___ freebsd-net@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-net To unsubscribe, send any mail to freebsd-net

Re: Ordering problem in if_detach_internal regarding if_bridge

2014-06-24 Thread John Baldwin
On Monday, June 23, 2014 1:12:54 pm Roger Pau Monné wrote: On 23/06/14 18:49, Alexander V. Chernikov wrote: On 23.06.2014 20:39, Alexander V. Chernikov wrote: On 23.06.2014 19:32, John Baldwin wrote: On Friday, June 20, 2014 11:25:51 am Roger Pau Monné wrote: Hello, I've stumbled

Re: Ordering problem in if_detach_internal regarding if_bridge

2014-06-23 Thread John Baldwin
this earlier so that we allow outside consumers to detach from an interface before it is destroyed. I'm not sure if it would break things, but I would be tempted to move this even earlier right after it is removed from the global ifnet list but before the taskqueue_drain, etc. -- John Baldwin

Re: LAN network performance issues

2014-03-07 Thread John Baldwin
such as the NIC being used? -- John Baldwin ___ freebsd-net@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-net To unsubscribe, send any mail to freebsd-net-unsubscr...@freebsd.org

Re: Does pthread_set_name_np() work?

2013-09-03 Thread John Baldwin
can't trust the return value. -- John Baldwin ___ freebsd-net@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-net To unsubscribe, send any mail to freebsd-net-unsubscr...@freebsd.org

Re: [rfc] migrate lagg to an rmlock

2013-08-29 Thread John Baldwin
On Thursday, August 29, 2013 11:37:08 am Scott Long wrote: On Aug 29, 2013, at 7:42 AM, John Baldwin j...@freebsd.org wrote: On Saturday, August 24, 2013 10:16:33 am Robert Watson wrote: There are a number of other places in the kernel where migration to an rmlock makes sense

Re: kern/180430: [ofed] [patch] Bad UDP checksum calc for fragmented packets

2013-08-07 Thread John Baldwin
On Monday, August 05, 2013 6:49:01 am Meny Yossefi wrote: John, Will this be committed to 9.2 as well ? Yes, I committed it yesterday. -- John Baldwin ___ freebsd-net@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-net

Re: kern/180791: [ofed] [patch] Kernel crash on ifdown and kldunload mlxen

2013-07-25 Thread John Baldwin
The following reply was made to PR kern/180791; it has been noted by GNATS. From: John Baldwin j...@freebsd.org To: bug-follo...@freebsd.org, shah...@mellanox.com Cc: Subject: Re: kern/180791: [ofed] [patch] Kernel crash on ifdown and kldunload mlxen Date: Thu, 25 Jul 2013 15:18:06 -0400

Re: kern/180430: [ofed] [patch] Bad UDP checksum calc for fragmented packets

2013-07-22 Thread John Baldwin
The following reply was made to PR kern/180430; it has been noted by GNATS. From: John Baldwin j...@freebsd.org To: Meny Yossefi me...@mellanox.com Cc: bug-follo...@freebsd.org bug-follo...@freebsd.org Subject: Re: kern/180430: [ofed] [patch] Bad UDP checksum calc for fragmented packets Date

Re: kern/180430: [ofed] [patch] Bad UDP checksum calc for fragmented packets

2013-07-19 Thread John Baldwin
The following reply was made to PR kern/180430; it has been noted by GNATS. From: John Baldwin j...@freebsd.org To: bug-follo...@freebsd.org, me...@mellanox.com Cc: Subject: Re: kern/180430: [ofed] [patch] Bad UDP checksum calc for fragmented packets Date: Fri, 19 Jul 2013 11:13:44 -0400

Re: bind error when using SO_REUSEPORT(implies SO_REUSEADDR)

2013-07-18 Thread John Baldwin
On Wednesday, July 17, 2013 5:23:37 pm Mikolaj Golub wrote: On Tue, Jul 16, 2013 at 11:12:46AM -0400, John Baldwin wrote: On Thursday, March 15, 2012 8:07:46 pm Sean Bruno wrote: On Thu, 2012-03-15 at 16:59 -0700, Sean Bruno wrote: Hey, I just found a bind bug ticket in my queue about

Re: misc/179033: [dc] dc ethernet driver seems to have issues with some multiport card and mother board combinations

2013-07-16 Thread John Baldwin
, but the patch above will output enough debugging to verify it is working without requiring a verbose boot. John Baldwin wrote: On Monday, June 10, 2013 3:13:11 pm Mr. Clif wrote: Hi John and Pyun, Ok got the new kernel installed and tested. Yes it works! :-) Maybe that will also fix a simular

Re: bind error when using SO_REUSEPORT(implies SO_REUSEADDR)

2013-07-16 Thread John Baldwin
this is bind() not bind ... :-) Did the recent commit to HEAD fix this btw? -- John Baldwin ___ freebsd-net@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-net To unsubscribe, send any mail to freebsd-net-unsubscr

Re: kern/180430: [ofed] [patch] Bad UDP checksum calc for fragmented packets

2013-07-11 Thread John Baldwin
(MLX4_WQE_CTRL_IP_CSUM); + if (mb-m_pkthdr.csum_flags (CSUM_TCP|CSUM_UDP)) { + tx_desc-ctrl.srcrb_flags |= + cpu_to_be32(MLX4_WQE_CTRL_TCP_UDP_CSUM); priv-port_stats.tx_chksum_offload++; } -- John Baldwin

Re: misc/179033: [dc] dc ethernet driver seems to have issues with some multiport card and mother board combinations

2013-06-28 Thread John Baldwin
is at the URL below. I wasn't able to test your specific use case yet however (of the BIOS using an invalid range). Thanks for your help, Clif John Baldwin wrote: On Monday, June 10, 2013 3:13:11 pm Mr. Clif wrote: Hi John and Pyun, Ok got the new kernel installed and tested

Re: kern/179999: [ofed] [patch] Bug assigning HCA from IB to ETH

2013-06-27 Thread John Baldwin
The following reply was made to PR kern/17; it has been noted by GNATS. From: John Baldwin j...@freebsd.org To: bug-follo...@freebsd.org, shah...@mellanox.com Cc: Subject: Re: kern/17: [ofed] [patch] Bug assigning HCA from IB to ETH Date: Thu, 27 Jun 2013 14:10:42 -0400 Thanks, I

Re: Failed to allocate receive buffer problem

2013-06-25 Thread John Baldwin
? Specifically this line: 0/0/0 requests for mbufs denied (mbufs/clusters/mbuf+clusters) If so, it may be that the IPoIB layer has an mbuf leak. The rest of netstat - m might be useful here as you can see if any of the zones are full. -- John Baldwin ___ freebsd

Re: How to compile ipoib module manually?

2013-06-05 Thread John Baldwin
. Where can I find it? 2. How can I compile ipoib support? You will have to create one. You should be able to use the existing module Makefiles as a guide. -- John Baldwin ___ freebsd-net@freebsd.org mailing list http://lists.freebsd.org/mailman

Re: Create pkey on FreeBSD 9.1

2013-05-30 Thread John Baldwin
?). Can you tcpdump on the ib0 interface and see if your pings on ib0.100 show up and if they have the appropriate headers? -- John Baldwin ___ freebsd-net@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-net To unsubscribe

Re: misc/179033: [dc] dc ethernet driver seems to have issues with some multiport card and mother board combinations

2013-05-30 Thread John Baldwin
DC_USEIOSPACE #include dev/dc/if_dcreg.h If this fixes it then I can take this PR as a test case for handling the ISA enable bit in the PCI-PCI bridge code. -- John Baldwin ___ freebsd-net@freebsd.org mailing list http://lists.freebsd.org

Re: RFC: removing redundant checks in ether_input_internal()

2013-05-29 Thread John Baldwin
. None of these should trigger in production and all of them are an indication that something is very wrong with the packet or the caller. Eh, but if the only caller is ether_nh_input() then by definition you know that m-m_pkthdr.rcvif == ifp. -- John Baldwin

Re: Create pkey on FreeBSD 9.1

2013-05-29 Thread John Baldwin
vlandev ib0 vlan 0xc This will create a new vlanX interface (ifconfig will its precise name with its unit number to stdout). Simpler though is just 'ifconfig ib0.12 create' (and how most folks expect subinterfaces to be named). -- John Baldwin

Re: How to switch Datgram/Connected mtu modes?

2013-05-29 Thread John Baldwin
? It looks like the OFED bits in FreeBSD map Linux sysfs entries to sysctl nodes, but I don't have a box with IB handy to see what it looks like at runtime. -- John Baldwin ___ freebsd-net@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo

Re: bpf hold buffer in-use flag

2013-05-23 Thread John Baldwin
On Thursday, May 23, 2013 5:05:39 pm Guy Helmer wrote: On Jan 9, 2013, at 2:35 PM, John Baldwin j...@freebsd.org wrote: On Tuesday, November 13, 2012 4:40:57 pm Guy Helmer wrote: To try to completely resolve the race in bpfread(), I have put together these changes to add a flag

Re: High CPU interrupt load on intel I350T4 with igb on 8.3

2013-05-20 Thread John Baldwin
=revisionrevision=235553 This may not help with any issues in pf(4), but we had workloads at work (not involving pf) where this bug could cause boxes to spend 100% CPU in igb threads. -- John Baldwin ___ freebsd-net@freebsd.org mailing list http

Re: shm_map questions

2013-04-22 Thread John Baldwin
that object directly rather than an fd. Laurie --- On Thu, 4/18/13, John Baldwin j...@freebsd.org wrote: From: John Baldwin j...@freebsd.org Subject: Re: shm_map questions To: freebsd-net@freebsd.org Cc: Laurie Jennings laurie_jennings_1...@yahoo.com Date: Thursday, April 18, 2013, 6:50 AM

Re: Network connections are lost from time to time

2013-04-19 Thread John Baldwin
that do not have this problem, but maybe the problem is with my sysctl.conf and loader.conf settings: Which NIC driver are you using? -- John Baldwin ___ freebsd-net@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-net

Re: kern/176446: [netinet] [patch] Concurrency in ixgbe driving out-of-order packet process and spurious RST

2013-04-19 Thread John Baldwin
) { - ixgbe_rearm_queues(adapter, (u64)(1 que-msix)); - return (TRUE); - } - - return (FALSE); + return ((staterr IXGBE_RXD_STAT_DD) != 0); } -- John Baldwin ___ freebsd-net@freebsd.org mailing list http://lists.freebsd.org

Re: kern/176446: [netinet] [patch] Concurrency in ixgbe driving out-of-order packet process and spurious RST

2013-04-19 Thread John Baldwin
; } /* -- John Baldwin ___ freebsd-net@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-net To unsubscribe, send any mail to freebsd-net-unsubscr...@freebsd.org

Re: kern/176446: [netinet] [patch] Concurrency in ixgbe driving out-of-order packet process and spurious RST

2013-04-19 Thread John Baldwin
The following reply was made to PR kern/176446; it has been noted by GNATS. From: John Baldwin j...@freebsd.org To: freebsd-net@freebsd.org Cc: Jack Vogel jfvo...@gmail.com, bug-follo...@freebsd.org, Mike Karels m...@karels.net Subject: Re: kern/176446: [netinet] [patch] Concurrency in ixgbe

Re: kern/176446: [netinet] [patch] Concurrency in ixgbe driving out-of-order packet process and spurious RST

2013-04-19 Thread John Baldwin
The following reply was made to PR kern/176446; it has been noted by GNATS. From: John Baldwin j...@freebsd.org To: freebsd-net@freebsd.org Cc: Jack Vogel jfvo...@gmail.com, bug-follo...@freebsd.org Subject: Re: kern/176446: [netinet] [patch] Concurrency in ixgbe driving out-of-order packet

Re: Network connections are lost from time to time

2013-04-19 Thread John Baldwin
On Friday, April 19, 2013 12:32:18 pm C. L. Martinez wrote: On Friday, April 19, 2013, John Baldwin j...@freebsd.org wrote: On Friday, April 19, 2013 3:11:41 am C. L. Martinez wrote: Hi all, I have a strange problem with my FreeBSD 9.1 (fully patched): I loose ssh sessions from time

Re: Network connections are lost from time to time

2013-04-19 Thread John Baldwin
On Friday, April 19, 2013 4:14:43 pm C. L. Martinez wrote: On Friday, April 19, 2013, John Baldwin j...@freebsd.org wrote: On Friday, April 19, 2013 12:32:18 pm C. L. Martinez wrote: On Friday, April 19, 2013, John Baldwin j...@freebsd.org wrote: On Friday, April 19, 2013 3:11:41 am C. L

Re: shm_map questions

2013-04-18 Thread John Baldwin
multiple processes by passing it across a UNIX domain socket. Hope this helps. -- John Baldwin ___ freebsd-net@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-net To unsubscribe, send any mail to freebsd-net-unsubscr...@freebsd.org

Re: Small patch in OFED/sdp

2013-04-03 Thread John Baldwin
On Tuesday, April 02, 2013 2:33:18 pm Vijay Singh wrote: Hi, this is based on the the understanding that the SS_NBIO is a socket state, and not a state of the socket buffer. Committed, thanks! -- John Baldwin ___ freebsd-net@freebsd.org mailing list

Re: close(2) while accept(2) is blocked

2013-04-01 Thread John Baldwin
other system calls should probably be equivalent to vhold, whereas things like open/dup (and storing an fd in a cmsg) should be more like vref. close() should then be a vrele(). -- John Baldwin ___ freebsd-net@freebsd.org mailing list http

Re: KVM with freeBSD and SR-IOV vlan doesn't working!

2013-04-01 Thread John Baldwin
on a standalone machine? -- John Baldwin ___ freebsd-net@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-net To unsubscribe, send any mail to freebsd-net-unsubscr...@freebsd.org

Re: kern/176446: [netinet] [patch] Concurrency in ixgbe driving out-of-order packet process and spurious RST

2013-03-15 Thread John Baldwin
interrupt filters to really work properly and be on by default. -- John Baldwin ___ freebsd-net@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-net To unsubscribe, send any mail to freebsd-net-unsubscr...@freebsd.org

Re: kern/176446: [netinet] [patch] Concurrency in ixgbe driving out-of-order packet process and spurious RST

2013-03-14 Thread John Baldwin
The following reply was made to PR kern/176446; it has been noted by GNATS. From: John Baldwin j...@freebsd.org To: Charbon, Julien jchar...@verisign.com Cc: bug-follo...@freebsd.org, De La Gueronniere, Marc mdelagueronni...@verisign.com, j...@freebsd.org Subject: Re: kern/176446: [netinet

Re: kern/176446: [netinet] [patch] Concurrency in ixgbe driving out-of-order packet process and spurious RST

2013-02-28 Thread John Baldwin
The following reply was made to PR kern/176446; it has been noted by GNATS. From: John Baldwin j...@freebsd.org To: bug-follo...@freebsd.org, jchar...@verisign.com Cc: Subject: Re: kern/176446: [netinet] [patch] Concurrency in ixgbe driving out-of-order packet process and spurious RST Date

Re: kern/172113: [panic] [e1000] [patch] 9.1-RC1/amd64 panices in igb(4): m_getjcl: invalid cluster type

2013-02-21 Thread John Baldwin
The following reply was made to PR kern/172113; it has been noted by GNATS. From: John Baldwin j...@freebsd.org To: bug-follo...@freebsd.org, egrosb...@rdtc.ru Cc: Subject: Re: kern/172113: [panic] [e1000] [patch] 9.1-RC1/amd64 panices in igb(4): m_getjcl: invalid cluster type Date: Thu, 21

Re: [PATCH] Add a new TCP_IGNOREIDLE socket option

2013-02-20 Thread John Baldwin
read this in full, this does seem to very much be what I want and is a better solution than ignoring idle handling entirely. Ironic that this was posted a few weeks after my patch. :) Clearly this is not an isolated workflow. -- John Baldwin ___ freebsd

  1   2   3   4   >