eugen_grosbein.net removed subscribers: freebsd-net-list, emaste.
eugen_grosbein.net added a comment.
Sorry for the mess, my latest actions on this differential were
unintentional, some problems with old Firefox.
REPOSITORY
rS FreeBSD src repository
CHANGES SINCE LAST ACTION
eugen_grosbein.net reclaimed this revision.
REPOSITORY
rS FreeBSD src repository
CHANGES SINCE LAST ACTION
https://reviews.freebsd.org/D25681/new/
REVISION DETAIL
https://reviews.freebsd.org/D25681
EMAIL PREFERENCES
https://reviews.freebsd.org/settings/panel/emailpreferences/
To:
eugen_grosbein.net commandeered this revision.
eugen_grosbein.net added a reviewer: neel_neelc.org.
REPOSITORY
rS FreeBSD src repository
CHANGES SINCE LAST ACTION
https://reviews.freebsd.org/D25681/new/
REVISION DETAIL
https://reviews.freebsd.org/D25681
EMAIL PREFERENCES
eugen_grosbein.net marked an inline comment as done.
eugen_grosbein.net added inline comments.
INLINE COMMENTS
> ae wrote in if_stf.c:383
> Using in_localip() is preferred, because INADDR_HASH is protected with rmlock
> only in head/ and stable/11. So if you plan to merge this into stable/10,
eugen_grosbein.net marked an inline comment as done.
REPOSITORY
rS FreeBSD src repository
REVISION DETAIL
https://reviews.freebsd.org/D12457
EMAIL PREFERENCES
https://reviews.freebsd.org/settings/panel/emailpreferences/
To: eugen_grosbein.net, ae, avg, mav, rwatson
Cc: bz, imp,
eugen_grosbein.net marked 2 inline comments as done.
REPOSITORY
rS FreeBSD src repository
REVISION DETAIL
https://reviews.freebsd.org/D12457
EMAIL PREFERENCES
https://reviews.freebsd.org/settings/panel/emailpreferences/
To: eugen_grosbein.net, ae, avg, mav, rwatson
Cc: bz, imp,
eugen_grosbein.net marked an inline comment as done.
eugen_grosbein.net added inline comments.
INLINE COMMENTS
> mav wrote in in_mcast.c:1383
> Do I miss some other protection means or this and few below places just
> scream about possible races due to missing interface pointer pulled out of
>
eugen_grosbein.net marked 2 inline comments as done.
eugen_grosbein.net added a comment.
In https://reviews.freebsd.org/D12457#258249, @rwatson wrote:
> Many of these changes are not sufficient to address the underlying problems
in this code, as the lock covers loop iteration but fails
eugen_grosbein.net marked an inline comment as done.
eugen_grosbein.net added inline comments.
INLINE COMMENTS
> mav wrote in if_stf.c:383
> Wouldn't it be better to use in_localip() here instead of code duplication?
> Or I miss something?
in_localip() may be better, I just wished to make the
eugen_grosbein.net created this revision.
Herald added a subscriber: imp.
REVISION SUMMARY
If a system has dynamic ever changing set of IP addresses, it can panic due
to unprotected access to global INADDR_HASH in several kernel subsystems:
ip_input.c, in_mcast.c, if_stf(4).
There was
eugen_grosbein.net accepted this revision.
REPOSITORY
rS FreeBSD src repository
REVISION DETAIL
https://reviews.freebsd.org/D9270
EMAIL PREFERENCES
https://reviews.freebsd.org/settings/panel/emailpreferences/
To: ale, #manpages, wblock, #network, julian, mav, adrian, glebius,
eugen_grosbein.net added a comment.
> No, I'm not asking for support that would take a few weeks of ping pong in
a bug tracker, if any. This is real world feedback for this review. Take it or
leave it. :)
I was going to deal with this problem but I need mentioned details to start
with.
eugen_grosbein.net added a comment.
In https://reviews.freebsd.org/D9270#251108, @franco_opnsense.org wrote:
> Thanks, but we've narrowed it down to this commit.
Anyway, Bugzilla should be used for bug reports. Don't forget to describe how
did you narrowed it to the commit in
eugen_grosbein.net added a comment.
In https://reviews.freebsd.org/D9270#251087, @franco_opnsense.org wrote:
> We do seem to have a persistent problem with this patch in some PPPoE
environments that will cause a crash in ng_pppoe_rcvdata_ether():
>
> https://ibb.co/mRWKHF
>
14 matches
Mail list logo
