kristof abandoned this revision.
REVISION DETAIL
https://reviews.freebsd.org/D1944
EMAIL PREFERENCES
https://reviews.freebsd.org/settings/panel/emailpreferences/
To: kristof, trociny, gnn, zec, rodrigc, glebius, eri, bz, nvass-gmx.com
Cc: ryan_timewasted.me, mmoll, javier_ovi_yahoo.com,
bz added a comment.
Can I have you guys have a look at https://reviews.freebsd.org/D6924
Thanks
REVISION DETAIL
https://reviews.freebsd.org/D1944
EMAIL PREFERENCES
https://reviews.freebsd.org/settings/panel/emailpreferences/
To: nvass-gmx.com, trociny, kristof, gnn, zec, rodrigc,
___
freebsd-net@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-net
To unsubscribe, send any mail to "freebsd-net-unsubscr...@freebsd.org"
nvass-gmx.com added a comment.
Thanks for taking a look Kristof,
I believe all your points are valid. Thing is that all eventhandlers need a
more thorough look. They don't work as they should; be it virtualized or not,
be it a VIMAGE or GENERIC kernel. I am trying to take a look but I
kristof added inline comments.
INLINE COMMENTS
sys/netpfil/pf/pf_if.c:130 I don't understand why this is required. Surely if
an ifnet lives in V_ifnet (so, lives in the current vnet) ifp->if_vnet is
always going to be curvnet?
sys/netpfil/pf/pf_if.c:141 Why add curvnet here?